* [PATCH] media: vimc: sen: remove unused kthread_sen field
@ 2019-11-05 17:53 Dafna Hirschfeld
2019-11-06 13:36 ` Helen Koike
0 siblings, 1 reply; 2+ messages in thread
From: Dafna Hirschfeld @ 2019-11-05 17:53 UTC (permalink / raw)
To: linux-media
Cc: dafna.hirschfeld, helen.koike, andre.almeida, skhan, hverkuil,
kernel, dafna3
The field kthread_sen in the vimc_sen_device is
not set and used. So remove the field and
the code that check if it is non NULL
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
drivers/media/platform/vimc/vimc-sensor.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/media/platform/vimc/vimc-sensor.c b/drivers/media/platform/vimc/vimc-sensor.c
index 25ee89a067f7..32380f504591 100644
--- a/drivers/media/platform/vimc/vimc-sensor.c
+++ b/drivers/media/platform/vimc/vimc-sensor.c
@@ -18,7 +18,6 @@ struct vimc_sen_device {
struct vimc_ent_device ved;
struct v4l2_subdev sd;
struct tpg_data tpg;
- struct task_struct *kthread_sen;
u8 *frame;
/* The active format */
struct v4l2_mbus_framefmt mbus_format;
@@ -202,10 +201,6 @@ static int vimc_sen_s_stream(struct v4l2_subdev *sd, int enable)
const struct vimc_pix_map *vpix;
unsigned int frame_size;
- if (vsen->kthread_sen)
- /* tpg is already executing */
- return 0;
-
/* Calculate the frame size */
vpix = vimc_pix_map_by_code(vsen->mbus_format.code);
frame_size = vsen->mbus_format.width * vpix->bpp *
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: vimc: sen: remove unused kthread_sen field
2019-11-05 17:53 [PATCH] media: vimc: sen: remove unused kthread_sen field Dafna Hirschfeld
@ 2019-11-06 13:36 ` Helen Koike
0 siblings, 0 replies; 2+ messages in thread
From: Helen Koike @ 2019-11-06 13:36 UTC (permalink / raw)
To: Dafna Hirschfeld, linux-media
Cc: andre.almeida, skhan, hverkuil, kernel, dafna3
On 11/5/19 3:53 PM, Dafna Hirschfeld wrote:
> The field kthread_sen in the vimc_sen_device is
> not set and used. So remove the field and
> the code that check if it is non NULL
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
> ---
> drivers/media/platform/vimc/vimc-sensor.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/media/platform/vimc/vimc-sensor.c b/drivers/media/platform/vimc/vimc-sensor.c
> index 25ee89a067f7..32380f504591 100644
> --- a/drivers/media/platform/vimc/vimc-sensor.c
> +++ b/drivers/media/platform/vimc/vimc-sensor.c
> @@ -18,7 +18,6 @@ struct vimc_sen_device {
> struct vimc_ent_device ved;
> struct v4l2_subdev sd;
> struct tpg_data tpg;
> - struct task_struct *kthread_sen;
> u8 *frame;
> /* The active format */
> struct v4l2_mbus_framefmt mbus_format;
> @@ -202,10 +201,6 @@ static int vimc_sen_s_stream(struct v4l2_subdev *sd, int enable)
> const struct vimc_pix_map *vpix;
> unsigned int frame_size;
>
> - if (vsen->kthread_sen)
> - /* tpg is already executing */
> - return 0;
> -
> /* Calculate the frame size */
> vpix = vimc_pix_map_by_code(vsen->mbus_format.code);
> frame_size = vsen->mbus_format.width * vpix->bpp *
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-06 13:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 17:53 [PATCH] media: vimc: sen: remove unused kthread_sen field Dafna Hirschfeld
2019-11-06 13:36 ` Helen Koike
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.