* [RESEND PATCH] staging: mt7621-dma: align to match open parenthesis
@ 2019-11-05 19:38 Jules Irenge
2019-11-05 19:50 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Jules Irenge @ 2019-11-05 19:38 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Jules Irenge
Align to match open parenthesis.
"CHECK: Alignment should match open parenthesis".
Issue detected by checkpatch tool.
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
changes in the RESEND
-included one more allignment which was left out
drivers/staging/mt7621-dma/mtk-hsdma.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index 94c2c708dc92..20b898954416 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -548,7 +548,8 @@ static int mtk_hsdam_alloc_desc(struct mtk_hsdam_engine *hsdma,
int i;
chan->tx_ring = dma_alloc_coherent(hsdma->ddev.dev,
- 2 * HSDMA_DESCS_NUM * sizeof(*chan->tx_ring),
+ 2 * HSDMA_DESCS_NUM *
+ sizeof(*chan->tx_ring),
&chan->desc_addr, GFP_ATOMIC | __GFP_ZERO);
if (!chan->tx_ring)
goto no_mem;
@@ -569,8 +570,8 @@ static void mtk_hsdam_free_desc(struct mtk_hsdam_engine *hsdma,
{
if (chan->tx_ring) {
dma_free_coherent(hsdma->ddev.dev,
- 2 * HSDMA_DESCS_NUM * sizeof(*chan->tx_ring),
- chan->tx_ring, chan->desc_addr);
+ 2 * HSDMA_DESCS_NUM * sizeof(*chan->tx_ring),
+ chan->tx_ring, chan->desc_addr);
chan->tx_ring = NULL;
chan->rx_ring = NULL;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [RESEND PATCH] staging: mt7621-dma: align to match open parenthesis
2019-11-05 19:38 [RESEND PATCH] staging: mt7621-dma: align to match open parenthesis Jules Irenge
@ 2019-11-05 19:50 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2019-11-05 19:50 UTC (permalink / raw)
To: Jules Irenge; +Cc: outreachy-kernel, gregkh
On Tue, 5 Nov 2019, Jules Irenge wrote:
> Align to match open parenthesis.
>
> "CHECK: Alignment should match open parenthesis".
> Issue detected by checkpatch tool.
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> changes in the RESEND
> -included one more allignment which was left out
Then it's not a resend, it's a V2.
julia
>
> drivers/staging/mt7621-dma/mtk-hsdma.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index 94c2c708dc92..20b898954416 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -548,7 +548,8 @@ static int mtk_hsdam_alloc_desc(struct mtk_hsdam_engine *hsdma,
> int i;
>
> chan->tx_ring = dma_alloc_coherent(hsdma->ddev.dev,
> - 2 * HSDMA_DESCS_NUM * sizeof(*chan->tx_ring),
> + 2 * HSDMA_DESCS_NUM *
> + sizeof(*chan->tx_ring),
> &chan->desc_addr, GFP_ATOMIC | __GFP_ZERO);
> if (!chan->tx_ring)
> goto no_mem;
> @@ -569,8 +570,8 @@ static void mtk_hsdam_free_desc(struct mtk_hsdam_engine *hsdma,
> {
> if (chan->tx_ring) {
> dma_free_coherent(hsdma->ddev.dev,
> - 2 * HSDMA_DESCS_NUM * sizeof(*chan->tx_ring),
> - chan->tx_ring, chan->desc_addr);
> + 2 * HSDMA_DESCS_NUM * sizeof(*chan->tx_ring),
> + chan->tx_ring, chan->desc_addr);
> chan->tx_ring = NULL;
> chan->rx_ring = NULL;
> }
> --
> 2.23.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191105193814.46748-1-jbi.octave%40gmail.com.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RESEND PATCH] staging: mt7621-dma: align to match open parenthesis
@ 2019-11-05 19:27 Jules Irenge
0 siblings, 0 replies; 3+ messages in thread
From: Jules Irenge @ 2019-11-05 19:27 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, Jules Irenge
Align to match open parenthesis.
"CHECK: Alignment should match open parenthesis".
Issue detected by checkpatch tool.
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
changes :
Included one more alignment fix
drivers/staging/mt7621-dma/mtk-hsdma.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index 94c2c708dc92..20b898954416 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -548,7 +548,8 @@ static int mtk_hsdam_alloc_desc(struct mtk_hsdam_engine *hsdma,
int i;
chan->tx_ring = dma_alloc_coherent(hsdma->ddev.dev,
- 2 * HSDMA_DESCS_NUM * sizeof(*chan->tx_ring),
+ 2 * HSDMA_DESCS_NUM *
+ sizeof(*chan->tx_ring),
&chan->desc_addr, GFP_ATOMIC | __GFP_ZERO);
if (!chan->tx_ring)
goto no_mem;
@@ -569,8 +570,8 @@ static void mtk_hsdam_free_desc(struct mtk_hsdam_engine *hsdma,
{
if (chan->tx_ring) {
dma_free_coherent(hsdma->ddev.dev,
- 2 * HSDMA_DESCS_NUM * sizeof(*chan->tx_ring),
- chan->tx_ring, chan->desc_addr);
+ 2 * HSDMA_DESCS_NUM * sizeof(*chan->tx_ring),
+ chan->tx_ring, chan->desc_addr);
chan->tx_ring = NULL;
chan->rx_ring = NULL;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-05 19:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 19:38 [RESEND PATCH] staging: mt7621-dma: align to match open parenthesis Jules Irenge
2019-11-05 19:50 ` [Outreachy kernel] " Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2019-11-05 19:27 Jules Irenge
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.