From: Andrew Lunn <andrew@lunn.ch>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: richard@nod.at, linux-mtd@lists.infradead.org,
Angelo Dureghello <angelo.dureghello@timesys.com>,
vigneshr@ti.com
Subject: Re: [PATCH] mtd: devices: fix mchp23k256 read and write
Date: Wed, 6 Nov 2019 00:17:09 +0100 [thread overview]
Message-ID: <20191105231709.GB12610@lunn.ch> (raw)
In-Reply-To: <20191105194122.4dcee126@xps13>
On Tue, Nov 05, 2019 at 07:41:22PM +0100, Miquel Raynal wrote:
> Hi Angelo,
>
> + Andrew
>
> Angelo Dureghello <angelo.dureghello@timesys.com> wrote on Wed, 30 Oct
> 2019 12:39:57 +0100:
>
> > Due to the use of sizeof(), command size set for the spi transfer
> > was wrong. Driver was sending and receiving always 1 byte less
> > and especially on write, it was hanging.
> >
> > echo -n -e "\\x1\\x2\\x3\\x4" > /dev/mtd1
> >
> > And read part too now works as expected.
> >
> > hexdump -C -n16 /dev/mtd1
> > 00000000 01 02 03 04 ab f3 ad c2 ab e3 f4 36 dd 38 04 15
> > 00000010
> >
>
> Looks fine by me, just added Andrew in case he wants to review the
> patch as he was the original committer.
>
> Anyway you're missing a Cc: stable and Fixes tag on
> 5dc17fa6fb70 ("mtd: mchp23k256: Add driver for this SPI SRAM device")
Hi Miquèl
This is the wrong fixes tag. The correct one is
Fixes: 4379075a870b ("mtd: mchp23k256: Add support for mchp23lcv1024")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-11-05 23:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 11:39 [PATCH] mtd: devices: fix mchp23k256 read and write Angelo Dureghello
2019-11-05 18:41 ` Miquel Raynal
2019-11-05 23:17 ` Andrew Lunn [this message]
2019-11-05 23:39 ` Miquel Raynal
[not found] ` <CALJHbkDoiireW8iNqGgqRRQdQcKjiLVnxUcFBGkgzE=qsba7-A@mail.gmail.com>
2019-11-11 16:56 ` Angelo Dureghello
2019-11-12 14:19 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105231709.GB12610@lunn.ch \
--to=andrew@lunn.ch \
--cc=angelo.dureghello@timesys.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.