* [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd @ 2019-11-05 6:15 ` Charles Machalow 0 siblings, 0 replies; 20+ messages in thread From: Charles Machalow @ 2019-11-05 6:15 UTC (permalink / raw) To: linux-nvme Cc: csm10495, marta.rybczynska, Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, linux-kernel Changing nvme_passthru_cmd64 to add a field: rsvd2. This field is an explicit marker for the padding space added on certain platforms as a result of the enlargement of the result field from 32 bit to 64 bits in size. --- include/uapi/linux/nvme_ioctl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/nvme_ioctl.h b/include/uapi/linux/nvme_ioctl.h index e168dc59e..d99b5a772 100644 --- a/include/uapi/linux/nvme_ioctl.h +++ b/include/uapi/linux/nvme_ioctl.h @@ -63,6 +63,7 @@ struct nvme_passthru_cmd64 { __u32 cdw14; __u32 cdw15; __u32 timeout_ms; + __u32 rsvd2; __u64 result; }; -- 2.17.1 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd @ 2019-11-05 6:15 ` Charles Machalow 0 siblings, 0 replies; 20+ messages in thread From: Charles Machalow @ 2019-11-05 6:15 UTC (permalink / raw) To: linux-nvme Cc: Sagi Grimberg, csm10495, linux-kernel, Jens Axboe, marta.rybczynska, Keith Busch, Christoph Hellwig Changing nvme_passthru_cmd64 to add a field: rsvd2. This field is an explicit marker for the padding space added on certain platforms as a result of the enlargement of the result field from 32 bit to 64 bits in size. --- include/uapi/linux/nvme_ioctl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/nvme_ioctl.h b/include/uapi/linux/nvme_ioctl.h index e168dc59e..d99b5a772 100644 --- a/include/uapi/linux/nvme_ioctl.h +++ b/include/uapi/linux/nvme_ioctl.h @@ -63,6 +63,7 @@ struct nvme_passthru_cmd64 { __u32 cdw14; __u32 cdw15; __u32 timeout_ms; + __u32 rsvd2; __u64 result; }; -- 2.17.1 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd 2019-11-05 6:15 ` Charles Machalow @ 2019-11-05 7:39 ` Marta Rybczynska -1 siblings, 0 replies; 20+ messages in thread From: Marta Rybczynska @ 2019-11-05 7:39 UTC (permalink / raw) To: Charles Machalow Cc: linux-nvme, kbusch, axboe, Christoph Hellwig, Sagi Grimberg, linux-kernel ----- On 5 Nov, 2019, at 07:15, Charles Machalow csm10495@gmail.com wrote: > Changing nvme_passthru_cmd64 to add a field: rsvd2. This field is an explicit > marker for the padding space added on certain platforms as a result of the > enlargement of the result field from 32 bit to 64 bits in size. > --- > include/uapi/linux/nvme_ioctl.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/linux/nvme_ioctl.h b/include/uapi/linux/nvme_ioctl.h > index e168dc59e..d99b5a772 100644 > --- a/include/uapi/linux/nvme_ioctl.h > +++ b/include/uapi/linux/nvme_ioctl.h > @@ -63,6 +63,7 @@ struct nvme_passthru_cmd64 { > __u32 cdw14; > __u32 cdw15; > __u32 timeout_ms; > + __u32 rsvd2; > __u64 result; > }; > Looks good to me. However, please note that the new ioctl made it already to 5.3.8. Regards, Marta ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd @ 2019-11-05 7:39 ` Marta Rybczynska 0 siblings, 0 replies; 20+ messages in thread From: Marta Rybczynska @ 2019-11-05 7:39 UTC (permalink / raw) To: Charles Machalow Cc: Sagi Grimberg, linux-kernel, linux-nvme, axboe, kbusch, Christoph Hellwig ----- On 5 Nov, 2019, at 07:15, Charles Machalow csm10495@gmail.com wrote: > Changing nvme_passthru_cmd64 to add a field: rsvd2. This field is an explicit > marker for the padding space added on certain platforms as a result of the > enlargement of the result field from 32 bit to 64 bits in size. > --- > include/uapi/linux/nvme_ioctl.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/linux/nvme_ioctl.h b/include/uapi/linux/nvme_ioctl.h > index e168dc59e..d99b5a772 100644 > --- a/include/uapi/linux/nvme_ioctl.h > +++ b/include/uapi/linux/nvme_ioctl.h > @@ -63,6 +63,7 @@ struct nvme_passthru_cmd64 { > __u32 cdw14; > __u32 cdw15; > __u32 timeout_ms; > + __u32 rsvd2; > __u64 result; > }; > Looks good to me. However, please note that the new ioctl made it already to 5.3.8. Regards, Marta _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd 2019-11-05 7:39 ` Marta Rybczynska @ 2019-11-05 15:31 ` Christoph Hellwig -1 siblings, 0 replies; 20+ messages in thread From: Christoph Hellwig @ 2019-11-05 15:31 UTC (permalink / raw) To: Marta Rybczynska Cc: Charles Machalow, linux-nvme, kbusch, axboe, Christoph Hellwig, Sagi Grimberg, linux-kernel, Sasha Levin, Greg Kroah-Hartman, stable On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote: > Looks good to me. However, please note that the new ioctl made it already to 5.3.8. It wasn't in 5.3, but it seems like you are right and it somehow got picked for the stable releases. Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182 in 5.3-stable ASAP and make sure crap like backporting new ABIs that haven't seen a release yet is never ever going to happen again? ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd @ 2019-11-05 15:31 ` Christoph Hellwig 0 siblings, 0 replies; 20+ messages in thread From: Christoph Hellwig @ 2019-11-05 15:31 UTC (permalink / raw) To: Marta Rybczynska Cc: Sasha Levin, Sagi Grimberg, Greg Kroah-Hartman, Charles Machalow, linux-kernel, linux-nvme, axboe, stable, kbusch, Christoph Hellwig On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote: > Looks good to me. However, please note that the new ioctl made it already to 5.3.8. It wasn't in 5.3, but it seems like you are right and it somehow got picked for the stable releases. Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182 in 5.3-stable ASAP and make sure crap like backporting new ABIs that haven't seen a release yet is never ever going to happen again? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd 2019-11-05 15:31 ` Christoph Hellwig @ 2019-11-06 0:08 ` Sasha Levin -1 siblings, 0 replies; 20+ messages in thread From: Sasha Levin @ 2019-11-06 0:08 UTC (permalink / raw) To: Christoph Hellwig Cc: Marta Rybczynska, Charles Machalow, linux-nvme, kbusch, axboe, Sagi Grimberg, linux-kernel, Greg Kroah-Hartman, stable On Tue, Nov 05, 2019 at 04:31:44PM +0100, Christoph Hellwig wrote: >On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote: >> Looks good to me. However, please note that the new ioctl made it already to 5.3.8. > >It wasn't in 5.3, but it seems like you are right and it somehow got >picked for the stable releases. > >Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182 >in 5.3-stable ASAP and make sure crap like backporting new ABIs that >haven't seen a release yet is never ever going to happen again? Sure, I'll revert it. I guess I wasn't expecting to see something like this in a -rc release. How did it make it into one if it's not a fix? -- Thanks, Sasha ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd @ 2019-11-06 0:08 ` Sasha Levin 0 siblings, 0 replies; 20+ messages in thread From: Sasha Levin @ 2019-11-06 0:08 UTC (permalink / raw) To: Christoph Hellwig Cc: Sagi Grimberg, Marta Rybczynska, Greg Kroah-Hartman, Charles Machalow, linux-kernel, linux-nvme, axboe, stable, kbusch On Tue, Nov 05, 2019 at 04:31:44PM +0100, Christoph Hellwig wrote: >On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote: >> Looks good to me. However, please note that the new ioctl made it already to 5.3.8. > >It wasn't in 5.3, but it seems like you are right and it somehow got >picked for the stable releases. > >Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182 >in 5.3-stable ASAP and make sure crap like backporting new ABIs that >haven't seen a release yet is never ever going to happen again? Sure, I'll revert it. I guess I wasn't expecting to see something like this in a -rc release. How did it make it into one if it's not a fix? -- Thanks, Sasha _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd 2019-11-06 0:08 ` Sasha Levin @ 2019-11-06 0:18 ` Keith Busch -1 siblings, 0 replies; 20+ messages in thread From: Keith Busch @ 2019-11-06 0:18 UTC (permalink / raw) To: Sasha Levin Cc: Christoph Hellwig, Marta Rybczynska, Charles Machalow, linux-nvme, axboe, Sagi Grimberg, linux-kernel, Greg Kroah-Hartman, stable On Tue, Nov 05, 2019 at 07:08:36PM -0500, Sasha Levin wrote: > On Tue, Nov 05, 2019 at 04:31:44PM +0100, Christoph Hellwig wrote: > > On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote: > > > Looks good to me. However, please note that the new ioctl made it already to 5.3.8. > > > > It wasn't in 5.3, but it seems like you are right and it somehow got > > picked for the stable releases. > > > > Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182 > > in 5.3-stable ASAP and make sure crap like backporting new ABIs that > > haven't seen a release yet is never ever going to happen again? > > Sure, I'll revert it. I guess I wasn't expecting to see something like > this in a -rc release. How did it make it into one if it's not a fix? It is a fix, but it wasn't marked as such in the original changelog. I've adjusted it for the pull request, currently staged here: https://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=0d6eeb1fd625272bd60d25f2d5e116cf582fc7dc Still, a new ioctl seems pretty aggressive for stable bot, yeah? ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd @ 2019-11-06 0:18 ` Keith Busch 0 siblings, 0 replies; 20+ messages in thread From: Keith Busch @ 2019-11-06 0:18 UTC (permalink / raw) To: Sasha Levin Cc: Sagi Grimberg, Marta Rybczynska, Greg Kroah-Hartman, Charles Machalow, linux-kernel, linux-nvme, axboe, stable, Christoph Hellwig On Tue, Nov 05, 2019 at 07:08:36PM -0500, Sasha Levin wrote: > On Tue, Nov 05, 2019 at 04:31:44PM +0100, Christoph Hellwig wrote: > > On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote: > > > Looks good to me. However, please note that the new ioctl made it already to 5.3.8. > > > > It wasn't in 5.3, but it seems like you are right and it somehow got > > picked for the stable releases. > > > > Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182 > > in 5.3-stable ASAP and make sure crap like backporting new ABIs that > > haven't seen a release yet is never ever going to happen again? > > Sure, I'll revert it. I guess I wasn't expecting to see something like > this in a -rc release. How did it make it into one if it's not a fix? It is a fix, but it wasn't marked as such in the original changelog. I've adjusted it for the pull request, currently staged here: https://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=0d6eeb1fd625272bd60d25f2d5e116cf582fc7dc Still, a new ioctl seems pretty aggressive for stable bot, yeah? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd 2019-11-06 0:08 ` Sasha Levin @ 2019-11-06 1:09 ` Christoph Hellwig -1 siblings, 0 replies; 20+ messages in thread From: Christoph Hellwig @ 2019-11-06 1:09 UTC (permalink / raw) To: Sasha Levin Cc: Christoph Hellwig, Marta Rybczynska, Charles Machalow, linux-nvme, kbusch, axboe, Sagi Grimberg, linux-kernel, Greg Kroah-Hartman, stable On Tue, Nov 05, 2019 at 07:08:36PM -0500, Sasha Levin wrote: > On Tue, Nov 05, 2019 at 04:31:44PM +0100, Christoph Hellwig wrote: >> On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote: >>> Looks good to me. However, please note that the new ioctl made it already to 5.3.8. >> >> It wasn't in 5.3, but it seems like you are right and it somehow got >> picked for the stable releases. >> >> Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182 >> in 5.3-stable ASAP and make sure crap like backporting new ABIs that >> haven't seen a release yet is never ever going to happen again? > > Sure, I'll revert it. I guess I wasn't expecting to see something like > this in a -rc release. How did it make it into one if it's not a fix? 76d609da9ed1cc0dc780e2b539d7b827ce28f182 is a backport of 65e68edce0db433aa0c2b26d7dc14fbbbeb89fbb, which went into 5.4-rc2 and was not marked for stable. It might kinda bend the normal merge window rules a little, but I don't see how it could be considered something to backport. ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd @ 2019-11-06 1:09 ` Christoph Hellwig 0 siblings, 0 replies; 20+ messages in thread From: Christoph Hellwig @ 2019-11-06 1:09 UTC (permalink / raw) To: Sasha Levin Cc: Sagi Grimberg, Marta Rybczynska, Greg Kroah-Hartman, Charles Machalow, linux-kernel, linux-nvme, axboe, stable, kbusch, Christoph Hellwig On Tue, Nov 05, 2019 at 07:08:36PM -0500, Sasha Levin wrote: > On Tue, Nov 05, 2019 at 04:31:44PM +0100, Christoph Hellwig wrote: >> On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote: >>> Looks good to me. However, please note that the new ioctl made it already to 5.3.8. >> >> It wasn't in 5.3, but it seems like you are right and it somehow got >> picked for the stable releases. >> >> Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182 >> in 5.3-stable ASAP and make sure crap like backporting new ABIs that >> haven't seen a release yet is never ever going to happen again? > > Sure, I'll revert it. I guess I wasn't expecting to see something like > this in a -rc release. How did it make it into one if it's not a fix? 76d609da9ed1cc0dc780e2b539d7b827ce28f182 is a backport of 65e68edce0db433aa0c2b26d7dc14fbbbeb89fbb, which went into 5.4-rc2 and was not marked for stable. It might kinda bend the normal merge window rules a little, but I don't see how it could be considered something to backport. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd 2019-11-05 6:15 ` Charles Machalow @ 2019-11-05 14:34 ` Christoph Hellwig -1 siblings, 0 replies; 20+ messages in thread From: Christoph Hellwig @ 2019-11-05 14:34 UTC (permalink / raw) To: Charles Machalow Cc: linux-nvme, marta.rybczynska, Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, linux-kernel Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de> ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd @ 2019-11-05 14:34 ` Christoph Hellwig 0 siblings, 0 replies; 20+ messages in thread From: Christoph Hellwig @ 2019-11-05 14:34 UTC (permalink / raw) To: Charles Machalow Cc: Sagi Grimberg, linux-kernel, linux-nvme, Jens Axboe, marta.rybczynska, Keith Busch, Christoph Hellwig Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de> _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd 2019-11-05 6:15 ` Charles Machalow @ 2019-11-05 15:26 ` Keith Busch -1 siblings, 0 replies; 20+ messages in thread From: Keith Busch @ 2019-11-05 15:26 UTC (permalink / raw) To: Charles Machalow Cc: linux-nvme, marta.rybczynska, Jens Axboe, Christoph Hellwig, Sagi Grimberg, linux-kernel On Mon, Nov 04, 2019 at 10:15:10PM -0800, Charles Machalow wrote: > Changing nvme_passthru_cmd64 to add a field: rsvd2. This field is an explicit > marker for the padding space added on certain platforms as a result of the > enlargement of the result field from 32 bit to 64 bits in size. Charles, Could you reply with your "Signed-off-by" so I can apply this patch? Thanks. ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd @ 2019-11-05 15:26 ` Keith Busch 0 siblings, 0 replies; 20+ messages in thread From: Keith Busch @ 2019-11-05 15:26 UTC (permalink / raw) To: Charles Machalow Cc: Sagi Grimberg, linux-kernel, linux-nvme, Jens Axboe, marta.rybczynska, Christoph Hellwig On Mon, Nov 04, 2019 at 10:15:10PM -0800, Charles Machalow wrote: > Changing nvme_passthru_cmd64 to add a field: rsvd2. This field is an explicit > marker for the padding space added on certain platforms as a result of the > enlargement of the result field from 32 bit to 64 bits in size. Charles, Could you reply with your "Signed-off-by" so I can apply this patch? Thanks. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd 2019-11-05 15:26 ` Keith Busch @ 2019-11-05 20:56 ` Charles Machalow -1 siblings, 0 replies; 20+ messages in thread From: Charles Machalow @ 2019-11-05 20:56 UTC (permalink / raw) To: Keith Busch Cc: linux-nvme, marta.rybczynska, Jens Axboe, Christoph Hellwig, Sagi Grimberg, linux-kernel Sorry, still new to this process. Signed-off-by: Charles Machalow <csm10495@gmail.com> - Charlie Scott Machalow On Tue, Nov 5, 2019 at 7:26 AM Keith Busch <kbusch@kernel.org> wrote: > > On Mon, Nov 04, 2019 at 10:15:10PM -0800, Charles Machalow wrote: > > Changing nvme_passthru_cmd64 to add a field: rsvd2. This field is an explicit > > marker for the padding space added on certain platforms as a result of the > > enlargement of the result field from 32 bit to 64 bits in size. > > Charles, > Could you reply with your "Signed-off-by" so I can apply this patch? > Thanks. ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd @ 2019-11-05 20:56 ` Charles Machalow 0 siblings, 0 replies; 20+ messages in thread From: Charles Machalow @ 2019-11-05 20:56 UTC (permalink / raw) To: Keith Busch Cc: Sagi Grimberg, linux-kernel, linux-nvme, Jens Axboe, marta.rybczynska, Christoph Hellwig Sorry, still new to this process. Signed-off-by: Charles Machalow <csm10495@gmail.com> - Charlie Scott Machalow On Tue, Nov 5, 2019 at 7:26 AM Keith Busch <kbusch@kernel.org> wrote: > > On Mon, Nov 04, 2019 at 10:15:10PM -0800, Charles Machalow wrote: > > Changing nvme_passthru_cmd64 to add a field: rsvd2. This field is an explicit > > marker for the padding space added on certain platforms as a result of the > > enlargement of the result field from 32 bit to 64 bits in size. > > Charles, > Could you reply with your "Signed-off-by" so I can apply this patch? > Thanks. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd 2019-11-05 6:15 ` Charles Machalow @ 2019-11-05 21:21 ` Keith Busch -1 siblings, 0 replies; 20+ messages in thread From: Keith Busch @ 2019-11-05 21:21 UTC (permalink / raw) To: Charles Machalow Cc: linux-nvme, marta.rybczynska, Jens Axboe, Christoph Hellwig, Sagi Grimberg, linux-kernel Thanks, applied for the next 5.4-rc pull with an updated changelog to indicate the "Fixes" commit since not having the padding does indeed break the compat ioctl. ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd @ 2019-11-05 21:21 ` Keith Busch 0 siblings, 0 replies; 20+ messages in thread From: Keith Busch @ 2019-11-05 21:21 UTC (permalink / raw) To: Charles Machalow Cc: Sagi Grimberg, linux-kernel, linux-nvme, Jens Axboe, marta.rybczynska, Christoph Hellwig Thanks, applied for the next 5.4-rc pull with an updated changelog to indicate the "Fixes" commit since not having the padding does indeed break the compat ioctl. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2019-11-06 1:09 UTC | newest] Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-05 6:15 [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd Charles Machalow 2019-11-05 6:15 ` Charles Machalow 2019-11-05 7:39 ` Marta Rybczynska 2019-11-05 7:39 ` Marta Rybczynska 2019-11-05 15:31 ` Christoph Hellwig 2019-11-05 15:31 ` Christoph Hellwig 2019-11-06 0:08 ` Sasha Levin 2019-11-06 0:08 ` Sasha Levin 2019-11-06 0:18 ` Keith Busch 2019-11-06 0:18 ` Keith Busch 2019-11-06 1:09 ` Christoph Hellwig 2019-11-06 1:09 ` Christoph Hellwig 2019-11-05 14:34 ` Christoph Hellwig 2019-11-05 14:34 ` Christoph Hellwig 2019-11-05 15:26 ` Keith Busch 2019-11-05 15:26 ` Keith Busch 2019-11-05 20:56 ` Charles Machalow 2019-11-05 20:56 ` Charles Machalow 2019-11-05 21:21 ` Keith Busch 2019-11-05 21:21 ` Keith Busch
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.