From: Paul Mackerras <paulus@ozlabs.org>
To: Bharata B Rao <bharata@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
linux-mm@kvack.org, paulus@au1.ibm.com,
aneesh.kumar@linux.vnet.ibm.com, jglisse@redhat.com,
cclaudio@linux.ibm.com, linuxram@us.ibm.com,
sukadev@linux.vnet.ibm.com, hch@lst.de
Subject: Re: [PATCH v10 4/8] KVM: PPC: Radix changes for secure guest
Date: Wed, 6 Nov 2019 16:58:23 +1100 [thread overview]
Message-ID: <20191106055823.GE12069@oak.ozlabs.ibm.com> (raw)
In-Reply-To: <20191104041800.24527-5-bharata@linux.ibm.com>
On Mon, Nov 04, 2019 at 09:47:56AM +0530, Bharata B Rao wrote:
> - After the guest becomes secure, when we handle a page fault of a page
> belonging to SVM in HV, send that page to UV via UV_PAGE_IN.
> - Whenever a page is unmapped on the HV side, inform UV via UV_PAGE_INVAL.
> - Ensure all those routines that walk the secondary page tables of
> the guest don't do so in case of secure VM. For secure guest, the
> active secondary page tables are in secure memory and the secondary
> page tables in HV are freed when guest becomes secure.
Why do we free the page tables? Just to save a little memory? It
feels like it would make things more fragile.
Also, I don't see where the freeing gets done in this patch.
Paul.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@ozlabs.org>
To: Bharata B Rao <bharata@linux.ibm.com>
Cc: linuxram@us.ibm.com, cclaudio@linux.ibm.com,
kvm-ppc@vger.kernel.org, linux-mm@kvack.org, jglisse@redhat.com,
aneesh.kumar@linux.vnet.ibm.com, paulus@au1.ibm.com,
sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
hch@lst.de
Subject: Re: [PATCH v10 4/8] KVM: PPC: Radix changes for secure guest
Date: Wed, 6 Nov 2019 16:58:23 +1100 [thread overview]
Message-ID: <20191106055823.GE12069@oak.ozlabs.ibm.com> (raw)
In-Reply-To: <20191104041800.24527-5-bharata@linux.ibm.com>
On Mon, Nov 04, 2019 at 09:47:56AM +0530, Bharata B Rao wrote:
> - After the guest becomes secure, when we handle a page fault of a page
> belonging to SVM in HV, send that page to UV via UV_PAGE_IN.
> - Whenever a page is unmapped on the HV side, inform UV via UV_PAGE_INVAL.
> - Ensure all those routines that walk the secondary page tables of
> the guest don't do so in case of secure VM. For secure guest, the
> active secondary page tables are in secure memory and the secondary
> page tables in HV are freed when guest becomes secure.
Why do we free the page tables? Just to save a little memory? It
feels like it would make things more fragile.
Also, I don't see where the freeing gets done in this patch.
Paul.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@ozlabs.org>
To: Bharata B Rao <bharata@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
linux-mm@kvack.org, paulus@au1.ibm.com,
aneesh.kumar@linux.vnet.ibm.com, jglisse@redhat.com,
cclaudio@linux.ibm.com, linuxram@us.ibm.com,
sukadev@linux.vnet.ibm.com, hch@lst.de
Subject: Re: [PATCH v10 4/8] KVM: PPC: Radix changes for secure guest
Date: Wed, 06 Nov 2019 05:58:23 +0000 [thread overview]
Message-ID: <20191106055823.GE12069@oak.ozlabs.ibm.com> (raw)
In-Reply-To: <20191104041800.24527-5-bharata@linux.ibm.com>
On Mon, Nov 04, 2019 at 09:47:56AM +0530, Bharata B Rao wrote:
> - After the guest becomes secure, when we handle a page fault of a page
> belonging to SVM in HV, send that page to UV via UV_PAGE_IN.
> - Whenever a page is unmapped on the HV side, inform UV via UV_PAGE_INVAL.
> - Ensure all those routines that walk the secondary page tables of
> the guest don't do so in case of secure VM. For secure guest, the
> active secondary page tables are in secure memory and the secondary
> page tables in HV are freed when guest becomes secure.
Why do we free the page tables? Just to save a little memory? It
feels like it would make things more fragile.
Also, I don't see where the freeing gets done in this patch.
Paul.
next prev parent reply other threads:[~2019-11-06 5:58 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 4:17 [PATCH v10 0/8] KVM: PPC: Driver to manage pages of secure guest Bharata B Rao
2019-11-04 4:29 ` Bharata B Rao
2019-11-04 4:17 ` Bharata B Rao
2019-11-04 4:17 ` [PATCH v10 1/8] mm: ksm: Export ksm_madvise() Bharata B Rao
2019-11-04 4:29 ` Bharata B Rao
2019-11-04 4:17 ` Bharata B Rao
2019-11-06 4:33 ` Paul Mackerras
2019-11-06 4:33 ` Paul Mackerras
2019-11-06 4:33 ` Paul Mackerras
2019-11-06 6:45 ` Bharata B Rao
2019-11-06 6:57 ` Bharata B Rao
2019-11-06 6:45 ` Bharata B Rao
2019-11-07 5:45 ` Paul Mackerras
2019-11-07 5:45 ` Paul Mackerras
2019-11-07 5:45 ` Paul Mackerras
2019-11-15 14:10 ` Bharata B Rao
2019-11-15 14:22 ` Bharata B Rao
2019-11-15 14:10 ` Bharata B Rao
2019-11-04 4:17 ` [PATCH v10 2/8] KVM: PPC: Support for running secure guests Bharata B Rao
2019-11-04 4:29 ` Bharata B Rao
2019-11-04 4:17 ` Bharata B Rao
2019-11-06 4:34 ` Paul Mackerras
2019-11-06 4:34 ` Paul Mackerras
2019-11-06 4:34 ` Paul Mackerras
2019-11-04 4:17 ` [PATCH v10 3/8] KVM: PPC: Shared pages support for " Bharata B Rao
2019-11-04 4:29 ` Bharata B Rao
2019-11-04 4:17 ` Bharata B Rao
2019-11-06 4:52 ` Paul Mackerras
2019-11-06 4:52 ` Paul Mackerras
2019-11-06 4:52 ` Paul Mackerras
2019-11-06 8:22 ` Bharata B Rao
2019-11-06 8:34 ` Bharata B Rao
2019-11-06 8:22 ` Bharata B Rao
2019-11-06 8:29 ` Bharata B Rao
2019-11-06 8:41 ` Bharata B Rao
2019-11-06 8:29 ` Bharata B Rao
2019-11-04 4:17 ` [PATCH v10 4/8] KVM: PPC: Radix changes for secure guest Bharata B Rao
2019-11-04 4:29 ` Bharata B Rao
2019-11-04 4:17 ` Bharata B Rao
2019-11-06 5:58 ` Paul Mackerras [this message]
2019-11-06 5:58 ` Paul Mackerras
2019-11-06 5:58 ` Paul Mackerras
2019-11-06 8:36 ` Bharata B Rao
2019-11-06 8:48 ` Bharata B Rao
2019-11-06 8:36 ` Bharata B Rao
2019-11-04 4:17 ` [PATCH v10 5/8] KVM: PPC: Handle memory plug/unplug to secure VM Bharata B Rao
2019-11-04 4:29 ` Bharata B Rao
2019-11-04 4:17 ` Bharata B Rao
2019-11-11 4:25 ` Paul Mackerras
2019-11-11 4:25 ` Paul Mackerras
2019-11-11 4:25 ` Paul Mackerras
2019-11-04 4:17 ` [PATCH v10 6/8] KVM: PPC: Support reset of secure guest Bharata B Rao
2019-11-04 4:29 ` Bharata B Rao
2019-11-04 4:17 ` Bharata B Rao
2019-11-11 5:28 ` Paul Mackerras
2019-11-11 5:28 ` Paul Mackerras
2019-11-11 5:28 ` Paul Mackerras
2019-11-11 6:55 ` Bharata B Rao
2019-11-11 6:55 ` Bharata B Rao
2019-11-11 6:55 ` Bharata B Rao
2019-11-12 5:34 ` Paul Mackerras
2019-11-12 5:34 ` Paul Mackerras
2019-11-12 5:34 ` Paul Mackerras
2019-11-13 15:29 ` Bharata B Rao
2019-11-13 15:41 ` Bharata B Rao
2019-11-13 15:29 ` Bharata B Rao
2019-11-14 5:07 ` Paul Mackerras
2019-11-14 5:07 ` Paul Mackerras
2019-11-14 5:07 ` Paul Mackerras
2019-11-04 4:17 ` [PATCH v10 7/8] KVM: PPC: Implement H_SVM_INIT_ABORT hcall Bharata B Rao
2019-11-04 4:29 ` Bharata B Rao
2019-11-04 4:17 ` Bharata B Rao
2019-11-11 4:19 ` Paul Mackerras
2019-11-11 4:19 ` Paul Mackerras
2019-11-11 4:19 ` Paul Mackerras
2019-11-12 1:01 ` Ram Pai
2019-11-12 1:01 ` Ram Pai
2019-11-12 1:01 ` Ram Pai
2019-11-12 5:38 ` Paul Mackerras
2019-11-12 5:38 ` Paul Mackerras
2019-11-12 5:38 ` Paul Mackerras
2019-11-12 7:52 ` Ram Pai
2019-11-12 7:52 ` Ram Pai
2019-11-12 7:52 ` Ram Pai
2019-11-12 11:32 ` Paul Mackerras
2019-11-12 11:32 ` Paul Mackerras
2019-11-12 11:32 ` Paul Mackerras
2019-11-12 14:45 ` Ram Pai
2019-11-12 14:45 ` Ram Pai
2019-11-12 14:45 ` Ram Pai
2019-11-13 0:14 ` Paul Mackerras
2019-11-13 0:14 ` Paul Mackerras
2019-11-13 0:14 ` Paul Mackerras
2019-11-13 6:32 ` Ram Pai
2019-11-13 6:32 ` Ram Pai
2019-11-13 6:32 ` Ram Pai
2019-11-13 21:18 ` Paul Mackerras
2019-11-13 21:18 ` Paul Mackerras
2019-11-13 21:18 ` Paul Mackerras
2019-11-13 21:50 ` Ram Pai
2019-11-13 21:50 ` Ram Pai
2019-11-13 21:50 ` Ram Pai
2019-11-14 5:08 ` Paul Mackerras
2019-11-14 5:08 ` Paul Mackerras
2019-11-14 5:08 ` Paul Mackerras
2019-11-14 7:02 ` Ram Pai
2019-11-14 7:02 ` Ram Pai
2019-11-14 7:02 ` Ram Pai
2019-11-04 4:18 ` [PATCH v10 8/8] KVM: PPC: Ultravisor: Add PPC_UV config option Bharata B Rao
2019-11-04 4:30 ` Bharata B Rao
2019-11-04 4:18 ` Bharata B Rao
2019-11-06 4:30 ` [PATCH v10 0/8] KVM: PPC: Driver to manage pages of secure guest Paul Mackerras
2019-11-06 4:30 ` Paul Mackerras
2019-11-06 4:30 ` Paul Mackerras
2019-11-06 6:20 ` Bharata B Rao
2019-11-06 6:32 ` Bharata B Rao
2019-11-06 6:20 ` Bharata B Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106055823.GE12069@oak.ozlabs.ibm.com \
--to=paulus@ozlabs.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=bharata@linux.ibm.com \
--cc=cclaudio@linux.ibm.com \
--cc=hch@lst.de \
--cc=jglisse@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=paulus@au1.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.