All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] rockchip: rk3399: rock960: Update config for TPL
@ 2019-11-06 11:43 Peter Robinson
  2019-11-07  9:11 ` Kever Yang
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Robinson @ 2019-11-06 11:43 UTC (permalink / raw)
  To: u-boot

The SPL is now running at SDRAM, and 0x10000 is used by BL31,
and the ARM SPL do not support relocate now, we need reserved
0x50000 so that it won't overwrite the code when we load the
bl31 to target space.
We should remove this after we enable the relocate feature.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 configs/rock960-rk3399_defconfig | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/configs/rock960-rk3399_defconfig b/configs/rock960-rk3399_defconfig
index cb3c68db6b..01b84a4742 100644
--- a/configs/rock960-rk3399_defconfig
+++ b/configs/rock960-rk3399_defconfig
@@ -8,13 +8,15 @@ CONFIG_SPL_STACK_R_ADDR=0x80000
 CONFIG_DEBUG_UART_BASE=0xFF1A0000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART=y
-CONFIG_SPL_TEXT_BASE=0xff8c2000
 CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rock960.dtb"
 # CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
 # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
 CONFIG_SPL_STACK_R=y
-CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x4000
+CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x10000
+CONFIG_SPL_ATF=y
+CONFIG_SPL_ATF_NO_PLATFORM_PARAM=y
+CONFIG_TPL=y
 CONFIG_SYS_PROMPT="rock960 => "
 CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_GPT=y
@@ -56,4 +58,6 @@ CONFIG_USB_ETHER_ASIX88179=y
 CONFIG_USB_ETHER_MCS7830=y
 CONFIG_USB_ETHER_RTL8152=y
 CONFIG_USB_ETHER_SMSC95XX=y
+CONFIG_USE_TINY_PRINTF=y
+CONFIG_SPL_TINY_MEMSET=y
 CONFIG_ERRNO_STR=y
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] rockchip: rk3399: rock960: Update config for TPL
  2019-11-06 11:43 [U-Boot] [PATCH] rockchip: rk3399: rock960: Update config for TPL Peter Robinson
@ 2019-11-07  9:11 ` Kever Yang
  0 siblings, 0 replies; 6+ messages in thread
From: Kever Yang @ 2019-11-07  9:11 UTC (permalink / raw)
  To: u-boot


On 2019/11/6 下午7:43, Peter Robinson wrote:
> The SPL is now running at SDRAM, and 0x10000 is used by BL31,
> and the ARM SPL do not support relocate now, we need reserved
> 0x50000 so that it won't overwrite the code when we load the
> bl31 to target space.
> We should remove this after we enable the relocate feature.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>


Reviewed-by: Kever Yang <kever.yang@rock-chips.com>


Thanks,

- Kever

> ---
>   configs/rock960-rk3399_defconfig | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/configs/rock960-rk3399_defconfig b/configs/rock960-rk3399_defconfig
> index cb3c68db6b..01b84a4742 100644
> --- a/configs/rock960-rk3399_defconfig
> +++ b/configs/rock960-rk3399_defconfig
> @@ -8,13 +8,15 @@ CONFIG_SPL_STACK_R_ADDR=0x80000
>   CONFIG_DEBUG_UART_BASE=0xFF1A0000
>   CONFIG_DEBUG_UART_CLOCK=24000000
>   CONFIG_DEBUG_UART=y
> -CONFIG_SPL_TEXT_BASE=0xff8c2000
>   CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rock960.dtb"
>   # CONFIG_DISPLAY_CPUINFO is not set
>   CONFIG_DISPLAY_BOARDINFO_LATE=y
>   # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
>   CONFIG_SPL_STACK_R=y
> -CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x4000
> +CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x10000
> +CONFIG_SPL_ATF=y
> +CONFIG_SPL_ATF_NO_PLATFORM_PARAM=y
> +CONFIG_TPL=y
>   CONFIG_SYS_PROMPT="rock960 => "
>   CONFIG_CMD_BOOTZ=y
>   CONFIG_CMD_GPT=y
> @@ -56,4 +58,6 @@ CONFIG_USB_ETHER_ASIX88179=y
>   CONFIG_USB_ETHER_MCS7830=y
>   CONFIG_USB_ETHER_RTL8152=y
>   CONFIG_USB_ETHER_SMSC95XX=y
> +CONFIG_USE_TINY_PRINTF=y
> +CONFIG_SPL_TINY_MEMSET=y
>   CONFIG_ERRNO_STR=y

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] rockchip: rk3399: rock960: Update config for TPL
  2019-10-14  8:58 ` Kever Yang
@ 2019-11-06 11:44   ` Peter Robinson
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Robinson @ 2019-11-06 11:44 UTC (permalink / raw)
  To: u-boot

On Mon, Oct 14, 2019 at 9:58 AM Kever Yang <kever.yang@rock-chips.com> wrote:
>
> Hi Peter,
>
> On 2019/10/9 下午7:20, Peter Robinson wrote:
>
> The SPL is now running at SDRAM, and 0x10000 is used by BL31,
> and the ARM SPL do not support relocate now, we need reserved
> 0x50000 so that it won't overwrite the code when we load the
> bl31 to target space.
> We should remove this after we enable the relocate feature.
>
> The SPL need malloc 0x9000 for MMC as buffer used for transfer
> data to IRAM(The EMMC DMA can not transfer data to IRAM directly).
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  configs/rock960-rk3399_defconfig | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/configs/rock960-rk3399_defconfig b/configs/rock960-rk3399_defconfig
> index cb3c68db6b..f211a65587 100644
> --- a/configs/rock960-rk3399_defconfig
> +++ b/configs/rock960-rk3399_defconfig
> @@ -2,19 +2,21 @@ CONFIG_ARM=y
>  CONFIG_ARCH_ROCKCHIP=y
>  CONFIG_SYS_TEXT_BASE=0x00200000
>  CONFIG_ROCKCHIP_RK3399=y
> -CONFIG_ROCKCHIP_SPL_RESERVE_IRAM=0x4000
> +CONFIG_ROCKCHIP_SPL_RESERVE_IRAM=0x50000
>
>
> Could you update this to '0x0'(drop this line to use default value) since I have
>
> already update this in another mail[0], I can merge them together.

Update sent.

Thanks,
Peter

> Thanks,
>
> - Kever
>
> [0] https://patchwork.ozlabs.org/patch/1173719/
>
>  CONFIG_TARGET_ROCK960_RK3399=y
>  CONFIG_SPL_STACK_R_ADDR=0x80000
>  CONFIG_DEBUG_UART_BASE=0xFF1A0000
>  CONFIG_DEBUG_UART_CLOCK=24000000
>  CONFIG_DEBUG_UART=y
> -CONFIG_SPL_TEXT_BASE=0xff8c2000
>  CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rock960.dtb"
>  # CONFIG_DISPLAY_CPUINFO is not set
>  CONFIG_DISPLAY_BOARDINFO_LATE=y
>  # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
>  CONFIG_SPL_STACK_R=y
> -CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x4000
> +CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x10000
> +CONFIG_SPL_ATF=y
> +CONFIG_SPL_ATF_NO_PLATFORM_PARAM=y
> +CONFIG_TPL=y
>  CONFIG_SYS_PROMPT="rock960 => "
>  CONFIG_CMD_BOOTZ=y
>  CONFIG_CMD_GPT=y
> @@ -56,4 +58,6 @@ CONFIG_USB_ETHER_ASIX88179=y
>  CONFIG_USB_ETHER_MCS7830=y
>  CONFIG_USB_ETHER_RTL8152=y
>  CONFIG_USB_ETHER_SMSC95XX=y
> +CONFIG_USE_TINY_PRINTF=y
> +CONFIG_SPL_TINY_MEMSET=y
>  CONFIG_ERRNO_STR=y

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] rockchip: rk3399: rock960: Update config for TPL
  2019-10-09 11:20 Peter Robinson
  2019-10-12 18:44 ` Anand Moon
@ 2019-10-14  8:58 ` Kever Yang
  2019-11-06 11:44   ` Peter Robinson
  1 sibling, 1 reply; 6+ messages in thread
From: Kever Yang @ 2019-10-14  8:58 UTC (permalink / raw)
  To: u-boot

Hi Peter,

On 2019/10/9 下午7:20, Peter Robinson wrote:
> The SPL is now running at SDRAM, and 0x10000 is used by BL31,
> and the ARM SPL do not support relocate now, we need reserved
> 0x50000 so that it won't overwrite the code when we load the
> bl31 to target space.
> We should remove this after we enable the relocate feature.
>
> The SPL need malloc 0x9000 for MMC as buffer used for transfer
> data to IRAM(The EMMC DMA can not transfer data to IRAM directly).
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>   configs/rock960-rk3399_defconfig | 10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/configs/rock960-rk3399_defconfig b/configs/rock960-rk3399_defconfig
> index cb3c68db6b..f211a65587 100644
> --- a/configs/rock960-rk3399_defconfig
> +++ b/configs/rock960-rk3399_defconfig
> @@ -2,19 +2,21 @@ CONFIG_ARM=y
>   CONFIG_ARCH_ROCKCHIP=y
>   CONFIG_SYS_TEXT_BASE=0x00200000
>   CONFIG_ROCKCHIP_RK3399=y
> -CONFIG_ROCKCHIP_SPL_RESERVE_IRAM=0x4000
> +CONFIG_ROCKCHIP_SPL_RESERVE_IRAM=0x50000


Could you update this to '0x0'(drop this line to use default value) 
since I have

already update this in another mail[0], I can merge them together.

Thanks,

- Kever

[0] https://patchwork.ozlabs.org/patch/1173719/ 
<https://patchwork.ozlabs.org/patch/1173719/>

>   CONFIG_TARGET_ROCK960_RK3399=y
>   CONFIG_SPL_STACK_R_ADDR=0x80000
>   CONFIG_DEBUG_UART_BASE=0xFF1A0000
>   CONFIG_DEBUG_UART_CLOCK=24000000
>   CONFIG_DEBUG_UART=y
> -CONFIG_SPL_TEXT_BASE=0xff8c2000
>   CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rock960.dtb"
>   # CONFIG_DISPLAY_CPUINFO is not set
>   CONFIG_DISPLAY_BOARDINFO_LATE=y
>   # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
>   CONFIG_SPL_STACK_R=y
> -CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x4000
> +CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x10000
> +CONFIG_SPL_ATF=y
> +CONFIG_SPL_ATF_NO_PLATFORM_PARAM=y
> +CONFIG_TPL=y
>   CONFIG_SYS_PROMPT="rock960 => "
>   CONFIG_CMD_BOOTZ=y
>   CONFIG_CMD_GPT=y
> @@ -56,4 +58,6 @@ CONFIG_USB_ETHER_ASIX88179=y
>   CONFIG_USB_ETHER_MCS7830=y
>   CONFIG_USB_ETHER_RTL8152=y
>   CONFIG_USB_ETHER_SMSC95XX=y
> +CONFIG_USE_TINY_PRINTF=y
> +CONFIG_SPL_TINY_MEMSET=y
>   CONFIG_ERRNO_STR=y

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] rockchip: rk3399: rock960: Update config for TPL
  2019-10-09 11:20 Peter Robinson
@ 2019-10-12 18:44 ` Anand Moon
  2019-10-14  8:58 ` Kever Yang
  1 sibling, 0 replies; 6+ messages in thread
From: Anand Moon @ 2019-10-12 18:44 UTC (permalink / raw)
  To: u-boot

Hi Peter,

On Wed, 9 Oct 2019 at 16:50, Peter Robinson <pbrobinson@gmail.com> wrote:
>
> The SPL is now running at SDRAM, and 0x10000 is used by BL31,
> and the ARM SPL do not support relocate now, we need reserved
> 0x50000 so that it won't overwrite the code when we load the
> bl31 to target space.
> We should remove this after we enable the relocate feature.
>
> The SPL need malloc 0x9000 for MMC as buffer used for transfer
> data to IRAM(The EMMC DMA can not transfer data to IRAM directly).
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

I have Rock960 Model A board, I have tied this patch but I cannot
get the board to boot up using microSD card with latest u-boot,
I have not tried to update the eMMC module with latest u-boot as of now.

But could you share the steps needed to build this images.
I follow this script
[0] https://pastebin.com/t6y7eWQL

If you could share some input on build the latest u-boot
and update the u-boot to microSD card of eMMC.

Is their any latest image available to this board using upstream
u-boot and kernel.

Best Regards
-Anand

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] rockchip: rk3399: rock960: Update config for TPL
@ 2019-10-09 11:20 Peter Robinson
  2019-10-12 18:44 ` Anand Moon
  2019-10-14  8:58 ` Kever Yang
  0 siblings, 2 replies; 6+ messages in thread
From: Peter Robinson @ 2019-10-09 11:20 UTC (permalink / raw)
  To: u-boot

The SPL is now running at SDRAM, and 0x10000 is used by BL31,
and the ARM SPL do not support relocate now, we need reserved
0x50000 so that it won't overwrite the code when we load the
bl31 to target space.
We should remove this after we enable the relocate feature.

The SPL need malloc 0x9000 for MMC as buffer used for transfer
data to IRAM(The EMMC DMA can not transfer data to IRAM directly).

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 configs/rock960-rk3399_defconfig | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/configs/rock960-rk3399_defconfig b/configs/rock960-rk3399_defconfig
index cb3c68db6b..f211a65587 100644
--- a/configs/rock960-rk3399_defconfig
+++ b/configs/rock960-rk3399_defconfig
@@ -2,19 +2,21 @@ CONFIG_ARM=y
 CONFIG_ARCH_ROCKCHIP=y
 CONFIG_SYS_TEXT_BASE=0x00200000
 CONFIG_ROCKCHIP_RK3399=y
-CONFIG_ROCKCHIP_SPL_RESERVE_IRAM=0x4000
+CONFIG_ROCKCHIP_SPL_RESERVE_IRAM=0x50000
 CONFIG_TARGET_ROCK960_RK3399=y
 CONFIG_SPL_STACK_R_ADDR=0x80000
 CONFIG_DEBUG_UART_BASE=0xFF1A0000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART=y
-CONFIG_SPL_TEXT_BASE=0xff8c2000
 CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rock960.dtb"
 # CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
 # CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
 CONFIG_SPL_STACK_R=y
-CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x4000
+CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x10000
+CONFIG_SPL_ATF=y
+CONFIG_SPL_ATF_NO_PLATFORM_PARAM=y
+CONFIG_TPL=y
 CONFIG_SYS_PROMPT="rock960 => "
 CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_GPT=y
@@ -56,4 +58,6 @@ CONFIG_USB_ETHER_ASIX88179=y
 CONFIG_USB_ETHER_MCS7830=y
 CONFIG_USB_ETHER_RTL8152=y
 CONFIG_USB_ETHER_SMSC95XX=y
+CONFIG_USE_TINY_PRINTF=y
+CONFIG_SPL_TINY_MEMSET=y
 CONFIG_ERRNO_STR=y
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-11-07  9:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 11:43 [U-Boot] [PATCH] rockchip: rk3399: rock960: Update config for TPL Peter Robinson
2019-11-07  9:11 ` Kever Yang
  -- strict thread matches above, loose matches on Subject: below --
2019-10-09 11:20 Peter Robinson
2019-10-12 18:44 ` Anand Moon
2019-10-14  8:58 ` Kever Yang
2019-11-06 11:44   ` Peter Robinson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.