All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] OMAP2: remove unused wakeup_cpu
@ 2019-11-06 12:06 ` Ben Dooks (Codethink)
  0 siblings, 0 replies; 3+ messages in thread
From: Ben Dooks (Codethink) @ 2019-11-06 12:06 UTC (permalink / raw)
  To: linux-kernel
  Cc: Tony Lindgren, linux-omap, Ben Dooks (Codethink),
	Russell King, linux-arm-kernel

The wakeup_cpu variable in omap4_enter_lowpower() is set
but then is not used after this. Remove it to fix
the compiler warning:

arch/arm/mach-omap2/omap-mpuss-lowpower.c: In function âomap4_enter_lowpowerâ:
arch/arm/mach-omap2/omap-mpuss-lowpower.c:230:15: warning: variable âwakeup_cpuâ set but not used [-Wunused-but-set-variable]

Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Tony Lindgren <tony@atomide.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
 arch/arm/mach-omap2/omap-mpuss-lowpower.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/mach-omap2/omap-mpuss-lowpower.c b/arch/arm/mach-omap2/omap-mpuss-lowpower.c
index 2d8f90546591..67fa28532a3a 100644
--- a/arch/arm/mach-omap2/omap-mpuss-lowpower.c
+++ b/arch/arm/mach-omap2/omap-mpuss-lowpower.c
@@ -227,7 +227,6 @@ int omap4_enter_lowpower(unsigned int cpu, unsigned int power_state)
 {
 	struct omap4_cpu_pm_info *pm_info = &per_cpu(omap4_pm_info, cpu);
 	unsigned int save_state = 0, cpu_logic_state = PWRDM_POWER_RET;
-	unsigned int wakeup_cpu;
 
 	if (omap_rev() == OMAP4430_REV_ES1_0)
 		return -ENXIO;
@@ -292,7 +291,6 @@ int omap4_enter_lowpower(unsigned int cpu, unsigned int power_state)
 	 * secure devices, CPUx does WFI which can result in
 	 * domain transition
 	 */
-	wakeup_cpu = smp_processor_id();
 	pwrdm_set_next_pwrst(pm_info->pwrdm, PWRDM_POWER_ON);
 
 	pwrdm_post_transition(NULL);
-- 
2.24.0.rc1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [PATCH] OMAP2: remove unused wakeup_cpu
@ 2019-11-06 12:06 ` Ben Dooks (Codethink)
  0 siblings, 0 replies; 3+ messages in thread
From: Ben Dooks (Codethink) @ 2019-11-06 12:06 UTC (permalink / raw)
  To: linux-kernel
  Cc: Tony Lindgren, linux-omap, Ben Dooks (Codethink),
	Russell King, linux-arm-kernel

The wakeup_cpu variable in omap4_enter_lowpower() is set
but then is not used after this. Remove it to fix
the compiler warning:

arch/arm/mach-omap2/omap-mpuss-lowpower.c: In function âomap4_enter_lowpowerâ:
arch/arm/mach-omap2/omap-mpuss-lowpower.c:230:15: warning: variable âwakeup_cpuâ set but not used [-Wunused-but-set-variable]

Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Tony Lindgren <tony@atomide.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
 arch/arm/mach-omap2/omap-mpuss-lowpower.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/mach-omap2/omap-mpuss-lowpower.c b/arch/arm/mach-omap2/omap-mpuss-lowpower.c
index 2d8f90546591..67fa28532a3a 100644
--- a/arch/arm/mach-omap2/omap-mpuss-lowpower.c
+++ b/arch/arm/mach-omap2/omap-mpuss-lowpower.c
@@ -227,7 +227,6 @@ int omap4_enter_lowpower(unsigned int cpu, unsigned int power_state)
 {
 	struct omap4_cpu_pm_info *pm_info = &per_cpu(omap4_pm_info, cpu);
 	unsigned int save_state = 0, cpu_logic_state = PWRDM_POWER_RET;
-	unsigned int wakeup_cpu;
 
 	if (omap_rev() == OMAP4430_REV_ES1_0)
 		return -ENXIO;
@@ -292,7 +291,6 @@ int omap4_enter_lowpower(unsigned int cpu, unsigned int power_state)
 	 * secure devices, CPUx does WFI which can result in
 	 * domain transition
 	 */
-	wakeup_cpu = smp_processor_id();
 	pwrdm_set_next_pwrst(pm_info->pwrdm, PWRDM_POWER_ON);
 
 	pwrdm_post_transition(NULL);
-- 
2.24.0.rc1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] OMAP2: remove unused wakeup_cpu
  2019-11-06 12:06 ` Ben Dooks (Codethink)
  (?)
@ 2019-11-11 20:45 ` Tony Lindgren
  -1 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2019-11-11 20:45 UTC (permalink / raw)
  To: Ben Dooks (Codethink)
  Cc: linux-kernel, linux-omap, Russell King, linux-arm-kernel

Hi,

* Ben Dooks (Codethink) <ben.dooks@codethink.co.uk> [191106 04:06]:
> The wakeup_cpu variable in omap4_enter_lowpower() is set
> but then is not used after this. Remove it to fix
> the compiler warning:
> 
> arch/arm/mach-omap2/omap-mpuss-lowpower.c: In function âomap4_enter_lowpowerâ:
> arch/arm/mach-omap2/omap-mpuss-lowpower.c:230:15: warning: variable âwakeup_cpuâ set but not used [-Wunused-but-set-variable]

I have already queued up an earlier similar patch:

5395b5557acb ("ARM: OMAP2+: Remove unused wakeup_cpu")

Thanks,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-11 20:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 12:06 [PATCH] OMAP2: remove unused wakeup_cpu Ben Dooks (Codethink)
2019-11-06 12:06 ` Ben Dooks (Codethink)
2019-11-11 20:45 ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.