[PATCH 2/2] rtc: bd70528: Fix hour register mask

[PATCH 2/2] rtc: bd70528: Fix hour register mask

[Matti Vaittinen]

When RTC is used in 24H mode (and it is by this driver) the maximum
hour value is 24 in BCD. This occupies bits [5:0] - which means
correct mask for HOUR register is 0x3f not 0x1f. Fix the mask

Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
 include/linux/mfd/rohm-bd70528.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/rohm-bd70528.h b/include/linux/mfd/rohm-bd70528.h
index 1013e60c5b25..b0109ee6dae2 100644
--- a/include/linux/mfd/rohm-bd70528.h
+++ b/include/linux/mfd/rohm-bd70528.h
@@ -317,7 +317,7 @@ enum {
 #define BD70528_MASK_RTC_MINUTE		0x7f
 #define BD70528_MASK_RTC_HOUR_24H	0x80
 #define BD70528_MASK_RTC_HOUR_PM	0x20
-#define BD70528_MASK_RTC_HOUR		0x1f
+#define BD70528_MASK_RTC_HOUR		0x3f
 #define BD70528_MASK_RTC_DAY		0x3f
 #define BD70528_MASK_RTC_WEEK		0x07
 #define BD70528_MASK_RTC_MONTH		0x1f
-- 
2.21.0


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 

Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

[Alexandre Belloni]

On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> When RTC is used in 24H mode (and it is by this driver) the maximum
> hour value is 24 in BCD. This occupies bits [5:0] - which means
> correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> 
> Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
>  include/linux/mfd/rohm-bd70528.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

[Alexandre Belloni]

On 05/11/2019 17:53:18+0100, Alexandre Belloni wrote:
> On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > When RTC is used in 24H mode (and it is by this driver) the maximum
> > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > 
> > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> >  include/linux/mfd/rohm-bd70528.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> Applied, thanks.
> 

Actually, is there any point in doing that since "rtc: bd70528 add
BD71828 support" will conflict with it and correct the issue anyway?

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

[Vaittinen, Matti]

Hello Alexandre,

I'd expect the BD71828 support to still take a while. I don't expect it
to land in next kernel release. I'd prefer getting this fix in now (and
I hope it might also get merged to earlier releases by the 'fixes'
tag). So if it's not a problem for you then please apply this fix now -
I can rebase the BD71828 support when this fix is out :)

Br,
	Matti Vaittinen

On Tue, 2019-11-05 at 17:57 +0100, Alexandre Belloni wrote:
> On 05/11/2019 17:53:18+0100, Alexandre Belloni wrote:
> > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > > When RTC is used in 24H mode (and it is by this driver) the
> > > maximum
> > > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > > 
> > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM
> > > bd70528 RTC")
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com
> > > >
> > > ---
> > >  include/linux/mfd/rohm-bd70528.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > Applied, thanks.
> > 
> 
> Actually, is there any point in doing that since "rtc: bd70528 add
> BD71828 support" will conflict with it and correct the issue anyway?
> 

Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

[Lee Jones]

On Tue, 05 Nov 2019, Alexandre Belloni wrote:

> On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > When RTC is used in 24H mode (and it is by this driver) the maximum
> > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > 
> > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> >  include/linux/mfd/rohm-bd70528.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> Applied, thanks.

You have been duped. This is clearly not an RTC patch.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

[Alexandre Belloni]

On 07/11/2019 10:59:49+0000, Lee Jones wrote:
> On Tue, 05 Nov 2019, Alexandre Belloni wrote:
> 
> > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > > When RTC is used in 24H mode (and it is by this driver) the maximum
> > > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > > 
> > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > > ---
> > >  include/linux/mfd/rohm-bd70528.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > Applied, thanks.
> 
> You have been duped. This is clearly not an RTC patch.
> 

Well, it only affects the RTC driver. Do you want to take it?

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

[Alexandre Belloni]

On 07/11/2019 12:33:53+0100, Alexandre Belloni wrote:
> On 07/11/2019 10:59:49+0000, Lee Jones wrote:
> > On Tue, 05 Nov 2019, Alexandre Belloni wrote:
> > 
> > > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > > > When RTC is used in 24H mode (and it is by this driver) the maximum
> > > > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > > > 
> > > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > > > ---
> > > >  include/linux/mfd/rohm-bd70528.h | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > Applied, thanks.
> > 
> > You have been duped. This is clearly not an RTC patch.
> > 
> 
> Well, it only affects the RTC driver. Do you want to take it?
> 

I've removed it from rtc-next, up to you to take it.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

[Vaittinen, Matti]

On Thu, 2019-11-07 at 10:59 +0000, Lee Jones wrote:
> On Tue, 05 Nov 2019, Alexandre Belloni wrote:
> 
> > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > > When RTC is used in 24H mode (and it is by this driver) the
> > > maximum
> > > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > > 
> > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM
> > > bd70528 RTC")
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com
> > > >
> > > ---
> > >  include/linux/mfd/rohm-bd70528.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > Applied, thanks.
> 
> You have been duped. This is clearly not an RTC patch.

Sorry. My bad. I used the rtc: prefix as this clearly is RTC fix -
although the header may be MFD territory. I should have known that
maintaining is done per file basis. I try to be more careful in the
future.

Br,
	Matti Vaittinen