[PATCH 1/2] USB: serial: mos7720: fix remote wakeup

[PATCH 1/2] USB: serial: mos7720: fix remote wakeup

[Johan Hovold]

The driver was setting the device remote-wakeup feature during probe in
violation of the USB specification (which says it should only be set
just prior to suspending the device). This could potentially waste
power during suspend as well as lead to spurious wakeups.

Note that USB core would clear the remote-wakeup feature at first
resume.

Fixes: 0f64478cbc7a ("USB: add USB serial mos7720 driver")
Cc: stable <stable@vger.kernel.org>     # 2.6.19
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/mos7720.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
index 18110225d506..2ec4eeacebc7 100644
--- a/drivers/usb/serial/mos7720.c
+++ b/drivers/usb/serial/mos7720.c
@@ -1833,10 +1833,6 @@ static int mos7720_startup(struct usb_serial *serial)
 	product = le16_to_cpu(serial->dev->descriptor.idProduct);
 	dev = serial->dev;
 
-	/* setting configuration feature to one */
-	usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),
-			(__u8)0x03, 0x00, 0x01, 0x00, NULL, 0x00, 5000);
-
 	if (product == MOSCHIP_DEVICE_ID_7715) {
 		struct urb *urb = serial->port[0]->interrupt_in_urb;
 
-- 
2.23.0

[PATCH 2/2] USB: serial: mos7840: fix remote wakeup

[Johan Hovold]

The driver was setting the device remote-wakeup feature during probe in
violation of the USB specification (which says it should only be set
just prior to suspending the device). This could potentially waste
power during suspend as well as lead to spurious wakeups.

Note that USB core would clear the remote-wakeup feature at first
resume.

Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
Cc: stable <stable@vger.kernel.org>     # 2.6.19
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/mos7840.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 3eeeee38debc..ab4bf8d6d7df 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -2290,11 +2290,6 @@ static int mos7840_port_probe(struct usb_serial_port *port)
 			goto error;
 		} else
 			dev_dbg(&port->dev, "ZLP_REG5 Writing success status%d\n", status);
-
-		/* setting configuration feature to one */
-		usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),
-				0x03, 0x00, 0x01, 0x00, NULL, 0x00,
-				MOS_WDR_TIMEOUT);
 	}
 	return 0;
 error:
-- 
2.23.0

Re: [PATCH 1/2] USB: serial: mos7720: fix remote wakeup

[Greg KH]

On Thu, Nov 07, 2019 at 02:21:18PM +0100, Johan Hovold wrote:
> The driver was setting the device remote-wakeup feature during probe in
> violation of the USB specification (which says it should only be set
> just prior to suspending the device). This could potentially waste
> power during suspend as well as lead to spurious wakeups.
> 
> Note that USB core would clear the remote-wakeup feature at first
> resume.
> 
> Fixes: 0f64478cbc7a ("USB: add USB serial mos7720 driver")
> Cc: stable <stable@vger.kernel.org>     # 2.6.19
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/usb/serial/mos7720.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
> index 18110225d506..2ec4eeacebc7 100644
> --- a/drivers/usb/serial/mos7720.c
> +++ b/drivers/usb/serial/mos7720.c
> @@ -1833,10 +1833,6 @@ static int mos7720_startup(struct usb_serial *serial)
>  	product = le16_to_cpu(serial->dev->descriptor.idProduct);
>  	dev = serial->dev;
>  
> -	/* setting configuration feature to one */
> -	usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),
> -			(__u8)0x03, 0x00, 0x01, 0x00, NULL, 0x00, 5000);
> -
>  	if (product == MOSCHIP_DEVICE_ID_7715) {
>  		struct urb *urb = serial->port[0]->interrupt_in_urb;
>  

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH 2/2] USB: serial: mos7840: fix remote wakeup

[Greg KH]

On Thu, Nov 07, 2019 at 02:21:19PM +0100, Johan Hovold wrote:
> The driver was setting the device remote-wakeup feature during probe in
> violation of the USB specification (which says it should only be set
> just prior to suspending the device). This could potentially waste
> power during suspend as well as lead to spurious wakeups.
> 
> Note that USB core would clear the remote-wakeup feature at first
> resume.
> 
> Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
> Cc: stable <stable@vger.kernel.org>     # 2.6.19
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/usb/serial/mos7840.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index 3eeeee38debc..ab4bf8d6d7df 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -2290,11 +2290,6 @@ static int mos7840_port_probe(struct usb_serial_port *port)
>  			goto error;
>  		} else
>  			dev_dbg(&port->dev, "ZLP_REG5 Writing success status%d\n", status);
> -
> -		/* setting configuration feature to one */
> -		usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),
> -				0x03, 0x00, 0x01, 0x00, NULL, 0x00,
> -				MOS_WDR_TIMEOUT);
>  	}
>  	return 0;
>  error:
> -- 
> 2.23.0

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>