All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2 1/3] fdt: fix bcm283x dm-pre-reloc definitions
@ 2019-11-07 16:43 matthias.bgg at kernel.org
  2019-11-07 16:43 ` [U-Boot] [PATCH v2 3/3] drivers: bcm283x: Set pre-location flag for OF_BOARD matthias.bgg at kernel.org
  2019-11-07 16:52 ` [U-Boot] [PATCH v2 1/3] fdt: fix bcm283x dm-pre-reloc definitions Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: matthias.bgg at kernel.org @ 2019-11-07 16:43 UTC (permalink / raw)
  To: u-boot

From: Matthias Brugger <mbrugger@suse.com>

In commmit
143256b353 ("fdt: update bcm283x device tree sources to Linux 5.1-rc6 state")
we delete the label for the node soc. As we don't need the to add the
property dm-pre-reloc to this node, we can delete it fomr
bcm283x-uboot.dtsi

Signed-off-by: Matthias Brugger <mbrugger@suse.com>

---

Changes in v2:
- node soc, does not need a label
- dm-pre-reloc not needed for node soc

 arch/arm/dts/bcm283x-uboot.dtsi | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/dts/bcm283x-uboot.dtsi b/arch/arm/dts/bcm283x-uboot.dtsi
index 6cc1aa3f93..36548dad62 100644
--- a/arch/arm/dts/bcm283x-uboot.dtsi
+++ b/arch/arm/dts/bcm283x-uboot.dtsi
@@ -6,10 +6,6 @@
  * (C) Copyright 2016 Fabian Vogt <fvogt@suse.com>
  */
 
-&soc {
-	u-boot,dm-pre-reloc;
-};
-
 &uart0 {
 	skip-init;
 	u-boot,dm-pre-reloc;
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2 3/3] drivers: bcm283x: Set pre-location flag for OF_BOARD
  2019-11-07 16:43 [U-Boot] [PATCH v2 1/3] fdt: fix bcm283x dm-pre-reloc definitions matthias.bgg at kernel.org
@ 2019-11-07 16:43 ` matthias.bgg at kernel.org
  2019-11-07 16:52 ` [U-Boot] [PATCH v2 1/3] fdt: fix bcm283x dm-pre-reloc definitions Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: matthias.bgg at kernel.org @ 2019-11-07 16:43 UTC (permalink / raw)
  To: u-boot

From: Matthias Brugger <mbrugger@suse.com>

U-Boot support on Raspberry Pi 4 relies on the device-tree
provided by the firmware. The blob does not contain the
U-Boot specific pre-loc-rel properties. The result is, that
the U-Boot banner is not printed.

We fix this by setting the DM_FLAG_PRE_RELOC flag in the driver,
if we rely on a device-tree provided by the firmware.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>

---

Changes in v2:
- add DM_FLAG_PRE_RELOC for RPi4 case

 drivers/pinctrl/broadcom/pinctrl-bcm283x.c | 2 +-
 drivers/serial/serial_bcm283x_mu.c         | 2 +-
 drivers/serial/serial_bcm283x_pl011.c      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/broadcom/pinctrl-bcm283x.c b/drivers/pinctrl/broadcom/pinctrl-bcm283x.c
index 3be080d29e..1bb91d6eed 100644
--- a/drivers/pinctrl/broadcom/pinctrl-bcm283x.c
+++ b/drivers/pinctrl/broadcom/pinctrl-bcm283x.c
@@ -148,7 +148,7 @@ U_BOOT_DRIVER(pinctrl_bcm283x) = {
 	.priv_auto_alloc_size = sizeof(struct bcm283x_pinctrl_priv),
 	.ops		= &bcm283x_pinctrl_ops,
 	.probe		= bcm283x_pinctl_probe,
-#if !CONFIG_IS_ENABLED(OF_CONTROL)
+#if !CONFIG_IS_ENABLED(OF_CONTROL) || CONFIG_IS_ENABLED(OF_BOARD)
 	.flags		= DM_FLAG_PRE_RELOC,
 #endif
 };
diff --git a/drivers/serial/serial_bcm283x_mu.c b/drivers/serial/serial_bcm283x_mu.c
index bd1d89ec83..a6ffc84b96 100644
--- a/drivers/serial/serial_bcm283x_mu.c
+++ b/drivers/serial/serial_bcm283x_mu.c
@@ -199,7 +199,7 @@ U_BOOT_DRIVER(serial_bcm283x_mu) = {
 	.platdata_auto_alloc_size = sizeof(struct bcm283x_mu_serial_platdata),
 	.probe = bcm283x_mu_serial_probe,
 	.ops = &bcm283x_mu_serial_ops,
-#if !CONFIG_IS_ENABLED(OF_CONTROL)
+#if !CONFIG_IS_ENABLED(OF_CONTROL) || CONFIG_IS_ENABLED(OF_BOARD)
 	.flags = DM_FLAG_PRE_RELOC,
 #endif
 	.priv_auto_alloc_size = sizeof(struct bcm283x_mu_priv),
diff --git a/drivers/serial/serial_bcm283x_pl011.c b/drivers/serial/serial_bcm283x_pl011.c
index 2527bb8b1c..7d8ab7b716 100644
--- a/drivers/serial/serial_bcm283x_pl011.c
+++ b/drivers/serial/serial_bcm283x_pl011.c
@@ -90,7 +90,7 @@ U_BOOT_DRIVER(bcm283x_pl011_uart) = {
 	.platdata_auto_alloc_size = sizeof(struct pl01x_serial_platdata),
 	.probe	= pl01x_serial_probe,
 	.ops	= &bcm283x_pl011_serial_ops,
-#if !CONFIG_IS_ENABLED(OF_CONTROL)
+#if !CONFIG_IS_ENABLED(OF_CONTROL) || CONFIG_IS_ENABLED(OF_BOARD)
 	.flags	= DM_FLAG_PRE_RELOC,
 #endif
 	.priv_auto_alloc_size = sizeof(struct pl01x_priv),
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2 1/3] fdt: fix bcm283x dm-pre-reloc definitions
  2019-11-07 16:43 [U-Boot] [PATCH v2 1/3] fdt: fix bcm283x dm-pre-reloc definitions matthias.bgg at kernel.org
  2019-11-07 16:43 ` [U-Boot] [PATCH v2 3/3] drivers: bcm283x: Set pre-location flag for OF_BOARD matthias.bgg at kernel.org
@ 2019-11-07 16:52 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2019-11-07 16:52 UTC (permalink / raw)
  To: u-boot

On Thu, Nov 07, 2019 at 05:43:35PM +0100, matthias.bgg at kernel.org wrote:

> From: Matthias Brugger <mbrugger@suse.com>
> 
> In commmit
> 143256b353 ("fdt: update bcm283x device tree sources to Linux 5.1-rc6 state")
> we delete the label for the node soc. As we don't need the to add the
> property dm-pre-reloc to this node, we can delete it fomr
> bcm283x-uboot.dtsi
> 
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> 

Tested-by: Tom Rini <trini@konsulko.com> [RPi 3, 32b and 64b modes]

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191107/6e559abe/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-07 16:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 16:43 [U-Boot] [PATCH v2 1/3] fdt: fix bcm283x dm-pre-reloc definitions matthias.bgg at kernel.org
2019-11-07 16:43 ` [U-Boot] [PATCH v2 3/3] drivers: bcm283x: Set pre-location flag for OF_BOARD matthias.bgg at kernel.org
2019-11-07 16:52 ` [U-Boot] [PATCH v2 1/3] fdt: fix bcm283x dm-pre-reloc definitions Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.