* [PATCH dma-debug: reorder struct dma_debug_entry fields
@ 2019-10-30 19:32 Eric Dumazet
2019-11-07 17:44 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2019-10-30 19:32 UTC (permalink / raw)
To: Christoph Hellwig
Cc: linux-kernel, Eric Dumazet, Eric Dumazet, Marek Szyprowski
This patch moves all fields used during exact match
lookups to the first cache line.
This makes debug_dma_mapping_error() and friends
about 50% faster.
Since it removes two 32bit holes, force a cacheline
alignment on struct dma_debug_entry.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
---
kernel/dma/debug.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
index 35e2a853bff9c482d789ab331d79aaee07753a97..004496654aaa543a52fdd6684af5a87ef02ff054 100644
--- a/kernel/dma/debug.c
+++ b/kernel/dma/debug.c
@@ -54,33 +54,33 @@ enum map_err_types {
* struct dma_debug_entry - track a dma_map* or dma_alloc_coherent mapping
* @list: node on pre-allocated free_entries list
* @dev: 'dev' argument to dma_map_{page|single|sg} or dma_alloc_coherent
- * @type: single, page, sg, coherent
- * @pfn: page frame of the start address
- * @offset: offset of mapping relative to pfn
* @size: length of the mapping
+ * @type: single, page, sg, coherent
* @direction: enum dma_data_direction
* @sg_call_ents: 'nents' from dma_map_sg
* @sg_mapped_ents: 'mapped_ents' from dma_map_sg
+ * @pfn: page frame of the start address
+ * @offset: offset of mapping relative to pfn
* @map_err_type: track whether dma_mapping_error() was checked
* @stacktrace: support backtraces when a violation is detected
*/
struct dma_debug_entry {
struct list_head list;
struct device *dev;
- int type;
- unsigned long pfn;
- size_t offset;
u64 dev_addr;
u64 size;
+ int type;
int direction;
int sg_call_ents;
int sg_mapped_ents;
+ unsigned long pfn;
+ size_t offset;
enum map_err_types map_err_type;
#ifdef CONFIG_STACKTRACE
unsigned int stack_len;
unsigned long stack_entries[DMA_DEBUG_STACKTRACE_ENTRIES];
#endif
-};
+} ____cacheline_aligned_in_smp;
typedef bool (*match_fn)(struct dma_debug_entry *, struct dma_debug_entry *);
--
2.24.0.rc0.303.g954a862665-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH dma-debug: reorder struct dma_debug_entry fields
2019-10-30 19:32 [PATCH dma-debug: reorder struct dma_debug_entry fields Eric Dumazet
@ 2019-11-07 17:44 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2019-11-07 17:44 UTC (permalink / raw)
To: Eric Dumazet
Cc: Christoph Hellwig, linux-kernel, Eric Dumazet, Marek Szyprowski
Thanks,
applied to the dma-mapping tree for 5.5.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-07 17:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30 19:32 [PATCH dma-debug: reorder struct dma_debug_entry fields Eric Dumazet
2019-11-07 17:44 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.