Re: [Xen-devel] [PATCH] tools: pygrub actually cross-compiles just fine

Re: [Xen-devel] [PATCH] tools: pygrub actually cross-compiles just fine

[Stefano Stabellini]

+ xen-devel

On Tue, 5 Nov 2019, Stefano Stabellini wrote:
> Actually, pygrub cross-compiles without issues. The cross-compilation
> work-around goes back to 2005 and it probably referred to PowerPC.
> 
> Remove the work-around now.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> CC: Christopher Clark <christopher.w.clark@gmail.com>
> ---
>  tools/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/Makefile b/tools/Makefile
> index 7b1f6c4d28..0a293b4a30 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -39,11 +39,11 @@ SUBDIRS-$(CONFIG_X86) += xenpaging
>  SUBDIRS-$(CONFIG_X86) += debugger/gdbsx
>  SUBDIRS-$(CONFIG_X86) += debugger/kdd
>  SUBDIRS-$(CONFIG_TESTS) += tests
> +SUBDIRS-y += python
> +SUBDIRS-y += pygrub
>  
>  # These don't cross-compile
>  ifeq ($(XEN_COMPILE_ARCH),$(XEN_TARGET_ARCH))
> -SUBDIRS-y += python
> -SUBDIRS-y += pygrub
>  SUBDIRS-$(OCAML_TOOLS) += ocaml
>  endif
>  
> -- 
> 2.17.1
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] tools: pygrub actually cross-compiles just fine

[Wei Liu]

Cc xen-devel

On Tue, Nov 05, 2019 at 03:51:13PM -0800, Stefano Stabellini wrote:
> Actually, pygrub cross-compiles without issues. The cross-compilation
> work-around goes back to 2005 and it probably referred to PowerPC.
> 
> Remove the work-around now.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> CC: Christopher Clark <christopher.w.clark@gmail.com>

Presumably you tried to cross-compile it for Arm? It would be good to
mention that in the commit message.

I think the content of this patch is fine:

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] tools: pygrub actually cross-compiles just fine

[Stefano Stabellini]

On Wed, 6 Nov 2019, Wei Liu wrote:
> On Tue, Nov 05, 2019 at 03:51:13PM -0800, Stefano Stabellini wrote:
> > Actually, pygrub cross-compiles without issues. The cross-compilation
> > work-around goes back to 2005 and it probably referred to PowerPC.
> > 
> > Remove the work-around now.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > CC: Christopher Clark <christopher.w.clark@gmail.com>
> 
> Presumably you tried to cross-compile it for Arm? It would be good to
> mention that in the commit message.
> 
> I think the content of this patch is fine:

It cross-compiles fine for aarch64 on x86_64 with Yocto.  Although we
don't do any cross-compilations in OSSTest as far as I know, so applying
the patch won't break OSSTest, given the state of the release, I think
it would be best to wait for the next merge window.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] tools: pygrub actually cross-compiles just fine

[Wei Liu]

On Wed, Nov 06, 2019 at 08:10:47AM -0800, Stefano Stabellini wrote:
> On Wed, 6 Nov 2019, Wei Liu wrote:
> > On Tue, Nov 05, 2019 at 03:51:13PM -0800, Stefano Stabellini wrote:
> > > Actually, pygrub cross-compiles without issues. The cross-compilation
> > > work-around goes back to 2005 and it probably referred to PowerPC.
> > > 
> > > Remove the work-around now.
> > > 
> > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > > CC: Christopher Clark <christopher.w.clark@gmail.com>
> > 
> > Presumably you tried to cross-compile it for Arm? It would be good to
> > mention that in the commit message.
> > 
> > I think the content of this patch is fine:
> 
> It cross-compiles fine for aarch64 on x86_64 with Yocto.  Although we
> don't do any cross-compilations in OSSTest as far as I know, so applying
> the patch won't break OSSTest, given the state of the release, I think
> it would be best to wait for the next merge window.

That's of course fine by me.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] tools: pygrub actually cross-compiles just fine

[Stefano Stabellini]

On Thu, 7 Nov 2019, Wei Liu wrote:
> On Wed, Nov 06, 2019 at 08:10:47AM -0800, Stefano Stabellini wrote:
> > On Wed, 6 Nov 2019, Wei Liu wrote:
> > > On Tue, Nov 05, 2019 at 03:51:13PM -0800, Stefano Stabellini wrote:
> > > > Actually, pygrub cross-compiles without issues. The cross-compilation
> > > > work-around goes back to 2005 and it probably referred to PowerPC.
> > > > 
> > > > Remove the work-around now.
> > > > 
> > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > > > CC: Christopher Clark <christopher.w.clark@gmail.com>
> > > 
> > > Presumably you tried to cross-compile it for Arm? It would be good to
> > > mention that in the commit message.
> > > 
> > > I think the content of this patch is fine:
> > 
> > It cross-compiles fine for aarch64 on x86_64 with Yocto.  Although we
> > don't do any cross-compilations in OSSTest as far as I know, so applying
> > the patch won't break OSSTest, given the state of the release, I think
> > it would be best to wait for the next merge window.
> 
> That's of course fine by me.

I'll resend the patch with a better commit message. It would be good to
get an ack if you are OK with it (of course there will be no committing
it right now.)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] tools: pygrub actually cross-compiles just fine

[Wei Liu]

On Thu, Nov 07, 2019 at 10:22:23AM -0800, Stefano Stabellini wrote:
> On Thu, 7 Nov 2019, Wei Liu wrote:
> > On Wed, Nov 06, 2019 at 08:10:47AM -0800, Stefano Stabellini wrote:
> > > On Wed, 6 Nov 2019, Wei Liu wrote:
> > > > On Tue, Nov 05, 2019 at 03:51:13PM -0800, Stefano Stabellini wrote:
> > > > > Actually, pygrub cross-compiles without issues. The cross-compilation
> > > > > work-around goes back to 2005 and it probably referred to PowerPC.
> > > > > 
> > > > > Remove the work-around now.
> > > > > 
> > > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > > > > CC: Christopher Clark <christopher.w.clark@gmail.com>
> > > > 
> > > > Presumably you tried to cross-compile it for Arm? It would be good to
> > > > mention that in the commit message.
> > > > 
> > > > I think the content of this patch is fine:
> > > 
> > > It cross-compiles fine for aarch64 on x86_64 with Yocto.  Although we
> > > don't do any cross-compilations in OSSTest as far as I know, so applying
> > > the patch won't break OSSTest, given the state of the release, I think
> > > it would be best to wait for the next merge window.
> > 
> > That's of course fine by me.
> 
> I'll resend the patch with a better commit message. It would be good to
> get an ack if you are OK with it (of course there will be no committing
> it right now.)

Acked-by: Wei Liu <wl@xen.org>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel