All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 01/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant
Date: Thu, 7 Nov 2019 20:22:36 +0100	[thread overview]
Message-ID: <20191107192236.GA961@kunai> (raw)
In-Reply-To: <cd25c799-bb10-aa59-8705-b079eff2165e@lucaceresoli.net>

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

Hi Luca,

> I beg your pardon for the newbie question, perhaps a stupid one, kind of
> nitpicking, and not even strictly related to this patch, but what's the
> reason for these functions being declared extern?

I did this for consistency reasons. I agree that the 'extern' keyword
could need some second thought, yet I think that should be a seperate
patchset. And that does not have priority for me, so if someone is
interested... :)

> For the rest LGTM, I did some grep checks before/after the patchset, ran
> some build tests, and everything looks fine.

Cool, thanks for your review!

All the best,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-11-07 19:22 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06  9:50 [RFC PATCH 00/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant Wolfram Sang
2019-11-06  9:50 ` Wolfram Sang
2019-11-06  9:50 ` Wolfram Sang
2019-11-06  9:50 ` Wolfram Sang
2019-11-06  9:50 ` [RFC PATCH 01/12] " Wolfram Sang
2019-11-06 12:39   ` Max Staudt
2019-11-07 17:31   ` Luca Ceresoli
2019-11-07 19:22     ` Wolfram Sang [this message]
2019-11-08  8:01       ` Luca Ceresoli
2019-11-28 16:16   ` Wolfram Sang
2019-11-06  9:50 ` [RFC PATCH 02/12] i2c: icy: convert to i2c_new_scanned_device Wolfram Sang
2019-11-06 11:33   ` Max Staudt
2019-11-28 16:16   ` Wolfram Sang
2019-11-06  9:50 ` [RFC PATCH 03/12] macintosh: " Wolfram Sang
2019-11-06  9:50   ` Wolfram Sang
2019-11-06  9:50 ` [RFC PATCH 04/12] platform: chrome: " Wolfram Sang
2019-11-06  9:50 ` [RFC PATCH 05/12] video: fbdev: matrox: " Wolfram Sang
2019-11-06  9:50   ` Wolfram Sang
2019-11-06  9:50   ` Wolfram Sang
2019-11-07  8:33   ` Daniel Vetter
2019-11-07  8:33     ` Daniel Vetter
2019-11-07  8:33     ` Daniel Vetter
2019-11-28 16:18     ` Wolfram Sang
2019-11-28 16:18       ` Wolfram Sang
2019-11-28 16:18       ` Wolfram Sang
2019-11-28 16:19   ` Wolfram Sang
2019-11-28 16:19     ` Wolfram Sang
2019-11-28 16:19     ` Wolfram Sang
2019-11-06  9:50 ` [RFC PATCH 06/12] input: mouse: " Wolfram Sang
2019-11-11 18:19   ` Dmitry Torokhov
2019-11-06  9:50 ` [RFC PATCH 07/12] media: pci: cx23885: " Wolfram Sang
2019-11-06 11:18   ` Hans Verkuil
2019-11-06  9:50 ` [RFC PATCH 08/12] media: pci: cx88: " Wolfram Sang
2019-11-06 11:18   ` Hans Verkuil
2019-11-06 14:49     ` Wolfram Sang
2019-11-06  9:50 ` [RFC PATCH 09/12] media: pci: bt8xx: " Wolfram Sang
2019-11-06 11:19   ` Hans Verkuil
2019-11-06  9:50 ` [RFC PATCH 10/12] media: pci: cx18: " Wolfram Sang
2019-11-06 11:23   ` Hans Verkuil
2019-11-06  9:50 ` [RFC PATCH 11/12] media: pci: ivtv: " Wolfram Sang
2019-11-06 11:21   ` Hans Verkuil
2019-11-06  9:50 ` [RFC PATCH 12/12] media: v4l2-core: " Wolfram Sang
2019-11-06 11:24   ` Hans Verkuil
2019-11-06 10:06 ` [RFC PATCH 00/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant Sean Young
2019-11-06 10:06   ` Sean Young
2019-11-06 10:06   ` Sean Young
2019-11-06 10:06   ` Sean Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107192236.GA961@kunai \
    --to=wsa@the-dreams.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@lucaceresoli.net \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.