From: kbuild test robot <lkp@intel.com>
To: Ganapatrao Prabhakerrao Kulkarni <gkulkarni@marvell.com>
Cc: kbuild-all@lists.01.org,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"will@kernel.org" <will@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"gklkml16@gmail.com" <gklkml16@gmail.com>
Subject: Re: [PATCH 1/2] perf/core: Adding capability to disable PMUs event multiplexing
Date: Fri, 8 Nov 2019 07:17:16 +0800 [thread overview]
Message-ID: <201911080713.ko4Px5eQ%lkp@intel.com> (raw)
In-Reply-To: <1573002091-9744-2-git-send-email-gkulkarni@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 2536 bytes --]
Hi Ganapatrao,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on arm-soc/for-next]
[also build test WARNING on v5.4-rc6 next-20191107]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Ganapatrao-Prabhakerrao-Kulkarni/perf-core-Adding-capability-to-disable-PMUs-event-multiplexing/20191108-054345
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git for-next
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
kernel/events/core.c: In function '__perf_mux_hrtimer_init':
>> kernel/events/core.c:1097:10: warning: 'return' with a value, in function returning void
return 0;
^
kernel/events/core.c:1085:13: note: declared here
static void __perf_mux_hrtimer_init(struct perf_cpu_context *cpuctx, int cpu)
^~~~~~~~~~~~~~~~~~~~~~~
vim +/return +1097 kernel/events/core.c
1084
1085 static void __perf_mux_hrtimer_init(struct perf_cpu_context *cpuctx, int cpu)
1086 {
1087 struct hrtimer *timer = &cpuctx->hrtimer;
1088 struct pmu *pmu = cpuctx->ctx.pmu;
1089 u64 interval;
1090
1091 /* no multiplexing needed for SW PMU */
1092 if (pmu->task_ctx_nr == perf_sw_context)
1093 return;
1094
1095 /* No PMU support */
1096 if (pmu->capabilities & PERF_PMU_CAP_NO_MUX_EVENTS)
> 1097 return 0;
1098
1099 /*
1100 * check default is sane, if not set then force to
1101 * default interval (1/tick)
1102 */
1103 interval = pmu->hrtimer_interval_ms;
1104 if (interval < 1)
1105 interval = pmu->hrtimer_interval_ms = PERF_CPU_HRTIMER;
1106
1107 cpuctx->hrtimer_interval = ns_to_ktime(NSEC_PER_MSEC * interval);
1108
1109 raw_spin_lock_init(&cpuctx->hrtimer_lock);
1110 hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_PINNED_HARD);
1111 timer->function = perf_mux_hrtimer_handler;
1112 }
1113
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 7207 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Ganapatrao Prabhakerrao Kulkarni <gkulkarni@marvell.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
kbuild-all@lists.01.org,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gklkml16@gmail.com" <gklkml16@gmail.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"will@kernel.org" <will@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] perf/core: Adding capability to disable PMUs event multiplexing
Date: Fri, 8 Nov 2019 07:17:16 +0800 [thread overview]
Message-ID: <201911080713.ko4Px5eQ%lkp@intel.com> (raw)
In-Reply-To: <1573002091-9744-2-git-send-email-gkulkarni@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 2536 bytes --]
Hi Ganapatrao,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on arm-soc/for-next]
[also build test WARNING on v5.4-rc6 next-20191107]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Ganapatrao-Prabhakerrao-Kulkarni/perf-core-Adding-capability-to-disable-PMUs-event-multiplexing/20191108-054345
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git for-next
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
kernel/events/core.c: In function '__perf_mux_hrtimer_init':
>> kernel/events/core.c:1097:10: warning: 'return' with a value, in function returning void
return 0;
^
kernel/events/core.c:1085:13: note: declared here
static void __perf_mux_hrtimer_init(struct perf_cpu_context *cpuctx, int cpu)
^~~~~~~~~~~~~~~~~~~~~~~
vim +/return +1097 kernel/events/core.c
1084
1085 static void __perf_mux_hrtimer_init(struct perf_cpu_context *cpuctx, int cpu)
1086 {
1087 struct hrtimer *timer = &cpuctx->hrtimer;
1088 struct pmu *pmu = cpuctx->ctx.pmu;
1089 u64 interval;
1090
1091 /* no multiplexing needed for SW PMU */
1092 if (pmu->task_ctx_nr == perf_sw_context)
1093 return;
1094
1095 /* No PMU support */
1096 if (pmu->capabilities & PERF_PMU_CAP_NO_MUX_EVENTS)
> 1097 return 0;
1098
1099 /*
1100 * check default is sane, if not set then force to
1101 * default interval (1/tick)
1102 */
1103 interval = pmu->hrtimer_interval_ms;
1104 if (interval < 1)
1105 interval = pmu->hrtimer_interval_ms = PERF_CPU_HRTIMER;
1106
1107 cpuctx->hrtimer_interval = ns_to_ktime(NSEC_PER_MSEC * interval);
1108
1109 raw_spin_lock_init(&cpuctx->hrtimer_lock);
1110 hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_PINNED_HARD);
1111 timer->function = perf_mux_hrtimer_handler;
1112 }
1113
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 7207 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 1/2] perf/core: Adding capability to disable PMUs event multiplexing
Date: Fri, 08 Nov 2019 07:17:16 +0800 [thread overview]
Message-ID: <201911080713.ko4Px5eQ%lkp@intel.com> (raw)
In-Reply-To: <1573002091-9744-2-git-send-email-gkulkarni@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 2605 bytes --]
Hi Ganapatrao,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on arm-soc/for-next]
[also build test WARNING on v5.4-rc6 next-20191107]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Ganapatrao-Prabhakerrao-Kulkarni/perf-core-Adding-capability-to-disable-PMUs-event-multiplexing/20191108-054345
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git for-next
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
kernel/events/core.c: In function '__perf_mux_hrtimer_init':
>> kernel/events/core.c:1097:10: warning: 'return' with a value, in function returning void
return 0;
^
kernel/events/core.c:1085:13: note: declared here
static void __perf_mux_hrtimer_init(struct perf_cpu_context *cpuctx, int cpu)
^~~~~~~~~~~~~~~~~~~~~~~
vim +/return +1097 kernel/events/core.c
1084
1085 static void __perf_mux_hrtimer_init(struct perf_cpu_context *cpuctx, int cpu)
1086 {
1087 struct hrtimer *timer = &cpuctx->hrtimer;
1088 struct pmu *pmu = cpuctx->ctx.pmu;
1089 u64 interval;
1090
1091 /* no multiplexing needed for SW PMU */
1092 if (pmu->task_ctx_nr == perf_sw_context)
1093 return;
1094
1095 /* No PMU support */
1096 if (pmu->capabilities & PERF_PMU_CAP_NO_MUX_EVENTS)
> 1097 return 0;
1098
1099 /*
1100 * check default is sane, if not set then force to
1101 * default interval (1/tick)
1102 */
1103 interval = pmu->hrtimer_interval_ms;
1104 if (interval < 1)
1105 interval = pmu->hrtimer_interval_ms = PERF_CPU_HRTIMER;
1106
1107 cpuctx->hrtimer_interval = ns_to_ktime(NSEC_PER_MSEC * interval);
1108
1109 raw_spin_lock_init(&cpuctx->hrtimer_lock);
1110 hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_PINNED_HARD);
1111 timer->function = perf_mux_hrtimer_handler;
1112 }
1113
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 7207 bytes --]
next prev parent reply other threads:[~2019-11-07 23:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 1:01 [PATCH 0/2] Workaround for ThunderX2 erratum 221 Ganapatrao Prabhakerrao Kulkarni
2019-11-06 1:01 ` Ganapatrao Prabhakerrao Kulkarni
2019-11-06 1:01 ` [PATCH 1/2] perf/core: Adding capability to disable PMUs event multiplexing Ganapatrao Prabhakerrao Kulkarni
2019-11-06 1:01 ` Ganapatrao Prabhakerrao Kulkarni
2019-11-06 9:40 ` Peter Zijlstra
2019-11-06 9:40 ` Peter Zijlstra
2019-11-06 9:58 ` Peter Zijlstra
2019-11-06 9:58 ` Peter Zijlstra
2019-11-06 11:28 ` Mark Rutland
2019-11-06 11:28 ` Mark Rutland
2019-11-06 23:28 ` Ganapatrao Kulkarni
2019-11-06 23:28 ` Ganapatrao Kulkarni
2019-11-07 14:35 ` Ganapatrao Kulkarni
2019-11-07 14:35 ` Ganapatrao Kulkarni
2019-11-07 14:52 ` Mark Rutland
2019-11-07 14:52 ` Mark Rutland
2019-11-07 15:45 ` Ganapatrao Kulkarni
2019-11-07 15:45 ` Ganapatrao Kulkarni
2019-11-07 15:54 ` Mark Rutland
2019-11-07 15:54 ` Mark Rutland
2019-11-07 15:04 ` Peter Zijlstra
2019-11-07 15:04 ` Peter Zijlstra
2019-11-07 23:17 ` kbuild test robot [this message]
2019-11-07 23:17 ` kbuild test robot
2019-11-07 23:17 ` kbuild test robot
2019-11-06 1:01 ` [PATCH 2/2] Thunderx2, uncore: Add workaround for ThunderX2 erratum 221 Ganapatrao Prabhakerrao Kulkarni
2019-11-06 1:01 ` Ganapatrao Prabhakerrao Kulkarni
2019-11-06 11:37 ` Mark Rutland
2019-11-06 11:37 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911080713.ko4Px5eQ%lkp@intel.com \
--to=lkp@intel.com \
--cc=corbet@lwn.net \
--cc=gklkml16@gmail.com \
--cc=gkulkarni@marvell.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.