From: Wambui Karuga <wambui.karugax@gmail.com> To: Sean Paul <sean@poorly.run> Cc: hjc@rock-chips.com, heiko@sntech.de, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output Date: Fri, 8 Nov 2019 15:46:30 +0300 [thread overview] Message-ID: <20191108124630.GA10207@wambui> (raw) In-Reply-To: <20191107133851.GF63329@art_vandelay> On Thu, Nov 07, 2019 at 08:38:51AM -0500, Sean Paul wrote: > On Thu, Nov 07, 2019 at 01:54:22AM -0800, Joe Perches wrote: > > On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > > > Replace the use of the dev_err macro with the DRM_DEV_ERROR > > > DRM helper macro. > > > > The commit message should show the reason _why_ you are doing > > this instead of just stating that you are doing this. > > > > It's not that dev_err is uncommon in drivers/gpu/drm. > > > > It is uncommon (this is the sole instance) in rockchip, however. So it makes > sense to convert the dev_* prints in rockchip to DRM_DEV for consistency. > > Wambui, could you also please convert the dev_warn instance as well? > Hey, Sean. Trying to convert this dev_warn instance, but the corresponding DRM_WARN macro does not take the dev parameter which seems to be useful in the original output. Should I still convert it to DRM_WARN without the hdmi->dev parameter? Thanks, wambui > I'll apply this to drm-misc-next and expand on the commit message a bit. > > Thanks, > > Sean > > > $ git grep -w dev_err drivers/gpu/drm | wc -l > > 1950 > > $ git grep -w DRM_DEV_ERROR drivers/gpu/drm | wc -l > > 756 > > > > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > > [] > > > @@ -916,7 +916,7 @@ static int dw_mipi_dsi_rockchip_probe(struct platform_device *pdev) > > > } > > > > > > if (!dsi->cdata) { > > > - dev_err(dev, "no dsi-config for %s node\n", np->name); > > > + DRM_DEV_ERROR(dev, "no dsi-config for %s node\n", np->name); > > > return -EINVAL; > > > } > > > > > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Sean Paul, Software Engineer, Google / Chromium OS
WARNING: multiple messages have this Message-ID (diff)
From: Wambui Karuga <wambui.karugax@gmail.com> To: Sean Paul <sean@poorly.run> Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output Date: Fri, 8 Nov 2019 15:46:30 +0300 [thread overview] Message-ID: <20191108124630.GA10207@wambui> (raw) Message-ID: <20191108124630._oGeinmwDMAGYqBlAN7doJ12ZZXC7jbzq7BQgPYJJUo@z> (raw) In-Reply-To: <20191107133851.GF63329@art_vandelay> On Thu, Nov 07, 2019 at 08:38:51AM -0500, Sean Paul wrote: > On Thu, Nov 07, 2019 at 01:54:22AM -0800, Joe Perches wrote: > > On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > > > Replace the use of the dev_err macro with the DRM_DEV_ERROR > > > DRM helper macro. > > > > The commit message should show the reason _why_ you are doing > > this instead of just stating that you are doing this. > > > > It's not that dev_err is uncommon in drivers/gpu/drm. > > > > It is uncommon (this is the sole instance) in rockchip, however. So it makes > sense to convert the dev_* prints in rockchip to DRM_DEV for consistency. > > Wambui, could you also please convert the dev_warn instance as well? > Hey, Sean. Trying to convert this dev_warn instance, but the corresponding DRM_WARN macro does not take the dev parameter which seems to be useful in the original output. Should I still convert it to DRM_WARN without the hdmi->dev parameter? Thanks, wambui > I'll apply this to drm-misc-next and expand on the commit message a bit. > > Thanks, > > Sean > > > $ git grep -w dev_err drivers/gpu/drm | wc -l > > 1950 > > $ git grep -w DRM_DEV_ERROR drivers/gpu/drm | wc -l > > 756 > > > > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > > [] > > > @@ -916,7 +916,7 @@ static int dw_mipi_dsi_rockchip_probe(struct platform_device *pdev) > > > } > > > > > > if (!dsi->cdata) { > > > - dev_err(dev, "no dsi-config for %s node\n", np->name); > > > + DRM_DEV_ERROR(dev, "no dsi-config for %s node\n", np->name); > > > return -EINVAL; > > > } > > > > > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-08 12:46 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-07 9:29 [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output Wambui Karuga 2019-11-07 9:29 ` Wambui Karuga 2019-11-07 9:29 ` Wambui Karuga 2019-11-07 9:54 ` Joe Perches 2019-11-07 9:54 ` Joe Perches 2019-11-07 9:54 ` Joe Perches 2019-11-07 13:38 ` Sean Paul 2019-11-07 13:38 ` Sean Paul 2019-11-07 13:38 ` Sean Paul 2019-11-07 18:22 ` Wambui Karuga 2019-11-07 18:22 ` Wambui Karuga 2019-11-08 12:46 ` Wambui Karuga [this message] 2019-11-08 12:46 ` Wambui Karuga 2019-11-08 14:06 ` Heiko Stübner 2019-11-08 14:06 ` Heiko Stübner 2019-11-08 14:06 ` Heiko Stübner 2019-11-08 16:06 ` Sean Paul 2019-11-08 16:06 ` Sean Paul 2019-11-08 16:06 ` Sean Paul 2019-11-08 20:07 ` Wambui Karuga 2019-11-08 20:07 ` Wambui Karuga 2019-11-08 20:07 ` Wambui Karuga 2019-11-09 0:42 ` Joe Perches 2019-11-09 0:42 ` Joe Perches 2019-11-09 0:42 ` Joe Perches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191108124630.GA10207@wambui \ --to=wambui.karugax@gmail.com \ --cc=20191107133851.GF63329@art_vandelay \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=heiko@sntech.de \ --cc=hjc@rock-chips.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.