* [PATCH 1/3] drm/i915/bios: rename bios to oprom when mapping pci rom
@ 2019-11-08 21:13 ` Lucas De Marchi
0 siblings, 0 replies; 14+ messages in thread
From: Lucas De Marchi @ 2019-11-08 21:13 UTC (permalink / raw)
To: intel-gfx
oprom is actually a better name to use when using
pci_map_rom(). "bios" is way too generic and confusing.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191108003602.33526-2-lucas.demarchi@intel.com
---
drivers/gpu/drm/i915/display/intel_bios.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index a03f56b7b4ef..1f83616cfc32 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1804,7 +1804,7 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
return vbt;
}
-static const struct vbt_header *find_vbt(void __iomem *bios, size_t size)
+static const struct vbt_header *find_vbt(void __iomem *oprom, size_t size)
{
size_t i;
@@ -1812,14 +1812,14 @@ static const struct vbt_header *find_vbt(void __iomem *bios, size_t size)
for (i = 0; i + 4 < size; i++) {
void *vbt;
- if (ioread32(bios + i) != *((const u32 *) "$VBT"))
+ if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
continue;
/*
* This is the one place where we explicitly discard the address
* space (__iomem) of the BIOS/VBT.
*/
- vbt = (void __force *) bios + i;
+ vbt = (void __force *)oprom + i;
if (intel_bios_is_valid_vbt(vbt, size - i))
return vbt;
@@ -1842,7 +1842,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
struct pci_dev *pdev = dev_priv->drm.pdev;
const struct vbt_header *vbt = dev_priv->opregion.vbt;
const struct bdb_header *bdb;
- u8 __iomem *bios = NULL;
+ u8 __iomem *oprom = NULL;
if (!HAS_DISPLAY(dev_priv) || !INTEL_DISPLAY_ENABLED(dev_priv)) {
DRM_DEBUG_KMS("Skipping VBT init due to disabled display.\n");
@@ -1855,11 +1855,11 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
if (!vbt) {
size_t size;
- bios = pci_map_rom(pdev, &size);
- if (!bios)
+ oprom = pci_map_rom(pdev, &size);
+ if (!oprom)
goto out;
- vbt = find_vbt(bios, size);
+ vbt = find_vbt(oprom, size);
if (!vbt)
goto out;
@@ -1893,8 +1893,8 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
init_vbt_missing_defaults(dev_priv);
}
- if (bios)
- pci_unmap_rom(pdev, bios);
+ if (oprom)
+ pci_unmap_rom(pdev, oprom);
}
/**
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 1/3] drm/i915/bios: rename bios to oprom when mapping pci rom
@ 2019-11-08 21:13 ` Lucas De Marchi
0 siblings, 0 replies; 14+ messages in thread
From: Lucas De Marchi @ 2019-11-08 21:13 UTC (permalink / raw)
To: intel-gfx
oprom is actually a better name to use when using
pci_map_rom(). "bios" is way too generic and confusing.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191108003602.33526-2-lucas.demarchi@intel.com
---
drivers/gpu/drm/i915/display/intel_bios.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index a03f56b7b4ef..1f83616cfc32 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1804,7 +1804,7 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
return vbt;
}
-static const struct vbt_header *find_vbt(void __iomem *bios, size_t size)
+static const struct vbt_header *find_vbt(void __iomem *oprom, size_t size)
{
size_t i;
@@ -1812,14 +1812,14 @@ static const struct vbt_header *find_vbt(void __iomem *bios, size_t size)
for (i = 0; i + 4 < size; i++) {
void *vbt;
- if (ioread32(bios + i) != *((const u32 *) "$VBT"))
+ if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
continue;
/*
* This is the one place where we explicitly discard the address
* space (__iomem) of the BIOS/VBT.
*/
- vbt = (void __force *) bios + i;
+ vbt = (void __force *)oprom + i;
if (intel_bios_is_valid_vbt(vbt, size - i))
return vbt;
@@ -1842,7 +1842,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
struct pci_dev *pdev = dev_priv->drm.pdev;
const struct vbt_header *vbt = dev_priv->opregion.vbt;
const struct bdb_header *bdb;
- u8 __iomem *bios = NULL;
+ u8 __iomem *oprom = NULL;
if (!HAS_DISPLAY(dev_priv) || !INTEL_DISPLAY_ENABLED(dev_priv)) {
DRM_DEBUG_KMS("Skipping VBT init due to disabled display.\n");
@@ -1855,11 +1855,11 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
if (!vbt) {
size_t size;
- bios = pci_map_rom(pdev, &size);
- if (!bios)
+ oprom = pci_map_rom(pdev, &size);
+ if (!oprom)
goto out;
- vbt = find_vbt(bios, size);
+ vbt = find_vbt(oprom, size);
if (!vbt)
goto out;
@@ -1893,8 +1893,8 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
init_vbt_missing_defaults(dev_priv);
}
- if (bios)
- pci_unmap_rom(pdev, bios);
+ if (oprom)
+ pci_unmap_rom(pdev, oprom);
}
/**
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/3] drm/i915/bios: make sure to check vbt size
@ 2019-11-08 21:13 ` Lucas De Marchi
0 siblings, 0 replies; 14+ messages in thread
From: Lucas De Marchi @ 2019-11-08 21:13 UTC (permalink / raw)
To: intel-gfx
When we call intel_bios_is_valid_vbt(), size may not actually be the
size of the VBT, but rather the size of the blob the VBT is contained
in. For example, when mapping the PCI oprom, size will be the entire
oprom size. We don't want to read beyond what is reported to be the
VBT. So make sure we vbt->vbt_size makes sense and use that for
the latter checks.
v2: check for vbt_size after checking for vbt signature and give it a
more meaningful error message (from Jani)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
https://patchwork.freedesktop.org/patch/msgid/20191108003602.33526-3-lucas.demarchi@intel.com
---
drivers/gpu/drm/i915/display/intel_bios.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 1f83616cfc32..c79781e1ccbf 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1787,6 +1787,13 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
return false;
}
+ if (vbt->vbt_size > size) {
+ DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
+ return false;
+ }
+
+ size = vbt->vbt_size;
+
if (range_overflows_t(size_t,
vbt->bdb_offset,
sizeof(struct bdb_header),
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 2/3] drm/i915/bios: make sure to check vbt size
@ 2019-11-08 21:13 ` Lucas De Marchi
0 siblings, 0 replies; 14+ messages in thread
From: Lucas De Marchi @ 2019-11-08 21:13 UTC (permalink / raw)
To: intel-gfx
When we call intel_bios_is_valid_vbt(), size may not actually be the
size of the VBT, but rather the size of the blob the VBT is contained
in. For example, when mapping the PCI oprom, size will be the entire
oprom size. We don't want to read beyond what is reported to be the
VBT. So make sure we vbt->vbt_size makes sense and use that for
the latter checks.
v2: check for vbt_size after checking for vbt signature and give it a
more meaningful error message (from Jani)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
https://patchwork.freedesktop.org/patch/msgid/20191108003602.33526-3-lucas.demarchi@intel.com
---
drivers/gpu/drm/i915/display/intel_bios.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 1f83616cfc32..c79781e1ccbf 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1787,6 +1787,13 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
return false;
}
+ if (vbt->vbt_size > size) {
+ DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
+ return false;
+ }
+
+ size = vbt->vbt_size;
+
if (range_overflows_t(size_t,
vbt->bdb_offset,
sizeof(struct bdb_header),
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/3] drm/i915/bios: do not discard address space
@ 2019-11-08 21:13 ` Lucas De Marchi
0 siblings, 0 replies; 14+ messages in thread
From: Lucas De Marchi @ 2019-11-08 21:13 UTC (permalink / raw)
To: intel-gfx
When we map the VBT through pci_map_rom() we may not be allowed
to simply discard the address space and go on reading the memory.
That doesn't work on my test system, but by dumping the rom via
sysfs I can can get the correct vbt. So change our find_vbt() to do
the same as done by pci_read_rom(), i.e. use memcpy_fromio().
v2: the just the minimal changes by not bothering with the unaligned io
reads: this can be done on top (from Ville and Jani)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 51 +++++++++++++++++------
1 file changed, 39 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index c79781e1ccbf..c079febae9c8 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1811,28 +1811,52 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
return vbt;
}
-static const struct vbt_header *find_vbt(void __iomem *oprom, size_t size)
+static const struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
{
+ void __iomem *p = NULL;
+ struct vbt_header *vbt;
+ u16 vbt_size;
size_t i;
/* Scour memory looking for the VBT signature. */
for (i = 0; i + 4 < size; i++) {
- void *vbt;
-
if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
continue;
- /*
- * This is the one place where we explicitly discard the address
- * space (__iomem) of the BIOS/VBT.
- */
- vbt = (void __force *)oprom + i;
- if (intel_bios_is_valid_vbt(vbt, size - i))
- return vbt;
-
+ p = oprom + i;
+ size -= i;
break;
}
+ if (!p)
+ return NULL;
+
+ if (sizeof(struct vbt_header) > size) {
+ DRM_DEBUG_DRIVER("VBT header incomplete\n");
+ return NULL;
+ }
+
+ vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
+ if (vbt_size > size) {
+ DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
+ return NULL;
+ }
+
+ /* The rest will be validated by intel_bios_is_valid_vbt() */
+ vbt = kmalloc(vbt_size, GFP_KERNEL);
+ if (!vbt)
+ return NULL;
+
+ memcpy_fromio(vbt, p, vbt_size);
+
+ if (!intel_bios_is_valid_vbt(vbt, vbt_size))
+ goto err_free_vbt;
+
+ return vbt;
+
+err_free_vbt:
+ kfree(vbt);
+
return NULL;
}
@@ -1866,7 +1890,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
if (!oprom)
goto out;
- vbt = find_vbt(oprom, size);
+ vbt = copy_vbt(oprom, size);
if (!vbt)
goto out;
@@ -1902,6 +1926,9 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
if (oprom)
pci_unmap_rom(pdev, oprom);
+
+ if (vbt != dev_priv->opregion.vbt)
+ kfree(vbt);
}
/**
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915/bios: do not discard address space
@ 2019-11-08 21:13 ` Lucas De Marchi
0 siblings, 0 replies; 14+ messages in thread
From: Lucas De Marchi @ 2019-11-08 21:13 UTC (permalink / raw)
To: intel-gfx
When we map the VBT through pci_map_rom() we may not be allowed
to simply discard the address space and go on reading the memory.
That doesn't work on my test system, but by dumping the rom via
sysfs I can can get the correct vbt. So change our find_vbt() to do
the same as done by pci_read_rom(), i.e. use memcpy_fromio().
v2: the just the minimal changes by not bothering with the unaligned io
reads: this can be done on top (from Ville and Jani)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 51 +++++++++++++++++------
1 file changed, 39 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index c79781e1ccbf..c079febae9c8 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -1811,28 +1811,52 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
return vbt;
}
-static const struct vbt_header *find_vbt(void __iomem *oprom, size_t size)
+static const struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
{
+ void __iomem *p = NULL;
+ struct vbt_header *vbt;
+ u16 vbt_size;
size_t i;
/* Scour memory looking for the VBT signature. */
for (i = 0; i + 4 < size; i++) {
- void *vbt;
-
if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
continue;
- /*
- * This is the one place where we explicitly discard the address
- * space (__iomem) of the BIOS/VBT.
- */
- vbt = (void __force *)oprom + i;
- if (intel_bios_is_valid_vbt(vbt, size - i))
- return vbt;
-
+ p = oprom + i;
+ size -= i;
break;
}
+ if (!p)
+ return NULL;
+
+ if (sizeof(struct vbt_header) > size) {
+ DRM_DEBUG_DRIVER("VBT header incomplete\n");
+ return NULL;
+ }
+
+ vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
+ if (vbt_size > size) {
+ DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
+ return NULL;
+ }
+
+ /* The rest will be validated by intel_bios_is_valid_vbt() */
+ vbt = kmalloc(vbt_size, GFP_KERNEL);
+ if (!vbt)
+ return NULL;
+
+ memcpy_fromio(vbt, p, vbt_size);
+
+ if (!intel_bios_is_valid_vbt(vbt, vbt_size))
+ goto err_free_vbt;
+
+ return vbt;
+
+err_free_vbt:
+ kfree(vbt);
+
return NULL;
}
@@ -1866,7 +1890,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
if (!oprom)
goto out;
- vbt = find_vbt(oprom, size);
+ vbt = copy_vbt(oprom, size);
if (!vbt)
goto out;
@@ -1902,6 +1926,9 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
if (oprom)
pci_unmap_rom(pdev, oprom);
+
+ if (vbt != dev_priv->opregion.vbt)
+ kfree(vbt);
}
/**
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/bios: rename bios to oprom when mapping pci rom
@ 2019-11-08 21:53 ` Patchwork
0 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-11-08 21:53 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915/bios: rename bios to oprom when mapping pci rom
URL : https://patchwork.freedesktop.org/series/69220/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7299 -> Patchwork_15200
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/index.html
Known issues
------------
Here are the changes found in Patchwork_15200 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-cml-s: [PASS][1] -> [DMESG-WARN][2] ([fdo#111764])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-cml-s/igt@gem_exec_suspend@basic-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/fi-cml-s/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-n3050: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][5] ([fdo#111407]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764
Participating hosts (51 -> 45)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7299 -> Patchwork_15200
CI-20190529: 20190529
CI_DRM_7299: e7de48a8b1161a99f4b8e4483bc1bb85f5d31039 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5268: c94958b8f7caefcda72392417ae6f3a98e36a48b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15200: 34ec8858b5a65094c2e08c5f7f836c82dc0fe97c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
34ec8858b5a6 drm/i915/bios: do not discard address space
b10e35f7f34d drm/i915/bios: make sure to check vbt size
0da736c6f40a drm/i915/bios: rename bios to oprom when mapping pci rom
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/bios: rename bios to oprom when mapping pci rom
@ 2019-11-08 21:53 ` Patchwork
0 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-11-08 21:53 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915/bios: rename bios to oprom when mapping pci rom
URL : https://patchwork.freedesktop.org/series/69220/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7299 -> Patchwork_15200
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/index.html
Known issues
------------
Here are the changes found in Patchwork_15200 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-cml-s: [PASS][1] -> [DMESG-WARN][2] ([fdo#111764])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-cml-s/igt@gem_exec_suspend@basic-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/fi-cml-s/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-n3050: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][5] ([fdo#111407]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764
Participating hosts (51 -> 45)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7299 -> Patchwork_15200
CI-20190529: 20190529
CI_DRM_7299: e7de48a8b1161a99f4b8e4483bc1bb85f5d31039 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5268: c94958b8f7caefcda72392417ae6f3a98e36a48b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15200: 34ec8858b5a65094c2e08c5f7f836c82dc0fe97c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
34ec8858b5a6 drm/i915/bios: do not discard address space
b10e35f7f34d drm/i915/bios: make sure to check vbt size
0da736c6f40a drm/i915/bios: rename bios to oprom when mapping pci rom
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/bios: rename bios to oprom when mapping pci rom
@ 2019-11-10 18:59 ` Patchwork
0 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-11-10 18:59 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915/bios: rename bios to oprom when mapping pci rom
URL : https://patchwork.freedesktop.org/series/69220/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7299_full -> Patchwork_15200_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_15200_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15200_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15200_full:
### IGT changes ###
#### Warnings ####
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [SKIP][1] ([fdo#111865]) -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@i915_pm_dc@dc6-psr.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb5/igt@i915_pm_dc@dc6-psr.html
Known issues
------------
Here are the changes found in Patchwork_15200_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_exec@basic-invalid-context-vcs1:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112080]) +12 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb7/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276] / [fdo#112080]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb1/igt@gem_ctx_isolation@vcs1-none.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb5/igt@gem_ctx_isolation@vcs1-none.html
* igt@gem_ctx_persistence@vcs0-mixed-process:
- shard-skl: [PASS][7] -> [FAIL][8] ([fdo#112194])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl5/igt@gem_ctx_persistence@vcs0-mixed-process.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-skl10/igt@gem_ctx_persistence@vcs0-mixed-process.html
* igt@gem_ctx_shared@q-smoketest-all:
- shard-tglb: [PASS][9] -> [INCOMPLETE][10] ([fdo#111735])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb1/igt@gem_ctx_shared@q-smoketest-all.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb6/igt@gem_ctx_shared@q-smoketest-all.html
* igt@gem_ctx_switch@all-light:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([fdo#111672])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb8/igt@gem_ctx_switch@all-light.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb4/igt@gem_ctx_switch@all-light.html
* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#112146]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb3/igt@gem_exec_schedule@in-order-bsd.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb2/igt@gem_exec_schedule@in-order-bsd.html
* igt@gem_exec_schedule@out-order-bsd2:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109276]) +20 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb1/igt@gem_exec_schedule@out-order-bsd2.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb5/igt@gem_exec_schedule@out-order-bsd2.html
* igt@gem_exec_suspend@basic-s0:
- shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([fdo#111832])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb3/igt@gem_exec_suspend@basic-s0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb3/igt@gem_exec_suspend@basic-s0.html
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +4 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl7/igt@gem_exec_suspend@basic-s3.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-kbl7/igt@gem_exec_suspend@basic-s3.html
* igt@gem_persistent_relocs@forked-thrashing:
- shard-snb: [PASS][21] -> [FAIL][22] ([fdo#112037])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb4/igt@gem_persistent_relocs@forked-thrashing.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-snb1/igt@gem_persistent_relocs@forked-thrashing.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-snb: [PASS][23] -> [DMESG-WARN][24] ([fdo#111870])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb4/igt@gem_userptr_blits@sync-unmap-after-close.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-snb4/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][25] -> [DMESG-WARN][26] ([fdo#108566]) +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl3/igt@i915_suspend@fence-restore-tiled2untiled.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#105363]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl3/igt@kms_flip@flip-vs-expired-vblank.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-skl10/igt@kms_flip@flip-vs-expired-vblank.html
- shard-glk: [PASS][29] -> [FAIL][30] ([fdo#105363])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-glk9/igt@kms_flip@flip-vs-expired-vblank.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-glk2/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render:
- shard-tglb: [PASS][31] -> [FAIL][32] ([fdo#103167]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][35] -> [FAIL][36] ([fdo#103166])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-x.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109642] / [fdo#111068])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb1/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb7/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_setmode@basic:
- shard-kbl: [PASS][41] -> [FAIL][42] ([fdo#99912])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl2/igt@kms_setmode@basic.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-kbl1/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-tglb: [PASS][43] -> [INCOMPLETE][44] ([fdo#111832] / [fdo#111850]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@prime_vgem@sync-render:
- shard-iclb: [PASS][45] -> [INCOMPLETE][46] ([fdo#107713])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb8/igt@prime_vgem@sync-render.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb7/igt@prime_vgem@sync-render.html
* igt@tools_test@tools_test:
- shard-glk: [PASS][47] -> [SKIP][48] ([fdo#109271])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-glk8/igt@tools_test@tools_test.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-glk9/igt@tools_test@tools_test.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [DMESG-WARN][49] ([fdo#108566]) -> [PASS][50] +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl2/igt@gem_ctx_isolation@rcs0-s3.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-apl8/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [SKIP][51] ([fdo#109276] / [fdo#112080]) -> [PASS][52] +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb3/igt@gem_ctx_persistence@vcs1-queued.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb2/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][53] ([fdo#110841]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb7/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_ctx_shared@q-smoketest-vebox:
- shard-tglb: [INCOMPLETE][55] ([fdo#111735]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@gem_ctx_shared@q-smoketest-vebox.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb5/igt@gem_ctx_shared@q-smoketest-vebox.html
* igt@gem_ctx_switch@vcs1:
- shard-iclb: [SKIP][57] ([fdo#112080]) -> [PASS][58] +9 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb5/igt@gem_ctx_switch@vcs1.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb2/igt@gem_ctx_switch@vcs1.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][59] ([fdo#112146]) -> [PASS][60] +5 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [DMESG-WARN][61] ([fdo#111870]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb7/igt@gem_userptr_blits@dmabuf-sync.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-snb1/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_workarounds@suspend-resume:
- shard-tglb: [INCOMPLETE][63] ([fdo#111832] / [fdo#111850]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb7/igt@gem_workarounds@suspend-resume.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb6/igt@gem_workarounds@suspend-resume.html
* igt@i915_selftest@live_requests:
- shard-tglb: [INCOMPLETE][65] ([fdo#112057]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb2/igt@i915_selftest@live_requests.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb2/igt@i915_selftest@live_requests.html
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [DMESG-WARN][67] ([fdo#108566]) -> [PASS][68] +4 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl3/igt@i915_suspend@sysfs-reader.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-kbl3/igt@i915_suspend@sysfs-reader.html
* igt@kms_color@pipe-b-ctm-0-5:
- shard-skl: [DMESG-WARN][69] ([fdo#106107]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl4/igt@kms_color@pipe-b-ctm-0-5.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-skl7/igt@kms_color@pipe-b-ctm-0-5.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic:
- shard-hsw: [FAIL][71] ([fdo#103355]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-hsw5/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][73] ([fdo#102670]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-apl: [DMESG-WARN][75] -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][77] ([fdo#103167]) -> [PASS][78] +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack:
- shard-tglb: [FAIL][79] ([fdo#103167]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-tglb: [TIMEOUT][81] ([fdo#112168]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb1/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][83] ([fdo#108145]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][85] ([fdo#109441]) -> [PASS][86] +3 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb5/igt@kms_psr@psr2_sprite_render.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][87] ([fdo#109276]) -> [PASS][88] +24 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb7/igt@prime_busy@hang-bsd2.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb4/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_eio@kms:
- shard-snb: [INCOMPLETE][89] ([fdo#105411]) -> [DMESG-WARN][90] ([fdo# 112000 ] / [fdo#111780 ] / [fdo#111781])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb1/igt@gem_eio@kms.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-snb7/igt@gem_eio@kms.html
* igt@gem_exec_schedule@deep-bsd1:
- shard-tglb: [FAIL][91] ([fdo#111646]) -> [INCOMPLETE][92] ([fdo#111671])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb7/igt@gem_exec_schedule@deep-bsd1.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb3/igt@gem_exec_schedule@deep-bsd1.html
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [FAIL][93] ([fdo#111330]) -> [SKIP][94] ([fdo#109276]) +3 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_mocs_settings@mocs-reset-bsd2.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb7/igt@gem_mocs_settings@mocs-reset-bsd2.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][95] ([fdo#110789] / [fdo#111870]) -> [DMESG-WARN][96] ([fdo#111870])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html
[fdo# 112000 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 112000
[fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
[fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
[fdo#111672]: https://bugs.freedesktop.org/show_bug.cgi?id=111672
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[fdo#111780 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111780
[fdo#111781]: https://bugs.freedesktop.org/show_bug.cgi?id=111781
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=11
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/bios: rename bios to oprom when mapping pci rom
@ 2019-11-10 18:59 ` Patchwork
0 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-11-10 18:59 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915/bios: rename bios to oprom when mapping pci rom
URL : https://patchwork.freedesktop.org/series/69220/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7299_full -> Patchwork_15200_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_15200_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15200_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15200_full:
### IGT changes ###
#### Warnings ####
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [SKIP][1] ([fdo#111865]) -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@i915_pm_dc@dc6-psr.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb5/igt@i915_pm_dc@dc6-psr.html
Known issues
------------
Here are the changes found in Patchwork_15200_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_exec@basic-invalid-context-vcs1:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112080]) +12 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb7/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276] / [fdo#112080]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb1/igt@gem_ctx_isolation@vcs1-none.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb5/igt@gem_ctx_isolation@vcs1-none.html
* igt@gem_ctx_persistence@vcs0-mixed-process:
- shard-skl: [PASS][7] -> [FAIL][8] ([fdo#112194])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl5/igt@gem_ctx_persistence@vcs0-mixed-process.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-skl10/igt@gem_ctx_persistence@vcs0-mixed-process.html
* igt@gem_ctx_shared@q-smoketest-all:
- shard-tglb: [PASS][9] -> [INCOMPLETE][10] ([fdo#111735])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb1/igt@gem_ctx_shared@q-smoketest-all.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb6/igt@gem_ctx_shared@q-smoketest-all.html
* igt@gem_ctx_switch@all-light:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([fdo#111672])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb8/igt@gem_ctx_switch@all-light.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb4/igt@gem_ctx_switch@all-light.html
* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#112146]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb3/igt@gem_exec_schedule@in-order-bsd.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb2/igt@gem_exec_schedule@in-order-bsd.html
* igt@gem_exec_schedule@out-order-bsd2:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109276]) +20 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb1/igt@gem_exec_schedule@out-order-bsd2.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb5/igt@gem_exec_schedule@out-order-bsd2.html
* igt@gem_exec_suspend@basic-s0:
- shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([fdo#111832])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb3/igt@gem_exec_suspend@basic-s0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb3/igt@gem_exec_suspend@basic-s0.html
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +4 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl7/igt@gem_exec_suspend@basic-s3.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-kbl7/igt@gem_exec_suspend@basic-s3.html
* igt@gem_persistent_relocs@forked-thrashing:
- shard-snb: [PASS][21] -> [FAIL][22] ([fdo#112037])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb4/igt@gem_persistent_relocs@forked-thrashing.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-snb1/igt@gem_persistent_relocs@forked-thrashing.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-snb: [PASS][23] -> [DMESG-WARN][24] ([fdo#111870])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb4/igt@gem_userptr_blits@sync-unmap-after-close.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-snb4/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][25] -> [DMESG-WARN][26] ([fdo#108566]) +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl3/igt@i915_suspend@fence-restore-tiled2untiled.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#105363]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl3/igt@kms_flip@flip-vs-expired-vblank.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-skl10/igt@kms_flip@flip-vs-expired-vblank.html
- shard-glk: [PASS][29] -> [FAIL][30] ([fdo#105363])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-glk9/igt@kms_flip@flip-vs-expired-vblank.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-glk2/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render:
- shard-tglb: [PASS][31] -> [FAIL][32] ([fdo#103167]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][35] -> [FAIL][36] ([fdo#103166])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-x.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109642] / [fdo#111068])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb1/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb7/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_setmode@basic:
- shard-kbl: [PASS][41] -> [FAIL][42] ([fdo#99912])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl2/igt@kms_setmode@basic.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-kbl1/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-tglb: [PASS][43] -> [INCOMPLETE][44] ([fdo#111832] / [fdo#111850]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@prime_vgem@sync-render:
- shard-iclb: [PASS][45] -> [INCOMPLETE][46] ([fdo#107713])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb8/igt@prime_vgem@sync-render.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb7/igt@prime_vgem@sync-render.html
* igt@tools_test@tools_test:
- shard-glk: [PASS][47] -> [SKIP][48] ([fdo#109271])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-glk8/igt@tools_test@tools_test.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-glk9/igt@tools_test@tools_test.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [DMESG-WARN][49] ([fdo#108566]) -> [PASS][50] +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl2/igt@gem_ctx_isolation@rcs0-s3.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-apl8/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [SKIP][51] ([fdo#109276] / [fdo#112080]) -> [PASS][52] +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb3/igt@gem_ctx_persistence@vcs1-queued.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb2/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][53] ([fdo#110841]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb7/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_ctx_shared@q-smoketest-vebox:
- shard-tglb: [INCOMPLETE][55] ([fdo#111735]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@gem_ctx_shared@q-smoketest-vebox.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb5/igt@gem_ctx_shared@q-smoketest-vebox.html
* igt@gem_ctx_switch@vcs1:
- shard-iclb: [SKIP][57] ([fdo#112080]) -> [PASS][58] +9 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb5/igt@gem_ctx_switch@vcs1.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb2/igt@gem_ctx_switch@vcs1.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][59] ([fdo#112146]) -> [PASS][60] +5 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [DMESG-WARN][61] ([fdo#111870]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb7/igt@gem_userptr_blits@dmabuf-sync.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-snb1/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_workarounds@suspend-resume:
- shard-tglb: [INCOMPLETE][63] ([fdo#111832] / [fdo#111850]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb7/igt@gem_workarounds@suspend-resume.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb6/igt@gem_workarounds@suspend-resume.html
* igt@i915_selftest@live_requests:
- shard-tglb: [INCOMPLETE][65] ([fdo#112057]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb2/igt@i915_selftest@live_requests.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb2/igt@i915_selftest@live_requests.html
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [DMESG-WARN][67] ([fdo#108566]) -> [PASS][68] +4 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl3/igt@i915_suspend@sysfs-reader.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-kbl3/igt@i915_suspend@sysfs-reader.html
* igt@kms_color@pipe-b-ctm-0-5:
- shard-skl: [DMESG-WARN][69] ([fdo#106107]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl4/igt@kms_color@pipe-b-ctm-0-5.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-skl7/igt@kms_color@pipe-b-ctm-0-5.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic:
- shard-hsw: [FAIL][71] ([fdo#103355]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-hsw5/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][73] ([fdo#102670]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-apl: [DMESG-WARN][75] -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][77] ([fdo#103167]) -> [PASS][78] +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack:
- shard-tglb: [FAIL][79] ([fdo#103167]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-tglb: [TIMEOUT][81] ([fdo#112168]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb1/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][83] ([fdo#108145]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][85] ([fdo#109441]) -> [PASS][86] +3 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb5/igt@kms_psr@psr2_sprite_render.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][87] ([fdo#109276]) -> [PASS][88] +24 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb7/igt@prime_busy@hang-bsd2.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb4/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_eio@kms:
- shard-snb: [INCOMPLETE][89] ([fdo#105411]) -> [DMESG-WARN][90] ([fdo# 112000 ] / [fdo#111780 ] / [fdo#111781])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb1/igt@gem_eio@kms.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-snb7/igt@gem_eio@kms.html
* igt@gem_exec_schedule@deep-bsd1:
- shard-tglb: [FAIL][91] ([fdo#111646]) -> [INCOMPLETE][92] ([fdo#111671])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb7/igt@gem_exec_schedule@deep-bsd1.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-tglb3/igt@gem_exec_schedule@deep-bsd1.html
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [FAIL][93] ([fdo#111330]) -> [SKIP][94] ([fdo#109276]) +3 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_mocs_settings@mocs-reset-bsd2.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-iclb7/igt@gem_mocs_settings@mocs-reset-bsd2.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][95] ([fdo#110789] / [fdo#111870]) -> [DMESG-WARN][96] ([fdo#111870])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html
[fdo# 112000 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 112000
[fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
[fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
[fdo#111672]: https://bugs.freedesktop.org/show_bug.cgi?id=111672
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[fdo#111780 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111780
[fdo#111781]: https://bugs.freedesktop.org/show_bug.cgi?id=111781
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=11
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15200/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] drm/i915/bios: do not discard address space
@ 2019-11-15 17:40 ` Ville Syrjälä
0 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjälä @ 2019-11-15 17:40 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Fri, Nov 08, 2019 at 01:13:53PM -0800, Lucas De Marchi wrote:
> When we map the VBT through pci_map_rom() we may not be allowed
> to simply discard the address space and go on reading the memory.
> That doesn't work on my test system, but by dumping the rom via
> sysfs I can can get the correct vbt. So change our find_vbt() to do
> the same as done by pci_read_rom(), i.e. use memcpy_fromio().
>
> v2: the just the minimal changes by not bothering with the unaligned io
> reads: this can be done on top (from Ville and Jani)
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 51 +++++++++++++++++------
> 1 file changed, 39 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index c79781e1ccbf..c079febae9c8 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1811,28 +1811,52 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
> return vbt;
> }
>
> -static const struct vbt_header *find_vbt(void __iomem *oprom, size_t size)
> +static const struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
> {
> + void __iomem *p = NULL;
> + struct vbt_header *vbt;
> + u16 vbt_size;
> size_t i;
>
> /* Scour memory looking for the VBT signature. */
> for (i = 0; i + 4 < size; i++) {
> - void *vbt;
> -
> if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
> continue;
>
> - /*
> - * This is the one place where we explicitly discard the address
> - * space (__iomem) of the BIOS/VBT.
> - */
> - vbt = (void __force *)oprom + i;
> - if (intel_bios_is_valid_vbt(vbt, size - i))
> - return vbt;
> -
> + p = oprom + i;
> + size -= i;
> break;
> }
>
> + if (!p)
> + return NULL;
> +
> + if (sizeof(struct vbt_header) > size) {
> + DRM_DEBUG_DRIVER("VBT header incomplete\n");
> + return NULL;
> + }
> +
> + vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
> + if (vbt_size > size) {
> + DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
> + return NULL;
> + }
> +
> + /* The rest will be validated by intel_bios_is_valid_vbt() */
> + vbt = kmalloc(vbt_size, GFP_KERNEL);
> + if (!vbt)
> + return NULL;
> +
> + memcpy_fromio(vbt, p, vbt_size);
> +
> + if (!intel_bios_is_valid_vbt(vbt, vbt_size))
> + goto err_free_vbt;
> +
> + return vbt;
> +
> +err_free_vbt:
> + kfree(vbt);
> +
> return NULL;
> }
>
> @@ -1866,7 +1890,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
> if (!oprom)
> goto out;
>
> - vbt = find_vbt(oprom, size);
> + vbt = copy_vbt(oprom, size);
> if (!vbt)
> goto out;
>
> @@ -1902,6 +1926,9 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
>
> if (oprom)
> pci_unmap_rom(pdev, oprom);
lgtm
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
As a followup we could now move the rom map/unamp into copy_vbt() as
there's no longer any need to keep it mapped across the whole thing.
> +
> + if (vbt != dev_priv->opregion.vbt)
> + kfree(vbt);
> }
>
> /**
> --
> 2.24.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915/bios: do not discard address space
@ 2019-11-15 17:40 ` Ville Syrjälä
0 siblings, 0 replies; 14+ messages in thread
From: Ville Syrjälä @ 2019-11-15 17:40 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Fri, Nov 08, 2019 at 01:13:53PM -0800, Lucas De Marchi wrote:
> When we map the VBT through pci_map_rom() we may not be allowed
> to simply discard the address space and go on reading the memory.
> That doesn't work on my test system, but by dumping the rom via
> sysfs I can can get the correct vbt. So change our find_vbt() to do
> the same as done by pci_read_rom(), i.e. use memcpy_fromio().
>
> v2: the just the minimal changes by not bothering with the unaligned io
> reads: this can be done on top (from Ville and Jani)
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bios.c | 51 +++++++++++++++++------
> 1 file changed, 39 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index c79781e1ccbf..c079febae9c8 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1811,28 +1811,52 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
> return vbt;
> }
>
> -static const struct vbt_header *find_vbt(void __iomem *oprom, size_t size)
> +static const struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
> {
> + void __iomem *p = NULL;
> + struct vbt_header *vbt;
> + u16 vbt_size;
> size_t i;
>
> /* Scour memory looking for the VBT signature. */
> for (i = 0; i + 4 < size; i++) {
> - void *vbt;
> -
> if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
> continue;
>
> - /*
> - * This is the one place where we explicitly discard the address
> - * space (__iomem) of the BIOS/VBT.
> - */
> - vbt = (void __force *)oprom + i;
> - if (intel_bios_is_valid_vbt(vbt, size - i))
> - return vbt;
> -
> + p = oprom + i;
> + size -= i;
> break;
> }
>
> + if (!p)
> + return NULL;
> +
> + if (sizeof(struct vbt_header) > size) {
> + DRM_DEBUG_DRIVER("VBT header incomplete\n");
> + return NULL;
> + }
> +
> + vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
> + if (vbt_size > size) {
> + DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
> + return NULL;
> + }
> +
> + /* The rest will be validated by intel_bios_is_valid_vbt() */
> + vbt = kmalloc(vbt_size, GFP_KERNEL);
> + if (!vbt)
> + return NULL;
> +
> + memcpy_fromio(vbt, p, vbt_size);
> +
> + if (!intel_bios_is_valid_vbt(vbt, vbt_size))
> + goto err_free_vbt;
> +
> + return vbt;
> +
> +err_free_vbt:
> + kfree(vbt);
> +
> return NULL;
> }
>
> @@ -1866,7 +1890,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
> if (!oprom)
> goto out;
>
> - vbt = find_vbt(oprom, size);
> + vbt = copy_vbt(oprom, size);
> if (!vbt)
> goto out;
>
> @@ -1902,6 +1926,9 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
>
> if (oprom)
> pci_unmap_rom(pdev, oprom);
lgtm
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
As a followup we could now move the rom map/unamp into copy_vbt() as
there's no longer any need to keep it mapped across the whole thing.
> +
> + if (vbt != dev_priv->opregion.vbt)
> + kfree(vbt);
> }
>
> /**
> --
> 2.24.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] drm/i915/bios: do not discard address space
@ 2019-11-15 17:45 ` Lucas De Marchi
0 siblings, 0 replies; 14+ messages in thread
From: Lucas De Marchi @ 2019-11-15 17:45 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Fri, Nov 15, 2019 at 07:40:15PM +0200, Ville Syrjälä wrote:
>On Fri, Nov 08, 2019 at 01:13:53PM -0800, Lucas De Marchi wrote:
>> When we map the VBT through pci_map_rom() we may not be allowed
>> to simply discard the address space and go on reading the memory.
>> That doesn't work on my test system, but by dumping the rom via
>> sysfs I can can get the correct vbt. So change our find_vbt() to do
>> the same as done by pci_read_rom(), i.e. use memcpy_fromio().
>>
>> v2: the just the minimal changes by not bothering with the unaligned io
>> reads: this can be done on top (from Ville and Jani)
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.c | 51 +++++++++++++++++------
>> 1 file changed, 39 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>> index c79781e1ccbf..c079febae9c8 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> @@ -1811,28 +1811,52 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
>> return vbt;
>> }
>>
>> -static const struct vbt_header *find_vbt(void __iomem *oprom, size_t size)
>> +static const struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
just noticed this shouldn't be const anymore, since the caller is
supposed to free the return
>> {
>> + void __iomem *p = NULL;
>> + struct vbt_header *vbt;
>> + u16 vbt_size;
>> size_t i;
>>
>> /* Scour memory looking for the VBT signature. */
>> for (i = 0; i + 4 < size; i++) {
>> - void *vbt;
>> -
>> if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
>> continue;
>>
>> - /*
>> - * This is the one place where we explicitly discard the address
>> - * space (__iomem) of the BIOS/VBT.
>> - */
>> - vbt = (void __force *)oprom + i;
>> - if (intel_bios_is_valid_vbt(vbt, size - i))
>> - return vbt;
>> -
>> + p = oprom + i;
>> + size -= i;
>> break;
>> }
>>
>> + if (!p)
>> + return NULL;
>> +
>> + if (sizeof(struct vbt_header) > size) {
>> + DRM_DEBUG_DRIVER("VBT header incomplete\n");
>> + return NULL;
>> + }
>> +
>> + vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
>> + if (vbt_size > size) {
>> + DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
>> + return NULL;
>> + }
>> +
>> + /* The rest will be validated by intel_bios_is_valid_vbt() */
>> + vbt = kmalloc(vbt_size, GFP_KERNEL);
>> + if (!vbt)
>> + return NULL;
>> +
>> + memcpy_fromio(vbt, p, vbt_size);
>> +
>> + if (!intel_bios_is_valid_vbt(vbt, vbt_size))
>> + goto err_free_vbt;
>> +
>> + return vbt;
>> +
>> +err_free_vbt:
>> + kfree(vbt);
>> +
>> return NULL;
>> }
>>
>> @@ -1866,7 +1890,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
>> if (!oprom)
>> goto out;
>>
>> - vbt = find_vbt(oprom, size);
>> + vbt = copy_vbt(oprom, size);
>> if (!vbt)
>> goto out;
>>
>> @@ -1902,6 +1926,9 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
>>
>> if (oprom)
>> pci_unmap_rom(pdev, oprom);
>
>lgtm
>Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>As a followup we could now move the rom map/unamp into copy_vbt() as
>there's no longer any need to keep it mapped across the whole thing.
yep, I will add this and a tentative to avoid the unaligned reads
thanks
Lucas De Marchi
>
>> +
>> + if (vbt != dev_priv->opregion.vbt)
>> + kfree(vbt);
>> }
>>
>> /**
>> --
>> 2.24.0
>
>--
>Ville Syrjälä
>Intel
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915/bios: do not discard address space
@ 2019-11-15 17:45 ` Lucas De Marchi
0 siblings, 0 replies; 14+ messages in thread
From: Lucas De Marchi @ 2019-11-15 17:45 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Fri, Nov 15, 2019 at 07:40:15PM +0200, Ville Syrjälä wrote:
>On Fri, Nov 08, 2019 at 01:13:53PM -0800, Lucas De Marchi wrote:
>> When we map the VBT through pci_map_rom() we may not be allowed
>> to simply discard the address space and go on reading the memory.
>> That doesn't work on my test system, but by dumping the rom via
>> sysfs I can can get the correct vbt. So change our find_vbt() to do
>> the same as done by pci_read_rom(), i.e. use memcpy_fromio().
>>
>> v2: the just the minimal changes by not bothering with the unaligned io
>> reads: this can be done on top (from Ville and Jani)
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_bios.c | 51 +++++++++++++++++------
>> 1 file changed, 39 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>> index c79781e1ccbf..c079febae9c8 100644
>> --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> @@ -1811,28 +1811,52 @@ bool intel_bios_is_valid_vbt(const void *buf, size_t size)
>> return vbt;
>> }
>>
>> -static const struct vbt_header *find_vbt(void __iomem *oprom, size_t size)
>> +static const struct vbt_header *copy_vbt(void __iomem *oprom, size_t size)
just noticed this shouldn't be const anymore, since the caller is
supposed to free the return
>> {
>> + void __iomem *p = NULL;
>> + struct vbt_header *vbt;
>> + u16 vbt_size;
>> size_t i;
>>
>> /* Scour memory looking for the VBT signature. */
>> for (i = 0; i + 4 < size; i++) {
>> - void *vbt;
>> -
>> if (ioread32(oprom + i) != *((const u32 *)"$VBT"))
>> continue;
>>
>> - /*
>> - * This is the one place where we explicitly discard the address
>> - * space (__iomem) of the BIOS/VBT.
>> - */
>> - vbt = (void __force *)oprom + i;
>> - if (intel_bios_is_valid_vbt(vbt, size - i))
>> - return vbt;
>> -
>> + p = oprom + i;
>> + size -= i;
>> break;
>> }
>>
>> + if (!p)
>> + return NULL;
>> +
>> + if (sizeof(struct vbt_header) > size) {
>> + DRM_DEBUG_DRIVER("VBT header incomplete\n");
>> + return NULL;
>> + }
>> +
>> + vbt_size = ioread16(p + offsetof(struct vbt_header, vbt_size));
>> + if (vbt_size > size) {
>> + DRM_DEBUG_DRIVER("VBT incomplete (vbt_size overflows)\n");
>> + return NULL;
>> + }
>> +
>> + /* The rest will be validated by intel_bios_is_valid_vbt() */
>> + vbt = kmalloc(vbt_size, GFP_KERNEL);
>> + if (!vbt)
>> + return NULL;
>> +
>> + memcpy_fromio(vbt, p, vbt_size);
>> +
>> + if (!intel_bios_is_valid_vbt(vbt, vbt_size))
>> + goto err_free_vbt;
>> +
>> + return vbt;
>> +
>> +err_free_vbt:
>> + kfree(vbt);
>> +
>> return NULL;
>> }
>>
>> @@ -1866,7 +1890,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
>> if (!oprom)
>> goto out;
>>
>> - vbt = find_vbt(oprom, size);
>> + vbt = copy_vbt(oprom, size);
>> if (!vbt)
>> goto out;
>>
>> @@ -1902,6 +1926,9 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
>>
>> if (oprom)
>> pci_unmap_rom(pdev, oprom);
>
>lgtm
>Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>As a followup we could now move the rom map/unamp into copy_vbt() as
>there's no longer any need to keep it mapped across the whole thing.
yep, I will add this and a tentative to avoid the unaligned reads
thanks
Lucas De Marchi
>
>> +
>> + if (vbt != dev_priv->opregion.vbt)
>> + kfree(vbt);
>> }
>>
>> /**
>> --
>> 2.24.0
>
>--
>Ville Syrjälä
>Intel
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-11-15 17:45 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-08 21:13 [PATCH 1/3] drm/i915/bios: rename bios to oprom when mapping pci rom Lucas De Marchi
2019-11-08 21:13 ` [Intel-gfx] " Lucas De Marchi
2019-11-08 21:13 ` [PATCH 2/3] drm/i915/bios: make sure to check vbt size Lucas De Marchi
2019-11-08 21:13 ` [Intel-gfx] " Lucas De Marchi
2019-11-08 21:13 ` [PATCH 3/3] drm/i915/bios: do not discard address space Lucas De Marchi
2019-11-08 21:13 ` [Intel-gfx] " Lucas De Marchi
2019-11-15 17:40 ` Ville Syrjälä
2019-11-15 17:40 ` [Intel-gfx] " Ville Syrjälä
2019-11-15 17:45 ` Lucas De Marchi
2019-11-15 17:45 ` [Intel-gfx] " Lucas De Marchi
2019-11-08 21:53 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/bios: rename bios to oprom when mapping pci rom Patchwork
2019-11-08 21:53 ` [Intel-gfx] " Patchwork
2019-11-10 18:59 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-10 18:59 ` [Intel-gfx] " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.