From: kbuild test robot <lkp@intel.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: kbuild-all@lists.01.org, linux-fsdevel@vger.kernel.org,
linux-mtd@lists.infradead.org, Jan Kara <jack@suse.com>,
Richard Weinberger <richard@nod.at>,
kernel@pengutronix.de, Sascha Hauer <s.hauer@pengutronix.de>,
Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Subject: Re: [PATCH 7/7] ubifs: Add quota support
Date: Fri, 8 Nov 2019 22:47:37 +0800 [thread overview]
Message-ID: <201911082236.nb3ky0Pw%lkp@intel.com> (raw)
In-Reply-To: <20191106091537.32480-8-s.hauer@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2655 bytes --]
Hi Sascha,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.4-rc6 next-20191108]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Sascha-Hauer/Add-quota-support-to-UBIFS/20191108-215456
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 847120f859cc45e074204f4cf33c8df069306eb2
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/ubifs/quota.c: In function 'ubifs_enable_quotas':
>> fs/ubifs/quota.c:509:9: error: implicit declaration of function 'dquot_load_quota_sb'; did you mean 'dquot_quota_on'? [-Werror=implicit-function-declaration]
ret = dquot_load_quota_sb(sb, type, QFMT_UBIFS,
^~~~~~~~~~~~~~~~~~~
dquot_quota_on
cc1: some warnings being treated as errors
vim +509 fs/ubifs/quota.c
487
488 /**
489 * ubifs_enable_quotas - enable quota
490 * @c: UBIFS file-system description object
491 *
492 * Enable usage tracking for all quota types.
493 */
494 int ubifs_enable_quotas(struct ubifs_info *c)
495 {
496 struct super_block *sb = c->vfs_sb;
497 struct quota_info *dqopt = sb_dqopt(sb);
498 int type, ret;
499
500 if (!c->quota_enable)
501 return 0;
502
503 dqopt->flags |= DQUOT_QUOTA_SYS_FILE | DQUOT_NOLIST_DIRTY;
504
505 for (type = 0; type < UBIFS_MAXQUOTAS; type++) {
506 if (!(c->quota_enable & (1 << type)))
507 continue;
508
> 509 ret = dquot_load_quota_sb(sb, type, QFMT_UBIFS,
510 DQUOT_USAGE_ENABLED | DQUOT_LIMITS_ENABLED);
511 if (ret)
512 goto out_quota_off;
513
514 c->dqblk_tree[type] = RB_ROOT;
515 }
516
517 return ubifs_quota_walk_index(c);
518
519 out_quota_off:
520 ubifs_disable_quotas(c);
521
522 return ret;
523 }
524
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50147 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
kbuild-all@lists.01.org, Richard Weinberger <richard@nod.at>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-mtd@lists.infradead.org, kernel@pengutronix.de,
Jan Kara <jack@suse.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 7/7] ubifs: Add quota support
Date: Fri, 8 Nov 2019 22:47:37 +0800 [thread overview]
Message-ID: <201911082236.nb3ky0Pw%lkp@intel.com> (raw)
In-Reply-To: <20191106091537.32480-8-s.hauer@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2655 bytes --]
Hi Sascha,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.4-rc6 next-20191108]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Sascha-Hauer/Add-quota-support-to-UBIFS/20191108-215456
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 847120f859cc45e074204f4cf33c8df069306eb2
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/ubifs/quota.c: In function 'ubifs_enable_quotas':
>> fs/ubifs/quota.c:509:9: error: implicit declaration of function 'dquot_load_quota_sb'; did you mean 'dquot_quota_on'? [-Werror=implicit-function-declaration]
ret = dquot_load_quota_sb(sb, type, QFMT_UBIFS,
^~~~~~~~~~~~~~~~~~~
dquot_quota_on
cc1: some warnings being treated as errors
vim +509 fs/ubifs/quota.c
487
488 /**
489 * ubifs_enable_quotas - enable quota
490 * @c: UBIFS file-system description object
491 *
492 * Enable usage tracking for all quota types.
493 */
494 int ubifs_enable_quotas(struct ubifs_info *c)
495 {
496 struct super_block *sb = c->vfs_sb;
497 struct quota_info *dqopt = sb_dqopt(sb);
498 int type, ret;
499
500 if (!c->quota_enable)
501 return 0;
502
503 dqopt->flags |= DQUOT_QUOTA_SYS_FILE | DQUOT_NOLIST_DIRTY;
504
505 for (type = 0; type < UBIFS_MAXQUOTAS; type++) {
506 if (!(c->quota_enable & (1 << type)))
507 continue;
508
> 509 ret = dquot_load_quota_sb(sb, type, QFMT_UBIFS,
510 DQUOT_USAGE_ENABLED | DQUOT_LIMITS_ENABLED);
511 if (ret)
512 goto out_quota_off;
513
514 c->dqblk_tree[type] = RB_ROOT;
515 }
516
517 return ubifs_quota_walk_index(c);
518
519 out_quota_off:
520 ubifs_disable_quotas(c);
521
522 return ret;
523 }
524
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50147 bytes --]
[-- Attachment #3: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 7/7] ubifs: Add quota support
Date: Fri, 08 Nov 2019 22:47:37 +0800 [thread overview]
Message-ID: <201911082236.nb3ky0Pw%lkp@intel.com> (raw)
In-Reply-To: <20191106091537.32480-8-s.hauer@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2733 bytes --]
Hi Sascha,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.4-rc6 next-20191108]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Sascha-Hauer/Add-quota-support-to-UBIFS/20191108-215456
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 847120f859cc45e074204f4cf33c8df069306eb2
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/ubifs/quota.c: In function 'ubifs_enable_quotas':
>> fs/ubifs/quota.c:509:9: error: implicit declaration of function 'dquot_load_quota_sb'; did you mean 'dquot_quota_on'? [-Werror=implicit-function-declaration]
ret = dquot_load_quota_sb(sb, type, QFMT_UBIFS,
^~~~~~~~~~~~~~~~~~~
dquot_quota_on
cc1: some warnings being treated as errors
vim +509 fs/ubifs/quota.c
487
488 /**
489 * ubifs_enable_quotas - enable quota
490 * @c: UBIFS file-system description object
491 *
492 * Enable usage tracking for all quota types.
493 */
494 int ubifs_enable_quotas(struct ubifs_info *c)
495 {
496 struct super_block *sb = c->vfs_sb;
497 struct quota_info *dqopt = sb_dqopt(sb);
498 int type, ret;
499
500 if (!c->quota_enable)
501 return 0;
502
503 dqopt->flags |= DQUOT_QUOTA_SYS_FILE | DQUOT_NOLIST_DIRTY;
504
505 for (type = 0; type < UBIFS_MAXQUOTAS; type++) {
506 if (!(c->quota_enable & (1 << type)))
507 continue;
508
> 509 ret = dquot_load_quota_sb(sb, type, QFMT_UBIFS,
510 DQUOT_USAGE_ENABLED | DQUOT_LIMITS_ENABLED);
511 if (ret)
512 goto out_quota_off;
513
514 c->dqblk_tree[type] = RB_ROOT;
515 }
516
517 return ubifs_quota_walk_index(c);
518
519 out_quota_off:
520 ubifs_disable_quotas(c);
521
522 return ret;
523 }
524
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 50147 bytes --]
next prev parent reply other threads:[~2019-11-08 14:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 9:15 [PATCH v3 0/7] Add quota support to UBIFS Sascha Hauer
2019-11-06 9:15 ` Sascha Hauer
2019-11-06 9:15 ` [PATCH 1/7] quota: Allow to pass mount path to quotactl Sascha Hauer
2019-11-06 9:15 ` Sascha Hauer
2019-11-06 10:05 ` Jan Kara
2019-11-06 10:05 ` Jan Kara
2019-11-06 10:15 ` Sascha Hauer
2019-11-06 10:15 ` Sascha Hauer
2019-11-06 9:15 ` [PATCH 2/7] ubifs: move checks and preparation into setflags() Sascha Hauer
2019-11-06 9:15 ` Sascha Hauer
2020-01-19 19:56 ` Richard Weinberger
2020-01-19 19:56 ` Richard Weinberger
2019-11-06 9:15 ` [PATCH 3/7] ubifs: Add support for FS_IOC_FS[SG]ETXATTR ioctls Sascha Hauer
2019-11-06 9:15 ` Sascha Hauer
2020-01-19 19:55 ` Richard Weinberger
2020-01-19 19:55 ` Richard Weinberger
2019-11-06 9:15 ` [PATCH 4/7] ubifs: do not ubifs_inode() on potentially NULL pointer Sascha Hauer
2019-11-06 9:15 ` Sascha Hauer
2020-01-19 19:58 ` Richard Weinberger
2020-01-19 19:58 ` Richard Weinberger
2019-11-06 9:15 ` [PATCH 5/7] ubifs: Add support for project id Sascha Hauer
2019-11-06 9:15 ` Sascha Hauer
2020-01-19 20:09 ` Richard Weinberger
2020-01-19 20:09 ` Richard Weinberger
2020-01-24 8:05 ` Sascha Hauer
2020-01-24 8:05 ` Sascha Hauer
2019-11-06 9:15 ` [PATCH 6/7] ubifs: export get_znode Sascha Hauer
2019-11-06 9:15 ` Sascha Hauer
2019-11-06 9:15 ` [PATCH 7/7] ubifs: Add quota support Sascha Hauer
2019-11-06 9:15 ` Sascha Hauer
2019-11-06 10:14 ` Jan Kara
2019-11-06 10:14 ` Jan Kara
2019-11-11 8:57 ` Sascha Hauer
2019-11-11 8:57 ` Sascha Hauer
2019-11-11 16:34 ` Jan Kara
2019-11-11 16:34 ` Jan Kara
2019-11-12 8:59 ` Sascha Hauer
2019-11-12 8:59 ` Sascha Hauer
2019-11-12 9:31 ` Jan Kara
2019-11-12 9:31 ` Jan Kara
2019-11-08 14:47 ` kbuild test robot [this message]
2019-11-08 14:47 ` kbuild test robot
2019-11-08 14:47 ` kbuild test robot
2021-03-30 10:43 [PATCH v5 0/7] Add quota support to UBIFS Sascha Hauer
2021-03-30 10:43 ` [PATCH 7/7] ubifs: Add quota support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911082236.nb3ky0Pw%lkp@intel.com \
--to=lkp@intel.com \
--cc=jack@suse.com \
--cc=kbuild-all@lists.01.org \
--cc=kernel@pengutronix.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.