[linux-arm:zii 31/50] arch/m68k/include/asm/bitops.h:64:33: warning: this statement may fall through

[linux-arm:zii 31/50] arch/m68k/include/asm/bitops.h:64:33: warning: this statement may fall through

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 5396 bytes --]

tree:   git://git.armlinux.org.uk/~rmk/linux-arm zii
head:   4ba7c03360edc60a37545f9d7bf73f1e8aeac783
commit: 1acc1100d4f221dbef96ffe69b21109dea79ca29 [31/50] net: sfp: add more extended compliance codes
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 1acc1100d4f221dbef96ffe69b21109dea79ca29
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/bitops.h:19:0,
                    from include/linux/kernel.h:12,
                    from include/linux/list.h:9,
                    from include/linux/preempt.h:11,
                    from include/linux/spinlock.h:51,
                    from include/linux/kref.h:16,
                    from drivers/net/phy/sfp-bus.c:3:
   drivers/net/phy/sfp-bus.c: In function 'sfp_parse_support':
>> arch/m68k/include/asm/bitops.h:64:33: warning: this statement may fall through [-Wimplicit-fallthrough=]
    #define set_bit(nr, vaddr) (__builtin_constant_p(nr) ? \
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        bset_mem_set_bit(nr, vaddr) : \
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
        bfset_mem_set_bit(nr, vaddr))
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> arch/m68k/include/asm/bitops.h:68:30: note: in expansion of macro 'set_bit'
    #define __set_bit(nr, vaddr) set_bit(nr, vaddr)
                                 ^~~~~~~
>> include/linux/phylink.h:273:2: note: in expansion of macro '__set_bit'
     op(ETHTOOL_LINK_MODE_ ## mode ## _BIT, bm)
     ^~
>> include/linux/phylink.h:275:31: note: in expansion of macro '__phylink_do_bit'
    #define phylink_set(bm, mode) __phylink_do_bit(__set_bit, bm, mode)
                                  ^~~~~~~~~~~~~~~~
   drivers/net/phy/sfp-bus.c:203:3: note: in expansion of macro 'phylink_set'
      phylink_set(modes, 100000baseCR4_Full);
      ^~~~~~~~~~~
   drivers/net/phy/sfp-bus.c:204:2: note: here
     case SFF8024_ECC_25GBASE_CR_S:
     ^~~~
--
   In file included from include/linux/bitops.h:19:0,
                    from include/linux/kernel.h:12,
                    from include/linux/list.h:9,
                    from include/linux/preempt.h:11,
                    from include/linux/spinlock.h:51,
                    from include/linux/kref.h:16,
                    from drivers/net//phy/sfp-bus.c:3:
   drivers/net//phy/sfp-bus.c: In function 'sfp_parse_support':
>> arch/m68k/include/asm/bitops.h:64:33: warning: this statement may fall through [-Wimplicit-fallthrough=]
    #define set_bit(nr, vaddr) (__builtin_constant_p(nr) ? \
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        bset_mem_set_bit(nr, vaddr) : \
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
        bfset_mem_set_bit(nr, vaddr))
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> arch/m68k/include/asm/bitops.h:68:30: note: in expansion of macro 'set_bit'
    #define __set_bit(nr, vaddr) set_bit(nr, vaddr)
                                 ^~~~~~~
>> include/linux/phylink.h:273:2: note: in expansion of macro '__set_bit'
     op(ETHTOOL_LINK_MODE_ ## mode ## _BIT, bm)
     ^~
>> include/linux/phylink.h:275:31: note: in expansion of macro '__phylink_do_bit'
    #define phylink_set(bm, mode) __phylink_do_bit(__set_bit, bm, mode)
                                  ^~~~~~~~~~~~~~~~
   drivers/net//phy/sfp-bus.c:203:3: note: in expansion of macro 'phylink_set'
      phylink_set(modes, 100000baseCR4_Full);
      ^~~~~~~~~~~
   drivers/net//phy/sfp-bus.c:204:2: note: here
     case SFF8024_ECC_25GBASE_CR_S:
     ^~~~

vim +64 arch/m68k/include/asm/bitops.h

171d809df1896c Greg Ungerer 2011-05-17  57  
171d809df1896c Greg Ungerer 2011-05-17  58  #if defined(CONFIG_COLDFIRE)
171d809df1896c Greg Ungerer 2011-05-17  59  #define	set_bit(nr, vaddr)	bset_reg_set_bit(nr, vaddr)
171d809df1896c Greg Ungerer 2011-05-17  60  #elif defined(CONFIG_CPU_HAS_NO_BITFIELDS)
171d809df1896c Greg Ungerer 2011-05-17  61  #define	set_bit(nr, vaddr)	bset_mem_set_bit(nr, vaddr)
171d809df1896c Greg Ungerer 2011-05-17  62  #else
171d809df1896c Greg Ungerer 2011-05-17  63  #define set_bit(nr, vaddr)	(__builtin_constant_p(nr) ? \
171d809df1896c Greg Ungerer 2011-05-17 @64  				bset_mem_set_bit(nr, vaddr) : \
171d809df1896c Greg Ungerer 2011-05-17  65  				bfset_mem_set_bit(nr, vaddr))
171d809df1896c Greg Ungerer 2011-05-17  66  #endif
171d809df1896c Greg Ungerer 2011-05-17  67  
171d809df1896c Greg Ungerer 2011-05-17 @68  #define __set_bit(nr, vaddr)	set_bit(nr, vaddr)
171d809df1896c Greg Ungerer 2011-05-17  69  
171d809df1896c Greg Ungerer 2011-05-17  70  

:::::: The code at line 64 was first introduced by commit
:::::: 171d809df1896c1022f9778cd2788be6c255a7dc m68k: merge mmu and non-mmu bitops.h

:::::: TO: Greg Ungerer <gerg@uclinux.org>
:::::: CC: Greg Ungerer <gerg@uclinux.org>

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 50903 bytes --]