* [PATCH] i2c: ismt: Add missed pci_release_region
@ 2019-11-09 7:54 ` Chuhong Yuan
0 siblings, 0 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-11-09 7:54 UTC (permalink / raw)
Cc: linux-i2c, linux-kernel, Chuhong Yuan
ismt_remove forgets to call pci_release_region when remove.
Add the call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/i2c/busses/i2c-ismt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
index 2f95e25a10f7..c393e629cac3 100644
--- a/drivers/i2c/busses/i2c-ismt.c
+++ b/drivers/i2c/busses/i2c-ismt.c
@@ -943,6 +943,8 @@ static void ismt_remove(struct pci_dev *pdev)
struct ismt_priv *priv = pci_get_drvdata(pdev);
i2c_del_adapter(&priv->adapter);
+
+ pci_release_region(pdev, SMBBAR);
}
static struct pci_driver ismt_driver = {
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] i2c: ismt: Add missed pci_release_region
@ 2019-11-09 7:54 ` Chuhong Yuan
0 siblings, 0 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-11-09 7:54 UTC (permalink / raw)
Cc: linux-i2c, linux-kernel, Chuhong Yuan
ismt_remove forgets to call pci_release_region when remove.
Add the call to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/i2c/busses/i2c-ismt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
index 2f95e25a10f7..c393e629cac3 100644
--- a/drivers/i2c/busses/i2c-ismt.c
+++ b/drivers/i2c/busses/i2c-ismt.c
@@ -943,6 +943,8 @@ static void ismt_remove(struct pci_dev *pdev)
struct ismt_priv *priv = pci_get_drvdata(pdev);
i2c_del_adapter(&priv->adapter);
+
+ pci_release_region(pdev, SMBBAR);
}
static struct pci_driver ismt_driver = {
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: ismt: Add missed pci_release_region
2019-11-09 7:54 ` Chuhong Yuan
(?)
@ 2020-03-22 16:08 ` Wolfram Sang
-1 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2020-03-22 16:08 UTC (permalink / raw)
To: Chuhong Yuan, Seth Heasley, Neil Horman; +Cc: linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
On Sat, Nov 09, 2019 at 03:54:35PM +0800, Chuhong Yuan wrote:
> ismt_remove forgets to call pci_release_region when remove.
> Add the call to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Chuhong Yuan, your To-Header is broken, so you never got a response.
Adding the maintainers to CC.
> ---
> drivers/i2c/busses/i2c-ismt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index 2f95e25a10f7..c393e629cac3 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -943,6 +943,8 @@ static void ismt_remove(struct pci_dev *pdev)
> struct ismt_priv *priv = pci_get_drvdata(pdev);
>
> i2c_del_adapter(&priv->adapter);
> +
> + pci_release_region(pdev, SMBBAR);
> }
>
> static struct pci_driver ismt_driver = {
> --
> 2.23.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-22 16:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-09 7:54 [PATCH] i2c: ismt: Add missed pci_release_region Chuhong Yuan
2019-11-09 7:54 ` Chuhong Yuan
2020-03-22 16:08 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.