* [PATCH] drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-09 10:53 ` Chris Wilson 0 siblings, 0 replies; 14+ messages in thread From: Chris Wilson @ 2019-11-09 10:53 UTC (permalink / raw) To: intel-gfx; +Cc: Chris Wilson, Tvrtko Ursulin, stable We report "frequencies" (actual-frequency, requested-frequency) as the number of accumulated cycles so that the average frequency over that period may be determined by the user. This means the units we report to the user are Mcycles (or just M), not MHz. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: stable@vger.kernel.org --- drivers/gpu/drm/i915/i915_pmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c index 4804775644bf..9b02be0ad4e6 100644 --- a/drivers/gpu/drm/i915/i915_pmu.c +++ b/drivers/gpu/drm/i915/i915_pmu.c @@ -908,8 +908,8 @@ create_event_attributes(struct i915_pmu *pmu) const char *name; const char *unit; } events[] = { - __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "MHz"), - __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "MHz"), + __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "M"), + __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "M"), __event(I915_PMU_INTERRUPTS, "interrupts", NULL), __event(I915_PMU_RC6_RESIDENCY, "rc6-residency", "ns"), }; -- 2.24.0 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-09 10:53 ` Chris Wilson 0 siblings, 0 replies; 14+ messages in thread From: Chris Wilson @ 2019-11-09 10:53 UTC (permalink / raw) To: intel-gfx; +Cc: stable We report "frequencies" (actual-frequency, requested-frequency) as the number of accumulated cycles so that the average frequency over that period may be determined by the user. This means the units we report to the user are Mcycles (or just M), not MHz. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: stable@vger.kernel.org --- drivers/gpu/drm/i915/i915_pmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c index 4804775644bf..9b02be0ad4e6 100644 --- a/drivers/gpu/drm/i915/i915_pmu.c +++ b/drivers/gpu/drm/i915/i915_pmu.c @@ -908,8 +908,8 @@ create_event_attributes(struct i915_pmu *pmu) const char *name; const char *unit; } events[] = { - __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "MHz"), - __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "MHz"), + __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "M"), + __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "M"), __event(I915_PMU_INTERRUPTS, "interrupts", NULL), __event(I915_PMU_RC6_RESIDENCY, "rc6-residency", "ns"), }; -- 2.24.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 14+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-09 11:30 ` Patchwork 0 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2019-11-09 11:30 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/pmu: "Frequency" is reported as accumulated cycles URL : https://patchwork.freedesktop.org/series/69233/ State : success == Summary == CI Bug Log - changes from CI_DRM_7299 -> Patchwork_15203 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/index.html Known issues ------------ Here are the changes found in Patchwork_15203 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s3: - fi-cml-s: [PASS][1] -> [DMESG-WARN][2] ([fdo#111764]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-cml-s/igt@gem_exec_suspend@basic-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/fi-cml-s/igt@gem_exec_suspend@basic-s3.html * igt@i915_selftest@live_gem_contexts: - fi-bsw-kefka: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html #### Possible fixes #### * igt@i915_selftest@live_blt: - fi-hsw-peppy: [DMESG-FAIL][5] ([fdo#112147]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-hsw-peppy/igt@i915_selftest@live_blt.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/fi-hsw-peppy/igt@i915_selftest@live_blt.html [fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542 [fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764 [fdo#112147]: https://bugs.freedesktop.org/show_bug.cgi?id=112147 Participating hosts (51 -> 44) ------------------------------ Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-hsw-4770 fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7299 -> Patchwork_15203 CI-20190529: 20190529 CI_DRM_7299: e7de48a8b1161a99f4b8e4483bc1bb85f5d31039 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5268: c94958b8f7caefcda72392417ae6f3a98e36a48b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_15203: 14399eab6e1d34cd355323b1a251b98abda2f22d @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 14399eab6e1d drm/i915/pmu: "Frequency" is reported as accumulated cycles == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-09 11:30 ` Patchwork 0 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2019-11-09 11:30 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/pmu: "Frequency" is reported as accumulated cycles URL : https://patchwork.freedesktop.org/series/69233/ State : success == Summary == CI Bug Log - changes from CI_DRM_7299 -> Patchwork_15203 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/index.html Known issues ------------ Here are the changes found in Patchwork_15203 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s3: - fi-cml-s: [PASS][1] -> [DMESG-WARN][2] ([fdo#111764]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-cml-s/igt@gem_exec_suspend@basic-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/fi-cml-s/igt@gem_exec_suspend@basic-s3.html * igt@i915_selftest@live_gem_contexts: - fi-bsw-kefka: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html #### Possible fixes #### * igt@i915_selftest@live_blt: - fi-hsw-peppy: [DMESG-FAIL][5] ([fdo#112147]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/fi-hsw-peppy/igt@i915_selftest@live_blt.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/fi-hsw-peppy/igt@i915_selftest@live_blt.html [fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542 [fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764 [fdo#112147]: https://bugs.freedesktop.org/show_bug.cgi?id=112147 Participating hosts (51 -> 44) ------------------------------ Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-hsw-4770 fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7299 -> Patchwork_15203 CI-20190529: 20190529 CI_DRM_7299: e7de48a8b1161a99f4b8e4483bc1bb85f5d31039 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5268: c94958b8f7caefcda72392417ae6f3a98e36a48b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_15203: 14399eab6e1d34cd355323b1a251b98abda2f22d @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 14399eab6e1d drm/i915/pmu: "Frequency" is reported as accumulated cycles == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-10 20:57 ` Patchwork 0 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2019-11-10 20:57 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/pmu: "Frequency" is reported as accumulated cycles URL : https://patchwork.freedesktop.org/series/69233/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7299_full -> Patchwork_15203_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_15203_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_15203_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_15203_full: ### IGT changes ### #### Possible regressions #### * igt@i915_pm_dc@dc6-dpms: - shard-iclb: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb1/igt@i915_pm_dc@dc6-dpms.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html #### Warnings #### * igt@i915_pm_dc@dc6-psr: - shard-tglb: [SKIP][3] ([fdo#111865]) -> [FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@i915_pm_dc@dc6-psr.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb3/igt@i915_pm_dc@dc6-psr.html Known issues ------------ Here are the changes found in Patchwork_15203_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@vecs0-s3: - shard-skl: [PASS][5] -> [INCOMPLETE][6] ([fdo#104108]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl3/igt@gem_ctx_isolation@vecs0-s3.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl8/igt@gem_ctx_isolation@vecs0-s3.html * igt@gem_ctx_persistence@vcs1-mixed: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276] / [fdo#112080]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb4/igt@gem_ctx_persistence@vcs1-mixed.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb6/igt@gem_ctx_persistence@vcs1-mixed.html * igt@gem_ctx_shared@q-smoketest-all: - shard-tglb: [PASS][9] -> [INCOMPLETE][10] ([fdo#111735]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb1/igt@gem_ctx_shared@q-smoketest-all.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb6/igt@gem_ctx_shared@q-smoketest-all.html * igt@gem_ctx_switch@vcs1-heavy: - shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#112080]) +5 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb4/igt@gem_ctx_switch@vcs1-heavy.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb8/igt@gem_ctx_switch@vcs1-heavy.html * igt@gem_exec_schedule@out-order-bsd2: - shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109276]) +15 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb1/igt@gem_exec_schedule@out-order-bsd2.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb7/igt@gem_exec_schedule@out-order-bsd2.html * igt@gem_exec_schedule@preempt-queue-blt: - shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([fdo#111677]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb5/igt@gem_exec_schedule@preempt-queue-blt.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb6/igt@gem_exec_schedule@preempt-queue-blt.html * igt@gem_exec_schedule@wide-bsd: - shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#112146]) +5 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb8/igt@gem_exec_schedule@wide-bsd.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html * igt@gem_exec_suspend@basic-s0: - shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([fdo#111832]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb3/igt@gem_exec_suspend@basic-s0.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb2/igt@gem_exec_suspend@basic-s0.html * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc: - shard-skl: [PASS][21] -> [DMESG-WARN][22] ([fdo#111626]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl9/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc.html * igt@gem_workarounds@suspend-resume-fd: - shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([fdo#111832] / [fdo#111850]) +2 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb8/igt@gem_workarounds@suspend-resume-fd.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb7/igt@gem_workarounds@suspend-resume-fd.html * igt@i915_pm_rps@waitboost: - shard-apl: [PASS][25] -> [FAIL][26] ([fdo#102250]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl7/igt@i915_pm_rps@waitboost.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-apl2/igt@i915_pm_rps@waitboost.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-apl: [PASS][27] -> [DMESG-WARN][28] ([fdo#108566]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [PASS][29] -> [FAIL][30] ([fdo#105363]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt: - shard-tglb: [PASS][31] -> [FAIL][32] ([fdo#103167]) +3 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt: - shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +3 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-kbl: [PASS][35] -> [DMESG-WARN][36] ([fdo#108566]) +4 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][37] -> [FAIL][38] ([fdo#108145] / [fdo#110403]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109642] / [fdo#111068]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@kms_psr2_su@frontbuffer.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb8/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_cursor_plane_move: - shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109441]) +2 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb4/igt@kms_psr@psr2_cursor_plane_move.html * igt@kms_setmode@basic: - shard-kbl: [PASS][43] -> [FAIL][44] ([fdo#99912]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl2/igt@kms_setmode@basic.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-kbl4/igt@kms_setmode@basic.html #### Possible fixes #### * igt@gem_ctx_isolation@rcs0-s3: - shard-apl: [DMESG-WARN][45] ([fdo#108566]) -> [PASS][46] +2 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl2/igt@gem_ctx_isolation@rcs0-s3.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-apl7/igt@gem_ctx_isolation@rcs0-s3.html * igt@gem_ctx_isolation@vcs1-clean: - shard-iclb: [SKIP][47] ([fdo#109276] / [fdo#112080]) -> [PASS][48] +2 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb6/igt@gem_ctx_isolation@vcs1-clean.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb1/igt@gem_ctx_isolation@vcs1-clean.html * igt@gem_ctx_shared@exec-single-timeline-bsd: - shard-iclb: [SKIP][49] ([fdo#110841]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb8/igt@gem_ctx_shared@exec-single-timeline-bsd.html * igt@gem_ctx_shared@q-smoketest-vebox: - shard-tglb: [INCOMPLETE][51] ([fdo#111735]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@gem_ctx_shared@q-smoketest-vebox.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb3/igt@gem_ctx_shared@q-smoketest-vebox.html * igt@gem_ctx_switch@vcs1: - shard-iclb: [SKIP][53] ([fdo#112080]) -> [PASS][54] +10 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb5/igt@gem_ctx_switch@vcs1.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb2/igt@gem_ctx_switch@vcs1.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [SKIP][55] ([fdo#112146]) -> [PASS][56] +3 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb3/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_exec_schedule@smoketest-all: - shard-tglb: [INCOMPLETE][57] ([fdo#111855]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@gem_exec_schedule@smoketest-all.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb5/igt@gem_exec_schedule@smoketest-all.html * igt@gem_userptr_blits@dmabuf-unsync: - shard-hsw: [DMESG-WARN][59] ([fdo#110789] / [fdo#111870]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw5/igt@gem_userptr_blits@dmabuf-unsync.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-hsw5/igt@gem_userptr_blits@dmabuf-unsync.html * igt@gem_userptr_blits@map-fixed-invalidate-busy: - shard-hsw: [DMESG-WARN][61] ([fdo#111870]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html * igt@gem_userptr_blits@sync-unmap-cycles: - shard-snb: [DMESG-WARN][63] ([fdo#110789] / [fdo#111870]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html * igt@gem_workarounds@suspend-resume: - shard-tglb: [INCOMPLETE][65] ([fdo#111832] / [fdo#111850]) -> [PASS][66] +2 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb7/igt@gem_workarounds@suspend-resume.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb6/igt@gem_workarounds@suspend-resume.html * igt@i915_selftest@live_requests: - shard-tglb: [INCOMPLETE][67] ([fdo#112057]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb2/igt@i915_selftest@live_requests.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb1/igt@i915_selftest@live_requests.html * igt@kms_color@pipe-b-ctm-0-5: - shard-skl: [DMESG-WARN][69] ([fdo#106107]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl4/igt@kms_color@pipe-b-ctm-0-5.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl9/igt@kms_color@pipe-b-ctm-0-5.html * igt@kms_cursor_legacy@cursor-vs-flip-atomic: - shard-hsw: [FAIL][71] ([fdo#103355]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-hsw2/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html * igt@kms_cursor_legacy@cursora-vs-flipa-atomic: - shard-tglb: [INCOMPLETE][73] ([fdo#112035 ]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb1/igt@kms_cursor_legacy@cursora-vs-flipa-atomic.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb8/igt@kms_cursor_legacy@cursora-vs-flipa-atomic.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-skl: [FAIL][75] ([fdo#102670]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy: - shard-apl: [DMESG-WARN][77] -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [DMESG-WARN][79] ([fdo#108566]) -> [PASS][80] +10 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render: - shard-iclb: [FAIL][81] ([fdo#103167]) -> [PASS][82] +3 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt: - shard-tglb: [FAIL][83] ([fdo#103167]) -> [PASS][84] +2 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [FAIL][85] ([fdo#108145]) -> [PASS][86] +1 similar issue [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_psr2_su@page_flip: - shard-iclb: [SKIP][87] ([fdo#109642] / [fdo#111068]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb1/igt@kms_psr2_su@page_flip.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb2/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_sprite_blt: - shard-iclb: [SKIP][89] ([fdo#109441]) -> [PASS][90] +1 similar issue [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb8/igt@kms_psr@psr2_sprite_blt.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend: - shard-hsw: [INCOMPLETE][91] ([fdo#103540]) -> [PASS][92] +1 similar issue [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw5/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-hsw2/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html * igt@prime_busy@hang-bsd2: - shard-iclb: [SKIP][93] ([fdo#109276]) -> [PASS][94] +18 similar issues [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb7/igt@prime_busy@hang-bsd2.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb1/igt@prime_busy@hang-bsd2.html #### Warnings #### * igt@gem_ctx_isolation@vcs1-nonpriv: - shard-iclb: [FAIL][95] ([fdo#111329]) -> [SKIP][96] ([fdo#109276] / [fdo#112080]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup: - shard-hsw: [DMESG-WARN][97] ([fdo#111870]) -> [DMESG-WARN][98] ([fdo#110789] / [fdo#111870]) [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html [fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250 [fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789 [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 [fdo#1 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-10 20:57 ` Patchwork 0 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2019-11-10 20:57 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915/pmu: "Frequency" is reported as accumulated cycles URL : https://patchwork.freedesktop.org/series/69233/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7299_full -> Patchwork_15203_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_15203_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_15203_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_15203_full: ### IGT changes ### #### Possible regressions #### * igt@i915_pm_dc@dc6-dpms: - shard-iclb: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb1/igt@i915_pm_dc@dc6-dpms.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html #### Warnings #### * igt@i915_pm_dc@dc6-psr: - shard-tglb: [SKIP][3] ([fdo#111865]) -> [FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@i915_pm_dc@dc6-psr.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb3/igt@i915_pm_dc@dc6-psr.html Known issues ------------ Here are the changes found in Patchwork_15203_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@vecs0-s3: - shard-skl: [PASS][5] -> [INCOMPLETE][6] ([fdo#104108]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl3/igt@gem_ctx_isolation@vecs0-s3.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl8/igt@gem_ctx_isolation@vecs0-s3.html * igt@gem_ctx_persistence@vcs1-mixed: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276] / [fdo#112080]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb4/igt@gem_ctx_persistence@vcs1-mixed.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb6/igt@gem_ctx_persistence@vcs1-mixed.html * igt@gem_ctx_shared@q-smoketest-all: - shard-tglb: [PASS][9] -> [INCOMPLETE][10] ([fdo#111735]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb1/igt@gem_ctx_shared@q-smoketest-all.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb6/igt@gem_ctx_shared@q-smoketest-all.html * igt@gem_ctx_switch@vcs1-heavy: - shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#112080]) +5 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb4/igt@gem_ctx_switch@vcs1-heavy.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb8/igt@gem_ctx_switch@vcs1-heavy.html * igt@gem_exec_schedule@out-order-bsd2: - shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109276]) +15 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb1/igt@gem_exec_schedule@out-order-bsd2.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb7/igt@gem_exec_schedule@out-order-bsd2.html * igt@gem_exec_schedule@preempt-queue-blt: - shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([fdo#111677]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb5/igt@gem_exec_schedule@preempt-queue-blt.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb6/igt@gem_exec_schedule@preempt-queue-blt.html * igt@gem_exec_schedule@wide-bsd: - shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#112146]) +5 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb8/igt@gem_exec_schedule@wide-bsd.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html * igt@gem_exec_suspend@basic-s0: - shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([fdo#111832]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb3/igt@gem_exec_suspend@basic-s0.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb2/igt@gem_exec_suspend@basic-s0.html * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc: - shard-skl: [PASS][21] -> [DMESG-WARN][22] ([fdo#111626]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl9/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc.html * igt@gem_workarounds@suspend-resume-fd: - shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([fdo#111832] / [fdo#111850]) +2 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb8/igt@gem_workarounds@suspend-resume-fd.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb7/igt@gem_workarounds@suspend-resume-fd.html * igt@i915_pm_rps@waitboost: - shard-apl: [PASS][25] -> [FAIL][26] ([fdo#102250]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl7/igt@i915_pm_rps@waitboost.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-apl2/igt@i915_pm_rps@waitboost.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-apl: [PASS][27] -> [DMESG-WARN][28] ([fdo#108566]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [PASS][29] -> [FAIL][30] ([fdo#105363]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt: - shard-tglb: [PASS][31] -> [FAIL][32] ([fdo#103167]) +3 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt: - shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +3 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-kbl: [PASS][35] -> [DMESG-WARN][36] ([fdo#108566]) +4 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][37] -> [FAIL][38] ([fdo#108145] / [fdo#110403]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109642] / [fdo#111068]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@kms_psr2_su@frontbuffer.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb8/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_cursor_plane_move: - shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109441]) +2 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb4/igt@kms_psr@psr2_cursor_plane_move.html * igt@kms_setmode@basic: - shard-kbl: [PASS][43] -> [FAIL][44] ([fdo#99912]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl2/igt@kms_setmode@basic.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-kbl4/igt@kms_setmode@basic.html #### Possible fixes #### * igt@gem_ctx_isolation@rcs0-s3: - shard-apl: [DMESG-WARN][45] ([fdo#108566]) -> [PASS][46] +2 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl2/igt@gem_ctx_isolation@rcs0-s3.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-apl7/igt@gem_ctx_isolation@rcs0-s3.html * igt@gem_ctx_isolation@vcs1-clean: - shard-iclb: [SKIP][47] ([fdo#109276] / [fdo#112080]) -> [PASS][48] +2 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb6/igt@gem_ctx_isolation@vcs1-clean.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb1/igt@gem_ctx_isolation@vcs1-clean.html * igt@gem_ctx_shared@exec-single-timeline-bsd: - shard-iclb: [SKIP][49] ([fdo#110841]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb8/igt@gem_ctx_shared@exec-single-timeline-bsd.html * igt@gem_ctx_shared@q-smoketest-vebox: - shard-tglb: [INCOMPLETE][51] ([fdo#111735]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@gem_ctx_shared@q-smoketest-vebox.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb3/igt@gem_ctx_shared@q-smoketest-vebox.html * igt@gem_ctx_switch@vcs1: - shard-iclb: [SKIP][53] ([fdo#112080]) -> [PASS][54] +10 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb5/igt@gem_ctx_switch@vcs1.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb2/igt@gem_ctx_switch@vcs1.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [SKIP][55] ([fdo#112146]) -> [PASS][56] +3 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb3/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_exec_schedule@smoketest-all: - shard-tglb: [INCOMPLETE][57] ([fdo#111855]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb6/igt@gem_exec_schedule@smoketest-all.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb5/igt@gem_exec_schedule@smoketest-all.html * igt@gem_userptr_blits@dmabuf-unsync: - shard-hsw: [DMESG-WARN][59] ([fdo#110789] / [fdo#111870]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw5/igt@gem_userptr_blits@dmabuf-unsync.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-hsw5/igt@gem_userptr_blits@dmabuf-unsync.html * igt@gem_userptr_blits@map-fixed-invalidate-busy: - shard-hsw: [DMESG-WARN][61] ([fdo#111870]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy.html * igt@gem_userptr_blits@sync-unmap-cycles: - shard-snb: [DMESG-WARN][63] ([fdo#110789] / [fdo#111870]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html * igt@gem_workarounds@suspend-resume: - shard-tglb: [INCOMPLETE][65] ([fdo#111832] / [fdo#111850]) -> [PASS][66] +2 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb7/igt@gem_workarounds@suspend-resume.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb6/igt@gem_workarounds@suspend-resume.html * igt@i915_selftest@live_requests: - shard-tglb: [INCOMPLETE][67] ([fdo#112057]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb2/igt@i915_selftest@live_requests.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb1/igt@i915_selftest@live_requests.html * igt@kms_color@pipe-b-ctm-0-5: - shard-skl: [DMESG-WARN][69] ([fdo#106107]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl4/igt@kms_color@pipe-b-ctm-0-5.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl9/igt@kms_color@pipe-b-ctm-0-5.html * igt@kms_cursor_legacy@cursor-vs-flip-atomic: - shard-hsw: [FAIL][71] ([fdo#103355]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-hsw2/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html * igt@kms_cursor_legacy@cursora-vs-flipa-atomic: - shard-tglb: [INCOMPLETE][73] ([fdo#112035 ]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb1/igt@kms_cursor_legacy@cursora-vs-flipa-atomic.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb8/igt@kms_cursor_legacy@cursora-vs-flipa-atomic.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-skl: [FAIL][75] ([fdo#102670]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy: - shard-apl: [DMESG-WARN][77] -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [DMESG-WARN][79] ([fdo#108566]) -> [PASS][80] +10 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render: - shard-iclb: [FAIL][81] ([fdo#103167]) -> [PASS][82] +3 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt: - shard-tglb: [FAIL][83] ([fdo#103167]) -> [PASS][84] +2 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [FAIL][85] ([fdo#108145]) -> [PASS][86] +1 similar issue [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_psr2_su@page_flip: - shard-iclb: [SKIP][87] ([fdo#109642] / [fdo#111068]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb1/igt@kms_psr2_su@page_flip.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb2/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_sprite_blt: - shard-iclb: [SKIP][89] ([fdo#109441]) -> [PASS][90] +1 similar issue [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb8/igt@kms_psr@psr2_sprite_blt.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend: - shard-hsw: [INCOMPLETE][91] ([fdo#103540]) -> [PASS][92] +1 similar issue [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw5/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-hsw2/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html * igt@prime_busy@hang-bsd2: - shard-iclb: [SKIP][93] ([fdo#109276]) -> [PASS][94] +18 similar issues [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb7/igt@prime_busy@hang-bsd2.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb1/igt@prime_busy@hang-bsd2.html #### Warnings #### * igt@gem_ctx_isolation@vcs1-nonpriv: - shard-iclb: [FAIL][95] ([fdo#111329]) -> [SKIP][96] ([fdo#109276] / [fdo#112080]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup: - shard-hsw: [DMESG-WARN][97] ([fdo#111870]) -> [DMESG-WARN][98] ([fdo#110789] / [fdo#111870]) [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7299/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html [fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250 [fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789 [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 [fdo#1 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15203/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-11 9:11 ` Tvrtko Ursulin 0 siblings, 0 replies; 14+ messages in thread From: Tvrtko Ursulin @ 2019-11-11 9:11 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: stable On 09/11/2019 10:53, Chris Wilson wrote: > We report "frequencies" (actual-frequency, requested-frequency) as the > number of accumulated cycles so that the average frequency over that > period may be determined by the user. This means the units we report to > the user are Mcycles (or just M), not MHz. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/i915/i915_pmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c > index 4804775644bf..9b02be0ad4e6 100644 > --- a/drivers/gpu/drm/i915/i915_pmu.c > +++ b/drivers/gpu/drm/i915/i915_pmu.c > @@ -908,8 +908,8 @@ create_event_attributes(struct i915_pmu *pmu) > const char *name; > const char *unit; > } events[] = { > - __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "MHz"), > - __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "MHz"), > + __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "M"), > + __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "M"), > __event(I915_PMU_INTERRUPTS, "interrupts", NULL), > __event(I915_PMU_RC6_RESIDENCY, "rc6-residency", "ns"), > }; > MHz was wrong yes. But is 'M' established or would 'Mcycles' be better? Regards, Tvrtko ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-11 9:11 ` Tvrtko Ursulin 0 siblings, 0 replies; 14+ messages in thread From: Tvrtko Ursulin @ 2019-11-11 9:11 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: stable On 09/11/2019 10:53, Chris Wilson wrote: > We report "frequencies" (actual-frequency, requested-frequency) as the > number of accumulated cycles so that the average frequency over that > period may be determined by the user. This means the units we report to > the user are Mcycles (or just M), not MHz. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/i915/i915_pmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c > index 4804775644bf..9b02be0ad4e6 100644 > --- a/drivers/gpu/drm/i915/i915_pmu.c > +++ b/drivers/gpu/drm/i915/i915_pmu.c > @@ -908,8 +908,8 @@ create_event_attributes(struct i915_pmu *pmu) > const char *name; > const char *unit; > } events[] = { > - __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "MHz"), > - __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "MHz"), > + __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "M"), > + __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "M"), > __event(I915_PMU_INTERRUPTS, "interrupts", NULL), > __event(I915_PMU_RC6_RESIDENCY, "rc6-residency", "ns"), > }; > MHz was wrong yes. But is 'M' established or would 'Mcycles' be better? Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-11 9:43 ` Chris Wilson 0 siblings, 0 replies; 14+ messages in thread From: Chris Wilson @ 2019-11-11 9:43 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx; +Cc: stable Quoting Tvrtko Ursulin (2019-11-11 09:11:03) > > On 09/11/2019 10:53, Chris Wilson wrote: > > We report "frequencies" (actual-frequency, requested-frequency) as the > > number of accumulated cycles so that the average frequency over that > > period may be determined by the user. This means the units we report to > > the user are Mcycles (or just M), not MHz. > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Cc: stable@vger.kernel.org > > --- > > drivers/gpu/drm/i915/i915_pmu.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c > > index 4804775644bf..9b02be0ad4e6 100644 > > --- a/drivers/gpu/drm/i915/i915_pmu.c > > +++ b/drivers/gpu/drm/i915/i915_pmu.c > > @@ -908,8 +908,8 @@ create_event_attributes(struct i915_pmu *pmu) > > const char *name; > > const char *unit; > > } events[] = { > > - __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "MHz"), > > - __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "MHz"), > > + __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "M"), > > + __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "M"), > > __event(I915_PMU_INTERRUPTS, "interrupts", NULL), > > __event(I915_PMU_RC6_RESIDENCY, "rc6-residency", "ns"), > > }; > > > > MHz was wrong yes. But is 'M' established or would 'Mcycles' be better? The only place where "cycles" pops up is in the perf ui, the other events that I thought were similar in nature are unitless. As the 'cycle' itself is not an SI base unit as it is a mere count. ~o~ I have no idea ~o~ -Chris ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-11 9:43 ` Chris Wilson 0 siblings, 0 replies; 14+ messages in thread From: Chris Wilson @ 2019-11-11 9:43 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx; +Cc: stable Quoting Tvrtko Ursulin (2019-11-11 09:11:03) > > On 09/11/2019 10:53, Chris Wilson wrote: > > We report "frequencies" (actual-frequency, requested-frequency) as the > > number of accumulated cycles so that the average frequency over that > > period may be determined by the user. This means the units we report to > > the user are Mcycles (or just M), not MHz. > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Cc: stable@vger.kernel.org > > --- > > drivers/gpu/drm/i915/i915_pmu.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c > > index 4804775644bf..9b02be0ad4e6 100644 > > --- a/drivers/gpu/drm/i915/i915_pmu.c > > +++ b/drivers/gpu/drm/i915/i915_pmu.c > > @@ -908,8 +908,8 @@ create_event_attributes(struct i915_pmu *pmu) > > const char *name; > > const char *unit; > > } events[] = { > > - __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "MHz"), > > - __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "MHz"), > > + __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "M"), > > + __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "M"), > > __event(I915_PMU_INTERRUPTS, "interrupts", NULL), > > __event(I915_PMU_RC6_RESIDENCY, "rc6-residency", "ns"), > > }; > > > > MHz was wrong yes. But is 'M' established or would 'Mcycles' be better? The only place where "cycles" pops up is in the perf ui, the other events that I thought were similar in nature are unitless. As the 'cycle' itself is not an SI base unit as it is a mere count. ~o~ I have no idea ~o~ -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-11 10:40 ` Tvrtko Ursulin 0 siblings, 0 replies; 14+ messages in thread From: Tvrtko Ursulin @ 2019-11-11 10:40 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: stable On 11/11/2019 09:43, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2019-11-11 09:11:03) >> >> On 09/11/2019 10:53, Chris Wilson wrote: >>> We report "frequencies" (actual-frequency, requested-frequency) as the >>> number of accumulated cycles so that the average frequency over that >>> period may be determined by the user. This means the units we report to >>> the user are Mcycles (or just M), not MHz. >>> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >>> Cc: stable@vger.kernel.org >>> --- >>> drivers/gpu/drm/i915/i915_pmu.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c >>> index 4804775644bf..9b02be0ad4e6 100644 >>> --- a/drivers/gpu/drm/i915/i915_pmu.c >>> +++ b/drivers/gpu/drm/i915/i915_pmu.c >>> @@ -908,8 +908,8 @@ create_event_attributes(struct i915_pmu *pmu) >>> const char *name; >>> const char *unit; >>> } events[] = { >>> - __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "MHz"), >>> - __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "MHz"), >>> + __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "M"), >>> + __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "M"), >>> __event(I915_PMU_INTERRUPTS, "interrupts", NULL), >>> __event(I915_PMU_RC6_RESIDENCY, "rc6-residency", "ns"), >>> }; >>> >> >> MHz was wrong yes. But is 'M' established or would 'Mcycles' be better? > > The only place where "cycles" pops up is in the perf ui, the other > events that I thought were similar in nature are unitless. As the > 'cycle' itself is not an SI base unit as it is a mere count. > > ~o~ I have no idea ~o~ But if the argument if that 'cycle' is not SI then neither is 'M'. So I think I would prefer 'Mcycles'. Nevertheless, I guess a strange 'M' is better than wrong 'MHz'. Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-11 10:40 ` Tvrtko Ursulin 0 siblings, 0 replies; 14+ messages in thread From: Tvrtko Ursulin @ 2019-11-11 10:40 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: stable On 11/11/2019 09:43, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2019-11-11 09:11:03) >> >> On 09/11/2019 10:53, Chris Wilson wrote: >>> We report "frequencies" (actual-frequency, requested-frequency) as the >>> number of accumulated cycles so that the average frequency over that >>> period may be determined by the user. This means the units we report to >>> the user are Mcycles (or just M), not MHz. >>> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >>> Cc: stable@vger.kernel.org >>> --- >>> drivers/gpu/drm/i915/i915_pmu.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c >>> index 4804775644bf..9b02be0ad4e6 100644 >>> --- a/drivers/gpu/drm/i915/i915_pmu.c >>> +++ b/drivers/gpu/drm/i915/i915_pmu.c >>> @@ -908,8 +908,8 @@ create_event_attributes(struct i915_pmu *pmu) >>> const char *name; >>> const char *unit; >>> } events[] = { >>> - __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "MHz"), >>> - __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "MHz"), >>> + __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "M"), >>> + __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "M"), >>> __event(I915_PMU_INTERRUPTS, "interrupts", NULL), >>> __event(I915_PMU_RC6_RESIDENCY, "rc6-residency", "ns"), >>> }; >>> >> >> MHz was wrong yes. But is 'M' established or would 'Mcycles' be better? > > The only place where "cycles" pops up is in the perf ui, the other > events that I thought were similar in nature are unitless. As the > 'cycle' itself is not an SI base unit as it is a mere count. > > ~o~ I have no idea ~o~ But if the argument if that 'cycle' is not SI then neither is 'M'. So I think I would prefer 'Mcycles'. Nevertheless, I guess a strange 'M' is better than wrong 'MHz'. Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-11 11:59 ` Chris Wilson 0 siblings, 0 replies; 14+ messages in thread From: Chris Wilson @ 2019-11-11 11:59 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx; +Cc: stable Quoting Tvrtko Ursulin (2019-11-11 10:40:17) > > On 11/11/2019 09:43, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-11-11 09:11:03) > >> > >> On 09/11/2019 10:53, Chris Wilson wrote: > >>> We report "frequencies" (actual-frequency, requested-frequency) as the > >>> number of accumulated cycles so that the average frequency over that > >>> period may be determined by the user. This means the units we report to > >>> the user are Mcycles (or just M), not MHz. > >>> > >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > >>> Cc: stable@vger.kernel.org > >>> --- > >>> drivers/gpu/drm/i915/i915_pmu.c | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c > >>> index 4804775644bf..9b02be0ad4e6 100644 > >>> --- a/drivers/gpu/drm/i915/i915_pmu.c > >>> +++ b/drivers/gpu/drm/i915/i915_pmu.c > >>> @@ -908,8 +908,8 @@ create_event_attributes(struct i915_pmu *pmu) > >>> const char *name; > >>> const char *unit; > >>> } events[] = { > >>> - __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "MHz"), > >>> - __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "MHz"), > >>> + __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "M"), > >>> + __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "M"), > >>> __event(I915_PMU_INTERRUPTS, "interrupts", NULL), > >>> __event(I915_PMU_RC6_RESIDENCY, "rc6-residency", "ns"), > >>> }; > >>> > >> > >> MHz was wrong yes. But is 'M' established or would 'Mcycles' be better? > > > > The only place where "cycles" pops up is in the perf ui, the other > > events that I thought were similar in nature are unitless. As the > > 'cycle' itself is not an SI base unit as it is a mere count. > > > > ~o~ I have no idea ~o~ > > But if the argument if that 'cycle' is not SI then neither is 'M'. So I > think I would prefer 'Mcycles'. Nevertheless, I guess a strange 'M' is > better than wrong 'MHz'. Yeah, I'm really tempted to say we should just remove the M as well but what a waste of bits! I think 'M' is understandable from context, whereas MHz was quite misleading in perf stat :) Still, if we ever get any feedback, it should be easy to fix :) -Chris ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/pmu: "Frequency" is reported as accumulated cycles @ 2019-11-11 11:59 ` Chris Wilson 0 siblings, 0 replies; 14+ messages in thread From: Chris Wilson @ 2019-11-11 11:59 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx; +Cc: stable Quoting Tvrtko Ursulin (2019-11-11 10:40:17) > > On 11/11/2019 09:43, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-11-11 09:11:03) > >> > >> On 09/11/2019 10:53, Chris Wilson wrote: > >>> We report "frequencies" (actual-frequency, requested-frequency) as the > >>> number of accumulated cycles so that the average frequency over that > >>> period may be determined by the user. This means the units we report to > >>> the user are Mcycles (or just M), not MHz. > >>> > >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > >>> Cc: stable@vger.kernel.org > >>> --- > >>> drivers/gpu/drm/i915/i915_pmu.c | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c > >>> index 4804775644bf..9b02be0ad4e6 100644 > >>> --- a/drivers/gpu/drm/i915/i915_pmu.c > >>> +++ b/drivers/gpu/drm/i915/i915_pmu.c > >>> @@ -908,8 +908,8 @@ create_event_attributes(struct i915_pmu *pmu) > >>> const char *name; > >>> const char *unit; > >>> } events[] = { > >>> - __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "MHz"), > >>> - __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "MHz"), > >>> + __event(I915_PMU_ACTUAL_FREQUENCY, "actual-frequency", "M"), > >>> + __event(I915_PMU_REQUESTED_FREQUENCY, "requested-frequency", "M"), > >>> __event(I915_PMU_INTERRUPTS, "interrupts", NULL), > >>> __event(I915_PMU_RC6_RESIDENCY, "rc6-residency", "ns"), > >>> }; > >>> > >> > >> MHz was wrong yes. But is 'M' established or would 'Mcycles' be better? > > > > The only place where "cycles" pops up is in the perf ui, the other > > events that I thought were similar in nature are unitless. As the > > 'cycle' itself is not an SI base unit as it is a mere count. > > > > ~o~ I have no idea ~o~ > > But if the argument if that 'cycle' is not SI then neither is 'M'. So I > think I would prefer 'Mcycles'. Nevertheless, I guess a strange 'M' is > better than wrong 'MHz'. Yeah, I'm really tempted to say we should just remove the M as well but what a waste of bits! I think 'M' is understandable from context, whereas MHz was quite misleading in perf stat :) Still, if we ever get any feedback, it should be easy to fix :) -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-11-11 11:59 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-09 10:53 [PATCH] drm/i915/pmu: "Frequency" is reported as accumulated cycles Chris Wilson 2019-11-09 10:53 ` [Intel-gfx] " Chris Wilson 2019-11-09 11:30 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-11-09 11:30 ` [Intel-gfx] " Patchwork 2019-11-10 20:57 ` ✗ Fi.CI.IGT: failure " Patchwork 2019-11-10 20:57 ` [Intel-gfx] " Patchwork 2019-11-11 9:11 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2019-11-11 9:11 ` Tvrtko Ursulin 2019-11-11 9:43 ` Chris Wilson 2019-11-11 9:43 ` Chris Wilson 2019-11-11 10:40 ` Tvrtko Ursulin 2019-11-11 10:40 ` Tvrtko Ursulin 2019-11-11 11:59 ` Chris Wilson 2019-11-11 11:59 ` Chris Wilson
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.