All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] i915/gem_blits: Use common igt_fls()
@ 2019-11-09 15:10 ` Chris Wilson
  0 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2019-11-09 15:10 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

igt_aux.h already provides the optimal igt_fls(), so use that in
preference to open coding the brute force version.

Reported-by: Stuart Summers <stuart.summers@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Stuart Summers <stuart.summers@intel.com>
---
 tests/i915/gem_blits.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/tests/i915/gem_blits.c b/tests/i915/gem_blits.c
index e0346a7c7..f9cb12bb8 100644
--- a/tests/i915/gem_blits.c
+++ b/tests/i915/gem_blits.c
@@ -57,16 +57,6 @@ enum mode {
 	WC,
 };
 
-static int fls(uint64_t x)
-{
-	int t;
-
-	for (t = 0; x >> t; t++)
-		;
-
-	return t;
-}
-
 static unsigned int
 get_tiling_stride(const struct device *device,
 		  unsigned int width, unsigned int tiling)
@@ -81,7 +71,7 @@ get_tiling_stride(const struct device *device,
 		else
 			stride = ALIGN(stride, 128);
 		if (device->gen < 4)
-			stride = 1 << fls(stride - 1);
+			stride = 1 << igt_fls(stride - 1);
 	} else {
 		if (device->gen >= 8)
 			stride = ALIGN(stride, 64);
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-11-13 20:38 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-09 15:10 [PATCH i-g-t] i915/gem_blits: Use common igt_fls() Chris Wilson
2019-11-09 15:10 ` [igt-dev] " Chris Wilson
2019-11-09 15:10 ` [Intel-gfx] " Chris Wilson
2019-11-09 15:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-11-10 22:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-11-11 10:47 ` [igt-dev] [PATCH i-g-t] " Arkadiusz Hiler
2019-11-11 10:47   ` [Intel-gfx] " Arkadiusz Hiler
2019-11-13 20:38 ` Summers, Stuart
2019-11-13 20:38   ` [igt-dev] " Summers, Stuart
2019-11-13 20:38   ` [Intel-gfx] " Summers, Stuart

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.