From: Lee Jones <lee.jones@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: robh@kernel.org, broonie@kernel.org, linus.walleij@linaro.org,
vinod.koul@linaro.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
spapothi@codeaurora.org, bgoswami@codeaurora.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec
Date: Mon, 11 Nov 2019 13:36:10 +0000 [thread overview]
Message-ID: <20191111133610.GO3218@dell> (raw)
In-Reply-To: <ce2244ac-2219-3cc0-8ad6-7491295fbbef@linaro.org>
> > > +static void wcd934x_slim_remove(struct slim_device *sdev)
> > > +{
> > > + struct wcd934x_ddata *ddata = dev_get_drvdata(&sdev->dev);
> > > +
> > > + regulator_bulk_disable(WCD934X_MAX_SUPPLY, ddata->supplies);
> > > + mfd_remove_devices(&sdev->dev);
> > > + kfree(ddata);
> > > +}
> > > +
> > > +static const struct slim_device_id wcd934x_slim_id[] = {
> > > + { SLIM_MANF_ID_QCOM, SLIM_PROD_CODE_WCD9340, 0x1, 0x0 },
> >
> > What do the last parameters mean? Might be better to define them.
>
> This is Instance ID and Device ID of SLIMBus enumeration address.
Great.
Please define them in the same was you did for the product code.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: robh@kernel.org, alsa-devel@alsa-project.org,
bgoswami@codeaurora.org, vinod.koul@linaro.org,
devicetree@vger.kernel.org, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
broonie@kernel.org, spapothi@codeaurora.org
Subject: Re: [alsa-devel] [PATCH v3 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec
Date: Mon, 11 Nov 2019 13:36:10 +0000 [thread overview]
Message-ID: <20191111133610.GO3218@dell> (raw)
In-Reply-To: <ce2244ac-2219-3cc0-8ad6-7491295fbbef@linaro.org>
> > > +static void wcd934x_slim_remove(struct slim_device *sdev)
> > > +{
> > > + struct wcd934x_ddata *ddata = dev_get_drvdata(&sdev->dev);
> > > +
> > > + regulator_bulk_disable(WCD934X_MAX_SUPPLY, ddata->supplies);
> > > + mfd_remove_devices(&sdev->dev);
> > > + kfree(ddata);
> > > +}
> > > +
> > > +static const struct slim_device_id wcd934x_slim_id[] = {
> > > + { SLIM_MANF_ID_QCOM, SLIM_PROD_CODE_WCD9340, 0x1, 0x0 },
> >
> > What do the last parameters mean? Might be better to define them.
>
> This is Instance ID and Device ID of SLIMBus enumeration address.
Great.
Please define them in the same was you did for the product code.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-11 13:36 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 11:26 [PATCH v3 00/11] ASoC: Add support to WCD9340/WCD9341 codec Srinivas Kandagatla
2019-10-29 11:26 ` [alsa-devel] " Srinivas Kandagatla
2019-10-29 11:26 ` [PATCH v3 01/11] ASoC: dt-bindings: add dt bindings for WCD9340/WCD9341 audio codec Srinivas Kandagatla
2019-10-29 11:26 ` [alsa-devel] " Srinivas Kandagatla
2019-11-05 19:31 ` Rob Herring
2019-11-05 19:31 ` [alsa-devel] " Rob Herring
2019-11-06 10:08 ` Srinivas Kandagatla
2019-11-06 10:08 ` [alsa-devel] " Srinivas Kandagatla
2019-11-07 17:40 ` Rob Herring
2019-11-07 17:40 ` [alsa-devel] " Rob Herring
2019-10-29 11:26 ` [PATCH v3 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec Srinivas Kandagatla
2019-10-29 11:26 ` [alsa-devel] " Srinivas Kandagatla
2019-11-11 11:18 ` Lee Jones
2019-11-11 11:18 ` [alsa-devel] " Lee Jones
2019-11-11 12:48 ` Srinivas Kandagatla
2019-11-11 12:48 ` [alsa-devel] " Srinivas Kandagatla
2019-11-11 13:36 ` Lee Jones [this message]
2019-11-11 13:36 ` Lee Jones
2019-10-29 11:26 ` [PATCH v3 03/11] ASoC: " Srinivas Kandagatla
2019-10-29 11:26 ` [alsa-devel] " Srinivas Kandagatla
2019-10-29 11:26 ` [PATCH v3 04/11] ASoC: wcd934x: add basic controls Srinivas Kandagatla
2019-10-29 11:26 ` [alsa-devel] " Srinivas Kandagatla
2019-10-29 11:26 ` [PATCH v3 05/11] ASoC: wcd934x: add playback dapm widgets Srinivas Kandagatla
2019-10-29 11:26 ` [alsa-devel] " Srinivas Kandagatla
2019-10-29 11:26 ` [PATCH v3 06/11] ASoC: wcd934x: add capture " Srinivas Kandagatla
2019-10-29 11:26 ` [alsa-devel] " Srinivas Kandagatla
2019-10-29 11:26 ` [PATCH v3 07/11] ASoC: wcd934x: add audio routings Srinivas Kandagatla
2019-10-29 11:26 ` [alsa-devel] " Srinivas Kandagatla
2019-10-29 11:26 ` [PATCH v3 08/11] dt-bindings: pinctrl: qcom-wcd934x: Add bindings for gpio Srinivas Kandagatla
2019-10-29 11:26 ` [alsa-devel] " Srinivas Kandagatla
2019-11-03 23:19 ` Linus Walleij
2019-11-03 23:19 ` [alsa-devel] " Linus Walleij
2019-11-04 9:35 ` Srinivas Kandagatla
2019-11-04 9:35 ` [alsa-devel] " Srinivas Kandagatla
2019-11-05 13:25 ` Linus Walleij
2019-11-05 13:25 ` [alsa-devel] " Linus Walleij
2019-11-05 13:27 ` Srinivas Kandagatla
2019-11-05 13:27 ` [alsa-devel] " Srinivas Kandagatla
2019-11-05 18:49 ` Rob Herring
2019-11-05 18:49 ` [alsa-devel] " Rob Herring
2019-10-29 11:26 ` [PATCH v3 09/11] pinctrl: qcom-wcd934x: Add support to wcd934x pinctrl driver Srinivas Kandagatla
2019-10-29 11:26 ` [alsa-devel] " Srinivas Kandagatla
2019-10-30 14:50 ` Stephen Boyd
2019-10-30 14:50 ` [alsa-devel] " Stephen Boyd
2019-10-31 10:31 ` Srinivas Kandagatla
2019-10-31 10:31 ` [alsa-devel] " Srinivas Kandagatla
2019-10-29 11:26 ` [PATCH v3 10/11] ASoC: qcom: dt-bindings: Add compatible for DB845c and Lenovo Yoga Srinivas Kandagatla
2019-10-29 11:26 ` [alsa-devel] " Srinivas Kandagatla
2019-10-29 11:27 ` [PATCH v3 11/11] ASoC: qcom: sdm845: add support to " Srinivas Kandagatla
2019-10-29 11:27 ` [alsa-devel] " Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111133610.GO3218@dell \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=spapothi@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.