* [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() @ 2019-11-11 22:15 ` Andreas Färber 0 siblings, 0 replies; 12+ messages in thread From: Andreas Färber @ 2019-11-11 22:15 UTC (permalink / raw) To: linux-amlogic Cc: linux-arm-kernel, linux-kernel, Andreas Färber, Greg Kroah-Hartman, Martin Blumenstingl, Neil Armstrong, Kevin Hilman The helper soc_device_to_device() is considered deprecated. For a driver __init function the predictable prefix text "soc soc0:" from dev_info() does not add real value, so use pr_info() to emit the info text without such prefix. While at it, normalize the casing of "detected" for GX. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Andreas Färber <afaerber@suse.de> --- drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c index 01fc0d20a70d..105b819bbd5f 100644 --- a/drivers/soc/amlogic/meson-gx-socinfo.c +++ b/drivers/soc/amlogic/meson-gx-socinfo.c @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) struct device_node *np; struct regmap *regmap; unsigned int socinfo; - struct device *dev; int ret; /* look up for chipid node */ @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) kfree(soc_dev_attr); return PTR_ERR(soc_dev); } - dev = soc_device_to_device(soc_dev); - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", soc_dev_attr->soc_id, socinfo_to_major(socinfo), socinfo_to_minor(socinfo), diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c index 78f0f1aeca57..7db2c94a7130 100644 --- a/drivers/soc/amlogic/meson-mx-socinfo.c +++ b/drivers/soc/amlogic/meson-mx-socinfo.c @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) return PTR_ERR(soc_dev); } - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", - soc_dev_attr->soc_id, soc_dev_attr->revision); + pr_info("Amlogic %s %s detected\n", + soc_dev_attr->soc_id, soc_dev_attr->revision); return 0; } -- 2.16.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() @ 2019-11-11 22:15 ` Andreas Färber 0 siblings, 0 replies; 12+ messages in thread From: Andreas Färber @ 2019-11-11 22:15 UTC (permalink / raw) To: linux-amlogic Cc: Neil Armstrong, Martin Blumenstingl, Greg Kroah-Hartman, linux-kernel, Kevin Hilman, Andreas Färber, linux-arm-kernel The helper soc_device_to_device() is considered deprecated. For a driver __init function the predictable prefix text "soc soc0:" from dev_info() does not add real value, so use pr_info() to emit the info text without such prefix. While at it, normalize the casing of "detected" for GX. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Andreas Färber <afaerber@suse.de> --- drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c index 01fc0d20a70d..105b819bbd5f 100644 --- a/drivers/soc/amlogic/meson-gx-socinfo.c +++ b/drivers/soc/amlogic/meson-gx-socinfo.c @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) struct device_node *np; struct regmap *regmap; unsigned int socinfo; - struct device *dev; int ret; /* look up for chipid node */ @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) kfree(soc_dev_attr); return PTR_ERR(soc_dev); } - dev = soc_device_to_device(soc_dev); - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", soc_dev_attr->soc_id, socinfo_to_major(socinfo), socinfo_to_minor(socinfo), diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c index 78f0f1aeca57..7db2c94a7130 100644 --- a/drivers/soc/amlogic/meson-mx-socinfo.c +++ b/drivers/soc/amlogic/meson-mx-socinfo.c @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) return PTR_ERR(soc_dev); } - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", - soc_dev_attr->soc_id, soc_dev_attr->revision); + pr_info("Amlogic %s %s detected\n", + soc_dev_attr->soc_id, soc_dev_attr->revision); return 0; } -- 2.16.4 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() @ 2019-11-11 22:15 ` Andreas Färber 0 siblings, 0 replies; 12+ messages in thread From: Andreas Färber @ 2019-11-11 22:15 UTC (permalink / raw) To: linux-amlogic Cc: Neil Armstrong, Martin Blumenstingl, Greg Kroah-Hartman, linux-kernel, Kevin Hilman, Andreas Färber, linux-arm-kernel The helper soc_device_to_device() is considered deprecated. For a driver __init function the predictable prefix text "soc soc0:" from dev_info() does not add real value, so use pr_info() to emit the info text without such prefix. While at it, normalize the casing of "detected" for GX. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Andreas Färber <afaerber@suse.de> --- drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c index 01fc0d20a70d..105b819bbd5f 100644 --- a/drivers/soc/amlogic/meson-gx-socinfo.c +++ b/drivers/soc/amlogic/meson-gx-socinfo.c @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) struct device_node *np; struct regmap *regmap; unsigned int socinfo; - struct device *dev; int ret; /* look up for chipid node */ @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) kfree(soc_dev_attr); return PTR_ERR(soc_dev); } - dev = soc_device_to_device(soc_dev); - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", soc_dev_attr->soc_id, socinfo_to_major(socinfo), socinfo_to_minor(socinfo), diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c index 78f0f1aeca57..7db2c94a7130 100644 --- a/drivers/soc/amlogic/meson-mx-socinfo.c +++ b/drivers/soc/amlogic/meson-mx-socinfo.c @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) return PTR_ERR(soc_dev); } - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", - soc_dev_attr->soc_id, soc_dev_attr->revision); + pr_info("Amlogic %s %s detected\n", + soc_dev_attr->soc_id, soc_dev_attr->revision); return 0; } -- 2.16.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() 2019-11-11 22:15 ` Andreas Färber (?) @ 2019-11-12 5:40 ` Greg Kroah-Hartman -1 siblings, 0 replies; 12+ messages in thread From: Greg Kroah-Hartman @ 2019-11-12 5:40 UTC (permalink / raw) To: Andreas Färber Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Martin Blumenstingl, Neil Armstrong, Kevin Hilman On Mon, Nov 11, 2019 at 11:15:21PM +0100, Andreas Färber wrote: > The helper soc_device_to_device() is considered deprecated. > For a driver __init function the predictable prefix text > "soc soc0:" from dev_info() does not add real value, so use > pr_info() to emit the info text without such prefix. > > While at it, normalize the casing of "detected" for GX. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- > drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c > index 01fc0d20a70d..105b819bbd5f 100644 > --- a/drivers/soc/amlogic/meson-gx-socinfo.c > +++ b/drivers/soc/amlogic/meson-gx-socinfo.c > @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) > struct device_node *np; > struct regmap *regmap; > unsigned int socinfo; > - struct device *dev; > int ret; > > /* look up for chipid node */ > @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) > kfree(soc_dev_attr); > return PTR_ERR(soc_dev); > } > - dev = soc_device_to_device(soc_dev); > > - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", > + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", This should message should just be removed entirely. > soc_dev_attr->soc_id, > socinfo_to_major(socinfo), > socinfo_to_minor(socinfo), > diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c > index 78f0f1aeca57..7db2c94a7130 100644 > --- a/drivers/soc/amlogic/meson-mx-socinfo.c > +++ b/drivers/soc/amlogic/meson-mx-socinfo.c > @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) > return PTR_ERR(soc_dev); > } > > - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", > - soc_dev_attr->soc_id, soc_dev_attr->revision); > + pr_info("Amlogic %s %s detected\n", > + soc_dev_attr->soc_id, soc_dev_attr->revision); Same here, no need to polute the kernel log for when all is going just fine. That's why we created "common" driver init helpers, to prevent the ability for this type of noise from even being able to be created at all. thanks, greg k-h ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() @ 2019-11-12 5:40 ` Greg Kroah-Hartman 0 siblings, 0 replies; 12+ messages in thread From: Greg Kroah-Hartman @ 2019-11-12 5:40 UTC (permalink / raw) To: Andreas Färber Cc: Neil Armstrong, Martin Blumenstingl, Kevin Hilman, linux-kernel, linux-amlogic, linux-arm-kernel On Mon, Nov 11, 2019 at 11:15:21PM +0100, Andreas Färber wrote: > The helper soc_device_to_device() is considered deprecated. > For a driver __init function the predictable prefix text > "soc soc0:" from dev_info() does not add real value, so use > pr_info() to emit the info text without such prefix. > > While at it, normalize the casing of "detected" for GX. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- > drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c > index 01fc0d20a70d..105b819bbd5f 100644 > --- a/drivers/soc/amlogic/meson-gx-socinfo.c > +++ b/drivers/soc/amlogic/meson-gx-socinfo.c > @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) > struct device_node *np; > struct regmap *regmap; > unsigned int socinfo; > - struct device *dev; > int ret; > > /* look up for chipid node */ > @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) > kfree(soc_dev_attr); > return PTR_ERR(soc_dev); > } > - dev = soc_device_to_device(soc_dev); > > - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", > + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", This should message should just be removed entirely. > soc_dev_attr->soc_id, > socinfo_to_major(socinfo), > socinfo_to_minor(socinfo), > diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c > index 78f0f1aeca57..7db2c94a7130 100644 > --- a/drivers/soc/amlogic/meson-mx-socinfo.c > +++ b/drivers/soc/amlogic/meson-mx-socinfo.c > @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) > return PTR_ERR(soc_dev); > } > > - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", > - soc_dev_attr->soc_id, soc_dev_attr->revision); > + pr_info("Amlogic %s %s detected\n", > + soc_dev_attr->soc_id, soc_dev_attr->revision); Same here, no need to polute the kernel log for when all is going just fine. That's why we created "common" driver init helpers, to prevent the ability for this type of noise from even being able to be created at all. thanks, greg k-h _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() @ 2019-11-12 5:40 ` Greg Kroah-Hartman 0 siblings, 0 replies; 12+ messages in thread From: Greg Kroah-Hartman @ 2019-11-12 5:40 UTC (permalink / raw) To: Andreas Färber Cc: Neil Armstrong, Martin Blumenstingl, Kevin Hilman, linux-kernel, linux-amlogic, linux-arm-kernel On Mon, Nov 11, 2019 at 11:15:21PM +0100, Andreas Färber wrote: > The helper soc_device_to_device() is considered deprecated. > For a driver __init function the predictable prefix text > "soc soc0:" from dev_info() does not add real value, so use > pr_info() to emit the info text without such prefix. > > While at it, normalize the casing of "detected" for GX. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- > drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c > index 01fc0d20a70d..105b819bbd5f 100644 > --- a/drivers/soc/amlogic/meson-gx-socinfo.c > +++ b/drivers/soc/amlogic/meson-gx-socinfo.c > @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) > struct device_node *np; > struct regmap *regmap; > unsigned int socinfo; > - struct device *dev; > int ret; > > /* look up for chipid node */ > @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) > kfree(soc_dev_attr); > return PTR_ERR(soc_dev); > } > - dev = soc_device_to_device(soc_dev); > > - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", > + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", This should message should just be removed entirely. > soc_dev_attr->soc_id, > socinfo_to_major(socinfo), > socinfo_to_minor(socinfo), > diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c > index 78f0f1aeca57..7db2c94a7130 100644 > --- a/drivers/soc/amlogic/meson-mx-socinfo.c > +++ b/drivers/soc/amlogic/meson-mx-socinfo.c > @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) > return PTR_ERR(soc_dev); > } > > - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", > - soc_dev_attr->soc_id, soc_dev_attr->revision); > + pr_info("Amlogic %s %s detected\n", > + soc_dev_attr->soc_id, soc_dev_attr->revision); Same here, no need to polute the kernel log for when all is going just fine. That's why we created "common" driver init helpers, to prevent the ability for this type of noise from even being able to be created at all. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() 2019-11-12 5:40 ` Greg Kroah-Hartman (?) @ 2019-11-12 8:11 ` Andreas Färber -1 siblings, 0 replies; 12+ messages in thread From: Andreas Färber @ 2019-11-12 8:11 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Martin Blumenstingl, Neil Armstrong, Kevin Hilman Am 12.11.19 um 06:40 schrieb Greg Kroah-Hartman: > On Mon, Nov 11, 2019 at 11:15:21PM +0100, Andreas Färber wrote: >> The helper soc_device_to_device() is considered deprecated. >> For a driver __init function the predictable prefix text >> "soc soc0:" from dev_info() does not add real value, so use >> pr_info() to emit the info text without such prefix. >> >> While at it, normalize the casing of "detected" for GX. >> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >> Cc: Neil Armstrong <narmstrong@baylibre.com> >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- >> drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- >> drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- >> 2 files changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c >> index 01fc0d20a70d..105b819bbd5f 100644 >> --- a/drivers/soc/amlogic/meson-gx-socinfo.c >> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c >> @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) >> struct device_node *np; >> struct regmap *regmap; >> unsigned int socinfo; >> - struct device *dev; >> int ret; >> >> /* look up for chipid node */ >> @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) >> kfree(soc_dev_attr); >> return PTR_ERR(soc_dev); >> } >> - dev = soc_device_to_device(soc_dev); >> >> - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", >> + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", > > This should message should just be removed entirely. > >> soc_dev_attr->soc_id, >> socinfo_to_major(socinfo), >> socinfo_to_minor(socinfo), >> diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c >> index 78f0f1aeca57..7db2c94a7130 100644 >> --- a/drivers/soc/amlogic/meson-mx-socinfo.c >> +++ b/drivers/soc/amlogic/meson-mx-socinfo.c >> @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) >> return PTR_ERR(soc_dev); >> } >> >> - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", >> - soc_dev_attr->soc_id, soc_dev_attr->revision); >> + pr_info("Amlogic %s %s detected\n", >> + soc_dev_attr->soc_id, soc_dev_attr->revision); > > Same here, no need to polute the kernel log for when all is going just > fine. > > That's why we created "common" driver init helpers, to prevent the > ability for this type of noise from even being able to be created at > all. Let's have that discussion in the central thread please. Fact here is that Amlogic GX's kernel output (and this code getting mirrored into U-Boot) made me aware of this driver in the first place. Regards, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg) ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() @ 2019-11-12 8:11 ` Andreas Färber 0 siblings, 0 replies; 12+ messages in thread From: Andreas Färber @ 2019-11-12 8:11 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Neil Armstrong, Martin Blumenstingl, Kevin Hilman, linux-kernel, linux-amlogic, linux-arm-kernel Am 12.11.19 um 06:40 schrieb Greg Kroah-Hartman: > On Mon, Nov 11, 2019 at 11:15:21PM +0100, Andreas Färber wrote: >> The helper soc_device_to_device() is considered deprecated. >> For a driver __init function the predictable prefix text >> "soc soc0:" from dev_info() does not add real value, so use >> pr_info() to emit the info text without such prefix. >> >> While at it, normalize the casing of "detected" for GX. >> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >> Cc: Neil Armstrong <narmstrong@baylibre.com> >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- >> drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- >> drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- >> 2 files changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c >> index 01fc0d20a70d..105b819bbd5f 100644 >> --- a/drivers/soc/amlogic/meson-gx-socinfo.c >> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c >> @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) >> struct device_node *np; >> struct regmap *regmap; >> unsigned int socinfo; >> - struct device *dev; >> int ret; >> >> /* look up for chipid node */ >> @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) >> kfree(soc_dev_attr); >> return PTR_ERR(soc_dev); >> } >> - dev = soc_device_to_device(soc_dev); >> >> - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", >> + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", > > This should message should just be removed entirely. > >> soc_dev_attr->soc_id, >> socinfo_to_major(socinfo), >> socinfo_to_minor(socinfo), >> diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c >> index 78f0f1aeca57..7db2c94a7130 100644 >> --- a/drivers/soc/amlogic/meson-mx-socinfo.c >> +++ b/drivers/soc/amlogic/meson-mx-socinfo.c >> @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) >> return PTR_ERR(soc_dev); >> } >> >> - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", >> - soc_dev_attr->soc_id, soc_dev_attr->revision); >> + pr_info("Amlogic %s %s detected\n", >> + soc_dev_attr->soc_id, soc_dev_attr->revision); > > Same here, no need to polute the kernel log for when all is going just > fine. > > That's why we created "common" driver init helpers, to prevent the > ability for this type of noise from even being able to be created at > all. Let's have that discussion in the central thread please. Fact here is that Amlogic GX's kernel output (and this code getting mirrored into U-Boot) made me aware of this driver in the first place. Regards, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg) _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() @ 2019-11-12 8:11 ` Andreas Färber 0 siblings, 0 replies; 12+ messages in thread From: Andreas Färber @ 2019-11-12 8:11 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Neil Armstrong, Martin Blumenstingl, Kevin Hilman, linux-kernel, linux-amlogic, linux-arm-kernel Am 12.11.19 um 06:40 schrieb Greg Kroah-Hartman: > On Mon, Nov 11, 2019 at 11:15:21PM +0100, Andreas Färber wrote: >> The helper soc_device_to_device() is considered deprecated. >> For a driver __init function the predictable prefix text >> "soc soc0:" from dev_info() does not add real value, so use >> pr_info() to emit the info text without such prefix. >> >> While at it, normalize the casing of "detected" for GX. >> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >> Cc: Neil Armstrong <narmstrong@baylibre.com> >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- >> drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- >> drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- >> 2 files changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c >> index 01fc0d20a70d..105b819bbd5f 100644 >> --- a/drivers/soc/amlogic/meson-gx-socinfo.c >> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c >> @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) >> struct device_node *np; >> struct regmap *regmap; >> unsigned int socinfo; >> - struct device *dev; >> int ret; >> >> /* look up for chipid node */ >> @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) >> kfree(soc_dev_attr); >> return PTR_ERR(soc_dev); >> } >> - dev = soc_device_to_device(soc_dev); >> >> - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", >> + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", > > This should message should just be removed entirely. > >> soc_dev_attr->soc_id, >> socinfo_to_major(socinfo), >> socinfo_to_minor(socinfo), >> diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c >> index 78f0f1aeca57..7db2c94a7130 100644 >> --- a/drivers/soc/amlogic/meson-mx-socinfo.c >> +++ b/drivers/soc/amlogic/meson-mx-socinfo.c >> @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) >> return PTR_ERR(soc_dev); >> } >> >> - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", >> - soc_dev_attr->soc_id, soc_dev_attr->revision); >> + pr_info("Amlogic %s %s detected\n", >> + soc_dev_attr->soc_id, soc_dev_attr->revision); > > Same here, no need to polute the kernel log for when all is going just > fine. > > That's why we created "common" driver init helpers, to prevent the > ability for this type of noise from even being able to be created at > all. Let's have that discussion in the central thread please. Fact here is that Amlogic GX's kernel output (and this code getting mirrored into U-Boot) made me aware of this driver in the first place. Regards, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() 2019-11-12 8:11 ` Andreas Färber (?) @ 2019-11-12 9:06 ` Neil Armstrong -1 siblings, 0 replies; 12+ messages in thread From: Neil Armstrong @ 2019-11-12 9:06 UTC (permalink / raw) To: Andreas Färber, Greg Kroah-Hartman Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Martin Blumenstingl, Kevin Hilman On 12/11/2019 09:11, Andreas Färber wrote: > Am 12.11.19 um 06:40 schrieb Greg Kroah-Hartman: >> On Mon, Nov 11, 2019 at 11:15:21PM +0100, Andreas Färber wrote: >>> The helper soc_device_to_device() is considered deprecated. >>> For a driver __init function the predictable prefix text >>> "soc soc0:" from dev_info() does not add real value, so use >>> pr_info() to emit the info text without such prefix. >>> >>> While at it, normalize the casing of "detected" for GX. >>> >>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >>> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >>> Cc: Neil Armstrong <narmstrong@baylibre.com> >>> Signed-off-by: Andreas Färber <afaerber@suse.de> >>> --- >>> drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- >>> drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- >>> 2 files changed, 3 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c >>> index 01fc0d20a70d..105b819bbd5f 100644 >>> --- a/drivers/soc/amlogic/meson-gx-socinfo.c >>> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c >>> @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) >>> struct device_node *np; >>> struct regmap *regmap; >>> unsigned int socinfo; >>> - struct device *dev; >>> int ret; >>> >>> /* look up for chipid node */ >>> @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) >>> kfree(soc_dev_attr); >>> return PTR_ERR(soc_dev); >>> } >>> - dev = soc_device_to_device(soc_dev); >>> >>> - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", >>> + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", >> >> This should message should just be removed entirely. >> >>> soc_dev_attr->soc_id, >>> socinfo_to_major(socinfo), >>> socinfo_to_minor(socinfo), >>> diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c >>> index 78f0f1aeca57..7db2c94a7130 100644 >>> --- a/drivers/soc/amlogic/meson-mx-socinfo.c >>> +++ b/drivers/soc/amlogic/meson-mx-socinfo.c >>> @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) >>> return PTR_ERR(soc_dev); >>> } >>> >>> - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", >>> - soc_dev_attr->soc_id, soc_dev_attr->revision); >>> + pr_info("Amlogic %s %s detected\n", >>> + soc_dev_attr->soc_id, soc_dev_attr->revision); >> >> Same here, no need to polute the kernel log for when all is going just >> fine. >> >> That's why we created "common" driver init helpers, to prevent the >> ability for this type of noise from even being able to be created at >> all. > > Let's have that discussion in the central thread please. > > Fact here is that Amlogic GX's kernel output (and this code getting > mirrored into U-Boot) made me aware of this driver in the first place. As Uwe said in the common thread, this print doesn't polute the kernel log at all, it's pretty useful for CI, like kernelCI, to check the test coverage on SoCs revisions. Yes it's duplicated in U-boot, but a little fraction of the boards in kCi uses this U-Boot version, they often use the vendor bootloader. And BTW, by moving dev_info to pr_info actually changes the output format. Can you be more precise about why "soc_device_to_device()" is now suddently deprecated ? Neil > > Regards, > Andreas > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() @ 2019-11-12 9:06 ` Neil Armstrong 0 siblings, 0 replies; 12+ messages in thread From: Neil Armstrong @ 2019-11-12 9:06 UTC (permalink / raw) To: Andreas Färber, Greg Kroah-Hartman Cc: Martin Blumenstingl, linux-amlogic, linux-kernel, linux-arm-kernel, Kevin Hilman On 12/11/2019 09:11, Andreas Färber wrote: > Am 12.11.19 um 06:40 schrieb Greg Kroah-Hartman: >> On Mon, Nov 11, 2019 at 11:15:21PM +0100, Andreas Färber wrote: >>> The helper soc_device_to_device() is considered deprecated. >>> For a driver __init function the predictable prefix text >>> "soc soc0:" from dev_info() does not add real value, so use >>> pr_info() to emit the info text without such prefix. >>> >>> While at it, normalize the casing of "detected" for GX. >>> >>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >>> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >>> Cc: Neil Armstrong <narmstrong@baylibre.com> >>> Signed-off-by: Andreas Färber <afaerber@suse.de> >>> --- >>> drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- >>> drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- >>> 2 files changed, 3 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c >>> index 01fc0d20a70d..105b819bbd5f 100644 >>> --- a/drivers/soc/amlogic/meson-gx-socinfo.c >>> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c >>> @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) >>> struct device_node *np; >>> struct regmap *regmap; >>> unsigned int socinfo; >>> - struct device *dev; >>> int ret; >>> >>> /* look up for chipid node */ >>> @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) >>> kfree(soc_dev_attr); >>> return PTR_ERR(soc_dev); >>> } >>> - dev = soc_device_to_device(soc_dev); >>> >>> - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", >>> + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", >> >> This should message should just be removed entirely. >> >>> soc_dev_attr->soc_id, >>> socinfo_to_major(socinfo), >>> socinfo_to_minor(socinfo), >>> diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c >>> index 78f0f1aeca57..7db2c94a7130 100644 >>> --- a/drivers/soc/amlogic/meson-mx-socinfo.c >>> +++ b/drivers/soc/amlogic/meson-mx-socinfo.c >>> @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) >>> return PTR_ERR(soc_dev); >>> } >>> >>> - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", >>> - soc_dev_attr->soc_id, soc_dev_attr->revision); >>> + pr_info("Amlogic %s %s detected\n", >>> + soc_dev_attr->soc_id, soc_dev_attr->revision); >> >> Same here, no need to polute the kernel log for when all is going just >> fine. >> >> That's why we created "common" driver init helpers, to prevent the >> ability for this type of noise from even being able to be created at >> all. > > Let's have that discussion in the central thread please. > > Fact here is that Amlogic GX's kernel output (and this code getting > mirrored into U-Boot) made me aware of this driver in the first place. As Uwe said in the common thread, this print doesn't polute the kernel log at all, it's pretty useful for CI, like kernelCI, to check the test coverage on SoCs revisions. Yes it's duplicated in U-boot, but a little fraction of the boards in kCi uses this U-Boot version, they often use the vendor bootloader. And BTW, by moving dev_info to pr_info actually changes the output format. Can you be more precise about why "soc_device_to_device()" is now suddently deprecated ? Neil > > Regards, > Andreas > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() @ 2019-11-12 9:06 ` Neil Armstrong 0 siblings, 0 replies; 12+ messages in thread From: Neil Armstrong @ 2019-11-12 9:06 UTC (permalink / raw) To: Andreas Färber, Greg Kroah-Hartman Cc: Martin Blumenstingl, linux-amlogic, linux-kernel, linux-arm-kernel, Kevin Hilman On 12/11/2019 09:11, Andreas Färber wrote: > Am 12.11.19 um 06:40 schrieb Greg Kroah-Hartman: >> On Mon, Nov 11, 2019 at 11:15:21PM +0100, Andreas Färber wrote: >>> The helper soc_device_to_device() is considered deprecated. >>> For a driver __init function the predictable prefix text >>> "soc soc0:" from dev_info() does not add real value, so use >>> pr_info() to emit the info text without such prefix. >>> >>> While at it, normalize the casing of "detected" for GX. >>> >>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >>> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >>> Cc: Neil Armstrong <narmstrong@baylibre.com> >>> Signed-off-by: Andreas Färber <afaerber@suse.de> >>> --- >>> drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- >>> drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- >>> 2 files changed, 3 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c >>> index 01fc0d20a70d..105b819bbd5f 100644 >>> --- a/drivers/soc/amlogic/meson-gx-socinfo.c >>> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c >>> @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) >>> struct device_node *np; >>> struct regmap *regmap; >>> unsigned int socinfo; >>> - struct device *dev; >>> int ret; >>> >>> /* look up for chipid node */ >>> @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) >>> kfree(soc_dev_attr); >>> return PTR_ERR(soc_dev); >>> } >>> - dev = soc_device_to_device(soc_dev); >>> >>> - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", >>> + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", >> >> This should message should just be removed entirely. >> >>> soc_dev_attr->soc_id, >>> socinfo_to_major(socinfo), >>> socinfo_to_minor(socinfo), >>> diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c >>> index 78f0f1aeca57..7db2c94a7130 100644 >>> --- a/drivers/soc/amlogic/meson-mx-socinfo.c >>> +++ b/drivers/soc/amlogic/meson-mx-socinfo.c >>> @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) >>> return PTR_ERR(soc_dev); >>> } >>> >>> - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", >>> - soc_dev_attr->soc_id, soc_dev_attr->revision); >>> + pr_info("Amlogic %s %s detected\n", >>> + soc_dev_attr->soc_id, soc_dev_attr->revision); >> >> Same here, no need to polute the kernel log for when all is going just >> fine. >> >> That's why we created "common" driver init helpers, to prevent the >> ability for this type of noise from even being able to be created at >> all. > > Let's have that discussion in the central thread please. > > Fact here is that Amlogic GX's kernel output (and this code getting > mirrored into U-Boot) made me aware of this driver in the first place. As Uwe said in the common thread, this print doesn't polute the kernel log at all, it's pretty useful for CI, like kernelCI, to check the test coverage on SoCs revisions. Yes it's duplicated in U-boot, but a little fraction of the boards in kCi uses this U-Boot version, they often use the vendor bootloader. And BTW, by moving dev_info to pr_info actually changes the output format. Can you be more precise about why "soc_device_to_device()" is now suddently deprecated ? Neil > > Regards, > Andreas > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-11-12 9:06 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-11 22:15 [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() Andreas Färber 2019-11-11 22:15 ` Andreas Färber 2019-11-11 22:15 ` Andreas Färber 2019-11-12 5:40 ` Greg Kroah-Hartman 2019-11-12 5:40 ` Greg Kroah-Hartman 2019-11-12 5:40 ` Greg Kroah-Hartman 2019-11-12 8:11 ` Andreas Färber 2019-11-12 8:11 ` Andreas Färber 2019-11-12 8:11 ` Andreas Färber 2019-11-12 9:06 ` Neil Armstrong 2019-11-12 9:06 ` Neil Armstrong 2019-11-12 9:06 ` Neil Armstrong
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.