* [drm-drm-misc:drm-misc-next 5/5] include/linux/kernel.h:994:32: error: dereferencing pointer to incomplete type 'struct drm_bridge'
@ 2019-11-11 15:53 kbuild test robot
2019-11-12 9:22 ` Maxime Ripard
0 siblings, 1 reply; 5+ messages in thread
From: kbuild test robot @ 2019-11-11 15:53 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 15457 bytes --]
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
head: 6aa192698089b450b06d609355fc9c82c07856d2
commit: 6aa192698089b450b06d609355fc9c82c07856d2 [5/5] drm/bridge: Add Analogix anx6345 support
config: i386-randconfig-h004-201945 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
git checkout 6aa192698089b450b06d609355fc9c82c07856d2
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:48:20: error: field 'bridge' has incomplete type
struct drm_bridge bridge;
^~~~~~
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:52:21: error: field 'link' has incomplete type
struct drm_dp_link link;
^~~~
In file included from include/linux/export.h:44:0,
from include/linux/linkage.h:7,
from include/linux/kernel.h:8,
from include/linux/delay.h:22,
from drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:9:
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c: In function 'bridge_to_anx6345':
>> include/linux/kernel.h:994:32: error: dereferencing pointer to incomplete type 'struct drm_bridge'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^~~~~~
include/linux/compiler.h:330:9: note: in definition of macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^~~~~~~~~~~~~~~~~~
include/linux/kernel.h:994:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^~~~~~~~~~~~~~~~
include/linux/kernel.h:994:20: note: in expansion of macro '__same_type'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^~~~~~~~~~~
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:76:9: note: in expansion of macro 'container_of'
return container_of(bridge, struct anx6345, bridge);
^~~~~~~~~~~~
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c: In function 'anx6345_dp_link_training':
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:148:8: error: implicit declaration of function 'drm_dp_link_probe'; did you mean 'drm_dp_dpcd_write'? [-Werror=implicit-function-declaration]
err = drm_dp_link_probe(&anx6345->aux, &anx6345->link);
^~~~~~~~~~~~~~~~~
drm_dp_dpcd_write
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:155:8: error: implicit declaration of function 'drm_dp_link_power_up'; did you mean 'drm_plane_cleanup'? [-Werror=implicit-function-declaration]
err = drm_dp_link_power_up(&anx6345->aux, &anx6345->link);
^~~~~~~~~~~~~~~~~~~~
drm_plane_cleanup
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:208:8: error: implicit declaration of function 'drm_dp_link_configure'; did you mean 'of_dma_configure'? [-Werror=implicit-function-declaration]
err = drm_dp_link_configure(&anx6345->aux, &anx6345->link);
^~~~~~~~~~~~~~~~~~~~~
of_dma_configure
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c: At top level:
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:604:21: error: variable 'anx6345_bridge_funcs' has initializer but incomplete type
static const struct drm_bridge_funcs anx6345_bridge_funcs = {
^~~~~~~~~~~~~~~~
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:605:3: error: 'const struct drm_bridge_funcs' has no member named 'attach'
.attach = anx6345_bridge_attach,
^~~~~~
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:605:12: warning: excess elements in struct initializer
.attach = anx6345_bridge_attach,
^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:605:12: note: (near initialization for 'anx6345_bridge_funcs')
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:606:3: error: 'const struct drm_bridge_funcs' has no member named 'mode_valid'
.mode_valid = anx6345_bridge_mode_valid,
^~~~~~~~~~
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:606:16: warning: excess elements in struct initializer
.mode_valid = anx6345_bridge_mode_valid,
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:606:16: note: (near initialization for 'anx6345_bridge_funcs')
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:607:3: error: 'const struct drm_bridge_funcs' has no member named 'disable'
.disable = anx6345_bridge_disable,
^~~~~~~
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:607:13: warning: excess elements in struct initializer
.disable = anx6345_bridge_disable,
^~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:607:13: note: (near initialization for 'anx6345_bridge_funcs')
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:608:3: error: 'const struct drm_bridge_funcs' has no member named 'enable'
.enable = anx6345_bridge_enable,
^~~~~~
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:608:12: warning: excess elements in struct initializer
.enable = anx6345_bridge_enable,
^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:608:12: note: (near initialization for 'anx6345_bridge_funcs')
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c: In function 'anx6345_i2c_probe':
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:740:3: error: implicit declaration of function 'drm_bridge_add'; did you mean 'drm_panel_add'? [-Werror=implicit-function-declaration]
drm_bridge_add(&anx6345->bridge);
^~~~~~~~~~~~~~
drm_panel_add
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c: In function 'anx6345_i2c_remove':
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:757:2: error: implicit declaration of function 'drm_bridge_remove'; did you mean 'drm_panel_remove'? [-Werror=implicit-function-declaration]
drm_bridge_remove(&anx6345->bridge);
^~~~~~~~~~~~~~~~~
drm_panel_remove
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c: At top level:
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:604:38: error: storage size of 'anx6345_bridge_funcs' isn't known
static const struct drm_bridge_funcs anx6345_bridge_funcs = {
^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:48:20: error: field 'bridge' has incomplete type
struct drm_bridge bridge;
^~~~~~
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:52:21: error: field 'link' has incomplete type
struct drm_dp_link link;
^~~~
In file included from include/linux/export.h:44:0,
from include/linux/linkage.h:7,
from include/linux/kernel.h:8,
from include/linux/delay.h:22,
from drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:9:
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c: In function 'bridge_to_anx6345':
>> include/linux/kernel.h:994:32: error: dereferencing pointer to incomplete type 'struct drm_bridge'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^~~~~~
include/linux/compiler.h:330:9: note: in definition of macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^~~~~~~~~~~~~~~~~~
include/linux/kernel.h:994:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^~~~~~~~~~~~~~~~
include/linux/kernel.h:994:20: note: in expansion of macro '__same_type'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^~~~~~~~~~~
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:76:9: note: in expansion of macro 'container_of'
return container_of(bridge, struct anx6345, bridge);
^~~~~~~~~~~~
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c: In function 'anx6345_dp_link_training':
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:148:8: error: implicit declaration of function 'drm_dp_link_probe'; did you mean 'drm_dp_dpcd_write'? [-Werror=implicit-function-declaration]
err = drm_dp_link_probe(&anx6345->aux, &anx6345->link);
^~~~~~~~~~~~~~~~~
drm_dp_dpcd_write
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:155:8: error: implicit declaration of function 'drm_dp_link_power_up'; did you mean 'drm_plane_cleanup'? [-Werror=implicit-function-declaration]
err = drm_dp_link_power_up(&anx6345->aux, &anx6345->link);
^~~~~~~~~~~~~~~~~~~~
drm_plane_cleanup
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:208:8: error: implicit declaration of function 'drm_dp_link_configure'; did you mean 'of_dma_configure'? [-Werror=implicit-function-declaration]
err = drm_dp_link_configure(&anx6345->aux, &anx6345->link);
^~~~~~~~~~~~~~~~~~~~~
of_dma_configure
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c: At top level:
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:604:21: error: variable 'anx6345_bridge_funcs' has initializer but incomplete type
static const struct drm_bridge_funcs anx6345_bridge_funcs = {
^~~~~~~~~~~~~~~~
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:605:3: error: 'const struct drm_bridge_funcs' has no member named 'attach'
.attach = anx6345_bridge_attach,
^~~~~~
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:605:12: warning: excess elements in struct initializer
.attach = anx6345_bridge_attach,
^~~~~~~~~~~~~~~~~~~~~
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:605:12: note: (near initialization for 'anx6345_bridge_funcs')
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:606:3: error: 'const struct drm_bridge_funcs' has no member named 'mode_valid'
.mode_valid = anx6345_bridge_mode_valid,
^~~~~~~~~~
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:606:16: warning: excess elements in struct initializer
.mode_valid = anx6345_bridge_mode_valid,
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:606:16: note: (near initialization for 'anx6345_bridge_funcs')
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:607:3: error: 'const struct drm_bridge_funcs' has no member named 'disable'
.disable = anx6345_bridge_disable,
^~~~~~~
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:607:13: warning: excess elements in struct initializer
.disable = anx6345_bridge_disable,
^~~~~~~~~~~~~~~~~~~~~~
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:607:13: note: (near initialization for 'anx6345_bridge_funcs')
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:608:3: error: 'const struct drm_bridge_funcs' has no member named 'enable'
.enable = anx6345_bridge_enable,
^~~~~~
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:608:12: warning: excess elements in struct initializer
.enable = anx6345_bridge_enable,
^~~~~~~~~~~~~~~~~~~~~
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:608:12: note: (near initialization for 'anx6345_bridge_funcs')
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c: In function 'anx6345_i2c_probe':
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:740:3: error: implicit declaration of function 'drm_bridge_add'; did you mean 'drm_panel_add'? [-Werror=implicit-function-declaration]
drm_bridge_add(&anx6345->bridge);
^~~~~~~~~~~~~~
drm_panel_add
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c: In function 'anx6345_i2c_remove':
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:757:2: error: implicit declaration of function 'drm_bridge_remove'; did you mean 'drm_panel_remove'? [-Werror=implicit-function-declaration]
drm_bridge_remove(&anx6345->bridge);
^~~~~~~~~~~~~~~~~
drm_panel_remove
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c: At top level:
drivers/gpu//drm/bridge/analogix/analogix-anx6345.c:604:38: error: storage size of 'anx6345_bridge_funcs' isn't known
static const struct drm_bridge_funcs anx6345_bridge_funcs = {
^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +994 include/linux/kernel.h
cf14f27f82af78 Alexei Starovoitov 2018-03-28 984
^1da177e4c3f41 Linus Torvalds 2005-04-16 985 /**
^1da177e4c3f41 Linus Torvalds 2005-04-16 986 * container_of - cast a member of a structure out to the containing structure
^1da177e4c3f41 Linus Torvalds 2005-04-16 987 * @ptr: the pointer to the member.
^1da177e4c3f41 Linus Torvalds 2005-04-16 988 * @type: the type of the container struct this is embedded in.
^1da177e4c3f41 Linus Torvalds 2005-04-16 989 * @member: the name of the member within the struct.
^1da177e4c3f41 Linus Torvalds 2005-04-16 990 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 991 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 992 #define container_of(ptr, type, member) ({ \
c7acec713d14c6 Ian Abbott 2017-07-12 993 void *__mptr = (void *)(ptr); \
c7acec713d14c6 Ian Abbott 2017-07-12 @994 BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
c7acec713d14c6 Ian Abbott 2017-07-12 995 !__same_type(*(ptr), void), \
c7acec713d14c6 Ian Abbott 2017-07-12 996 "pointer type mismatch in container_of()"); \
c7acec713d14c6 Ian Abbott 2017-07-12 997 ((type *)(__mptr - offsetof(type, member))); })
^1da177e4c3f41 Linus Torvalds 2005-04-16 998
:::::: The code at line 994 was first introduced by commit
:::::: c7acec713d14c6ce8a20154f9dfda258d6bcad3b kernel.h: handle pointers to arrays better in container_of()
:::::: TO: Ian Abbott <abbotti@mev.co.uk>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28420 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [drm-drm-misc:drm-misc-next 5/5] include/linux/kernel.h:994:32: error: dereferencing pointer to incomplete type 'struct drm_bridge'
2019-11-11 15:53 [drm-drm-misc:drm-misc-next 5/5] include/linux/kernel.h:994:32: error: dereferencing pointer to incomplete type 'struct drm_bridge' kbuild test robot
@ 2019-11-12 9:22 ` Maxime Ripard
2019-11-12 12:10 ` Torsten Duwe
0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2019-11-12 9:22 UTC (permalink / raw)
To: Torsten Duwe
Cc: kbuild-all, kbuild test robot, dri-devel, Vasily Khoruzhick,
Sean Paul, Icenowy Zheng
[-- Attachment #1.1: Type: text/plain, Size: 1353 bytes --]
Hi Thorsten,
On Mon, Nov 11, 2019 at 11:53:20PM +0800, kbuild test robot wrote:
> tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
> head: 6aa192698089b450b06d609355fc9c82c07856d2
> commit: 6aa192698089b450b06d609355fc9c82c07856d2 [5/5] drm/bridge: Add Analogix anx6345 support
> config: i386-randconfig-h004-201945 (attached as .config)
> compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
> reproduce:
> git checkout 6aa192698089b450b06d609355fc9c82c07856d2
> # save the attached .config to linux build tree
> make ARCH=i386
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:48:20: error: field 'bridge' has incomplete type
> struct drm_bridge bridge;
> ^~~~~~
> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:52:21: error: field 'link' has incomplete type
> struct drm_dp_link link;
> ^~~~
It looks like you didn't compile your driver after rebasing.
The first error here is pretty trivial (missing drm_bridge.h include),
but the second one is there becaus the DP link helpers you rely on
have been removed.
Can you send a patch to fix this? Otherwise, we can just revert the
offending patch.
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [drm-drm-misc:drm-misc-next 5/5] include/linux/kernel.h:994:32: error: dereferencing pointer to incomplete type 'struct drm_bridge'
2019-11-12 9:22 ` Maxime Ripard
@ 2019-11-12 12:10 ` Torsten Duwe
0 siblings, 0 replies; 5+ messages in thread
From: Torsten Duwe @ 2019-11-12 12:10 UTC (permalink / raw)
To: Maxime Ripard
Cc: kbuild-all, kbuild test robot, dri-devel, Vasily Khoruzhick,
Sean Paul, Icenowy Zheng
On Tue, Nov 12, 2019 at 10:22:39AM +0100, Maxime Ripard wrote:
> Hi Thorsten,
>
> On Mon, Nov 11, 2019 at 11:53:20PM +0800, kbuild test robot wrote:
> >
> > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:48:20: error: field 'bridge' has incomplete type
> > struct drm_bridge bridge;
> > ^~~~~~
> > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:52:21: error: field 'link' has incomplete type
> > struct drm_dp_link link;
> > ^~~~
>
> It looks like you didn't compile your driver after rebasing.
FWIW I compiled and ran the rebased series, based on 5.4-rc6 + 025910db8.
Who needs stable in-kernel interfaces anyway :-/
> The first error here is pretty trivial (missing drm_bridge.h include),
> but the second one is there becaus the DP link helpers you rely on
> have been removed.
>
> Can you send a patch to fix this? Otherwise, we can just revert the
> offending patch.
https://patchwork.freedesktop.org/series/68031/ passed me by unnoticed;
I wonder why I Cc'ed Thierry on every single patch? A simple heads-up would
have sufficed.
Now that I have that series, I'm confident I can update the anx6345 driver
accordingly.
Stay tuned...
Torsten
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [drm-drm-misc:drm-misc-next 5/5] include/linux/kernel.h:994:32: error: dereferencing pointer to incomplete type 'struct drm_bridge'
@ 2019-11-12 12:10 ` Torsten Duwe
0 siblings, 0 replies; 5+ messages in thread
From: Torsten Duwe @ 2019-11-12 12:10 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]
On Tue, Nov 12, 2019 at 10:22:39AM +0100, Maxime Ripard wrote:
> Hi Thorsten,
>
> On Mon, Nov 11, 2019 at 11:53:20PM +0800, kbuild test robot wrote:
> >
> > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:48:20: error: field 'bridge' has incomplete type
> > struct drm_bridge bridge;
> > ^~~~~~
> > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:52:21: error: field 'link' has incomplete type
> > struct drm_dp_link link;
> > ^~~~
>
> It looks like you didn't compile your driver after rebasing.
FWIW I compiled and ran the rebased series, based on 5.4-rc6 + 025910db8.
Who needs stable in-kernel interfaces anyway :-/
> The first error here is pretty trivial (missing drm_bridge.h include),
> but the second one is there becaus the DP link helpers you rely on
> have been removed.
>
> Can you send a patch to fix this? Otherwise, we can just revert the
> offending patch.
https://patchwork.freedesktop.org/series/68031/ passed me by unnoticed;
I wonder why I Cc'ed Thierry on every single patch? A simple heads-up would
have sufficed.
Now that I have that series, I'm confident I can update the anx6345 driver
accordingly.
Stay tuned...
Torsten
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [drm-drm-misc:drm-misc-next 5/5] include/linux/kernel.h:994:32: error: dereferencing pointer to incomplete type 'struct drm_bridge'
2019-11-12 12:10 ` Torsten Duwe
(?)
@ 2019-11-12 18:44 ` Maxime Ripard
-1 siblings, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2019-11-12 18:44 UTC (permalink / raw)
To: Torsten Duwe
Cc: kbuild-all, kbuild test robot, dri-devel, Vasily Khoruzhick,
Sean Paul, Icenowy Zheng
[-- Attachment #1.1: Type: text/plain, Size: 1438 bytes --]
On Tue, Nov 12, 2019 at 01:10:13PM +0100, Torsten Duwe wrote:
> On Tue, Nov 12, 2019 at 10:22:39AM +0100, Maxime Ripard wrote:
> > Hi Thorsten,
> >
> > On Mon, Nov 11, 2019 at 11:53:20PM +0800, kbuild test robot wrote:
> > >
> > > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:48:20: error: field 'bridge' has incomplete type
> > > struct drm_bridge bridge;
> > > ^~~~~~
> > > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c:52:21: error: field 'link' has incomplete type
> > > struct drm_dp_link link;
> > > ^~~~
> >
> > It looks like you didn't compile your driver after rebasing.
>
> FWIW I compiled and ran the rebased series, based on 5.4-rc6 + 025910db8.
> Who needs stable in-kernel interfaces anyway :-/
So that's what you did? Yet you were saying that this was tested on
top of drm-misc-next and linux-next...
> > The first error here is pretty trivial (missing drm_bridge.h include),
> > but the second one is there becaus the DP link helpers you rely on
> > have been removed.
> >
> > Can you send a patch to fix this? Otherwise, we can just revert the
> > offending patch.
>
> https://patchwork.freedesktop.org/series/68031/ passed me by unnoticed;
> I wonder why I Cc'ed Thierry on every single patch? A simple heads-up would
> have sufficed.
>
> Now that I have that series, I'm confident I can update the anx6345 driver
> accordingly.
Thanks
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-12 18:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 15:53 [drm-drm-misc:drm-misc-next 5/5] include/linux/kernel.h:994:32: error: dereferencing pointer to incomplete type 'struct drm_bridge' kbuild test robot
2019-11-12 9:22 ` Maxime Ripard
2019-11-12 12:10 ` Torsten Duwe
2019-11-12 12:10 ` Torsten Duwe
2019-11-12 18:44 ` Maxime Ripard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.