From: Jordan Crouse <jcrouse@codeaurora.org> To: Arnd Bergmann <arnd@arndb.de> Cc: y2038@lists.linaro.org, Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, linux-kernel@vger.kernel.org, Jeykumar Sankaran <jsanka@codeaurora.org>, Sam Ravnborg <sam@ravnborg.org>, Joe Perches <joe@perches.com>, Jonathan Marek <jonathan@marek.ca>, "Kristian H. Kristensen" <hoegsberg@gmail.com>, Thomas Gleixner <tglx@linutronix.de>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH 14/16] drm/msm: avoid using 'timespec' Date: Tue, 12 Nov 2019 09:55:48 -0700 [thread overview] Message-ID: <20191112165548.GB14014@jcrouse1-lnx.qualcomm.com> (raw) In-Reply-To: <20191108213257.3097633-15-arnd@arndb.de> On Fri, Nov 08, 2019 at 10:32:52PM +0100, Arnd Bergmann wrote: > The timespec structure and associated interfaces are deprecated and will > be removed in the future because of the y2038 overflow. > > The use of ktime_to_timespec() in timeout_to_jiffies() does not > suffer from that overflow, but is easy to avoid by just converting > the ktime_t into jiffies directly. This seems good to me. y2038 changes are the best changes. Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/gpu/drm/msm/msm_drv.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h > index 71547e756e29..740bf7c70d8f 100644 > --- a/drivers/gpu/drm/msm/msm_drv.h > +++ b/drivers/gpu/drm/msm/msm_drv.h > @@ -454,8 +454,7 @@ static inline unsigned long timeout_to_jiffies(const ktime_t *timeout) > remaining_jiffies = 0; > } else { > ktime_t rem = ktime_sub(*timeout, now); > - struct timespec ts = ktime_to_timespec(rem); > - remaining_jiffies = timespec_to_jiffies(&ts); > + remaining_jiffies = ktime_divns(rem, NSEC_PER_SEC / HZ); > } > > return remaining_jiffies; > -- > 2.20.0 > -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Jordan Crouse <jcrouse@codeaurora.org> To: Arnd Bergmann <arnd@arndb.de> Cc: freedreno@lists.freedesktop.org, Jonathan Marek <jonathan@marek.ca>, y2038@lists.linaro.org, Sam Ravnborg <sam@ravnborg.org>, "Kristian H. Kristensen" <hoegsberg@gmail.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, Joe Perches <joe@perches.com>, Sean Paul <sean@poorly.run>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH 14/16] drm/msm: avoid using 'timespec' Date: Tue, 12 Nov 2019 09:55:48 -0700 [thread overview] Message-ID: <20191112165548.GB14014@jcrouse1-lnx.qualcomm.com> (raw) Message-ID: <20191112165548.vJWUR_L-qlWdsjNEIQcIN2SM-7vmQgYgd9vC3u72AJY@z> (raw) In-Reply-To: <20191108213257.3097633-15-arnd@arndb.de> On Fri, Nov 08, 2019 at 10:32:52PM +0100, Arnd Bergmann wrote: > The timespec structure and associated interfaces are deprecated and will > be removed in the future because of the y2038 overflow. > > The use of ktime_to_timespec() in timeout_to_jiffies() does not > suffer from that overflow, but is easy to avoid by just converting > the ktime_t into jiffies directly. This seems good to me. y2038 changes are the best changes. Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/gpu/drm/msm/msm_drv.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h > index 71547e756e29..740bf7c70d8f 100644 > --- a/drivers/gpu/drm/msm/msm_drv.h > +++ b/drivers/gpu/drm/msm/msm_drv.h > @@ -454,8 +454,7 @@ static inline unsigned long timeout_to_jiffies(const ktime_t *timeout) > remaining_jiffies = 0; > } else { > ktime_t rem = ktime_sub(*timeout, now); > - struct timespec ts = ktime_to_timespec(rem); > - remaining_jiffies = timespec_to_jiffies(&ts); > + remaining_jiffies = ktime_divns(rem, NSEC_PER_SEC / HZ); > } > > return remaining_jiffies; > -- > 2.20.0 > -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-12 16:55 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-08 21:32 [PATCH 00/16] drivers: y2038 updates Arnd Bergmann 2019-11-08 21:32 ` [Cluster-devel] " Arnd Bergmann 2019-11-08 21:32 ` Arnd Bergmann 2019-11-08 21:32 ` Arnd Bergmann 2019-11-08 21:32 ` Arnd Bergmann 2019-11-08 21:32 ` Arnd Bergmann 2019-11-08 21:32 ` [PATCH 01/16] staging: exfat: use prandom_u32() for i_generation Arnd Bergmann 2019-11-08 21:32 ` Arnd Bergmann 2019-11-08 21:53 ` Valdis Klētnieks 2019-11-08 21:53 ` Valdis Klētnieks 2019-11-08 21:32 ` [PATCH 02/16] fat: " Arnd Bergmann 2019-11-08 21:32 ` [PATCH 03/16] net: sock: use __kernel_old_timespec instead of timespec Arnd Bergmann 2019-11-09 19:09 ` Deepa Dinamani 2019-11-10 0:46 ` kbuild test robot 2019-11-08 21:32 ` [PATCH 04/16] dlm: use SO_SNDTIMEO_NEW instead of SO_SNDTIMEO_OLD Arnd Bergmann 2019-11-08 21:32 ` [Cluster-devel] " Arnd Bergmann 2019-11-09 19:14 ` Deepa Dinamani 2019-11-08 21:32 ` [PATCH 05/16] xtensa: ISS: avoid struct timeval Arnd Bergmann 2019-11-08 21:38 ` Max Filippov 2019-11-08 21:32 ` [PATCH 06/16] um: ubd: use 64-bit time_t where possible Arnd Bergmann 2019-11-08 21:32 ` Arnd Bergmann 2019-11-08 21:32 ` [PATCH 07/16] acct: stop using get_seconds() Arnd Bergmann 2019-11-08 21:32 ` [PATCH 08/16] tsacct: add 64-bit btime field Arnd Bergmann 2019-11-08 21:32 ` [PATCH 09/16] netfilter: nft_meta: use 64-bit time arithmetic Arnd Bergmann 2019-11-09 11:20 ` Phil Sutter 2019-11-15 22:44 ` Pablo Neira Ayuso 2019-11-08 21:32 ` [PATCH 10/16] packet: clarify timestamp overflow Arnd Bergmann 2019-11-08 21:32 ` [PATCH 11/16] quota: avoid time_t in v1_disk_dqblk definition Arnd Bergmann 2019-11-08 21:32 ` [PATCH 12/16] hostfs: pass 64-bit timestamps to/from user space Arnd Bergmann 2019-11-08 21:32 ` Arnd Bergmann 2019-11-20 20:30 ` [Y2038] " Ben Hutchings 2019-11-20 20:30 ` Ben Hutchings 2019-11-20 20:35 ` Ben Hutchings 2019-11-20 20:35 ` Ben Hutchings 2019-11-08 21:32 ` [PATCH 13/16] hfs/hfsplus: use 64-bit inode timestamps Arnd Bergmann 2019-11-13 3:53 ` Ernesto A. Fernández 2019-11-13 5:59 ` Viacheslav Dubeyko 2019-11-13 8:06 ` [Y2038] " Arnd Bergmann 2019-11-13 17:03 ` Viacheslav Dubeyko 2019-11-08 21:32 ` [PATCH 14/16] drm/msm: avoid using 'timespec' Arnd Bergmann 2019-11-08 21:32 ` Arnd Bergmann 2019-11-12 16:55 ` Jordan Crouse [this message] 2019-11-12 16:55 ` Jordan Crouse 2019-11-08 21:32 ` [PATCH 15/16] drm/etnaviv: use ktime_t for timeouts Arnd Bergmann 2019-11-08 21:32 ` Arnd Bergmann 2019-11-08 23:03 ` Lucas Stach 2019-11-08 23:03 ` Lucas Stach 2019-11-09 12:12 ` Arnd Bergmann 2019-11-09 12:12 ` Arnd Bergmann 2019-11-11 9:55 ` Lucas Stach 2019-11-11 9:55 ` Lucas Stach 2019-11-11 16:24 ` Arnd Bergmann 2019-11-11 16:24 ` Arnd Bergmann 2019-11-08 21:32 ` [PATCH 16/16] firewire: ohci: stop using get_seconds() for BUS_TIME Arnd Bergmann 2019-11-13 20:04 ` Stefan Richter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191112165548.GB14014@jcrouse1-lnx.qualcomm.com \ --to=jcrouse@codeaurora.org \ --cc=airlied@linux.ie \ --cc=arnd@arndb.de \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=hoegsberg@gmail.com \ --cc=joe@perches.com \ --cc=jonathan@marek.ca \ --cc=jsanka@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robdclark@gmail.com \ --cc=sam@ravnborg.org \ --cc=sean@poorly.run \ --cc=tglx@linutronix.de \ --cc=y2038@lists.linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.