All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Beckett <bob.beckett@collabora.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND PATCH 04/10] board: ge: bx50v3: Fix run-time warning
Date: Tue, 12 Nov 2019 19:15:14 +0000	[thread overview]
Message-ID: <20191112191521.11541-5-bob.beckett@collabora.com> (raw)
In-Reply-To: <20191112191521.11541-4-bob.beckett@collabora.com>

From: Ian Ray <ian.ray@ge.com>

Fix GPIO reservation warning on code paths that do not need LVDS power.

Signed-off-by: Ian Ray <ian.ray@ge.com>
Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
---

 board/ge/bx50v3/bx50v3.c | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c
index 530b106ba5..747171bf19 100644
--- a/board/ge/bx50v3/bx50v3.c
+++ b/board/ge/bx50v3/bx50v3.c
@@ -713,20 +713,23 @@ int ft_board_setup(void *blob, bd_t *bd)
 static int do_backlight_enable(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
 #ifdef CONFIG_VIDEO_IPUV3
-	/* We need at least 200ms between power on and backlight on
-	 * as per specifications from CHI MEI */
-	mdelay(250);
+	if (!is_b850v3()) {
+		/* We need at least 200ms between power on and backlight on
+		 * as per specifications from CHI MEI
+		 */
+		mdelay(250);
 
-	/* enable backlight PWM 1 */
-	pwm_init(0, 0, 0);
+		/* enable backlight PWM 1 */
+		pwm_init(0, 0, 0);
 
-	/* duty cycle 5000000ns, period: 5000000ns */
-	pwm_config(0, 5000000, 5000000);
+		/* duty cycle 5000000ns, period: 5000000ns */
+		pwm_config(0, 5000000, 5000000);
 
-	/* Backlight Power */
-	gpio_direction_output(LVDS_BACKLIGHT_GP, 1);
+		/* Backlight Power */
+		gpio_direction_output(LVDS_BACKLIGHT_GP, 1);
 
-	pwm_enable(0);
+		pwm_enable(0);
+	}
 #endif
 
 	return 0;
-- 
2.20.1

  reply	other threads:[~2019-11-12 19:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 19:15 [U-Boot] [RESEND PATCH 00/10] GE boards initial DM conversion Robert Beckett
2019-11-12 19:15 ` [U-Boot] [RESEND PATCH 01/10] board: ge: bx50v3: sync devicetrees from Linux Robert Beckett
2019-11-12 19:15   ` [U-Boot] [RESEND PATCH 02/10] board: ge: ppd: sync device tree " Robert Beckett
2019-11-12 19:15     ` [U-Boot] [RESEND PATCH 03/10] configs: bx50v3: Fix boot hang with video Robert Beckett
2019-11-12 19:15       ` Robert Beckett [this message]
2019-11-12 19:15         ` [U-Boot] [RESEND PATCH 05/10] board: ge: bx50v3: Fix message output to video console Robert Beckett
2019-11-12 19:15           ` [U-Boot] [RESEND PATCH 06/10] configs: ppd: DM for USB and regulators PPD Robert Beckett
2019-11-12 19:15             ` [U-Boot] [RESEND PATCH 07/10] board: ge: bx50v3: Enable DM for PCI and ethernet Robert Beckett
2019-11-12 19:15               ` [U-Boot] [RESEND PATCH 08/10] board: ge: pass rtc_status via device tree Robert Beckett
2019-11-12 19:15                 ` [U-Boot] [RESEND PATCH 09/10] board: ge: bx50v3: use imx wdt Robert Beckett
2019-11-12 19:15                   ` [U-Boot] [RESEND PATCH 10/10] board: ge: mx53ppd: " Robert Beckett
2019-12-27 16:41                     ` [U-Boot][RESEND " Simon Glass
2019-12-29 10:24                     ` [U-Boot] [RESEND " sbabic at denx.de
2019-12-29 10:28                   ` [U-Boot] [RESEND PATCH 09/10] board: ge: bx50v3: " sbabic at denx.de
2019-12-27 16:41                 ` [U-Boot][RESEND PATCH 08/10] board: ge: pass rtc_status via device tree Simon Glass
2019-12-29 10:28                 ` [U-Boot] [RESEND " sbabic at denx.de
2019-12-29 10:26               ` [U-Boot] [RESEND PATCH 07/10] board: ge: bx50v3: Enable DM for PCI and ethernet sbabic at denx.de
2019-12-29 10:27             ` [U-Boot] [RESEND PATCH 06/10] configs: ppd: DM for USB and regulators PPD sbabic at denx.de
2019-12-29 10:24           ` [U-Boot] [RESEND PATCH 05/10] board: ge: bx50v3: Fix message output to video console sbabic at denx.de
2019-12-29 10:26         ` [U-Boot] [RESEND PATCH 04/10] board: ge: bx50v3: Fix run-time warning sbabic at denx.de
2019-12-29 10:27       ` [U-Boot] [RESEND PATCH 03/10] configs: bx50v3: Fix boot hang with video sbabic at denx.de
2019-12-29 10:27     ` [U-Boot] [RESEND PATCH 02/10] board: ge: ppd: sync device tree from Linux sbabic at denx.de
2019-12-27 13:53   ` [U-Boot][RESEND PATCH 01/10] board: ge: bx50v3: sync devicetrees " Stefano Babic
2019-12-29 10:27   ` [U-Boot] [RESEND " sbabic at denx.de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191112191521.11541-5-bob.beckett@collabora.com \
    --to=bob.beckett@collabora.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.