* [PATCH] xfs: remove the unused m_chsize field
@ 2019-11-11 18:09 Christoph Hellwig
2019-11-12 1:38 ` Darrick J. Wong
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2019-11-11 18:09 UTC (permalink / raw)
To: linux-xfs
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_mount.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
index 2dceb446e651..43145a4ab690 100644
--- a/fs/xfs/xfs_mount.h
+++ b/fs/xfs/xfs_mount.h
@@ -155,7 +155,6 @@ typedef struct xfs_mount {
int m_swidth; /* stripe width */
uint8_t m_sectbb_log; /* sectlog - BBSHIFT */
const struct xfs_nameops *m_dirnameops; /* vector of dir name ops */
- uint m_chsize; /* size of next field */
atomic_t m_active_trans; /* number trans frozen */
struct xfs_mru_cache *m_filestream; /* per-mount filestream data */
struct delayed_work m_reclaim_work; /* background inode reclaim */
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: remove the unused m_chsize field
2019-11-11 18:09 [PATCH] xfs: remove the unused m_chsize field Christoph Hellwig
@ 2019-11-12 1:38 ` Darrick J. Wong
2019-11-12 21:26 ` Eric Sandeen
2019-11-12 23:09 ` Dave Chinner
0 siblings, 2 replies; 4+ messages in thread
From: Darrick J. Wong @ 2019-11-12 1:38 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-xfs
On Mon, Nov 11, 2019 at 07:09:57PM +0100, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Heh, what was that even used for?
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_mount.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index 2dceb446e651..43145a4ab690 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -155,7 +155,6 @@ typedef struct xfs_mount {
> int m_swidth; /* stripe width */
> uint8_t m_sectbb_log; /* sectlog - BBSHIFT */
> const struct xfs_nameops *m_dirnameops; /* vector of dir name ops */
> - uint m_chsize; /* size of next field */
> atomic_t m_active_trans; /* number trans frozen */
> struct xfs_mru_cache *m_filestream; /* per-mount filestream data */
> struct delayed_work m_reclaim_work; /* background inode reclaim */
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: remove the unused m_chsize field
2019-11-12 1:38 ` Darrick J. Wong
@ 2019-11-12 21:26 ` Eric Sandeen
2019-11-12 23:09 ` Dave Chinner
1 sibling, 0 replies; 4+ messages in thread
From: Eric Sandeen @ 2019-11-12 21:26 UTC (permalink / raw)
To: Darrick J. Wong, Christoph Hellwig; +Cc: linux-xfs
On 11/11/19 7:38 PM, Darrick J. Wong wrote:
> On Mon, Nov 11, 2019 at 07:09:57PM +0100, Christoph Hellwig wrote:
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Heh, what was that even used for?
>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks like it was there in the original CVS import,
and got removed in
commit da353b0d64e070ae7c5342a0d56ec20ae9ef5cfb
Author: David Chinner <dgc@sgi.com>
Date: Tue Aug 28 14:00:13 2007 +1000
[XFS] Radix tree based inode caching
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: remove the unused m_chsize field
2019-11-12 1:38 ` Darrick J. Wong
2019-11-12 21:26 ` Eric Sandeen
@ 2019-11-12 23:09 ` Dave Chinner
1 sibling, 0 replies; 4+ messages in thread
From: Dave Chinner @ 2019-11-12 23:09 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Christoph Hellwig, linux-xfs
On Mon, Nov 11, 2019 at 05:38:10PM -0800, Darrick J. Wong wrote:
> On Mon, Nov 11, 2019 at 07:09:57PM +0100, Christoph Hellwig wrote:
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Heh, what was that even used for?
> > - uint m_chsize; /* size of next field */
Inode cluster hash size.
We used to keep a linked list of all the inodes in a cluster in a
separate structure, so that we could easily iterate them when needed
(writeback/cluster freeing). They were kept in a separate hash table
so that they could be used as a quick reference inode cluster buffer
cache as well (IIRC it was to speed up things like xfs_imap_to_bp())
without having the overhead of a full buffer cache lookup...
The need for all this went away with the radix tree indexing and
gang lookups - I guess I missed removing this last fragment.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-12 23:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 18:09 [PATCH] xfs: remove the unused m_chsize field Christoph Hellwig
2019-11-12 1:38 ` Darrick J. Wong
2019-11-12 21:26 ` Eric Sandeen
2019-11-12 23:09 ` Dave Chinner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.