All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: keescook@chromium.org
Cc: yamada.masahiro@socionext.com, sparclinux@vger.kernel.org,
	matorola@gmail.com, gregkh@linuxfoundation.org,
	tglx@linutronix.de, linux-kernel@vger.kernel.org,
	ndesaulniers@google.com
Subject: Re: [PATCH] sparc: vdso: fix build error of vdso32
Date: Wed, 13 Nov 2019 16:21:57 -0800 (PST)	[thread overview]
Message-ID: <20191113.162157.111707512627631395.davem@davemloft.net> (raw)
In-Reply-To: <201911131558.6B0778229@keescook>

From: Kees Cook <keescook@chromium.org>
Date: Wed, 13 Nov 2019 15:59:27 -0800

> On Sun, Sep 22, 2019 at 08:34:36PM +0900, Masahiro Yamada wrote:
>> Since commit 54b8ae66ae1a ("kbuild: change *FLAGS_<basetarget>.o to
>> take the path relative to $(obj)"), sparc allmodconfig fails to build
>> as follows:
>> 
>>   CC      arch/sparc/vdso/vdso32/vclock_gettime.o
>> unrecognized e_machine 18 arch/sparc/vdso/vdso32/vclock_gettime.o
>> arch/sparc/vdso/vdso32/vclock_gettime.o: failed
>> 
>> The cause of the breakage is that -pg flag not being dropped.
>> 
>> The vdso32 files are located in the vdso32/ subdirectory, but I missed
>> to update the Makefile.
>> 
>> Fixes: 54b8ae66ae1a ("kbuild: change *FLAGS_<basetarget>.o to take the path relative to $(obj)")
>> Reported-by: Anatoly Pugachev <matorola@gmail.com>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> 
> I've tripped over this as well. Since no one has picked this up, can you
> take it via your tree Masahiro?

Yes, please do.  Sorry, I haven't had a lot of time for Sparc work lately.

Acked-by: David S. Miller <davem@davemloft.net>

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: keescook@chromium.org
Cc: yamada.masahiro@socionext.com, sparclinux@vger.kernel.org,
	matorola@gmail.com, gregkh@linuxfoundation.org,
	tglx@linutronix.de, linux-kernel@vger.kernel.org,
	ndesaulniers@google.com
Subject: Re: [PATCH] sparc: vdso: fix build error of vdso32
Date: Thu, 14 Nov 2019 00:21:57 +0000	[thread overview]
Message-ID: <20191113.162157.111707512627631395.davem@davemloft.net> (raw)
In-Reply-To: <201911131558.6B0778229@keescook>

From: Kees Cook <keescook@chromium.org>
Date: Wed, 13 Nov 2019 15:59:27 -0800

> On Sun, Sep 22, 2019 at 08:34:36PM +0900, Masahiro Yamada wrote:
>> Since commit 54b8ae66ae1a ("kbuild: change *FLAGS_<basetarget>.o to
>> take the path relative to $(obj)"), sparc allmodconfig fails to build
>> as follows:
>> 
>>   CC      arch/sparc/vdso/vdso32/vclock_gettime.o
>> unrecognized e_machine 18 arch/sparc/vdso/vdso32/vclock_gettime.o
>> arch/sparc/vdso/vdso32/vclock_gettime.o: failed
>> 
>> The cause of the breakage is that -pg flag not being dropped.
>> 
>> The vdso32 files are located in the vdso32/ subdirectory, but I missed
>> to update the Makefile.
>> 
>> Fixes: 54b8ae66ae1a ("kbuild: change *FLAGS_<basetarget>.o to take the path relative to $(obj)")
>> Reported-by: Anatoly Pugachev <matorola@gmail.com>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> 
> I've tripped over this as well. Since no one has picked this up, can you
> take it via your tree Masahiro?

Yes, please do.  Sorry, I haven't had a lot of time for Sparc work lately.

Acked-by: David S. Miller <davem@davemloft.net>

  reply	other threads:[~2019-11-14  0:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-22 11:34 [PATCH] sparc: vdso: fix build error of vdso32 Masahiro Yamada
2019-09-22 11:34 ` Masahiro Yamada
2019-09-27 15:46 ` Masahiro Yamada
2019-09-27 15:46   ` Masahiro Yamada
2019-10-18  8:27   ` Anatoly Pugachev
2019-10-18  8:27     ` Anatoly Pugachev
2019-11-13 23:59 ` Kees Cook
2019-11-13 23:59   ` Kees Cook
2019-11-14  0:21   ` David Miller [this message]
2019-11-14  0:21     ` David Miller
2019-11-14 15:08     ` Masahiro Yamada
2019-11-14 15:08       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113.162157.111707512627631395.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matorola@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.