From: Rob Herring <robh@kernel.org> To: Kamel Bouhara <kamel.bouhara@bootlin.com> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com> Subject: Re: [PATCH v3 1/2] dt-bindings: arm: at91: Document Kizboxmini and Smartkiz boards binding Date: Tue, 12 Nov 2019 21:50:22 -0600 [thread overview] Message-ID: <20191113035022.GA27823@bogus> (raw) In-Reply-To: <20191106083643.1995-1-kamel.bouhara@bootlin.com> On Wed, Nov 06, 2019 at 09:36:42AM +0100, Kamel Bouhara wrote: > Document devicetree's bindings for the Overkiz's Kizbox Mini and > Smartkiz boards, based on a SAM9G25 Atmel SoC. > > Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com> > --- > Changes in v2 > ============= > - Added Kizboxmini Base board documentation > - Merged Smartkiz documentation as it is also a sam9g25 based > board > > Changes in v3 > ============= > - Made a single items list with all the sam9g25 based boards and > put description into a comment. > - Fixed duplicated item in enum list and checked with 'make > dt_binding_check' Are you sure? > --- > Documentation/devicetree/bindings/arm/atmel-at91.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > index 6dd8be401673..e4140e94864d 100644 > --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > @@ -35,6 +35,16 @@ properties: > - atmel,at91sam9x60 > - const: atmel,at91sam9 > > + items: You are missing a '-' here, giving this: Traceback (most recent call last): File "/usr/local/bin/dt-mk-schema", line 32, in <module> schemas = dtschema.process_schemas(args.schemas, core_schema=(not args.useronly)) File "/usr/local/lib/python3.6/dist-packages/dtschema/lib.py", line 475, in process_schemas sch = process_schema(os.path.abspath(filename)) File "/usr/local/lib/python3.6/dist-packages/dtschema/lib.py", line 427, in process_schema schema = load_schema(filename) File "/usr/local/lib/python3.6/dist-packages/dtschema/lib.py", line 103, in load_schema return yaml.load(f.read()) File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/main.py", line 341, in load return constructor.get_single_data() File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 113, in get_single_data return self.construct_document(node) File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 123, in construct_document for _dummy in generator: File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 723, in construct_yaml_map value = self.construct_mapping(node) File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 440, in construct_mapping return BaseConstructor.construct_mapping(self, node, deep=deep) File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 257, in construct_mapping if self.check_mapping_key(node, key_node, mapping, key, value): File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 295, in check_mapping_key raise DuplicateKeyError(*args) ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping in "<unicode string>", line 23, column 9 found duplicate key "items" with value "[]" (original value: "[]") in "<unicode string>", line 38, column 9 To suppress this check see: http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys Duplicate keys will become an error in future releases, and are errors by default when using the new API. Documentation/devicetree/bindings/Makefile:33: recipe for target 'Documentation/devicetree/bindings/processed-schema.yaml' failed > + - enum: > + - overkiz,kizboxmini-base # Overkiz kizbox Mini Base Board > + - overkiz,kizboxmini-mb # Overkiz kizbox Mini Mother Board > + - overkiz,kizboxmini-rd # Overkiz kizbox Mini RailDIN > + - overkiz,smartkiz # Overkiz SmartKiz Board > + - const: atmel,at91sam9g25 > + - const: atmel,at91sam9x5 > + - const: atmel,at91sam9 > + > - items: > - enum: > - atmel,at91sam9g15 > -- > 2.24.0.rc1 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Kamel Bouhara <kamel.bouhara@bootlin.com> Cc: devicetree@vger.kernel.org, Alexandre Belloni <alexandre.belloni@bootlin.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/2] dt-bindings: arm: at91: Document Kizboxmini and Smartkiz boards binding Date: Tue, 12 Nov 2019 21:50:22 -0600 [thread overview] Message-ID: <20191113035022.GA27823@bogus> (raw) In-Reply-To: <20191106083643.1995-1-kamel.bouhara@bootlin.com> On Wed, Nov 06, 2019 at 09:36:42AM +0100, Kamel Bouhara wrote: > Document devicetree's bindings for the Overkiz's Kizbox Mini and > Smartkiz boards, based on a SAM9G25 Atmel SoC. > > Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com> > --- > Changes in v2 > ============= > - Added Kizboxmini Base board documentation > - Merged Smartkiz documentation as it is also a sam9g25 based > board > > Changes in v3 > ============= > - Made a single items list with all the sam9g25 based boards and > put description into a comment. > - Fixed duplicated item in enum list and checked with 'make > dt_binding_check' Are you sure? > --- > Documentation/devicetree/bindings/arm/atmel-at91.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > index 6dd8be401673..e4140e94864d 100644 > --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > @@ -35,6 +35,16 @@ properties: > - atmel,at91sam9x60 > - const: atmel,at91sam9 > > + items: You are missing a '-' here, giving this: Traceback (most recent call last): File "/usr/local/bin/dt-mk-schema", line 32, in <module> schemas = dtschema.process_schemas(args.schemas, core_schema=(not args.useronly)) File "/usr/local/lib/python3.6/dist-packages/dtschema/lib.py", line 475, in process_schemas sch = process_schema(os.path.abspath(filename)) File "/usr/local/lib/python3.6/dist-packages/dtschema/lib.py", line 427, in process_schema schema = load_schema(filename) File "/usr/local/lib/python3.6/dist-packages/dtschema/lib.py", line 103, in load_schema return yaml.load(f.read()) File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/main.py", line 341, in load return constructor.get_single_data() File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 113, in get_single_data return self.construct_document(node) File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 123, in construct_document for _dummy in generator: File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 723, in construct_yaml_map value = self.construct_mapping(node) File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 440, in construct_mapping return BaseConstructor.construct_mapping(self, node, deep=deep) File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 257, in construct_mapping if self.check_mapping_key(node, key_node, mapping, key, value): File "/usr/local/lib/python3.6/dist-packages/ruamel/yaml/constructor.py", line 295, in check_mapping_key raise DuplicateKeyError(*args) ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping in "<unicode string>", line 23, column 9 found duplicate key "items" with value "[]" (original value: "[]") in "<unicode string>", line 38, column 9 To suppress this check see: http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys Duplicate keys will become an error in future releases, and are errors by default when using the new API. Documentation/devicetree/bindings/Makefile:33: recipe for target 'Documentation/devicetree/bindings/processed-schema.yaml' failed > + - enum: > + - overkiz,kizboxmini-base # Overkiz kizbox Mini Base Board > + - overkiz,kizboxmini-mb # Overkiz kizbox Mini Mother Board > + - overkiz,kizboxmini-rd # Overkiz kizbox Mini RailDIN > + - overkiz,smartkiz # Overkiz SmartKiz Board > + - const: atmel,at91sam9g25 > + - const: atmel,at91sam9x5 > + - const: atmel,at91sam9 > + > - items: > - enum: > - atmel,at91sam9g15 > -- > 2.24.0.rc1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-13 3:50 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-06 8:36 [PATCH v3 1/2] dt-bindings: arm: at91: Document Kizboxmini and Smartkiz boards binding Kamel Bouhara 2019-11-06 8:36 ` Kamel Bouhara 2019-11-06 8:36 ` [PATCH v3 2/2] ARM: dts: at91: add smartkiz support and a common kizboxmini dtsi file Kamel Bouhara 2019-11-06 8:36 ` Kamel Bouhara 2019-11-13 3:50 ` Rob Herring [this message] 2019-11-13 3:50 ` [PATCH v3 1/2] dt-bindings: arm: at91: Document Kizboxmini and Smartkiz boards binding Rob Herring 2019-11-13 10:10 ` Kamel Bouhara 2019-11-13 10:10 ` Kamel Bouhara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191113035022.GA27823@bogus \ --to=robh@kernel.org \ --cc=alexandre.belloni@bootlin.com \ --cc=devicetree@vger.kernel.org \ --cc=kamel.bouhara@bootlin.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=ludovic.desroches@microchip.com \ --cc=nicolas.ferre@microchip.com \ --cc=thomas.petazzoni@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.