* [PATCH] media: platform: mtk-mdp: add missed destroy_workqueue in remove
@ 2019-11-13 6:37 ` Chuhong Yuan
0 siblings, 0 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-11-13 6:37 UTC (permalink / raw)
Cc: Minghsiu Tsai, Houlong Wei, Andrew-CT Chen,
Mauro Carvalho Chehab, Matthias Brugger, linux-media,
linux-arm-kernel, linux-mediatek, linux-kernel, Chuhong Yuan
The driver misses destroying wdt_wq when remove like what is done when
probe fails.
Add the missed calls like what is done to job_wq to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
index c1e29a46ae69..aeaed2cf4458 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
@@ -229,6 +229,9 @@ static int mtk_mdp_remove(struct platform_device *pdev)
mtk_mdp_unregister_m2m_device(mdp);
v4l2_device_unregister(&mdp->v4l2_dev);
+ flush_workqueue(mdp->wdt_wq);
+ destroy_workqueue(mdp->wdt_wq);
+
flush_workqueue(mdp->job_wq);
destroy_workqueue(mdp->job_wq);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] media: platform: mtk-mdp: add missed destroy_workqueue in remove
@ 2019-11-13 6:37 ` Chuhong Yuan
0 siblings, 0 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-11-13 6:37 UTC (permalink / raw)
Cc: Andrew-CT Chen, Minghsiu Tsai, Chuhong Yuan, linux-kernel,
Houlong Wei, linux-mediatek, Matthias Brugger,
Mauro Carvalho Chehab, linux-arm-kernel, linux-media
The driver misses destroying wdt_wq when remove like what is done when
probe fails.
Add the missed calls like what is done to job_wq to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
index c1e29a46ae69..aeaed2cf4458 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
@@ -229,6 +229,9 @@ static int mtk_mdp_remove(struct platform_device *pdev)
mtk_mdp_unregister_m2m_device(mdp);
v4l2_device_unregister(&mdp->v4l2_dev);
+ flush_workqueue(mdp->wdt_wq);
+ destroy_workqueue(mdp->wdt_wq);
+
flush_workqueue(mdp->job_wq);
destroy_workqueue(mdp->job_wq);
--
2.23.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] media: platform: mtk-mdp: add missed destroy_workqueue in remove
@ 2019-11-13 6:37 ` Chuhong Yuan
0 siblings, 0 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-11-13 6:37 UTC (permalink / raw)
Cc: Andrew-CT Chen, Minghsiu Tsai, Chuhong Yuan, linux-kernel,
Houlong Wei, linux-mediatek, Matthias Brugger,
Mauro Carvalho Chehab, linux-arm-kernel, linux-media
The driver misses destroying wdt_wq when remove like what is done when
probe fails.
Add the missed calls like what is done to job_wq to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
index c1e29a46ae69..aeaed2cf4458 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
@@ -229,6 +229,9 @@ static int mtk_mdp_remove(struct platform_device *pdev)
mtk_mdp_unregister_m2m_device(mdp);
v4l2_device_unregister(&mdp->v4l2_dev);
+ flush_workqueue(mdp->wdt_wq);
+ destroy_workqueue(mdp->wdt_wq);
+
flush_workqueue(mdp->job_wq);
destroy_workqueue(mdp->job_wq);
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-13 6:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 6:37 [PATCH] media: platform: mtk-mdp: add missed destroy_workqueue in remove Chuhong Yuan
2019-11-13 6:37 ` Chuhong Yuan
2019-11-13 6:37 ` Chuhong Yuan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.