[PATCH] s390: vfio-ap: fix some comments

[PATCH] s390: vfio-ap: fix some comments

[Cornelia Huck]

The functions are called vfio_ap_irq_{en,dis}able.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---

Just some minor stuff I noted while grepping for something.

---
 drivers/s390/crypto/vfio_ap_ops.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
index 5c0f53c6dde7..f8f3f3a4e5fd 100644
--- a/drivers/s390/crypto/vfio_ap_ops.c
+++ b/drivers/s390/crypto/vfio_ap_ops.c
@@ -182,7 +182,7 @@ struct ap_queue_status vfio_ap_irq_disable(struct vfio_ap_queue *q)
 }
 
 /**
- * vfio_ap_setirq: Enable Interruption for a APQN
+ * vfio_ap_irq_enable: Enable Interruption for a APQN
  *
  * @dev: the device associated with the ap_queue
  * @q:	 the vfio_ap_queue holding AQIC parameters
@@ -265,7 +265,7 @@ static struct ap_queue_status vfio_ap_irq_enable(struct vfio_ap_queue *q,
  * - AP_RESPONSE_Q_NOT_AVAIL: if the queue is not available
  * - AP_RESPONSE_DECONFIGURED: if the queue is not configured
  * - AP_RESPONSE_NORMAL (0) : in case of successs
- *   Check vfio_ap_setirq() and vfio_ap_clrirq() for other possible RC.
+ *   Check vfio_ap_irq_enable() and vfio_ap_irq_disable() for other possible RC.
  * We take the matrix_dev lock to ensure serialization on queues and
  * mediated device access.
  *
-- 
2.21.0

Re: [PATCH] s390: vfio-ap: fix some comments

[Pierre Morel]

:) thanks,

Regards,

Pierre

Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>

On 2019-11-13 10:53, Cornelia Huck wrote:
> The functions are called vfio_ap_irq_{en,dis}able.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>
> Just some minor stuff I noted while grepping for something.
>
> ---
>   drivers/s390/crypto/vfio_ap_ops.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
> index 5c0f53c6dde7..f8f3f3a4e5fd 100644
> --- a/drivers/s390/crypto/vfio_ap_ops.c
> +++ b/drivers/s390/crypto/vfio_ap_ops.c
> @@ -182,7 +182,7 @@ struct ap_queue_status vfio_ap_irq_disable(struct vfio_ap_queue *q)
>   }
>   
>   /**
> - * vfio_ap_setirq: Enable Interruption for a APQN
> + * vfio_ap_irq_enable: Enable Interruption for a APQN
>    *
>    * @dev: the device associated with the ap_queue
>    * @q:	 the vfio_ap_queue holding AQIC parameters
> @@ -265,7 +265,7 @@ static struct ap_queue_status vfio_ap_irq_enable(struct vfio_ap_queue *q,
>    * - AP_RESPONSE_Q_NOT_AVAIL: if the queue is not available
>    * - AP_RESPONSE_DECONFIGURED: if the queue is not configured
>    * - AP_RESPONSE_NORMAL (0) : in case of successs
> - *   Check vfio_ap_setirq() and vfio_ap_clrirq() for other possible RC.
> + *   Check vfio_ap_irq_enable() and vfio_ap_irq_disable() for other possible RC.
>    * We take the matrix_dev lock to ensure serialization on queues and
>    * mediated device access.
>    *

-- 
Pierre Morel
IBM Lab Boeblingen

Re: [PATCH] s390: vfio-ap: fix some comments

[Halil Pasic]

On Wed, 13 Nov 2019 10:53:19 +0100
Cornelia Huck <cohuck@redhat.com> wrote:

> The functions are called vfio_ap_irq_{en,dis}able.
> 
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>

Reviewed-by: Halil Pasic <pasic@linux.ibm.com>

Re: [PATCH] s390: vfio-ap: fix some comments

[Tony Krowiak]

Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>

On 11/13/19 7:15 AM, Pierre Morel wrote:
> Check vfio_ap_setirq

Re: [PATCH] s390: vfio-ap: fix some comments

[Tony Krowiak]

Ignore this, I've been having problems with synchronization of my 
Thunderbird email client and the upstream mailing
list. I responded without looking at the date this was posted.

On 4/29/20 10:52 AM, Tony Krowiak wrote:
> Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
>
> On 11/13/19 7:15 AM, Pierre Morel wrote:
>> Check vfio_ap_setirq
>