All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: laurent.pinchart@ideasonboard.com,
	kieran.bingham+renesas@ideasonboard.com, geert@linux-m68k.org,
	horms@verge.net.au, uli+renesas@fpond.eu
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
	airlied@linux.ie, daniel@ffwll.ch,
	linux-renesas-soc@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v7 7/7] drm: rcar-du: kms: Expand comment in vsps parsing routine
Date: Wed, 13 Nov 2019 11:05:56 +0100	[thread overview]
Message-ID: <20191113100556.15616-8-jacopo+renesas@jmondi.org> (raw)
In-Reply-To: <20191113100556.15616-1-jacopo+renesas@jmondi.org>

Expand comment in the 'vsps' parsing routine to specify the LIF
channel index defaults to 0 in case the second cell of the property
is not specified to remain compatible with older DT bindings.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 drivers/gpu/drm/rcar-du/rcar_du_kms.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index 7c9fb5860e54..186422ac552b 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -587,7 +587,11 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu)
 
 		vsps[j].crtcs_mask |= BIT(i);
 
-		/* Store the VSP pointer and pipe index in the CRTC. */
+		/*
+		 * Store the VSP pointer and pipe index in the CRTC. If the
+		 * second cell of the 'vsps' specifier isn't present, default
+		 * to 0 to remain compatible with older DT bindings.
+		 */
 		rcdu->crtcs[i].vsp = &rcdu->vsps[j];
 		rcdu->crtcs[i].vsp_pipe = cells >= 1 ? args.args[0] : 0;
 	}
-- 
2.23.0


WARNING: multiple messages have this Message-ID (diff)
From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: laurent.pinchart@ideasonboard.com,
	kieran.bingham+renesas@ideasonboard.com, geert@linux-m68k.org,
	horms@verge.net.au, uli+renesas@fpond.eu
Cc: airlied@linux.ie, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	Jacopo Mondi <jacopo+renesas@jmondi.org>
Subject: [PATCH v7 7/7] drm: rcar-du: kms: Expand comment in vsps parsing routine
Date: Wed, 13 Nov 2019 11:05:56 +0100	[thread overview]
Message-ID: <20191113100556.15616-8-jacopo+renesas@jmondi.org> (raw)
Message-ID: <20191113100556.Qcf3HgVB_oajCAIYEsO-2x3Im-KaZGgu9XGUsVsDVOw@z> (raw)
In-Reply-To: <20191113100556.15616-1-jacopo+renesas@jmondi.org>

Expand comment in the 'vsps' parsing routine to specify the LIF
channel index defaults to 0 in case the second cell of the property
is not specified to remain compatible with older DT bindings.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 drivers/gpu/drm/rcar-du/rcar_du_kms.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index 7c9fb5860e54..186422ac552b 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -587,7 +587,11 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu)
 
 		vsps[j].crtcs_mask |= BIT(i);
 
-		/* Store the VSP pointer and pipe index in the CRTC. */
+		/*
+		 * Store the VSP pointer and pipe index in the CRTC. If the
+		 * second cell of the 'vsps' specifier isn't present, default
+		 * to 0 to remain compatible with older DT bindings.
+		 */
 		rcdu->crtcs[i].vsp = &rcdu->vsps[j];
 		rcdu->crtcs[i].vsp_pipe = cells >= 1 ? args.args[0] : 0;
 	}
-- 
2.23.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-11-13 10:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 10:05 [PATCH v7 0/7] drm: rcar-du: Add Color Management Module (CMM) Jacopo Mondi
2019-11-13 10:05 ` Jacopo Mondi
2019-11-13 10:05 ` [PATCH v7 1/7] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Jacopo Mondi
2019-11-13 10:05   ` [PATCH v7 1/7] dt-bindings: display: renesas, cmm: " Jacopo Mondi
2019-11-13 10:05 ` [PATCH v7 2/7] dt-bindings: display, renesas,du: Document cmms property Jacopo Mondi
2019-11-13 10:05   ` [PATCH v7 2/7] dt-bindings: display, renesas, du: " Jacopo Mondi
2019-11-13 13:34   ` [PATCH v7 2/7] dt-bindings: display, renesas,du: " Geert Uytterhoeven
2019-11-13 13:34     ` [PATCH v7 2/7] dt-bindings: display, renesas, du: " Geert Uytterhoeven
2019-11-28  1:50     ` [PATCH v7 2/7] dt-bindings: display, renesas,du: " Laurent Pinchart
2019-11-28  1:50       ` Laurent Pinchart
2019-11-13 10:05 ` [PATCH v7 3/7] drm: rcar-du: Add support for CMM Jacopo Mondi
2019-11-13 10:05   ` Jacopo Mondi
2019-11-28  1:52   ` Laurent Pinchart
2019-11-28  1:52     ` Laurent Pinchart
2019-11-28  7:56   ` Geert Uytterhoeven
2019-11-28  7:56     ` Geert Uytterhoeven
2019-11-28  8:09     ` Laurent Pinchart
2019-11-28  8:09       ` Laurent Pinchart
2019-11-28  8:24       ` Geert Uytterhoeven
2019-11-28  8:24         ` Geert Uytterhoeven
2019-11-13 10:05 ` [PATCH v7 4/7] drm: rcar-du: kms: Initialize CMM instances Jacopo Mondi
2019-11-13 10:05   ` Jacopo Mondi
2019-11-13 10:05 ` [PATCH v7 5/7] drm: rcar-du: crtc: Control CMM operations Jacopo Mondi
2019-11-13 10:05   ` Jacopo Mondi
2019-12-17 23:02   ` [PATCH v7.1 5.7] " Laurent Pinchart
2019-12-17 23:02     ` Laurent Pinchart
2019-11-13 10:05 ` [PATCH v7 6/7] drm: rcar-du: crtc: Register GAMMA_LUT properties Jacopo Mondi
2019-11-13 10:05   ` Jacopo Mondi
2019-11-13 10:05 ` Jacopo Mondi [this message]
2019-11-13 10:05   ` [PATCH v7 7/7] drm: rcar-du: kms: Expand comment in vsps parsing routine Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113100556.15616-8-jacopo+renesas@jmondi.org \
    --to=jacopo+renesas@jmondi.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=uli+renesas@fpond.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.