* [PATCH] net: ep93xx_eth: fix mismatch of request_mem_region in remove
@ 2019-11-14 15:43 Chuhong Yuan
2019-11-15 20:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-11-14 15:43 UTC (permalink / raw)
Cc: Hartley Sweeten, David S . Miller, netdev, linux-kernel, Chuhong Yuan
The driver calls release_resource in remove to match request_mem_region
in probe, which is incorrect.
Fix it by using the right one, release_mem_region.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/net/ethernet/cirrus/ep93xx_eth.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/cirrus/ep93xx_eth.c b/drivers/net/ethernet/cirrus/ep93xx_eth.c
index f1a0c4dceda0..f37c9a08c4cf 100644
--- a/drivers/net/ethernet/cirrus/ep93xx_eth.c
+++ b/drivers/net/ethernet/cirrus/ep93xx_eth.c
@@ -763,6 +763,7 @@ static int ep93xx_eth_remove(struct platform_device *pdev)
{
struct net_device *dev;
struct ep93xx_priv *ep;
+ struct resource *mem;
dev = platform_get_drvdata(pdev);
if (dev == NULL)
@@ -778,8 +779,8 @@ static int ep93xx_eth_remove(struct platform_device *pdev)
iounmap(ep->base_addr);
if (ep->res != NULL) {
- release_resource(ep->res);
- kfree(ep->res);
+ mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ release_mem_region(mem->start, resource_size(mem));
}
free_netdev(dev);
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ep93xx_eth: fix mismatch of request_mem_region in remove
2019-11-14 15:43 [PATCH] net: ep93xx_eth: fix mismatch of request_mem_region in remove Chuhong Yuan
@ 2019-11-15 20:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-15 20:42 UTC (permalink / raw)
To: hslester96; +Cc: hsweeten, netdev, linux-kernel
From: Chuhong Yuan <hslester96@gmail.com>
Date: Thu, 14 Nov 2019 23:43:24 +0800
> The driver calls release_resource in remove to match request_mem_region
> in probe, which is incorrect.
> Fix it by using the right one, release_mem_region.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Applied, thanks.
It's a shame that you can't just pass in the thing you got back from
request_mem_region() to free it. And honestly the only thing that makes
calling release_region() wrong is that release_region() doesn't free up
the region object after unlinking it from the tree.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-15 20:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 15:43 [PATCH] net: ep93xx_eth: fix mismatch of request_mem_region in remove Chuhong Yuan
2019-11-15 20:42 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.