All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/i915: move power domains dumped variable to drm_i915_private
@ 2019-11-15 10:18 ` Jani Nikula
  0 siblings, 0 replies; 20+ messages in thread
From: Jani Nikula @ 2019-11-15 10:18 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Get rid of the module specific static variable.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 10 +++-------
 drivers/gpu/drm/i915/display/intel_display_power.h |  1 +
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index ce1b64f4dd44..cbdf27705166 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -5277,13 +5277,9 @@ static void intel_power_domains_verify_state(struct drm_i915_private *i915)
 		}
 	}
 
-	if (dump_domain_info) {
-		static bool dumped;
-
-		if (!dumped) {
-			intel_power_domains_dump_info(i915);
-			dumped = true;
-		}
+	if (dump_domain_info && !power_domains->dumped) {
+		intel_power_domains_dump_info(i915);
+		power_domains->dumped = true;
 	}
 
 	mutex_unlock(&power_domains->lock);
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index 1da04f3e0fb3..8af46661a10b 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -205,6 +205,7 @@ struct i915_power_domains {
 	 */
 	bool initializing;
 	bool display_core_suspended;
+	bool dumped;
 	int power_well_count;
 
 	intel_wakeref_t wakeref;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 20+ messages in thread
* [Intel-gfx] [PATCH 1/2] drm/i915: move power domains dumped variable to drm_i915_private
@ 2019-11-15 10:18 ` Jani Nikula
  0 siblings, 0 replies; 20+ messages in thread
From: Jani Nikula @ 2019-11-15 10:18 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Get rid of the module specific static variable.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 10 +++-------
 drivers/gpu/drm/i915/display/intel_display_power.h |  1 +
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index ce1b64f4dd44..cbdf27705166 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -5277,13 +5277,9 @@ static void intel_power_domains_verify_state(struct drm_i915_private *i915)
 		}
 	}
 
-	if (dump_domain_info) {
-		static bool dumped;
-
-		if (!dumped) {
-			intel_power_domains_dump_info(i915);
-			dumped = true;
-		}
+	if (dump_domain_info && !power_domains->dumped) {
+		intel_power_domains_dump_info(i915);
+		power_domains->dumped = true;
 	}
 
 	mutex_unlock(&power_domains->lock);
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index 1da04f3e0fb3..8af46661a10b 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -205,6 +205,7 @@ struct i915_power_domains {
 	 */
 	bool initializing;
 	bool display_core_suspended;
+	bool dumped;
 	int power_well_count;
 
 	intel_wakeref_t wakeref;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 20+ messages in thread
* [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
@ 2019-11-15 10:18   ` Jani Nikula
  0 siblings, 0 replies; 20+ messages in thread
From: Jani Nikula @ 2019-11-15 10:18 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Get rid of the module specific static variable.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h   | 2 ++
 drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 1779f600fcfb..e11ee3268ae3 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1283,6 +1283,8 @@ struct drm_i915_private {
 	/* Mutex to protect the above hdcp component related values. */
 	struct mutex hdcp_comp_mutex;
 
+	bool shown_bug_once;
+
 	I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
 
 	/*
diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
index c47261ae86ea..f434274b0b29 100644
--- a/drivers/gpu/drm/i915/i915_utils.c
+++ b/drivers/gpu/drm/i915/i915_utils.c
@@ -13,11 +13,10 @@
 		    "providing the dmesg log by booting with drm.debug=0xf"
 
 void
-__i915_printk(struct drm_i915_private *dev_priv, const char *level,
+__i915_printk(struct drm_i915_private *i915, const char *level,
 	      const char *fmt, ...)
 {
-	static bool shown_bug_once;
-	struct device *kdev = dev_priv->drm.dev;
+	struct device *kdev = i915->drm.dev;
 	bool is_error = level[1] <= KERN_ERR[1];
 	bool is_debug = level[1] == KERN_DEBUG[1];
 	struct va_format vaf;
@@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
 
 	va_end(args);
 
-	if (is_error && !shown_bug_once) {
+	if (is_error && !i915->shown_bug_once) {
 		/*
 		 * Ask the user to file a bug report for the error, except
 		 * if they may have caused the bug by fiddling with unsafe
@@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
 		 */
 		if (!test_taint(TAINT_USER))
 			dev_notice(kdev, "%s", FDO_BUG_MSG);
-		shown_bug_once = true;
+		i915->shown_bug_once = true;
 	}
 }
 
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 20+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
@ 2019-11-15 10:18   ` Jani Nikula
  0 siblings, 0 replies; 20+ messages in thread
From: Jani Nikula @ 2019-11-15 10:18 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Get rid of the module specific static variable.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h   | 2 ++
 drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 1779f600fcfb..e11ee3268ae3 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1283,6 +1283,8 @@ struct drm_i915_private {
 	/* Mutex to protect the above hdcp component related values. */
 	struct mutex hdcp_comp_mutex;
 
+	bool shown_bug_once;
+
 	I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
 
 	/*
diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
index c47261ae86ea..f434274b0b29 100644
--- a/drivers/gpu/drm/i915/i915_utils.c
+++ b/drivers/gpu/drm/i915/i915_utils.c
@@ -13,11 +13,10 @@
 		    "providing the dmesg log by booting with drm.debug=0xf"
 
 void
-__i915_printk(struct drm_i915_private *dev_priv, const char *level,
+__i915_printk(struct drm_i915_private *i915, const char *level,
 	      const char *fmt, ...)
 {
-	static bool shown_bug_once;
-	struct device *kdev = dev_priv->drm.dev;
+	struct device *kdev = i915->drm.dev;
 	bool is_error = level[1] <= KERN_ERR[1];
 	bool is_debug = level[1] == KERN_DEBUG[1];
 	struct va_format vaf;
@@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
 
 	va_end(args);
 
-	if (is_error && !shown_bug_once) {
+	if (is_error && !i915->shown_bug_once) {
 		/*
 		 * Ask the user to file a bug report for the error, except
 		 * if they may have caused the bug by fiddling with unsafe
@@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
 		 */
 		if (!test_taint(TAINT_USER))
 			dev_notice(kdev, "%s", FDO_BUG_MSG);
-		shown_bug_once = true;
+		i915->shown_bug_once = true;
 	}
 }
 
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
@ 2019-11-15 10:20     ` Jani Nikula
  0 siblings, 0 replies; 20+ messages in thread
From: Jani Nikula @ 2019-11-15 10:20 UTC (permalink / raw)
  To: intel-gfx

On Fri, 15 Nov 2019, Jani Nikula <jani.nikula@intel.com> wrote:
> Get rid of the module specific static variable.

Subject should say s/make/move/.

>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h   | 2 ++
>  drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
>  2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 1779f600fcfb..e11ee3268ae3 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1283,6 +1283,8 @@ struct drm_i915_private {
>  	/* Mutex to protect the above hdcp component related values. */
>  	struct mutex hdcp_comp_mutex;
>  
> +	bool shown_bug_once;
> +
>  	I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
>  
>  	/*
> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> index c47261ae86ea..f434274b0b29 100644
> --- a/drivers/gpu/drm/i915/i915_utils.c
> +++ b/drivers/gpu/drm/i915/i915_utils.c
> @@ -13,11 +13,10 @@
>  		    "providing the dmesg log by booting with drm.debug=0xf"
>  
>  void
> -__i915_printk(struct drm_i915_private *dev_priv, const char *level,
> +__i915_printk(struct drm_i915_private *i915, const char *level,
>  	      const char *fmt, ...)
>  {
> -	static bool shown_bug_once;
> -	struct device *kdev = dev_priv->drm.dev;
> +	struct device *kdev = i915->drm.dev;
>  	bool is_error = level[1] <= KERN_ERR[1];
>  	bool is_debug = level[1] == KERN_DEBUG[1];
>  	struct va_format vaf;
> @@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>  
>  	va_end(args);
>  
> -	if (is_error && !shown_bug_once) {
> +	if (is_error && !i915->shown_bug_once) {
>  		/*
>  		 * Ask the user to file a bug report for the error, except
>  		 * if they may have caused the bug by fiddling with unsafe
> @@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>  		 */
>  		if (!test_taint(TAINT_USER))
>  			dev_notice(kdev, "%s", FDO_BUG_MSG);
> -		shown_bug_once = true;
> +		i915->shown_bug_once = true;
>  	}
>  }

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
@ 2019-11-15 10:20     ` Jani Nikula
  0 siblings, 0 replies; 20+ messages in thread
From: Jani Nikula @ 2019-11-15 10:20 UTC (permalink / raw)
  To: intel-gfx

On Fri, 15 Nov 2019, Jani Nikula <jani.nikula@intel.com> wrote:
> Get rid of the module specific static variable.

Subject should say s/make/move/.

>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h   | 2 ++
>  drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
>  2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 1779f600fcfb..e11ee3268ae3 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1283,6 +1283,8 @@ struct drm_i915_private {
>  	/* Mutex to protect the above hdcp component related values. */
>  	struct mutex hdcp_comp_mutex;
>  
> +	bool shown_bug_once;
> +
>  	I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
>  
>  	/*
> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> index c47261ae86ea..f434274b0b29 100644
> --- a/drivers/gpu/drm/i915/i915_utils.c
> +++ b/drivers/gpu/drm/i915/i915_utils.c
> @@ -13,11 +13,10 @@
>  		    "providing the dmesg log by booting with drm.debug=0xf"
>  
>  void
> -__i915_printk(struct drm_i915_private *dev_priv, const char *level,
> +__i915_printk(struct drm_i915_private *i915, const char *level,
>  	      const char *fmt, ...)
>  {
> -	static bool shown_bug_once;
> -	struct device *kdev = dev_priv->drm.dev;
> +	struct device *kdev = i915->drm.dev;
>  	bool is_error = level[1] <= KERN_ERR[1];
>  	bool is_debug = level[1] == KERN_DEBUG[1];
>  	struct va_format vaf;
> @@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>  
>  	va_end(args);
>  
> -	if (is_error && !shown_bug_once) {
> +	if (is_error && !i915->shown_bug_once) {
>  		/*
>  		 * Ask the user to file a bug report for the error, except
>  		 * if they may have caused the bug by fiddling with unsafe
> @@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>  		 */
>  		if (!test_taint(TAINT_USER))
>  			dev_notice(kdev, "%s", FDO_BUG_MSG);
> -		shown_bug_once = true;
> +		i915->shown_bug_once = true;
>  	}
>  }

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
@ 2019-11-15 10:21     ` Chris Wilson
  0 siblings, 0 replies; 20+ messages in thread
From: Chris Wilson @ 2019-11-15 10:21 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Quoting Jani Nikula (2019-11-15 10:18:40)
> Get rid of the module specific static variable.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h   | 2 ++
>  drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 1779f600fcfb..e11ee3268ae3 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1283,6 +1283,8 @@ struct drm_i915_private {
>         /* Mutex to protect the above hdcp component related values. */
>         struct mutex hdcp_comp_mutex;
>  
> +       bool shown_bug_once;
> +
>         I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
>  
>         /*
> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> index c47261ae86ea..f434274b0b29 100644
> --- a/drivers/gpu/drm/i915/i915_utils.c
> +++ b/drivers/gpu/drm/i915/i915_utils.c
> @@ -13,11 +13,10 @@
>                     "providing the dmesg log by booting with drm.debug=0xf"
>  
>  void
> -__i915_printk(struct drm_i915_private *dev_priv, const char *level,
> +__i915_printk(struct drm_i915_private *i915, const char *level,
>               const char *fmt, ...)
>  {
> -       static bool shown_bug_once;
> -       struct device *kdev = dev_priv->drm.dev;
> +       struct device *kdev = i915->drm.dev;
>         bool is_error = level[1] <= KERN_ERR[1];
>         bool is_debug = level[1] == KERN_DEBUG[1];
>         struct va_format vaf;
> @@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>  
>         va_end(args);
>  
> -       if (is_error && !shown_bug_once) {
> +       if (is_error && !i915->shown_bug_once) {
>                 /*
>                  * Ask the user to file a bug report for the error, except
>                  * if they may have caused the bug by fiddling with unsafe
> @@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>                  */
>                 if (!test_taint(TAINT_USER))
>                         dev_notice(kdev, "%s", FDO_BUG_MSG);

I feel this plea to the users to file a bug report should be a one-time
thing; a true global.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
@ 2019-11-15 10:21     ` Chris Wilson
  0 siblings, 0 replies; 20+ messages in thread
From: Chris Wilson @ 2019-11-15 10:21 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx; +Cc: jani.nikula

Quoting Jani Nikula (2019-11-15 10:18:40)
> Get rid of the module specific static variable.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h   | 2 ++
>  drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 1779f600fcfb..e11ee3268ae3 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1283,6 +1283,8 @@ struct drm_i915_private {
>         /* Mutex to protect the above hdcp component related values. */
>         struct mutex hdcp_comp_mutex;
>  
> +       bool shown_bug_once;
> +
>         I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
>  
>         /*
> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> index c47261ae86ea..f434274b0b29 100644
> --- a/drivers/gpu/drm/i915/i915_utils.c
> +++ b/drivers/gpu/drm/i915/i915_utils.c
> @@ -13,11 +13,10 @@
>                     "providing the dmesg log by booting with drm.debug=0xf"
>  
>  void
> -__i915_printk(struct drm_i915_private *dev_priv, const char *level,
> +__i915_printk(struct drm_i915_private *i915, const char *level,
>               const char *fmt, ...)
>  {
> -       static bool shown_bug_once;
> -       struct device *kdev = dev_priv->drm.dev;
> +       struct device *kdev = i915->drm.dev;
>         bool is_error = level[1] <= KERN_ERR[1];
>         bool is_debug = level[1] == KERN_DEBUG[1];
>         struct va_format vaf;
> @@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>  
>         va_end(args);
>  
> -       if (is_error && !shown_bug_once) {
> +       if (is_error && !i915->shown_bug_once) {
>                 /*
>                  * Ask the user to file a bug report for the error, except
>                  * if they may have caused the bug by fiddling with unsafe
> @@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>                  */
>                 if (!test_taint(TAINT_USER))
>                         dev_notice(kdev, "%s", FDO_BUG_MSG);

I feel this plea to the users to file a bug report should be a one-time
thing; a true global.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
@ 2019-11-15 11:04       ` Jani Nikula
  0 siblings, 0 replies; 20+ messages in thread
From: Jani Nikula @ 2019-11-15 11:04 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

On Fri, 15 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2019-11-15 10:18:40)
>> Get rid of the module specific static variable.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  drivers/gpu/drm/i915/i915_drv.h   | 2 ++
>>  drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
>>  2 files changed, 6 insertions(+), 5 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index 1779f600fcfb..e11ee3268ae3 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -1283,6 +1283,8 @@ struct drm_i915_private {
>>         /* Mutex to protect the above hdcp component related values. */
>>         struct mutex hdcp_comp_mutex;
>>  
>> +       bool shown_bug_once;
>> +
>>         I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
>>  
>>         /*
>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
>> index c47261ae86ea..f434274b0b29 100644
>> --- a/drivers/gpu/drm/i915/i915_utils.c
>> +++ b/drivers/gpu/drm/i915/i915_utils.c
>> @@ -13,11 +13,10 @@
>>                     "providing the dmesg log by booting with drm.debug=0xf"
>>  
>>  void
>> -__i915_printk(struct drm_i915_private *dev_priv, const char *level,
>> +__i915_printk(struct drm_i915_private *i915, const char *level,
>>               const char *fmt, ...)
>>  {
>> -       static bool shown_bug_once;
>> -       struct device *kdev = dev_priv->drm.dev;
>> +       struct device *kdev = i915->drm.dev;
>>         bool is_error = level[1] <= KERN_ERR[1];
>>         bool is_debug = level[1] == KERN_DEBUG[1];
>>         struct va_format vaf;
>> @@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>>  
>>         va_end(args);
>>  
>> -       if (is_error && !shown_bug_once) {
>> +       if (is_error && !i915->shown_bug_once) {
>>                 /*
>>                  * Ask the user to file a bug report for the error, except
>>                  * if they may have caused the bug by fiddling with unsafe
>> @@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>>                  */
>>                 if (!test_taint(TAINT_USER))
>>                         dev_notice(kdev, "%s", FDO_BUG_MSG);
>
> I feel this plea to the users to file a bug report should be a one-time
> thing; a true global.

Fair enough.

I am wondering if we should have a convention of naming or commenting
legit globals, both to help automation detecting new accidental ones,
and to help people figure out not to send another conversion patch such
as this.

BR,
Jani.



> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
@ 2019-11-15 11:04       ` Jani Nikula
  0 siblings, 0 replies; 20+ messages in thread
From: Jani Nikula @ 2019-11-15 11:04 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

On Fri, 15 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2019-11-15 10:18:40)
>> Get rid of the module specific static variable.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  drivers/gpu/drm/i915/i915_drv.h   | 2 ++
>>  drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
>>  2 files changed, 6 insertions(+), 5 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index 1779f600fcfb..e11ee3268ae3 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -1283,6 +1283,8 @@ struct drm_i915_private {
>>         /* Mutex to protect the above hdcp component related values. */
>>         struct mutex hdcp_comp_mutex;
>>  
>> +       bool shown_bug_once;
>> +
>>         I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
>>  
>>         /*
>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
>> index c47261ae86ea..f434274b0b29 100644
>> --- a/drivers/gpu/drm/i915/i915_utils.c
>> +++ b/drivers/gpu/drm/i915/i915_utils.c
>> @@ -13,11 +13,10 @@
>>                     "providing the dmesg log by booting with drm.debug=0xf"
>>  
>>  void
>> -__i915_printk(struct drm_i915_private *dev_priv, const char *level,
>> +__i915_printk(struct drm_i915_private *i915, const char *level,
>>               const char *fmt, ...)
>>  {
>> -       static bool shown_bug_once;
>> -       struct device *kdev = dev_priv->drm.dev;
>> +       struct device *kdev = i915->drm.dev;
>>         bool is_error = level[1] <= KERN_ERR[1];
>>         bool is_debug = level[1] == KERN_DEBUG[1];
>>         struct va_format vaf;
>> @@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>>  
>>         va_end(args);
>>  
>> -       if (is_error && !shown_bug_once) {
>> +       if (is_error && !i915->shown_bug_once) {
>>                 /*
>>                  * Ask the user to file a bug report for the error, except
>>                  * if they may have caused the bug by fiddling with unsafe
>> @@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>>                  */
>>                 if (!test_taint(TAINT_USER))
>>                         dev_notice(kdev, "%s", FDO_BUG_MSG);
>
> I feel this plea to the users to file a bug report should be a one-time
> thing; a true global.

Fair enough.

I am wondering if we should have a convention of naming or commenting
legit globals, both to help automation detecting new accidental ones,
and to help people figure out not to send another conversion patch such
as this.

BR,
Jani.



> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
@ 2019-11-15 11:08         ` Chris Wilson
  0 siblings, 0 replies; 20+ messages in thread
From: Chris Wilson @ 2019-11-15 11:08 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx

Quoting Jani Nikula (2019-11-15 11:04:28)
> On Fri, 15 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Quoting Jani Nikula (2019-11-15 10:18:40)
> >> Get rid of the module specific static variable.
> >> 
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/i915_drv.h   | 2 ++
> >>  drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
> >>  2 files changed, 6 insertions(+), 5 deletions(-)
> >> 
> >> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> >> index 1779f600fcfb..e11ee3268ae3 100644
> >> --- a/drivers/gpu/drm/i915/i915_drv.h
> >> +++ b/drivers/gpu/drm/i915/i915_drv.h
> >> @@ -1283,6 +1283,8 @@ struct drm_i915_private {
> >>         /* Mutex to protect the above hdcp component related values. */
> >>         struct mutex hdcp_comp_mutex;
> >>  
> >> +       bool shown_bug_once;
> >> +
> >>         I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
> >>  
> >>         /*
> >> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> >> index c47261ae86ea..f434274b0b29 100644
> >> --- a/drivers/gpu/drm/i915/i915_utils.c
> >> +++ b/drivers/gpu/drm/i915/i915_utils.c
> >> @@ -13,11 +13,10 @@
> >>                     "providing the dmesg log by booting with drm.debug=0xf"
> >>  
> >>  void
> >> -__i915_printk(struct drm_i915_private *dev_priv, const char *level,
> >> +__i915_printk(struct drm_i915_private *i915, const char *level,
> >>               const char *fmt, ...)
> >>  {
> >> -       static bool shown_bug_once;
> >> -       struct device *kdev = dev_priv->drm.dev;
> >> +       struct device *kdev = i915->drm.dev;
> >>         bool is_error = level[1] <= KERN_ERR[1];
> >>         bool is_debug = level[1] == KERN_DEBUG[1];
> >>         struct va_format vaf;
> >> @@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
> >>  
> >>         va_end(args);
> >>  
> >> -       if (is_error && !shown_bug_once) {
> >> +       if (is_error && !i915->shown_bug_once) {
> >>                 /*
> >>                  * Ask the user to file a bug report for the error, except
> >>                  * if they may have caused the bug by fiddling with unsafe
> >> @@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
> >>                  */
> >>                 if (!test_taint(TAINT_USER))
> >>                         dev_notice(kdev, "%s", FDO_BUG_MSG);
> >
> > I feel this plea to the users to file a bug report should be a one-time
> > thing; a true global.
> 
> Fair enough.
> 
> I am wondering if we should have a convention of naming or commenting
> legit globals, both to help automation detecting new accidental ones,
> and to help people figure out not to send another conversion patch such
> as this.

global_i915_show_bug_once
module_i915_show_bug_once
this_is_not_a_drill_show_the_bug_only_once

Reverse Hungarian namespace?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
@ 2019-11-15 11:08         ` Chris Wilson
  0 siblings, 0 replies; 20+ messages in thread
From: Chris Wilson @ 2019-11-15 11:08 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx

Quoting Jani Nikula (2019-11-15 11:04:28)
> On Fri, 15 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Quoting Jani Nikula (2019-11-15 10:18:40)
> >> Get rid of the module specific static variable.
> >> 
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/i915_drv.h   | 2 ++
> >>  drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
> >>  2 files changed, 6 insertions(+), 5 deletions(-)
> >> 
> >> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> >> index 1779f600fcfb..e11ee3268ae3 100644
> >> --- a/drivers/gpu/drm/i915/i915_drv.h
> >> +++ b/drivers/gpu/drm/i915/i915_drv.h
> >> @@ -1283,6 +1283,8 @@ struct drm_i915_private {
> >>         /* Mutex to protect the above hdcp component related values. */
> >>         struct mutex hdcp_comp_mutex;
> >>  
> >> +       bool shown_bug_once;
> >> +
> >>         I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
> >>  
> >>         /*
> >> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> >> index c47261ae86ea..f434274b0b29 100644
> >> --- a/drivers/gpu/drm/i915/i915_utils.c
> >> +++ b/drivers/gpu/drm/i915/i915_utils.c
> >> @@ -13,11 +13,10 @@
> >>                     "providing the dmesg log by booting with drm.debug=0xf"
> >>  
> >>  void
> >> -__i915_printk(struct drm_i915_private *dev_priv, const char *level,
> >> +__i915_printk(struct drm_i915_private *i915, const char *level,
> >>               const char *fmt, ...)
> >>  {
> >> -       static bool shown_bug_once;
> >> -       struct device *kdev = dev_priv->drm.dev;
> >> +       struct device *kdev = i915->drm.dev;
> >>         bool is_error = level[1] <= KERN_ERR[1];
> >>         bool is_debug = level[1] == KERN_DEBUG[1];
> >>         struct va_format vaf;
> >> @@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
> >>  
> >>         va_end(args);
> >>  
> >> -       if (is_error && !shown_bug_once) {
> >> +       if (is_error && !i915->shown_bug_once) {
> >>                 /*
> >>                  * Ask the user to file a bug report for the error, except
> >>                  * if they may have caused the bug by fiddling with unsafe
> >> @@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
> >>                  */
> >>                 if (!test_taint(TAINT_USER))
> >>                         dev_notice(kdev, "%s", FDO_BUG_MSG);
> >
> > I feel this plea to the users to file a bug report should be a one-time
> > thing; a true global.
> 
> Fair enough.
> 
> I am wondering if we should have a convention of naming or commenting
> legit globals, both to help automation detecting new accidental ones,
> and to help people figure out not to send another conversion patch such
> as this.

global_i915_show_bug_once
module_i915_show_bug_once
this_is_not_a_drill_show_the_bug_only_once

Reverse Hungarian namespace?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: move power domains dumped variable to drm_i915_private
@ 2019-11-15 12:05   ` Patchwork
  0 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-11-15 12:05 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915: move power domains dumped variable to drm_i915_private
URL   : https://patchwork.freedesktop.org/series/69519/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7350 -> Patchwork_15277
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15277:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_pm_rpm@module-reload:
    - {fi-kbl-7560u}:     NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-kbl-7560u/igt@i915_pm_rpm@module-reload.html

  
Known issues
------------

  Here are the changes found in Patchwork_15277 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_busy@basic-flip-pipe-b:
    - fi-skl-6770hq:      [PASS][2] -> [DMESG-WARN][3] ([fdo#105541])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html

  * igt@kms_chamelium@dp-edid-read:
    - fi-kbl-7500u:       [PASS][4] -> [WARN][5] ([fdo#109483])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][6] -> [FAIL][7] ([fdo#111045] / [fdo#111096])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Possible fixes ####

  * igt@i915_module_load@reload-with-fault-injection:
    - {fi-kbl-7560u}:     [INCOMPLETE][8] ([fdo#109964] / [fdo#110343]) -> [PASS][9]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [DMESG-WARN][10] ([fdo#112261]) -> [PASS][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  * igt@kms_flip@basic-flip-vs-modeset:
    - fi-icl-dsi:         [INCOMPLETE][12] ([fdo#107713]) -> [PASS][13]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-icl-dsi/igt@kms_flip@basic-flip-vs-modeset.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-icl-dsi/igt@kms_flip@basic-flip-vs-modeset.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [FAIL][14] ([fdo#103167]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
  [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
  [fdo#110343]: https://bugs.freedesktop.org/show_bug.cgi?id=110343
  [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261


Participating hosts (49 -> 45)
------------------------------

  Missing    (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7350 -> Patchwork_15277

  CI-20190529: 20190529
  CI_DRM_7350: 152f497716543b573ad729cbee8dd0e51d6b4aaf @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5287: 9e57f8a51d59b3ffe4002d761fe0315d733bd66e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15277: 79227516d97e8fbe661d5213c6c2cb043cf88a72 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

79227516d97e drm/i915: make debug printer shown_bug_once variable to drm_i915_private
cdfb40523d81 drm/i915: move power domains dumped variable to drm_i915_private

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: move power domains dumped variable to drm_i915_private
@ 2019-11-15 12:05   ` Patchwork
  0 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-11-15 12:05 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915: move power domains dumped variable to drm_i915_private
URL   : https://patchwork.freedesktop.org/series/69519/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7350 -> Patchwork_15277
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15277:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_pm_rpm@module-reload:
    - {fi-kbl-7560u}:     NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-kbl-7560u/igt@i915_pm_rpm@module-reload.html

  
Known issues
------------

  Here are the changes found in Patchwork_15277 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_busy@basic-flip-pipe-b:
    - fi-skl-6770hq:      [PASS][2] -> [DMESG-WARN][3] ([fdo#105541])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-skl-6770hq/igt@kms_busy@basic-flip-pipe-b.html

  * igt@kms_chamelium@dp-edid-read:
    - fi-kbl-7500u:       [PASS][4] -> [WARN][5] ([fdo#109483])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][6] -> [FAIL][7] ([fdo#111045] / [fdo#111096])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Possible fixes ####

  * igt@i915_module_load@reload-with-fault-injection:
    - {fi-kbl-7560u}:     [INCOMPLETE][8] ([fdo#109964] / [fdo#110343]) -> [PASS][9]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [DMESG-WARN][10] ([fdo#112261]) -> [PASS][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  * igt@kms_flip@basic-flip-vs-modeset:
    - fi-icl-dsi:         [INCOMPLETE][12] ([fdo#107713]) -> [PASS][13]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-icl-dsi/igt@kms_flip@basic-flip-vs-modeset.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-icl-dsi/igt@kms_flip@basic-flip-vs-modeset.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [FAIL][14] ([fdo#103167]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
  [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
  [fdo#110343]: https://bugs.freedesktop.org/show_bug.cgi?id=110343
  [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261


Participating hosts (49 -> 45)
------------------------------

  Missing    (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7350 -> Patchwork_15277

  CI-20190529: 20190529
  CI_DRM_7350: 152f497716543b573ad729cbee8dd0e51d6b4aaf @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5287: 9e57f8a51d59b3ffe4002d761fe0315d733bd66e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15277: 79227516d97e8fbe661d5213c6c2cb043cf88a72 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

79227516d97e drm/i915: make debug printer shown_bug_once variable to drm_i915_private
cdfb40523d81 drm/i915: move power domains dumped variable to drm_i915_private

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: move power domains dumped variable to drm_i915_private
@ 2019-11-16 16:36   ` Patchwork
  0 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-11-16 16:36 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915: move power domains dumped variable to drm_i915_private
URL   : https://patchwork.freedesktop.org/series/69519/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7350_full -> Patchwork_15277_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15277_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15277_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15277_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_ctx_persistence@rcs0-mixed-process:
    - shard-skl:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl10/igt@gem_ctx_persistence@rcs0-mixed-process.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl10/igt@gem_ctx_persistence@rcs0-mixed-process.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * {igt@gem_exec_parse_blt@bb-start-cmd}:
    - shard-glk:          [PASS][3] -> [TIMEOUT][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-glk9/igt@gem_exec_parse_blt@bb-start-cmd.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-glk8/igt@gem_exec_parse_blt@bb-start-cmd.html

  * {igt@gem_exec_parse_blt@cmd-crossing-page}:
    - shard-tglb:         NOTRUN -> [SKIP][5] +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb7/igt@gem_exec_parse_blt@cmd-crossing-page.html

  * {igt@gem_exec_reloc@basic-spin-blt}:
    - shard-glk:          NOTRUN -> [TIMEOUT][6]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-glk4/igt@gem_exec_reloc@basic-spin-blt.html

  * {igt@gem_exec_reloc@basic-spin-bsd1}:
    - shard-snb:          NOTRUN -> [FAIL][7]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-snb6/igt@gem_exec_reloc@basic-spin-bsd1.html

  
Known issues
------------

  Here are the changes found in Patchwork_15277_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@bcs0-s3:
    - shard-tglb:         [PASS][8] -> [INCOMPLETE][9] ([fdo#111832]) +1 similar issue
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb2/igt@gem_ctx_isolation@bcs0-s3.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb5/igt@gem_ctx_isolation@bcs0-s3.html

  * igt@gem_ctx_persistence@vcs1-queued:
    - shard-iclb:         [PASS][10] -> [SKIP][11] ([fdo#109276] / [fdo#112080]) +2 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb6/igt@gem_ctx_persistence@vcs1-queued.html

  * igt@gem_eio@in-flight-suspend:
    - shard-kbl:          [PASS][12] -> [DMESG-WARN][13] ([fdo#108566])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl2/igt@gem_eio@in-flight-suspend.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl1/igt@gem_eio@in-flight-suspend.html

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [PASS][14] -> [SKIP][15] ([fdo#110854])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb4/igt@gem_exec_balancer@smoke.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb6/igt@gem_exec_balancer@smoke.html

  * igt@gem_exec_schedule@promotion-bsd1:
    - shard-iclb:         [PASS][16] -> [SKIP][17] ([fdo#109276]) +17 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb8/igt@gem_exec_schedule@promotion-bsd1.html

  * igt@gem_exec_schedule@wide-bsd:
    - shard-iclb:         [PASS][18] -> [SKIP][19] ([fdo#112146]) +2 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb5/igt@gem_exec_schedule@wide-bsd.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html

  * igt@gem_sync@basic-store-each:
    - shard-tglb:         [PASS][20] -> [INCOMPLETE][21] ([fdo#111647] / [fdo#111747])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb9/igt@gem_sync@basic-store-each.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb4/igt@gem_sync@basic-store-each.html

  * igt@gem_userptr_blits@sync-unmap:
    - shard-hsw:          [PASS][22] -> [DMESG-WARN][23] ([fdo#110789] / [fdo#111870])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-hsw6/igt@gem_userptr_blits@sync-unmap.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-hsw1/igt@gem_userptr_blits@sync-unmap.html

  * igt@i915_pm_backlight@fade_with_suspend:
    - shard-tglb:         [PASS][24] -> [INCOMPLETE][25] ([fdo#111832] / [fdo#111850]) +4 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb2/igt@i915_pm_backlight@fade_with_suspend.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb7/igt@i915_pm_backlight@fade_with_suspend.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-kbl:          [PASS][26] -> [SKIP][27] ([fdo#109271])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl3/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl7/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@i915_pm_rpm@pm-caching:
    - shard-hsw:          [PASS][28] -> [INCOMPLETE][29] ([fdo#103540] / [fdo#107807])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-hsw5/igt@i915_pm_rpm@pm-caching.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-hsw7/igt@i915_pm_rpm@pm-caching.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][30] -> [INCOMPLETE][31] ([fdo#103665])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding:
    - shard-skl:          [PASS][32] -> [FAIL][33] ([fdo#103232])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-skl:          [PASS][34] -> [FAIL][35] ([fdo#105363])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl4/igt@kms_flip@flip-vs-expired-vblank.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_flip@plain-flip-ts-check:
    - shard-skl:          [PASS][36] -> [FAIL][37] ([fdo#100368])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl2/igt@kms_flip@plain-flip-ts-check.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl8/igt@kms_flip@plain-flip-ts-check.html

  * igt@kms_flip_tiling@flip-changes-tiling:
    - shard-skl:          [PASS][38] -> [FAIL][39] ([fdo#108303])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl9/igt@kms_flip_tiling@flip-changes-tiling.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl10/igt@kms_flip_tiling@flip-changes-tiling.html

  * igt@kms_flip_tiling@flip-to-x-tiled:
    - shard-skl:          [PASS][40] -> [FAIL][41] ([fdo#108134])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl9/igt@kms_flip_tiling@flip-to-x-tiled.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl10/igt@kms_flip_tiling@flip-to-x-tiled.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
    - shard-iclb:         [PASS][42] -> [FAIL][43] ([fdo#103167]) +6 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
    - shard-tglb:         [PASS][44] -> [FAIL][45] ([fdo#103167]) +2 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
    - shard-apl:          [PASS][46] -> [DMESG-WARN][47] ([fdo#108566])
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html

  * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
    - shard-skl:          [PASS][48] -> [FAIL][49] ([fdo#108145])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [PASS][50] -> [FAIL][51] ([fdo#108145] / [fdo#110403])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][52] -> [SKIP][53] ([fdo#109642] / [fdo#111068])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb4/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [PASS][54] -> [SKIP][55] ([fdo#109441])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_setmode@basic:
    - shard-hsw:          [PASS][56] -> [FAIL][57] ([fdo#99912])
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-hsw5/igt@kms_setmode@basic.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-hsw6/igt@kms_setmode@basic.html
    - shard-kbl:          [PASS][58] -> [FAIL][59] ([fdo#99912])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl7/igt@kms_setmode@basic.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl3/igt@kms_setmode@basic.html

  * igt@perf_pmu@busy-no-semaphores-vcs1:
    - shard-iclb:         [PASS][60] -> [SKIP][61] ([fdo#112080]) +12 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb1/igt@perf_pmu@busy-no-semaphores-vcs1.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb6/igt@perf_pmu@busy-no-semaphores-vcs1.html

  
#### Possible fixes ####

  * igt@gem_busy@busy-vcs1:
    - shard-iclb:         [SKIP][62] ([fdo#112080]) -> [PASS][63] +11 similar issues
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb6/igt@gem_busy@busy-vcs1.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb2/igt@gem_busy@busy-vcs1.html

  * igt@gem_ctx_persistence@vcs1-mixed-process:
    - shard-iclb:         [SKIP][64] ([fdo#109276] / [fdo#112080]) -> [PASS][65] +3 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb7/igt@gem_ctx_persistence@vcs1-mixed-process.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb2/igt@gem_ctx_persistence@vcs1-mixed-process.html

  * igt@gem_eio@unwedge-stress:
    - shard-tglb:         [INCOMPLETE][66] ([fdo#111866]) -> [PASS][67]
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb6/igt@gem_eio@unwedge-stress.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb6/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_schedule@preempt-other-chain-bsd:
    - shard-iclb:         [SKIP][68] ([fdo#112146]) -> [PASS][69] +5 similar issues
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html

  * igt@gem_exec_schedule@preempt-queue-chain-bsd2:
    - shard-iclb:         [SKIP][70] ([fdo#109276]) -> [PASS][71] +6 similar issues
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb3/igt@gem_exec_schedule@preempt-queue-chain-bsd2.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb4/igt@gem_exec_schedule@preempt-queue-chain-bsd2.html

  * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
    - shard-apl:          [DMESG-FAIL][72] -> [PASS][73]
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-apl8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-apl3/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html

  * igt@gem_persistent_relocs@forked-thrashing:
    - shard-hsw:          [FAIL][74] ([fdo#112037]) -> [PASS][75]
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-hsw1/igt@gem_persistent_relocs@forked-thrashing.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-hsw2/igt@gem_persistent_relocs@forked-thrashing.html
    - shard-snb:          [INCOMPLETE][76] ([fdo#105411] / [fdo#112068 ]) -> [PASS][77]
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-snb1/igt@gem_persistent_relocs@forked-thrashing.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-snb6/igt@gem_persistent_relocs@forked-thrashing.html

  * igt@gem_softpin@noreloc-s3:
    - shard-apl:          [DMESG-WARN][78] ([fdo#108566]) -> [PASS][79] +1 similar issue
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-apl4/igt@gem_softpin@noreloc-s3.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-apl8/igt@gem_softpin@noreloc-s3.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-hsw:          [DMESG-WARN][80] ([fdo#111870]) -> [PASS][81]
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@i915_pm_rpm@system-suspend-execbuf:
    - shard-kbl:          [INCOMPLETE][82] ([fdo#103665] / [fdo#107807]) -> [PASS][83]
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl4/igt@i915_pm_rpm@system-suspend-execbuf.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl6/igt@i915_pm_rpm@system-suspend-execbuf.html

  * igt@i915_selftest@live_hangcheck:
    - shard-hsw:          [DMESG-FAIL][84] ([fdo#111991]) -> [PASS][85]
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-hsw7/igt@i915_selftest@live_hangcheck.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-hsw5/igt@i915_selftest@live_hangcheck.html

  * igt@i915_suspend@debugfs-reader:
    - shard-kbl:          [DMESG-WARN][86] ([fdo#108566]) -> [PASS][87] +2 similar issues
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl1/igt@i915_suspend@debugfs-reader.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl4/igt@i915_suspend@debugfs-reader.html

  * igt@kms_color@pipe-a-ctm-0-25:
    - shard-skl:          [DMESG-WARN][88] ([fdo#106107]) -> [PASS][89]
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl3/igt@kms_color@pipe-a-ctm-0-25.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl6/igt@kms_color@pipe-a-ctm-0-25.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-skl:          [INCOMPLETE][90] ([fdo#110741]) -> [PASS][91]
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
    - shard-iclb:         [DMESG-WARN][92] ([fdo#111764]) -> [PASS][93]
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-tglb:         [INCOMPLETE][94] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][95]
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb4/igt@kms_fbcon_fbt@fbc-suspend.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb8/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_fbcon_fbt@psr-suspend:
    - shard-skl:          [INCOMPLETE][96] ([fdo#104108]) -> [PASS][97]
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl3/igt@kms_fbcon_fbt@psr-suspend.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl7/igt@kms_fbcon_fbt@psr-suspend.html

  * igt@kms_flip@plain-flip-fb-recreate:
    - shard-kbl:          [FAIL][98] ([fdo#100368]) -> [PASS][99]
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl4/igt@kms_flip@plain-flip-fb-recreate.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl2/igt@kms_flip@plain-flip-fb-recreate.html

  * igt@kms_frontbuffer_tracking@basic:
    - shard-iclb:         [FAIL][100] ([fdo#103167]) -> [PASS][101] +6 similar issues
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb1/igt@kms_frontbuffer_tracking@basic.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb1/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-tglb:         [INCOMPLETE][102] ([fdo#111832] / [fdo#111850] / [fdo#111884]) -> [PASS][103]
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
    - shard-tglb:         [FAIL][104] ([fdo#103167]) -> [PASS][105] +2 similar issues
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - shard-tglb:         [INCOMPLETE][106] ([fdo#

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: move power domains dumped variable to drm_i915_private
@ 2019-11-16 16:36   ` Patchwork
  0 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-11-16 16:36 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915: move power domains dumped variable to drm_i915_private
URL   : https://patchwork.freedesktop.org/series/69519/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7350_full -> Patchwork_15277_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15277_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15277_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15277_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_ctx_persistence@rcs0-mixed-process:
    - shard-skl:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl10/igt@gem_ctx_persistence@rcs0-mixed-process.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl10/igt@gem_ctx_persistence@rcs0-mixed-process.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * {igt@gem_exec_parse_blt@bb-start-cmd}:
    - shard-glk:          [PASS][3] -> [TIMEOUT][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-glk9/igt@gem_exec_parse_blt@bb-start-cmd.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-glk8/igt@gem_exec_parse_blt@bb-start-cmd.html

  * {igt@gem_exec_parse_blt@cmd-crossing-page}:
    - shard-tglb:         NOTRUN -> [SKIP][5] +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb7/igt@gem_exec_parse_blt@cmd-crossing-page.html

  * {igt@gem_exec_reloc@basic-spin-blt}:
    - shard-glk:          NOTRUN -> [TIMEOUT][6]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-glk4/igt@gem_exec_reloc@basic-spin-blt.html

  * {igt@gem_exec_reloc@basic-spin-bsd1}:
    - shard-snb:          NOTRUN -> [FAIL][7]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-snb6/igt@gem_exec_reloc@basic-spin-bsd1.html

  
Known issues
------------

  Here are the changes found in Patchwork_15277_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@bcs0-s3:
    - shard-tglb:         [PASS][8] -> [INCOMPLETE][9] ([fdo#111832]) +1 similar issue
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb2/igt@gem_ctx_isolation@bcs0-s3.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb5/igt@gem_ctx_isolation@bcs0-s3.html

  * igt@gem_ctx_persistence@vcs1-queued:
    - shard-iclb:         [PASS][10] -> [SKIP][11] ([fdo#109276] / [fdo#112080]) +2 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb6/igt@gem_ctx_persistence@vcs1-queued.html

  * igt@gem_eio@in-flight-suspend:
    - shard-kbl:          [PASS][12] -> [DMESG-WARN][13] ([fdo#108566])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl2/igt@gem_eio@in-flight-suspend.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl1/igt@gem_eio@in-flight-suspend.html

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [PASS][14] -> [SKIP][15] ([fdo#110854])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb4/igt@gem_exec_balancer@smoke.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb6/igt@gem_exec_balancer@smoke.html

  * igt@gem_exec_schedule@promotion-bsd1:
    - shard-iclb:         [PASS][16] -> [SKIP][17] ([fdo#109276]) +17 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb8/igt@gem_exec_schedule@promotion-bsd1.html

  * igt@gem_exec_schedule@wide-bsd:
    - shard-iclb:         [PASS][18] -> [SKIP][19] ([fdo#112146]) +2 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb5/igt@gem_exec_schedule@wide-bsd.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html

  * igt@gem_sync@basic-store-each:
    - shard-tglb:         [PASS][20] -> [INCOMPLETE][21] ([fdo#111647] / [fdo#111747])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb9/igt@gem_sync@basic-store-each.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb4/igt@gem_sync@basic-store-each.html

  * igt@gem_userptr_blits@sync-unmap:
    - shard-hsw:          [PASS][22] -> [DMESG-WARN][23] ([fdo#110789] / [fdo#111870])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-hsw6/igt@gem_userptr_blits@sync-unmap.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-hsw1/igt@gem_userptr_blits@sync-unmap.html

  * igt@i915_pm_backlight@fade_with_suspend:
    - shard-tglb:         [PASS][24] -> [INCOMPLETE][25] ([fdo#111832] / [fdo#111850]) +4 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb2/igt@i915_pm_backlight@fade_with_suspend.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb7/igt@i915_pm_backlight@fade_with_suspend.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-kbl:          [PASS][26] -> [SKIP][27] ([fdo#109271])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl3/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl7/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@i915_pm_rpm@pm-caching:
    - shard-hsw:          [PASS][28] -> [INCOMPLETE][29] ([fdo#103540] / [fdo#107807])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-hsw5/igt@i915_pm_rpm@pm-caching.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-hsw7/igt@i915_pm_rpm@pm-caching.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][30] -> [INCOMPLETE][31] ([fdo#103665])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding:
    - shard-skl:          [PASS][32] -> [FAIL][33] ([fdo#103232])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-skl:          [PASS][34] -> [FAIL][35] ([fdo#105363])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl4/igt@kms_flip@flip-vs-expired-vblank.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_flip@plain-flip-ts-check:
    - shard-skl:          [PASS][36] -> [FAIL][37] ([fdo#100368])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl2/igt@kms_flip@plain-flip-ts-check.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl8/igt@kms_flip@plain-flip-ts-check.html

  * igt@kms_flip_tiling@flip-changes-tiling:
    - shard-skl:          [PASS][38] -> [FAIL][39] ([fdo#108303])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl9/igt@kms_flip_tiling@flip-changes-tiling.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl10/igt@kms_flip_tiling@flip-changes-tiling.html

  * igt@kms_flip_tiling@flip-to-x-tiled:
    - shard-skl:          [PASS][40] -> [FAIL][41] ([fdo#108134])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl9/igt@kms_flip_tiling@flip-to-x-tiled.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl10/igt@kms_flip_tiling@flip-to-x-tiled.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
    - shard-iclb:         [PASS][42] -> [FAIL][43] ([fdo#103167]) +6 similar issues
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
    - shard-tglb:         [PASS][44] -> [FAIL][45] ([fdo#103167]) +2 similar issues
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
    - shard-apl:          [PASS][46] -> [DMESG-WARN][47] ([fdo#108566])
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html

  * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
    - shard-skl:          [PASS][48] -> [FAIL][49] ([fdo#108145])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [PASS][50] -> [FAIL][51] ([fdo#108145] / [fdo#110403])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][52] -> [SKIP][53] ([fdo#109642] / [fdo#111068])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb4/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [PASS][54] -> [SKIP][55] ([fdo#109441])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_setmode@basic:
    - shard-hsw:          [PASS][56] -> [FAIL][57] ([fdo#99912])
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-hsw5/igt@kms_setmode@basic.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-hsw6/igt@kms_setmode@basic.html
    - shard-kbl:          [PASS][58] -> [FAIL][59] ([fdo#99912])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl7/igt@kms_setmode@basic.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl3/igt@kms_setmode@basic.html

  * igt@perf_pmu@busy-no-semaphores-vcs1:
    - shard-iclb:         [PASS][60] -> [SKIP][61] ([fdo#112080]) +12 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb1/igt@perf_pmu@busy-no-semaphores-vcs1.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb6/igt@perf_pmu@busy-no-semaphores-vcs1.html

  
#### Possible fixes ####

  * igt@gem_busy@busy-vcs1:
    - shard-iclb:         [SKIP][62] ([fdo#112080]) -> [PASS][63] +11 similar issues
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb6/igt@gem_busy@busy-vcs1.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb2/igt@gem_busy@busy-vcs1.html

  * igt@gem_ctx_persistence@vcs1-mixed-process:
    - shard-iclb:         [SKIP][64] ([fdo#109276] / [fdo#112080]) -> [PASS][65] +3 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb7/igt@gem_ctx_persistence@vcs1-mixed-process.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb2/igt@gem_ctx_persistence@vcs1-mixed-process.html

  * igt@gem_eio@unwedge-stress:
    - shard-tglb:         [INCOMPLETE][66] ([fdo#111866]) -> [PASS][67]
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb6/igt@gem_eio@unwedge-stress.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb6/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_schedule@preempt-other-chain-bsd:
    - shard-iclb:         [SKIP][68] ([fdo#112146]) -> [PASS][69] +5 similar issues
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html

  * igt@gem_exec_schedule@preempt-queue-chain-bsd2:
    - shard-iclb:         [SKIP][70] ([fdo#109276]) -> [PASS][71] +6 similar issues
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb3/igt@gem_exec_schedule@preempt-queue-chain-bsd2.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb4/igt@gem_exec_schedule@preempt-queue-chain-bsd2.html

  * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
    - shard-apl:          [DMESG-FAIL][72] -> [PASS][73]
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-apl8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-apl3/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html

  * igt@gem_persistent_relocs@forked-thrashing:
    - shard-hsw:          [FAIL][74] ([fdo#112037]) -> [PASS][75]
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-hsw1/igt@gem_persistent_relocs@forked-thrashing.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-hsw2/igt@gem_persistent_relocs@forked-thrashing.html
    - shard-snb:          [INCOMPLETE][76] ([fdo#105411] / [fdo#112068 ]) -> [PASS][77]
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-snb1/igt@gem_persistent_relocs@forked-thrashing.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-snb6/igt@gem_persistent_relocs@forked-thrashing.html

  * igt@gem_softpin@noreloc-s3:
    - shard-apl:          [DMESG-WARN][78] ([fdo#108566]) -> [PASS][79] +1 similar issue
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-apl4/igt@gem_softpin@noreloc-s3.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-apl8/igt@gem_softpin@noreloc-s3.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
    - shard-hsw:          [DMESG-WARN][80] ([fdo#111870]) -> [PASS][81]
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html

  * igt@i915_pm_rpm@system-suspend-execbuf:
    - shard-kbl:          [INCOMPLETE][82] ([fdo#103665] / [fdo#107807]) -> [PASS][83]
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl4/igt@i915_pm_rpm@system-suspend-execbuf.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl6/igt@i915_pm_rpm@system-suspend-execbuf.html

  * igt@i915_selftest@live_hangcheck:
    - shard-hsw:          [DMESG-FAIL][84] ([fdo#111991]) -> [PASS][85]
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-hsw7/igt@i915_selftest@live_hangcheck.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-hsw5/igt@i915_selftest@live_hangcheck.html

  * igt@i915_suspend@debugfs-reader:
    - shard-kbl:          [DMESG-WARN][86] ([fdo#108566]) -> [PASS][87] +2 similar issues
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl1/igt@i915_suspend@debugfs-reader.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl4/igt@i915_suspend@debugfs-reader.html

  * igt@kms_color@pipe-a-ctm-0-25:
    - shard-skl:          [DMESG-WARN][88] ([fdo#106107]) -> [PASS][89]
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl3/igt@kms_color@pipe-a-ctm-0-25.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl6/igt@kms_color@pipe-a-ctm-0-25.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-skl:          [INCOMPLETE][90] ([fdo#110741]) -> [PASS][91]
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
    - shard-iclb:         [DMESG-WARN][92] ([fdo#111764]) -> [PASS][93]
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-tglb:         [INCOMPLETE][94] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][95]
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb4/igt@kms_fbcon_fbt@fbc-suspend.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb8/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_fbcon_fbt@psr-suspend:
    - shard-skl:          [INCOMPLETE][96] ([fdo#104108]) -> [PASS][97]
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-skl3/igt@kms_fbcon_fbt@psr-suspend.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-skl7/igt@kms_fbcon_fbt@psr-suspend.html

  * igt@kms_flip@plain-flip-fb-recreate:
    - shard-kbl:          [FAIL][98] ([fdo#100368]) -> [PASS][99]
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-kbl4/igt@kms_flip@plain-flip-fb-recreate.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-kbl2/igt@kms_flip@plain-flip-fb-recreate.html

  * igt@kms_frontbuffer_tracking@basic:
    - shard-iclb:         [FAIL][100] ([fdo#103167]) -> [PASS][101] +6 similar issues
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-iclb1/igt@kms_frontbuffer_tracking@basic.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-iclb1/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-tglb:         [INCOMPLETE][102] ([fdo#111832] / [fdo#111850] / [fdo#111884]) -> [PASS][103]
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
    - shard-tglb:         [FAIL][104] ([fdo#103167]) -> [PASS][105] +2 similar issues
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7350/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - shard-tglb:         [INCOMPLETE][106] ([fdo#

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15277/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
  2019-11-15 11:08         ` [Intel-gfx] " Chris Wilson
  (?)
@ 2019-12-11 10:36         ` Jani Nikula
  2019-12-11 15:25           ` Joonas Lahtinen
  -1 siblings, 1 reply; 20+ messages in thread
From: Jani Nikula @ 2019-12-11 10:36 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

On Fri, 15 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2019-11-15 11:04:28)
>> On Fri, 15 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > Quoting Jani Nikula (2019-11-15 10:18:40)
>> >> Get rid of the module specific static variable.
>> >> 
>> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> >> ---
>> >>  drivers/gpu/drm/i915/i915_drv.h   | 2 ++
>> >>  drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
>> >>  2 files changed, 6 insertions(+), 5 deletions(-)
>> >> 
>> >> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> >> index 1779f600fcfb..e11ee3268ae3 100644
>> >> --- a/drivers/gpu/drm/i915/i915_drv.h
>> >> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> >> @@ -1283,6 +1283,8 @@ struct drm_i915_private {
>> >>         /* Mutex to protect the above hdcp component related values. */
>> >>         struct mutex hdcp_comp_mutex;
>> >>  
>> >> +       bool shown_bug_once;
>> >> +
>> >>         I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
>> >>  
>> >>         /*
>> >> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
>> >> index c47261ae86ea..f434274b0b29 100644
>> >> --- a/drivers/gpu/drm/i915/i915_utils.c
>> >> +++ b/drivers/gpu/drm/i915/i915_utils.c
>> >> @@ -13,11 +13,10 @@
>> >>                     "providing the dmesg log by booting with drm.debug=0xf"
>> >>  
>> >>  void
>> >> -__i915_printk(struct drm_i915_private *dev_priv, const char *level,
>> >> +__i915_printk(struct drm_i915_private *i915, const char *level,
>> >>               const char *fmt, ...)
>> >>  {
>> >> -       static bool shown_bug_once;
>> >> -       struct device *kdev = dev_priv->drm.dev;
>> >> +       struct device *kdev = i915->drm.dev;
>> >>         bool is_error = level[1] <= KERN_ERR[1];
>> >>         bool is_debug = level[1] == KERN_DEBUG[1];
>> >>         struct va_format vaf;
>> >> @@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>> >>  
>> >>         va_end(args);
>> >>  
>> >> -       if (is_error && !shown_bug_once) {
>> >> +       if (is_error && !i915->shown_bug_once) {
>> >>                 /*
>> >>                  * Ask the user to file a bug report for the error, except
>> >>                  * if they may have caused the bug by fiddling with unsafe
>> >> @@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>> >>                  */
>> >>                 if (!test_taint(TAINT_USER))
>> >>                         dev_notice(kdev, "%s", FDO_BUG_MSG);
>> >
>> > I feel this plea to the users to file a bug report should be a one-time
>> > thing; a true global.
>> 
>> Fair enough.
>> 
>> I am wondering if we should have a convention of naming or commenting
>> legit globals, both to help automation detecting new accidental ones,
>> and to help people figure out not to send another conversion patch such
>> as this.
>
> global_i915_show_bug_once
> module_i915_show_bug_once

I'd be fine with either of the prefixes. Or i915_{global,module}_ for
that matter.

Joonas, Rodrigo, anyone?


BR,
Jani.


> this_is_not_a_drill_show_the_bug_only_once
>
> Reverse Hungarian namespace?
> -Chris

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
  2019-12-11 10:36         ` Jani Nikula
@ 2019-12-11 15:25           ` Joonas Lahtinen
  2019-12-12  7:33             ` Vivi, Rodrigo
  2019-12-12  7:34             ` Jani Nikula
  0 siblings, 2 replies; 20+ messages in thread
From: Joonas Lahtinen @ 2019-12-11 15:25 UTC (permalink / raw)
  To: Chris Wilson, Jani Nikula, intel-gfx

Quoting Jani Nikula (2019-12-11 12:36:10)
> On Fri, 15 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Quoting Jani Nikula (2019-11-15 11:04:28)
> >> On Fri, 15 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >> > Quoting Jani Nikula (2019-11-15 10:18:40)
> >> >> Get rid of the module specific static variable.
> >> >> 
> >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >> >> ---
> >> >>  drivers/gpu/drm/i915/i915_drv.h   | 2 ++
> >> >>  drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
> >> >>  2 files changed, 6 insertions(+), 5 deletions(-)
> >> >> 
> >> >> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> >> >> index 1779f600fcfb..e11ee3268ae3 100644
> >> >> --- a/drivers/gpu/drm/i915/i915_drv.h
> >> >> +++ b/drivers/gpu/drm/i915/i915_drv.h
> >> >> @@ -1283,6 +1283,8 @@ struct drm_i915_private {
> >> >>         /* Mutex to protect the above hdcp component related values. */
> >> >>         struct mutex hdcp_comp_mutex;
> >> >>  
> >> >> +       bool shown_bug_once;
> >> >> +
> >> >>         I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
> >> >>  
> >> >>         /*
> >> >> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> >> >> index c47261ae86ea..f434274b0b29 100644
> >> >> --- a/drivers/gpu/drm/i915/i915_utils.c
> >> >> +++ b/drivers/gpu/drm/i915/i915_utils.c
> >> >> @@ -13,11 +13,10 @@
> >> >>                     "providing the dmesg log by booting with drm.debug=0xf"
> >> >>  
> >> >>  void
> >> >> -__i915_printk(struct drm_i915_private *dev_priv, const char *level,
> >> >> +__i915_printk(struct drm_i915_private *i915, const char *level,
> >> >>               const char *fmt, ...)
> >> >>  {
> >> >> -       static bool shown_bug_once;
> >> >> -       struct device *kdev = dev_priv->drm.dev;
> >> >> +       struct device *kdev = i915->drm.dev;
> >> >>         bool is_error = level[1] <= KERN_ERR[1];
> >> >>         bool is_debug = level[1] == KERN_DEBUG[1];
> >> >>         struct va_format vaf;
> >> >> @@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
> >> >>  
> >> >>         va_end(args);
> >> >>  
> >> >> -       if (is_error && !shown_bug_once) {
> >> >> +       if (is_error && !i915->shown_bug_once) {
> >> >>                 /*
> >> >>                  * Ask the user to file a bug report for the error, except
> >> >>                  * if they may have caused the bug by fiddling with unsafe
> >> >> @@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
> >> >>                  */
> >> >>                 if (!test_taint(TAINT_USER))
> >> >>                         dev_notice(kdev, "%s", FDO_BUG_MSG);
> >> >
> >> > I feel this plea to the users to file a bug report should be a one-time
> >> > thing; a true global.
> >> 
> >> Fair enough.
> >> 
> >> I am wondering if we should have a convention of naming or commenting
> >> legit globals, both to help automation detecting new accidental ones,
> >> and to help people figure out not to send another conversion patch such
> >> as this.
> >
> > global_i915_show_bug_once
> > module_i915_show_bug_once
> 
> I'd be fine with either of the prefixes. Or i915_{global,module}_ for

My vote goes for i915_global_* or global_i915_* (if we could get some
Kbuild infrastructure behind detecting global variables).

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
  2019-12-11 15:25           ` Joonas Lahtinen
@ 2019-12-12  7:33             ` Vivi, Rodrigo
  2019-12-12  7:34             ` Jani Nikula
  1 sibling, 0 replies; 20+ messages in thread
From: Vivi, Rodrigo @ 2019-12-12  7:33 UTC (permalink / raw)
  To: Joonas Lahtinen; +Cc: Nikula, Jani, intel-gfx



> On Dec 11, 2019, at 7:25 AM, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> 
> Quoting Jani Nikula (2019-12-11 12:36:10)
>> On Fri, 15 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>> Quoting Jani Nikula (2019-11-15 11:04:28)
>>>> On Fri, 15 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>>>>> Quoting Jani Nikula (2019-11-15 10:18:40)
>>>>>> Get rid of the module specific static variable.
>>>>>> 
>>>>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>>>>> ---
>>>>>> drivers/gpu/drm/i915/i915_drv.h   | 2 ++
>>>>>> drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
>>>>>> 2 files changed, 6 insertions(+), 5 deletions(-)
>>>>>> 
>>>>>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>>>>>> index 1779f600fcfb..e11ee3268ae3 100644
>>>>>> --- a/drivers/gpu/drm/i915/i915_drv.h
>>>>>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>>>>>> @@ -1283,6 +1283,8 @@ struct drm_i915_private {
>>>>>>        /* Mutex to protect the above hdcp component related values. */
>>>>>>        struct mutex hdcp_comp_mutex;
>>>>>> 
>>>>>> +       bool shown_bug_once;
>>>>>> +
>>>>>>        I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
>>>>>> 
>>>>>>        /*
>>>>>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
>>>>>> index c47261ae86ea..f434274b0b29 100644
>>>>>> --- a/drivers/gpu/drm/i915/i915_utils.c
>>>>>> +++ b/drivers/gpu/drm/i915/i915_utils.c
>>>>>> @@ -13,11 +13,10 @@
>>>>>>                    "providing the dmesg log by booting with drm.debug=0xf"
>>>>>> 
>>>>>> void
>>>>>> -__i915_printk(struct drm_i915_private *dev_priv, const char *level,
>>>>>> +__i915_printk(struct drm_i915_private *i915, const char *level,
>>>>>>              const char *fmt, ...)
>>>>>> {
>>>>>> -       static bool shown_bug_once;
>>>>>> -       struct device *kdev = dev_priv->drm.dev;
>>>>>> +       struct device *kdev = i915->drm.dev;
>>>>>>        bool is_error = level[1] <= KERN_ERR[1];
>>>>>>        bool is_debug = level[1] == KERN_DEBUG[1];
>>>>>>        struct va_format vaf;
>>>>>> @@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>>>>>> 
>>>>>>        va_end(args);
>>>>>> 
>>>>>> -       if (is_error && !shown_bug_once) {
>>>>>> +       if (is_error && !i915->shown_bug_once) {
>>>>>>                /*
>>>>>>                 * Ask the user to file a bug report for the error, except
>>>>>>                 * if they may have caused the bug by fiddling with unsafe
>>>>>> @@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>>>>>>                 */
>>>>>>                if (!test_taint(TAINT_USER))
>>>>>>                        dev_notice(kdev, "%s", FDO_BUG_MSG);
>>>>> 
>>>>> I feel this plea to the users to file a bug report should be a one-time
>>>>> thing; a true global.
>>>> 
>>>> Fair enough.
>>>> 
>>>> I am wondering if we should have a convention of naming or commenting
>>>> legit globals, both to help automation detecting new accidental ones,
>>>> and to help people figure out not to send another conversion patch such
>>>> as this.
>>> 
>>> global_i915_show_bug_once
>>> module_i915_show_bug_once
>> 
>> I'd be fine with either of the prefixes. Or i915_{global,module}_ for
> 
> My vote goes for i915_global_* or global_i915_* (if we could get some
> Kbuild infrastructure behind detecting global variables).

any of the provided options or combinations works for me. probably global
will be less confusing...

> 
> Regards, Joonas

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: make debug printer shown_bug_once variable to drm_i915_private
  2019-12-11 15:25           ` Joonas Lahtinen
  2019-12-12  7:33             ` Vivi, Rodrigo
@ 2019-12-12  7:34             ` Jani Nikula
  1 sibling, 0 replies; 20+ messages in thread
From: Jani Nikula @ 2019-12-12  7:34 UTC (permalink / raw)
  To: Joonas Lahtinen, Chris Wilson, intel-gfx

On Wed, 11 Dec 2019, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> Quoting Jani Nikula (2019-12-11 12:36:10)
>> On Fri, 15 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > Quoting Jani Nikula (2019-11-15 11:04:28)
>> >> On Fri, 15 Nov 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> >> > Quoting Jani Nikula (2019-11-15 10:18:40)
>> >> >> Get rid of the module specific static variable.
>> >> >> 
>> >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> >> >> ---
>> >> >>  drivers/gpu/drm/i915/i915_drv.h   | 2 ++
>> >> >>  drivers/gpu/drm/i915/i915_utils.c | 9 ++++-----
>> >> >>  2 files changed, 6 insertions(+), 5 deletions(-)
>> >> >> 
>> >> >> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> >> >> index 1779f600fcfb..e11ee3268ae3 100644
>> >> >> --- a/drivers/gpu/drm/i915/i915_drv.h
>> >> >> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> >> >> @@ -1283,6 +1283,8 @@ struct drm_i915_private {
>> >> >>         /* Mutex to protect the above hdcp component related values. */
>> >> >>         struct mutex hdcp_comp_mutex;
>> >> >>  
>> >> >> +       bool shown_bug_once;
>> >> >> +
>> >> >>         I915_SELFTEST_DECLARE(struct i915_selftest_stash selftest;)
>> >> >>  
>> >> >>         /*
>> >> >> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
>> >> >> index c47261ae86ea..f434274b0b29 100644
>> >> >> --- a/drivers/gpu/drm/i915/i915_utils.c
>> >> >> +++ b/drivers/gpu/drm/i915/i915_utils.c
>> >> >> @@ -13,11 +13,10 @@
>> >> >>                     "providing the dmesg log by booting with drm.debug=0xf"
>> >> >>  
>> >> >>  void
>> >> >> -__i915_printk(struct drm_i915_private *dev_priv, const char *level,
>> >> >> +__i915_printk(struct drm_i915_private *i915, const char *level,
>> >> >>               const char *fmt, ...)
>> >> >>  {
>> >> >> -       static bool shown_bug_once;
>> >> >> -       struct device *kdev = dev_priv->drm.dev;
>> >> >> +       struct device *kdev = i915->drm.dev;
>> >> >>         bool is_error = level[1] <= KERN_ERR[1];
>> >> >>         bool is_debug = level[1] == KERN_DEBUG[1];
>> >> >>         struct va_format vaf;
>> >> >> @@ -39,7 +38,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>> >> >>  
>> >> >>         va_end(args);
>> >> >>  
>> >> >> -       if (is_error && !shown_bug_once) {
>> >> >> +       if (is_error && !i915->shown_bug_once) {
>> >> >>                 /*
>> >> >>                  * Ask the user to file a bug report for the error, except
>> >> >>                  * if they may have caused the bug by fiddling with unsafe
>> >> >> @@ -47,7 +46,7 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>> >> >>                  */
>> >> >>                 if (!test_taint(TAINT_USER))
>> >> >>                         dev_notice(kdev, "%s", FDO_BUG_MSG);
>> >> >
>> >> > I feel this plea to the users to file a bug report should be a one-time
>> >> > thing; a true global.
>> >> 
>> >> Fair enough.
>> >> 
>> >> I am wondering if we should have a convention of naming or commenting
>> >> legit globals, both to help automation detecting new accidental ones,
>> >> and to help people figure out not to send another conversion patch such
>> >> as this.
>> >
>> > global_i915_show_bug_once
>> > module_i915_show_bug_once
>> 
>> I'd be fine with either of the prefixes. Or i915_{global,module}_ for
>
> My vote goes for i915_global_* or global_i915_* (if we could get some
> Kbuild infrastructure behind detecting global variables).

Chris suggested simply module_ or global_ on IRC (without i915 to not
mislead to thinking it's about the i915 instance). I tend to lean
towards module_ a bit because global implies visibility while here we do
mean static variables too.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 20+ messages in thread
end of thread, other threads:[~2019-12-12  7:34 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15 10:18 [PATCH 1/2] drm/i915: move power domains dumped variable to drm_i915_private Jani Nikula
2019-11-15 10:18 ` [Intel-gfx] " Jani Nikula
2019-11-15 10:18 ` [PATCH 2/2] drm/i915: make debug printer shown_bug_once " Jani Nikula
2019-11-15 10:18   ` [Intel-gfx] " Jani Nikula
2019-11-15 10:20   ` Jani Nikula
2019-11-15 10:20     ` [Intel-gfx] " Jani Nikula
2019-11-15 10:21   ` Chris Wilson
2019-11-15 10:21     ` [Intel-gfx] " Chris Wilson
2019-11-15 11:04     ` Jani Nikula
2019-11-15 11:04       ` [Intel-gfx] " Jani Nikula
2019-11-15 11:08       ` Chris Wilson
2019-11-15 11:08         ` [Intel-gfx] " Chris Wilson
2019-12-11 10:36         ` Jani Nikula
2019-12-11 15:25           ` Joonas Lahtinen
2019-12-12  7:33             ` Vivi, Rodrigo
2019-12-12  7:34             ` Jani Nikula
2019-11-15 12:05 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: move power domains dumped " Patchwork
2019-11-15 12:05   ` [Intel-gfx] " Patchwork
2019-11-16 16:36 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-16 16:36   ` [Intel-gfx] " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.