* [PATCH v1] media: venus: firmware: Use %pR to print IO resource
@ 2019-11-15 14:30 Andy Shevchenko
2020-01-08 13:37 ` Andy Shevchenko
2020-01-08 14:02 ` Stanimir Varbanov
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2019-11-15 14:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, linux-media, Mauro Carvalho Chehab
Cc: Andy Shevchenko
Replace explicit use of members of struct resource by %pR to print
the resource.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/media/platform/qcom/venus/firmware.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c
index d3d1748a7ef6..de6812fb55f4 100644
--- a/drivers/media/platform/qcom/venus/firmware.c
+++ b/drivers/media/platform/qcom/venus/firmware.c
@@ -100,8 +100,7 @@ static int venus_load_fw(struct venus_core *core, const char *fwname,
mem_va = memremap(r.start, *mem_size, MEMREMAP_WC);
if (!mem_va) {
- dev_err(dev, "unable to map memory region: %pa+%zx\n",
- &r.start, *mem_size);
+ dev_err(dev, "unable to map memory region: %pR\n", &r);
ret = -ENOMEM;
goto err_release_fw;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] media: venus: firmware: Use %pR to print IO resource
2019-11-15 14:30 [PATCH v1] media: venus: firmware: Use %pR to print IO resource Andy Shevchenko
@ 2020-01-08 13:37 ` Andy Shevchenko
2020-01-08 14:02 ` Stanimir Varbanov
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-01-08 13:37 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, linux-media, Mauro Carvalho Chehab
On Fri, Nov 15, 2019 at 04:30:44PM +0200, Andy Shevchenko wrote:
> Replace explicit use of members of struct resource by %pR to print
> the resource.
Any comment on this?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/media/platform/qcom/venus/firmware.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c
> index d3d1748a7ef6..de6812fb55f4 100644
> --- a/drivers/media/platform/qcom/venus/firmware.c
> +++ b/drivers/media/platform/qcom/venus/firmware.c
> @@ -100,8 +100,7 @@ static int venus_load_fw(struct venus_core *core, const char *fwname,
>
> mem_va = memremap(r.start, *mem_size, MEMREMAP_WC);
> if (!mem_va) {
> - dev_err(dev, "unable to map memory region: %pa+%zx\n",
> - &r.start, *mem_size);
> + dev_err(dev, "unable to map memory region: %pR\n", &r);
> ret = -ENOMEM;
> goto err_release_fw;
> }
> --
> 2.24.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] media: venus: firmware: Use %pR to print IO resource
2019-11-15 14:30 [PATCH v1] media: venus: firmware: Use %pR to print IO resource Andy Shevchenko
2020-01-08 13:37 ` Andy Shevchenko
@ 2020-01-08 14:02 ` Stanimir Varbanov
1 sibling, 0 replies; 3+ messages in thread
From: Stanimir Varbanov @ 2020-01-08 14:02 UTC (permalink / raw)
To: Andy Shevchenko, Andy Gross, Bjorn Andersson, linux-media,
Mauro Carvalho Chehab
Hi Andy,
Thanks for the patch!
On 11/15/19 4:30 PM, Andy Shevchenko wrote:
> Replace explicit use of members of struct resource by %pR to print
> the resource.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/media/platform/qcom/venus/firmware.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>
> diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c
> index d3d1748a7ef6..de6812fb55f4 100644
> --- a/drivers/media/platform/qcom/venus/firmware.c
> +++ b/drivers/media/platform/qcom/venus/firmware.c
> @@ -100,8 +100,7 @@ static int venus_load_fw(struct venus_core *core, const char *fwname,
>
> mem_va = memremap(r.start, *mem_size, MEMREMAP_WC);
> if (!mem_va) {
> - dev_err(dev, "unable to map memory region: %pa+%zx\n",
> - &r.start, *mem_size);
> + dev_err(dev, "unable to map memory region: %pR\n", &r);
> ret = -ENOMEM;
> goto err_release_fw;
> }
>
--
regards,
Stan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-08 14:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15 14:30 [PATCH v1] media: venus: firmware: Use %pR to print IO resource Andy Shevchenko
2020-01-08 13:37 ` Andy Shevchenko
2020-01-08 14:02 ` Stanimir Varbanov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.