* [PATCH v1 0/1] hw/arm: versal: Add the CRP as unimplemented
@ 2019-11-15 15:47 Edgar E. Iglesias
2019-11-15 15:47 ` [PATCH v1 1/1] " Edgar E. Iglesias
2019-11-15 18:12 ` [PATCH v1 0/1] " no-reply
0 siblings, 2 replies; 8+ messages in thread
From: Edgar E. Iglesias @ 2019-11-15 15:47 UTC (permalink / raw)
To: qemu-devel
Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias,
sai.pavan.boddu, frasse.iglesias, alistair, richard.henderson,
frederic.konrad, qemu-arm, philmd, luc.michel
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Some boot-loaders will access the CRP block and bug out
if recieving bus errors. Since we're in freeze, this does
not try to add a model of the CRP instead we only add it
as unimplemented. This is enough to work around the issue.
Cheers,
Edgar
Edgar E. Iglesias (1):
hw/arm: versal: Add the CRP as unimplemented
hw/arm/xlnx-versal.c | 2 ++
include/hw/arm/xlnx-versal.h | 3 +++
2 files changed, 5 insertions(+)
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1 1/1] hw/arm: versal: Add the CRP as unimplemented
2019-11-15 15:47 [PATCH v1 0/1] hw/arm: versal: Add the CRP as unimplemented Edgar E. Iglesias
@ 2019-11-15 15:47 ` Edgar E. Iglesias
2019-11-15 16:44 ` Alistair Francis
` (2 more replies)
2019-11-15 18:12 ` [PATCH v1 0/1] " no-reply
1 sibling, 3 replies; 8+ messages in thread
From: Edgar E. Iglesias @ 2019-11-15 15:47 UTC (permalink / raw)
To: qemu-devel
Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias,
sai.pavan.boddu, frasse.iglesias, alistair, richard.henderson,
frederic.konrad, qemu-arm, philmd, luc.michel
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Add the CRP as unimplemented thus avoiding bus errors when
guests access these registers.
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
hw/arm/xlnx-versal.c | 2 ++
include/hw/arm/xlnx-versal.h | 3 +++
2 files changed, 5 insertions(+)
diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c
index 98163eb1aa..8b3d8d85b8 100644
--- a/hw/arm/xlnx-versal.c
+++ b/hw/arm/xlnx-versal.c
@@ -257,6 +257,8 @@ static void versal_unimp(Versal *s)
MM_CRL, MM_CRL_SIZE);
versal_unimp_area(s, "crf", &s->mr_ps,
MM_FPD_CRF, MM_FPD_CRF_SIZE);
+ versal_unimp_area(s, "crp", &s->mr_ps,
+ MM_PMC_CRP, MM_PMC_CRP_SIZE);
versal_unimp_area(s, "iou-scntr", &s->mr_ps,
MM_IOU_SCNTR, MM_IOU_SCNTR_SIZE);
versal_unimp_area(s, "iou-scntr-seucre", &s->mr_ps,
diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h
index 14405c1465..d844c4ffe4 100644
--- a/include/hw/arm/xlnx-versal.h
+++ b/include/hw/arm/xlnx-versal.h
@@ -119,4 +119,7 @@ typedef struct Versal {
#define MM_IOU_SCNTRS_SIZE 0x10000
#define MM_FPD_CRF 0xfd1a0000U
#define MM_FPD_CRF_SIZE 0x140000
+
+#define MM_PMC_CRP 0xf1260000U
+#define MM_PMC_CRP_SIZE 0x10000
#endif
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/1] hw/arm: versal: Add the CRP as unimplemented
2019-11-15 15:47 ` [PATCH v1 1/1] " Edgar E. Iglesias
@ 2019-11-15 16:44 ` Alistair Francis
2019-11-15 20:20 ` Luc Michel
2019-11-21 15:28 ` Edgar E. Iglesias
2 siblings, 0 replies; 8+ messages in thread
From: Alistair Francis @ 2019-11-15 16:44 UTC (permalink / raw)
To: Edgar E. Iglesias
Cc: figlesia, Peter Maydell, Edgar Iglesias, Sai Pavan Boddu,
Francisco Iglesias, Alistair Francis, Richard Henderson,
qemu-devel@nongnu.org Developers, KONRAD Frederic,
Stefano Stabellini, qemu-arm, Philippe Mathieu-Daudé,
Luc Michel
On Fri, Nov 15, 2019 at 10:50 AM Edgar E. Iglesias
<edgar.iglesias@gmail.com> wrote:
>
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Add the CRP as unimplemented thus avoiding bus errors when
> guests access these registers.
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/arm/xlnx-versal.c | 2 ++
> include/hw/arm/xlnx-versal.h | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c
> index 98163eb1aa..8b3d8d85b8 100644
> --- a/hw/arm/xlnx-versal.c
> +++ b/hw/arm/xlnx-versal.c
> @@ -257,6 +257,8 @@ static void versal_unimp(Versal *s)
> MM_CRL, MM_CRL_SIZE);
> versal_unimp_area(s, "crf", &s->mr_ps,
> MM_FPD_CRF, MM_FPD_CRF_SIZE);
> + versal_unimp_area(s, "crp", &s->mr_ps,
> + MM_PMC_CRP, MM_PMC_CRP_SIZE);
> versal_unimp_area(s, "iou-scntr", &s->mr_ps,
> MM_IOU_SCNTR, MM_IOU_SCNTR_SIZE);
> versal_unimp_area(s, "iou-scntr-seucre", &s->mr_ps,
> diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h
> index 14405c1465..d844c4ffe4 100644
> --- a/include/hw/arm/xlnx-versal.h
> +++ b/include/hw/arm/xlnx-versal.h
> @@ -119,4 +119,7 @@ typedef struct Versal {
> #define MM_IOU_SCNTRS_SIZE 0x10000
> #define MM_FPD_CRF 0xfd1a0000U
> #define MM_FPD_CRF_SIZE 0x140000
> +
> +#define MM_PMC_CRP 0xf1260000U
> +#define MM_PMC_CRP_SIZE 0x10000
> #endif
> --
> 2.20.1
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 0/1] hw/arm: versal: Add the CRP as unimplemented
2019-11-15 15:47 [PATCH v1 0/1] hw/arm: versal: Add the CRP as unimplemented Edgar E. Iglesias
2019-11-15 15:47 ` [PATCH v1 1/1] " Edgar E. Iglesias
@ 2019-11-15 18:12 ` no-reply
2019-11-15 20:13 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 8+ messages in thread
From: no-reply @ 2019-11-15 18:12 UTC (permalink / raw)
To: edgar.iglesias
Cc: figlesia, peter.maydell, edgar.iglesias, sai.pavan.boddu,
frasse.iglesias, alistair, richard.henderson, qemu-devel,
frederic.konrad, sstabellini, qemu-arm, philmd, luc.michel
Patchew URL: https://patchew.org/QEMU/20191115154734.26449-1-edgar.iglesias@gmail.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===
The full log is available at
http://patchew.org/logs/20191115154734.26449-1-edgar.iglesias@gmail.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 0/1] hw/arm: versal: Add the CRP as unimplemented
2019-11-15 18:12 ` [PATCH v1 0/1] " no-reply
@ 2019-11-15 20:13 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-11-15 20:13 UTC (permalink / raw)
To: qemu-devel, no-reply, edgar.iglesias
Cc: figlesia, peter.maydell, edgar.iglesias, sai.pavan.boddu,
frasse.iglesias, alistair, richard.henderson, frederic.konrad,
sstabellini, qemu-arm, luc.michel
On 11/15/19 7:12 PM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20191115154734.26449-1-edgar.iglesias@gmail.com/
>
> This series failed the docker-quick@centos7 build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
>
[...]
> The full log is available at
> http://patchew.org/logs/20191115154734.26449-1-edgar.iglesias@gmail.com/testing.docker-quick@centos7/?type=message.
Unrelated error:
From https://github.com/patchew-project/qemu
* [new tag]
patchew/20191115154734.26449-1-edgar.iglesias@gmail.com ->
patchew/20191115154734.26449-1-edgar.iglesias@gmail.com
fatal: failed to write ref-pack file
fatal: The remote end hung up unexpectedly
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/1] hw/arm: versal: Add the CRP as unimplemented
2019-11-15 15:47 ` [PATCH v1 1/1] " Edgar E. Iglesias
2019-11-15 16:44 ` Alistair Francis
@ 2019-11-15 20:20 ` Luc Michel
2019-11-21 15:28 ` Edgar E. Iglesias
2 siblings, 0 replies; 8+ messages in thread
From: Luc Michel @ 2019-11-15 20:20 UTC (permalink / raw)
To: Edgar E. Iglesias, qemu-devel
Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias,
sai.pavan.boddu, frasse.iglesias, alistair, richard.henderson,
frederic.konrad, qemu-arm, philmd
On 11/15/19 4:47 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Add the CRP as unimplemented thus avoiding bus errors when
> guests access these registers.
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Luc Michel <luc.michel@greensocs.com>
> ---
> hw/arm/xlnx-versal.c | 2 ++
> include/hw/arm/xlnx-versal.h | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c
> index 98163eb1aa..8b3d8d85b8 100644
> --- a/hw/arm/xlnx-versal.c
> +++ b/hw/arm/xlnx-versal.c
> @@ -257,6 +257,8 @@ static void versal_unimp(Versal *s)
> MM_CRL, MM_CRL_SIZE);
> versal_unimp_area(s, "crf", &s->mr_ps,
> MM_FPD_CRF, MM_FPD_CRF_SIZE);
> + versal_unimp_area(s, "crp", &s->mr_ps,
> + MM_PMC_CRP, MM_PMC_CRP_SIZE);
> versal_unimp_area(s, "iou-scntr", &s->mr_ps,
> MM_IOU_SCNTR, MM_IOU_SCNTR_SIZE);
> versal_unimp_area(s, "iou-scntr-seucre", &s->mr_ps,
> diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h
> index 14405c1465..d844c4ffe4 100644
> --- a/include/hw/arm/xlnx-versal.h
> +++ b/include/hw/arm/xlnx-versal.h
> @@ -119,4 +119,7 @@ typedef struct Versal {
> #define MM_IOU_SCNTRS_SIZE 0x10000
> #define MM_FPD_CRF 0xfd1a0000U
> #define MM_FPD_CRF_SIZE 0x140000
> +
> +#define MM_PMC_CRP 0xf1260000U
> +#define MM_PMC_CRP_SIZE 0x10000
> #endif
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/1] hw/arm: versal: Add the CRP as unimplemented
2019-11-15 15:47 ` [PATCH v1 1/1] " Edgar E. Iglesias
2019-11-15 16:44 ` Alistair Francis
2019-11-15 20:20 ` Luc Michel
@ 2019-11-21 15:28 ` Edgar E. Iglesias
2019-11-21 15:32 ` Peter Maydell
2 siblings, 1 reply; 8+ messages in thread
From: Edgar E. Iglesias @ 2019-11-21 15:28 UTC (permalink / raw)
To: peter.maydell
Cc: figlesia, peter.maydell, sstabellini, sai.pavan.boddu,
frasse.iglesias, alistair, richard.henderson, qemu-devel,
frederic.konrad, qemu-arm, philmd, luc.michel
Hi Peter,
Can we consider this patch for 4.2?
Thanks,
Edgar
On Fri, Nov 15, 2019 at 04:47:34PM +0100, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Add the CRP as unimplemented thus avoiding bus errors when
> guests access these registers.
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> ---
> hw/arm/xlnx-versal.c | 2 ++
> include/hw/arm/xlnx-versal.h | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c
> index 98163eb1aa..8b3d8d85b8 100644
> --- a/hw/arm/xlnx-versal.c
> +++ b/hw/arm/xlnx-versal.c
> @@ -257,6 +257,8 @@ static void versal_unimp(Versal *s)
> MM_CRL, MM_CRL_SIZE);
> versal_unimp_area(s, "crf", &s->mr_ps,
> MM_FPD_CRF, MM_FPD_CRF_SIZE);
> + versal_unimp_area(s, "crp", &s->mr_ps,
> + MM_PMC_CRP, MM_PMC_CRP_SIZE);
> versal_unimp_area(s, "iou-scntr", &s->mr_ps,
> MM_IOU_SCNTR, MM_IOU_SCNTR_SIZE);
> versal_unimp_area(s, "iou-scntr-seucre", &s->mr_ps,
> diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h
> index 14405c1465..d844c4ffe4 100644
> --- a/include/hw/arm/xlnx-versal.h
> +++ b/include/hw/arm/xlnx-versal.h
> @@ -119,4 +119,7 @@ typedef struct Versal {
> #define MM_IOU_SCNTRS_SIZE 0x10000
> #define MM_FPD_CRF 0xfd1a0000U
> #define MM_FPD_CRF_SIZE 0x140000
> +
> +#define MM_PMC_CRP 0xf1260000U
> +#define MM_PMC_CRP_SIZE 0x10000
> #endif
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/1] hw/arm: versal: Add the CRP as unimplemented
2019-11-21 15:28 ` Edgar E. Iglesias
@ 2019-11-21 15:32 ` Peter Maydell
0 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2019-11-21 15:32 UTC (permalink / raw)
To: Edgar E. Iglesias
Cc: figlesia, Stefano Stabellini, Sai Pavan Boddu,
Francisco Iglesias, Alistair Francis, Richard Henderson,
QEMU Developers, KONRAD Frederic, qemu-arm,
Philippe Mathieu-Daudé,
Luc Michel
On Thu, 21 Nov 2019 at 15:28, Edgar E. Iglesias
<edgar.iglesias@xilinx.com> wrote:
>
> Hi Peter,
>
> Can we consider this patch for 4.2?
Sure, it looks pretty safe. I've applied it to my queue
for rc3.
thanks
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-11-21 15:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15 15:47 [PATCH v1 0/1] hw/arm: versal: Add the CRP as unimplemented Edgar E. Iglesias
2019-11-15 15:47 ` [PATCH v1 1/1] " Edgar E. Iglesias
2019-11-15 16:44 ` Alistair Francis
2019-11-15 20:20 ` Luc Michel
2019-11-21 15:28 ` Edgar E. Iglesias
2019-11-21 15:32 ` Peter Maydell
2019-11-15 18:12 ` [PATCH v1 0/1] " no-reply
2019-11-15 20:13 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.