* [U-Boot] [PATCH v2] spl: Introduce SPL_DM_GPIO Kconfig define
@ 2019-09-29 15:54 Lukasz Majewski
2019-10-09 9:02 ` Lukasz Majewski
0 siblings, 1 reply; 8+ messages in thread
From: Lukasz Majewski @ 2019-09-29 15:54 UTC (permalink / raw)
To: u-boot
This define indicates if DM_GPIO shall be supported in SPL. This allows
proper operation of DM converted GPIO drivers in SPL, which use
boards.
Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
Changes in v2:
- Add dependency on DM_GPIO
common/spl/Kconfig | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/common/spl/Kconfig b/common/spl/Kconfig
index f467eca2be..e3df8efa7e 100644
--- a/common/spl/Kconfig
+++ b/common/spl/Kconfig
@@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
the CPU moving the data. Enable this option to build the drivers
in drivers/dma as part of an SPL build.
+config SPL_DM_GPIO
+ bool "Support Driver Model GPIO drivers"
+ depends on SPL_GPIO_SUPPORT && DM_GPIO
+ help
+ Enable support for Driver Model based GPIO drivers in SPL.
+
config SPL_DRIVERS_MISC_SUPPORT
bool "Support misc drivers"
help
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2] spl: Introduce SPL_DM_GPIO Kconfig define
2019-09-29 15:54 [U-Boot] [PATCH v2] spl: Introduce SPL_DM_GPIO Kconfig define Lukasz Majewski
@ 2019-10-09 9:02 ` Lukasz Majewski
2019-10-11 23:01 ` Simon Glass
0 siblings, 1 reply; 8+ messages in thread
From: Lukasz Majewski @ 2019-10-09 9:02 UTC (permalink / raw)
To: u-boot
Dear Tom,
> This define indicates if DM_GPIO shall be supported in SPL. This
> allows proper operation of DM converted GPIO drivers in SPL, which use
> boards.
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>
> Changes in v2:
> - Add dependency on DM_GPIO
>
Tom, are there any issues preventing this patch from being applied to
-master?
> common/spl/Kconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> index f467eca2be..e3df8efa7e 100644
> --- a/common/spl/Kconfig
> +++ b/common/spl/Kconfig
> @@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
> the CPU moving the data. Enable this option to build the
> drivers in drivers/dma as part of an SPL build.
>
> +config SPL_DM_GPIO
> + bool "Support Driver Model GPIO drivers"
> + depends on SPL_GPIO_SUPPORT && DM_GPIO
> + help
> + Enable support for Driver Model based GPIO drivers in SPL.
> +
> config SPL_DRIVERS_MISC_SUPPORT
> bool "Support misc drivers"
> help
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191009/7d626b05/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2] spl: Introduce SPL_DM_GPIO Kconfig define
2019-10-09 9:02 ` Lukasz Majewski
@ 2019-10-11 23:01 ` Simon Glass
2019-10-14 12:41 ` Lukasz Majewski
0 siblings, 1 reply; 8+ messages in thread
From: Simon Glass @ 2019-10-11 23:01 UTC (permalink / raw)
To: u-boot
Hi Lukasz,
On Wed, 9 Oct 2019 at 03:02, Lukasz Majewski <lukma@denx.de> wrote:
>
> Dear Tom,
>
> > This define indicates if DM_GPIO shall be supported in SPL. This
> > allows proper operation of DM converted GPIO drivers in SPL, which use
> > boards.
> >
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> >
> > Changes in v2:
> > - Add dependency on DM_GPIO
> >
>
> Tom, are there any issues preventing this patch from being applied to
> -master?
This does not actually define DM_GPIO anywhere though, so this is unused.
As it happens I sent a similar patch[1], but it doesn't work. I'll try again.
>
> > common/spl/Kconfig | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> > index f467eca2be..e3df8efa7e 100644
> > --- a/common/spl/Kconfig
> > +++ b/common/spl/Kconfig
> > @@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
> > the CPU moving the data. Enable this option to build the
> > drivers in drivers/dma as part of an SPL build.
> >
> > +config SPL_DM_GPIO
> > + bool "Support Driver Model GPIO drivers"
> > + depends on SPL_GPIO_SUPPORT && DM_GPIO
> > + help
> > + Enable support for Driver Model based GPIO drivers in SPL.
> > +
> > config SPL_DRIVERS_MISC_SUPPORT
> > bool "Support misc drivers"
> > help
>
Regards,
SImon
[1] http://patchwork.ozlabs.org/patch/1167276/
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2] spl: Introduce SPL_DM_GPIO Kconfig define
2019-10-11 23:01 ` Simon Glass
@ 2019-10-14 12:41 ` Lukasz Majewski
2019-10-16 3:40 ` Simon Glass
0 siblings, 1 reply; 8+ messages in thread
From: Lukasz Majewski @ 2019-10-14 12:41 UTC (permalink / raw)
To: u-boot
Hi Simon,
> Hi Lukasz,
>
> On Wed, 9 Oct 2019 at 03:02, Lukasz Majewski <lukma@denx.de> wrote:
> >
> > Dear Tom,
> >
> > > This define indicates if DM_GPIO shall be supported in SPL. This
> > > allows proper operation of DM converted GPIO drivers in SPL,
> > > which use boards.
> > >
> > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > ---
> > >
> > > Changes in v2:
> > > - Add dependency on DM_GPIO
> > >
> >
> > Tom, are there any issues preventing this patch from being applied
> > to -master?
>
> This does not actually define DM_GPIO anywhere though, so this is
> unused.
The goal of this patch is to introduce in Kconfig a CONFIG_SPL_DM_GPIO.
This define would be needed anyway, no matter if you perform the
changes from [1].
This Kconfig define is necessary for the XEA board (i.MX28 based one),
which uses OF_PLATDATA in SPL excessively to fit into size constraints.
To be more precise the mxs_gpio.c driver uses
#if CONFIG_IS_ENABLED(DM_GPIO) to provide DM GPIO support in SPL with
OF_PLATDATA.
>
> As it happens I sent a similar patch[1], but it doesn't work. I'll
> try again.
It would be great if we could have [1] not causing build breaks.
However, for my used case it would be enough to have the Kconfig
definition of CONFIG_SPL_DM_GPIO (as I'm using OF_PLATDATA) with it.
Simon, if you don't have time to do the fix for [1] I would opt for
pulling this patch (to just add proper Kconfig define).
>
> >
> > > common/spl/Kconfig | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> > > index f467eca2be..e3df8efa7e 100644
> > > --- a/common/spl/Kconfig
> > > +++ b/common/spl/Kconfig
> > > @@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
> > > the CPU moving the data. Enable this option to build the
> > > drivers in drivers/dma as part of an SPL build.
> > >
> > > +config SPL_DM_GPIO
> > > + bool "Support Driver Model GPIO drivers"
> > > + depends on SPL_GPIO_SUPPORT && DM_GPIO
> > > + help
> > > + Enable support for Driver Model based GPIO drivers in SPL.
> > > +
> > > config SPL_DRIVERS_MISC_SUPPORT
> > > bool "Support misc drivers"
> > > help
> >
>
> Regards,
> SImon
>
> [1] http://patchwork.ozlabs.org/patch/1167276/
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191014/36b1bf8f/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2] spl: Introduce SPL_DM_GPIO Kconfig define
2019-10-14 12:41 ` Lukasz Majewski
@ 2019-10-16 3:40 ` Simon Glass
2019-11-17 20:37 ` Lukasz Majewski
0 siblings, 1 reply; 8+ messages in thread
From: Simon Glass @ 2019-10-16 3:40 UTC (permalink / raw)
To: u-boot
Hi Lukasz,
On Mon, 14 Oct 2019 at 06:41, Lukasz Majewski <lukma@denx.de> wrote:
>
> Hi Simon,
>
> > Hi Lukasz,
> >
> > On Wed, 9 Oct 2019 at 03:02, Lukasz Majewski <lukma@denx.de> wrote:
> > >
> > > Dear Tom,
> > >
> > > > This define indicates if DM_GPIO shall be supported in SPL. This
> > > > allows proper operation of DM converted GPIO drivers in SPL,
> > > > which use boards.
> > > >
> > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > > ---
> > > >
> > > > Changes in v2:
> > > > - Add dependency on DM_GPIO
> > > >
> > >
> > > Tom, are there any issues preventing this patch from being applied
> > > to -master?
> >
> > This does not actually define DM_GPIO anywhere though, so this is
> > unused.
>
> The goal of this patch is to introduce in Kconfig a CONFIG_SPL_DM_GPIO.
> This define would be needed anyway, no matter if you perform the
> changes from [1].
>
> This Kconfig define is necessary for the XEA board (i.MX28 based one),
> which uses OF_PLATDATA in SPL excessively to fit into size constraints.
>
> To be more precise the mxs_gpio.c driver uses
> #if CONFIG_IS_ENABLED(DM_GPIO) to provide DM GPIO support in SPL with
> OF_PLATDATA.
>
>
> >
> > As it happens I sent a similar patch[1], but it doesn't work. I'll
> > try again.
>
> It would be great if we could have [1] not causing build breaks.
> However, for my used case it would be enough to have the Kconfig
> definition of CONFIG_SPL_DM_GPIO (as I'm using OF_PLATDATA) with it.
>
> Simon, if you don't have time to do the fix for [1] I would opt for
> pulling this patch (to just add proper Kconfig define).
I have had a crack at this here:
https://gitlab.denx.de/u-boot/custodians/u-boot-dm/commit/a6d15bbd9e4e7684dd47d21817df85915f28cbab
I expect to send this series along with this patch at the end of this week.
>
> >
> > >
> > > > common/spl/Kconfig | 6 ++++++
> > > > 1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> > > > index f467eca2be..e3df8efa7e 100644
> > > > --- a/common/spl/Kconfig
> > > > +++ b/common/spl/Kconfig
> > > > @@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
> > > > the CPU moving the data. Enable this option to build the
> > > > drivers in drivers/dma as part of an SPL build.
> > > >
> > > > +config SPL_DM_GPIO
> > > > + bool "Support Driver Model GPIO drivers"
> > > > + depends on SPL_GPIO_SUPPORT && DM_GPIO
> > > > + help
> > > > + Enable support for Driver Model based GPIO drivers in SPL.
> > > > +
> > > > config SPL_DRIVERS_MISC_SUPPORT
> > > > bool "Support misc drivers"
> > > > help
> > >
> >
> > Regards,
> > SImon
> >
> > [1] http://patchwork.ozlabs.org/patch/1167276/
>
Regards,
Simon
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2] spl: Introduce SPL_DM_GPIO Kconfig define
2019-10-16 3:40 ` Simon Glass
@ 2019-11-17 20:37 ` Lukasz Majewski
2019-11-17 20:54 ` Lukasz Majewski
0 siblings, 1 reply; 8+ messages in thread
From: Lukasz Majewski @ 2019-11-17 20:37 UTC (permalink / raw)
To: u-boot
Hi Simon,
> Hi Lukasz,
>
> On Mon, 14 Oct 2019 at 06:41, Lukasz Majewski <lukma@denx.de> wrote:
> >
> > Hi Simon,
> >
> > > Hi Lukasz,
> > >
> > > On Wed, 9 Oct 2019 at 03:02, Lukasz Majewski <lukma@denx.de>
> > > wrote:
> > > >
> > > > Dear Tom,
> > > >
> > > > > This define indicates if DM_GPIO shall be supported in SPL.
> > > > > This allows proper operation of DM converted GPIO drivers in
> > > > > SPL, which use boards.
> > > > >
> > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > > > ---
> > > > >
> > > > > Changes in v2:
> > > > > - Add dependency on DM_GPIO
> > > > >
> > > >
> > > > Tom, are there any issues preventing this patch from being
> > > > applied to -master?
> > >
> > > This does not actually define DM_GPIO anywhere though, so this is
> > > unused.
> >
> > The goal of this patch is to introduce in Kconfig a
> > CONFIG_SPL_DM_GPIO. This define would be needed anyway, no matter
> > if you perform the changes from [1].
> >
> > This Kconfig define is necessary for the XEA board (i.MX28 based
> > one), which uses OF_PLATDATA in SPL excessively to fit into size
> > constraints.
> >
> > To be more precise the mxs_gpio.c driver uses
> > #if CONFIG_IS_ENABLED(DM_GPIO) to provide DM GPIO support in SPL
> > with OF_PLATDATA.
> >
> >
> > >
> > > As it happens I sent a similar patch[1], but it doesn't work. I'll
> > > try again.
> >
> > It would be great if we could have [1] not causing build breaks.
> > However, for my used case it would be enough to have the Kconfig
> > definition of CONFIG_SPL_DM_GPIO (as I'm using OF_PLATDATA) with it.
> >
> > Simon, if you don't have time to do the fix for [1] I would opt for
> > pulling this patch (to just add proper Kconfig define).
>
> I have had a crack at this here:
>
> https://gitlab.denx.de/u-boot/custodians/u-boot-dm/commit/a6d15bbd9e4e7684dd47d21817df85915f28cbab
>
> I expect to send this series along with this patch at the end of this
> week.
If I may ask - have you made any progress on this?
>
> >
> > >
> > > >
> > > > > common/spl/Kconfig | 6 ++++++
> > > > > 1 file changed, 6 insertions(+)
> > > > >
> > > > > diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> > > > > index f467eca2be..e3df8efa7e 100644
> > > > > --- a/common/spl/Kconfig
> > > > > +++ b/common/spl/Kconfig
> > > > > @@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
> > > > > the CPU moving the data. Enable this option to build
> > > > > the drivers in drivers/dma as part of an SPL build.
> > > > >
> > > > > +config SPL_DM_GPIO
> > > > > + bool "Support Driver Model GPIO drivers"
> > > > > + depends on SPL_GPIO_SUPPORT && DM_GPIO
> > > > > + help
> > > > > + Enable support for Driver Model based GPIO drivers in
> > > > > SPL. +
> > > > > config SPL_DRIVERS_MISC_SUPPORT
> > > > > bool "Support misc drivers"
> > > > > help
> > > >
> > >
> > > Regards,
> > > SImon
> > >
> > > [1] http://patchwork.ozlabs.org/patch/1167276/
> >
>
> Regards,
> Simon
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191117/ea4e4fa1/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2] spl: Introduce SPL_DM_GPIO Kconfig define
2019-11-17 20:37 ` Lukasz Majewski
@ 2019-11-17 20:54 ` Lukasz Majewski
2019-12-27 16:42 ` Simon Glass
0 siblings, 1 reply; 8+ messages in thread
From: Lukasz Majewski @ 2019-11-17 20:54 UTC (permalink / raw)
To: u-boot
Hi Simon,
> Hi Simon,
>
> > Hi Lukasz,
> >
> > On Mon, 14 Oct 2019 at 06:41, Lukasz Majewski <lukma@denx.de>
> > wrote:
> > >
> > > Hi Simon,
> > >
> > > > Hi Lukasz,
> > > >
> > > > On Wed, 9 Oct 2019 at 03:02, Lukasz Majewski <lukma@denx.de>
> > > > wrote:
> > > > >
> > > > > Dear Tom,
> > > > >
> > > > > > This define indicates if DM_GPIO shall be supported in SPL.
> > > > > > This allows proper operation of DM converted GPIO drivers in
> > > > > > SPL, which use boards.
> > > > > >
> > > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > > > > ---
> > > > > >
> > > > > > Changes in v2:
> > > > > > - Add dependency on DM_GPIO
> > > > > >
> > > > >
> > > > > Tom, are there any issues preventing this patch from being
> > > > > applied to -master?
> > > >
> > > > This does not actually define DM_GPIO anywhere though, so this
> > > > is unused.
> > >
> > > The goal of this patch is to introduce in Kconfig a
> > > CONFIG_SPL_DM_GPIO. This define would be needed anyway, no matter
> > > if you perform the changes from [1].
> > >
> > > This Kconfig define is necessary for the XEA board (i.MX28 based
> > > one), which uses OF_PLATDATA in SPL excessively to fit into size
> > > constraints.
> > >
> > > To be more precise the mxs_gpio.c driver uses
> > > #if CONFIG_IS_ENABLED(DM_GPIO) to provide DM GPIO support in SPL
> > > with OF_PLATDATA.
> > >
> > >
> > > >
> > > > As it happens I sent a similar patch[1], but it doesn't work.
> > > > I'll try again.
> > >
> > > It would be great if we could have [1] not causing build breaks.
> > > However, for my used case it would be enough to have the Kconfig
> > > definition of CONFIG_SPL_DM_GPIO (as I'm using OF_PLATDATA) with
> > > it.
> > >
> > > Simon, if you don't have time to do the fix for [1] I would opt
> > > for pulling this patch (to just add proper Kconfig define).
> >
> > I have had a crack at this here:
> >
> > https://gitlab.denx.de/u-boot/custodians/u-boot-dm/commit/a6d15bbd9e4e7684dd47d21817df85915f28cbab
> >
> > I expect to send this series along with this patch at the end of
> > this week.
>
> If I may ask - have you made any progress on this?
In fact it blocks some i.MX28 related code (board to be precise) from
sending it upstream as converted drivers expect SPL_DM_GPIO to be
defined in Kconfig.
In fact I do just need following code:
https://patchwork.ozlabs.org/patch/1169013/
If you have some difficulties to solve (on e.g. other archs) then maybe
it would be enough to pull the above patch?
>
> >
> > >
> > > >
> > > > >
> > > > > > common/spl/Kconfig | 6 ++++++
> > > > > > 1 file changed, 6 insertions(+)
> > > > > >
> > > > > > diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> > > > > > index f467eca2be..e3df8efa7e 100644
> > > > > > --- a/common/spl/Kconfig
> > > > > > +++ b/common/spl/Kconfig
> > > > > > @@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
> > > > > > the CPU moving the data. Enable this option to build
> > > > > > the drivers in drivers/dma as part of an SPL build.
> > > > > >
> > > > > > +config SPL_DM_GPIO
> > > > > > + bool "Support Driver Model GPIO drivers"
> > > > > > + depends on SPL_GPIO_SUPPORT && DM_GPIO
> > > > > > + help
> > > > > > + Enable support for Driver Model based GPIO drivers
> > > > > > in SPL. +
> > > > > > config SPL_DRIVERS_MISC_SUPPORT
> > > > > > bool "Support misc drivers"
> > > > > > help
> > > > >
> > > >
> > > > Regards,
> > > > SImon
> > > >
> > > > [1] http://patchwork.ozlabs.org/patch/1167276/
> > >
> >
> > Regards,
> > Simon
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> lukma at denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191117/cdbcf15b/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] spl: Introduce SPL_DM_GPIO Kconfig define
2019-11-17 20:54 ` Lukasz Majewski
@ 2019-12-27 16:42 ` Simon Glass
0 siblings, 0 replies; 8+ messages in thread
From: Simon Glass @ 2019-12-27 16:42 UTC (permalink / raw)
To: u-boot
Hi Lukasz,
On Sun, 17 Nov 2019 at 13:54, Lukasz Majewski <lukma@denx.de> wrote:
>
> Hi Simon,
>
> > Hi Simon,
> >
> > > Hi Lukasz,
> > >
> > > On Mon, 14 Oct 2019 at 06:41, Lukasz Majewski <lukma@denx.de>
> > > wrote:
> > > >
> > > > Hi Simon,
> > > >
> > > > > Hi Lukasz,
> > > > >
> > > > > On Wed, 9 Oct 2019 at 03:02, Lukasz Majewski <lukma@denx.de>
> > > > > wrote:
> > > > > >
> > > > > > Dear Tom,
> > > > > >
> > > > > > > This define indicates if DM_GPIO shall be supported in SPL.
> > > > > > > This allows proper operation of DM converted GPIO drivers in
> > > > > > > SPL, which use boards.
> > > > > > >
> > > > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > > > > > > ---
> > > > > > >
> > > > > > > Changes in v2:
> > > > > > > - Add dependency on DM_GPIO
> > > > > > >
> > > > > >
> > > > > > Tom, are there any issues preventing this patch from being
> > > > > > applied to -master?
> > > > >
> > > > > This does not actually define DM_GPIO anywhere though, so this
> > > > > is unused.
> > > >
> > > > The goal of this patch is to introduce in Kconfig a
> > > > CONFIG_SPL_DM_GPIO. This define would be needed anyway, no matter
> > > > if you perform the changes from [1].
> > > >
> > > > This Kconfig define is necessary for the XEA board (i.MX28 based
> > > > one), which uses OF_PLATDATA in SPL excessively to fit into size
> > > > constraints.
> > > >
> > > > To be more precise the mxs_gpio.c driver uses
> > > > #if CONFIG_IS_ENABLED(DM_GPIO) to provide DM GPIO support in SPL
> > > > with OF_PLATDATA.
> > > >
> > > >
> > > > >
> > > > > As it happens I sent a similar patch[1], but it doesn't work.
> > > > > I'll try again.
> > > >
> > > > It would be great if we could have [1] not causing build breaks.
> > > > However, for my used case it would be enough to have the Kconfig
> > > > definition of CONFIG_SPL_DM_GPIO (as I'm using OF_PLATDATA) with
> > > > it.
> > > >
> > > > Simon, if you don't have time to do the fix for [1] I would opt
> > > > for pulling this patch (to just add proper Kconfig define).
> > >
> > > I have had a crack at this here:
> > >
> > > https://gitlab.denx.de/u-boot/custodians/u-boot-dm/commit/a6d15bbd9e4e7684dd47d21817df85915f28cbab
> > >
> > > I expect to send this series along with this patch at the end of
> > > this week.
> >
> > If I may ask - have you made any progress on this?
>
> In fact it blocks some i.MX28 related code (board to be precise) from
> sending it upstream as converted drivers expect SPL_DM_GPIO to be
> defined in Kconfig.
>
> In fact I do just need following code:
> https://patchwork.ozlabs.org/patch/1169013/
>
> If you have some difficulties to solve (on e.g. other archs) then maybe
> it would be enough to pull the above patch?
Just getting back to this, but see U-Boot next which has the full patch now.
Regards,
Simon
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-12-27 16:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-29 15:54 [U-Boot] [PATCH v2] spl: Introduce SPL_DM_GPIO Kconfig define Lukasz Majewski
2019-10-09 9:02 ` Lukasz Majewski
2019-10-11 23:01 ` Simon Glass
2019-10-14 12:41 ` Lukasz Majewski
2019-10-16 3:40 ` Simon Glass
2019-11-17 20:37 ` Lukasz Majewski
2019-11-17 20:54 ` Lukasz Majewski
2019-12-27 16:42 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.