All of lore.kernel.org
 help / color / mirror / Atom feed
* Failed cherry-picks on drm-intel-fixes
@ 2019-11-18 17:39 ` Rodrigo Vivi
  0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Vivi @ 2019-11-18 17:39 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

Hi Chris,

2 fixes failed on this cherry-pick round.

8eb4704b124c ("drm/i915: Protect request peeking with RCU")
3cac195875ef ("drm/i915: Leave the aliasing-ppgtt size alone")

The second is strange because git complain about the
empty commit.

Anyway, if any is needed could you please provide those
through your ickle/dif please?

Also looking there I noticed one commit pending:

drm/i915: Split i915_active.mutex into an irq-safe spinlock for the rbtree

It seems that we do need that, but I wonder why dim is not getting
itself. Also it conflicts on top of current drm-intel-fixes so
I'd need a rebased version anyway please!

Thanks a lot,
Rodrigo.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Intel-gfx] Failed cherry-picks on drm-intel-fixes
@ 2019-11-18 17:39 ` Rodrigo Vivi
  0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Vivi @ 2019-11-18 17:39 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

Hi Chris,

2 fixes failed on this cherry-pick round.

8eb4704b124c ("drm/i915: Protect request peeking with RCU")
3cac195875ef ("drm/i915: Leave the aliasing-ppgtt size alone")

The second is strange because git complain about the
empty commit.

Anyway, if any is needed could you please provide those
through your ickle/dif please?

Also looking there I noticed one commit pending:

drm/i915: Split i915_active.mutex into an irq-safe spinlock for the rbtree

It seems that we do need that, but I wonder why dim is not getting
itself. Also it conflicts on top of current drm-intel-fixes so
I'd need a rebased version anyway please!

Thanks a lot,
Rodrigo.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Failed cherry-picks on drm-intel-fixes
@ 2019-11-18 17:48   ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-11-18 17:48 UTC (permalink / raw)
  To: Rodrigo Vivi, intel-gfx

Quoting Rodrigo Vivi (2019-11-18 17:39:55)
> Hi Chris,
> 
> 2 fixes failed on this cherry-pick round.
> 
> 8eb4704b124c ("drm/i915: Protect request peeking with RCU")
> 3cac195875ef ("drm/i915: Leave the aliasing-ppgtt size alone")
> 
> The second is strange because git complain about the
> empty commit.
> 
> Anyway, if any is needed could you please provide those
> through your ickle/dif please?
> 
> Also looking there I noticed one commit pending:
> 
> drm/i915: Split i915_active.mutex into an irq-safe spinlock for the rbtree
> 
> It seems that we do need that, but I wonder why dim is not getting
> itself. Also it conflicts on top of current drm-intel-fixes so
> I'd need a rebased version anyway please!

That one is for dinf, we only need it for the lockdep commit in the next
merge window when we will get angry looks for abusing mutexes.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Intel-gfx] Failed cherry-picks on drm-intel-fixes
@ 2019-11-18 17:48   ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-11-18 17:48 UTC (permalink / raw)
  To: Rodrigo Vivi, intel-gfx

Quoting Rodrigo Vivi (2019-11-18 17:39:55)
> Hi Chris,
> 
> 2 fixes failed on this cherry-pick round.
> 
> 8eb4704b124c ("drm/i915: Protect request peeking with RCU")
> 3cac195875ef ("drm/i915: Leave the aliasing-ppgtt size alone")
> 
> The second is strange because git complain about the
> empty commit.
> 
> Anyway, if any is needed could you please provide those
> through your ickle/dif please?
> 
> Also looking there I noticed one commit pending:
> 
> drm/i915: Split i915_active.mutex into an irq-safe spinlock for the rbtree
> 
> It seems that we do need that, but I wonder why dim is not getting
> itself. Also it conflicts on top of current drm-intel-fixes so
> I'd need a rebased version anyway please!

That one is for dinf, we only need it for the lockdep commit in the next
merge window when we will get angry looks for abusing mutexes.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Failed cherry-picks on drm-intel-fixes
@ 2019-11-18 18:13   ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-11-18 18:13 UTC (permalink / raw)
  To: Rodrigo Vivi, intel-gfx

Quoting Rodrigo Vivi (2019-11-18 17:39:55)
> Hi Chris,
> 
> 2 fixes failed on this cherry-pick round.
> 
> 8eb4704b124c ("drm/i915: Protect request peeking with RCU")

https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=dif&id=7e27238e149ce4f00d9cd801fe3aa0ea55e986a2

> 3cac195875ef ("drm/i915: Leave the aliasing-ppgtt size alone")

That seems to be actually the fault of

commit 8f5e2b306b4e26db0ec65e0a27b232b179c9122b
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Mon Sep 2 05:02:43 2019 +0100

    drm/i915: Restrict the aliasing-ppgtt to the size of the ggtt

instead.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Intel-gfx] Failed cherry-picks on drm-intel-fixes
@ 2019-11-18 18:13   ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-11-18 18:13 UTC (permalink / raw)
  To: Rodrigo Vivi, intel-gfx

Quoting Rodrigo Vivi (2019-11-18 17:39:55)
> Hi Chris,
> 
> 2 fixes failed on this cherry-pick round.
> 
> 8eb4704b124c ("drm/i915: Protect request peeking with RCU")

https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=dif&id=7e27238e149ce4f00d9cd801fe3aa0ea55e986a2

> 3cac195875ef ("drm/i915: Leave the aliasing-ppgtt size alone")

That seems to be actually the fault of

commit 8f5e2b306b4e26db0ec65e0a27b232b179c9122b
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Mon Sep 2 05:02:43 2019 +0100

    drm/i915: Restrict the aliasing-ppgtt to the size of the ggtt

instead.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-11-18 18:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 17:39 Failed cherry-picks on drm-intel-fixes Rodrigo Vivi
2019-11-18 17:39 ` [Intel-gfx] " Rodrigo Vivi
2019-11-18 17:48 ` Chris Wilson
2019-11-18 17:48   ` [Intel-gfx] " Chris Wilson
2019-11-18 18:13 ` Chris Wilson
2019-11-18 18:13   ` [Intel-gfx] " Chris Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.