Re: [PATCH net-next v2 2/2] ipv4: use dst hint for ipv4 list receive

From: kbuild test robot <lkp@intel.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	Edward Cree <ecree@solarflare.com>
Subject: Re: [PATCH net-next v2 2/2] ipv4: use dst hint for ipv4 list receive
Date: Mon, 18 Nov 2019 22:11:15 +0800	[thread overview]
Message-ID: <201911182244.5fZHtUxj%lkp@intel.com> (raw)
In-Reply-To: <592c763828171c414e8927878b1a22027e33dee7.1574071944.git.pabeni@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1940 bytes --]

Hi Paolo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on v5.4-rc8 next-20191115]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Paolo-Abeni/net-introduce-and-use-route-hint/20191118-195936
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 19b7e21c55c81713c4011278143006af9f232504
config: mips-malta_kvm_defconfig (attached as .config)
compiler: mipsel-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   net//ipv4/ip_input.c: In function 'ip_can_cache_route_hint':
>> net//ipv4/ip_input.c:547:19: error: 'struct netns_ipv6' has no member named 'fib6_has_custom_rules'
            !net->ipv6.fib6_has_custom_rules;
                      ^
   net//ipv4/ip_input.c:551:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +547 net//ipv4/ip_input.c

   542	
   543	static bool ip_can_cache_route_hint(struct net *net, struct rtable *rt)
   544	{
   545		return rt->rt_type != RTN_BROADCAST &&
   546	#ifdef CONFIG_IP_MULTIPLE_TABLES
 > 547		       !net->ipv6.fib6_has_custom_rules;
   548	#else
   549		       1;
   550	#endif
   551	}
   552	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 20609 bytes --]