From: Nathan Chancellor <natechancellor@gmail.com> To: Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au> Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nick Desaulniers <ndesaulniers@google.com>, Nathan Chancellor <natechancellor@gmail.com> Subject: [PATCH v5 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp Date: Mon, 18 Nov 2019 21:57:12 -0700 [thread overview] Message-ID: <20191119045712.39633-4-natechancellor@gmail.com> (raw) In-Reply-To: <20191119045712.39633-1-natechancellor@gmail.com> r374662 gives LLVM the ability to convert certain loops into a reference to bcmp as an optimization; this breaks prom_init_check.sh: CALL arch/powerpc/kernel/prom_init_check.sh Error: External symbol 'bcmp' referenced from prom_init.c make[2]: *** [arch/powerpc/kernel/Makefile:196: prom_init_check] Error 1 bcmp is defined in lib/string.c as a wrapper for memcmp so this could be added to the whitelist. However, commit 450e7dd4001f ("powerpc/prom_init: don't use string functions from lib/") copied memcmp as prom_memcmp to avoid KASAN instrumentation so having bcmp be resolved to regular memcmp would break that assumption. Furthermore, because the compiler is the one that inserted bcmp, we cannot provide something like prom_bcmp. To prevent LLVM from being clever with optimizations like this, use -ffreestanding to tell LLVM we are not hosted so it is not free to make transformations like this. Link: https://github.com/ClangBuiltLinux/linux/issues/647 Link: https://github.com/llvm/llvm-project/commit/76cdcf25b883751d83402baea6316772aa73865c Reviewed-by: Nick Desaulneris <ndesaulniers@google.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- v1 -> v3: * New patch in the series v3 -> v4: * Rebase on v5.4-rc3. * Add Nick's reviewed-by tag. * Update the LLVM commit reference to the latest applied version (r374662) as it was originally committed as r370454, reverted in r370788, and reapplied as r374662. v4 -> v5: * Rebase on next-20191118 to avoid a conflict with commit 6266a4dadb1d ("powerpc/64s: Always disable branch profiling for prom_init.o") arch/powerpc/kernel/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile index 3c113ae0de2b..82170c155cb6 100644 --- a/arch/powerpc/kernel/Makefile +++ b/arch/powerpc/kernel/Makefile @@ -23,6 +23,7 @@ CFLAGS_prom.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) CFLAGS_prom_init.o += $(call cc-option, -fno-stack-protector) CFLAGS_prom_init.o += -DDISABLE_BRANCH_PROFILING +CFLAGS_prom_init.o += -ffreestanding ifdef CONFIG_FUNCTION_TRACER # Do not trace early boot code -- 2.24.0
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <natechancellor@gmail.com> To: Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au> Cc: clang-built-linux@googlegroups.com, Nathan Chancellor <natechancellor@gmail.com>, Nick Desaulniers <ndesaulniers@google.com>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp Date: Mon, 18 Nov 2019 21:57:12 -0700 [thread overview] Message-ID: <20191119045712.39633-4-natechancellor@gmail.com> (raw) In-Reply-To: <20191119045712.39633-1-natechancellor@gmail.com> r374662 gives LLVM the ability to convert certain loops into a reference to bcmp as an optimization; this breaks prom_init_check.sh: CALL arch/powerpc/kernel/prom_init_check.sh Error: External symbol 'bcmp' referenced from prom_init.c make[2]: *** [arch/powerpc/kernel/Makefile:196: prom_init_check] Error 1 bcmp is defined in lib/string.c as a wrapper for memcmp so this could be added to the whitelist. However, commit 450e7dd4001f ("powerpc/prom_init: don't use string functions from lib/") copied memcmp as prom_memcmp to avoid KASAN instrumentation so having bcmp be resolved to regular memcmp would break that assumption. Furthermore, because the compiler is the one that inserted bcmp, we cannot provide something like prom_bcmp. To prevent LLVM from being clever with optimizations like this, use -ffreestanding to tell LLVM we are not hosted so it is not free to make transformations like this. Link: https://github.com/ClangBuiltLinux/linux/issues/647 Link: https://github.com/llvm/llvm-project/commit/76cdcf25b883751d83402baea6316772aa73865c Reviewed-by: Nick Desaulneris <ndesaulniers@google.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- v1 -> v3: * New patch in the series v3 -> v4: * Rebase on v5.4-rc3. * Add Nick's reviewed-by tag. * Update the LLVM commit reference to the latest applied version (r374662) as it was originally committed as r370454, reverted in r370788, and reapplied as r374662. v4 -> v5: * Rebase on next-20191118 to avoid a conflict with commit 6266a4dadb1d ("powerpc/64s: Always disable branch profiling for prom_init.o") arch/powerpc/kernel/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile index 3c113ae0de2b..82170c155cb6 100644 --- a/arch/powerpc/kernel/Makefile +++ b/arch/powerpc/kernel/Makefile @@ -23,6 +23,7 @@ CFLAGS_prom.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) CFLAGS_prom_init.o += $(call cc-option, -fno-stack-protector) CFLAGS_prom_init.o += -DDISABLE_BRANCH_PROFILING +CFLAGS_prom_init.o += -ffreestanding ifdef CONFIG_FUNCTION_TRACER # Do not trace early boot code -- 2.24.0
next prev parent reply other threads:[~2019-11-19 4:57 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-11 18:20 [PATCH v3 0/3] LLVM/Clang fixes for pseries_defconfig Nathan Chancellor 2019-09-11 18:20 ` Nathan Chancellor 2019-09-11 18:20 ` [PATCH v3 1/3] powerpc: Don't add -mabi= flags when building with Clang Nathan Chancellor 2019-09-11 18:20 ` Nathan Chancellor 2019-09-11 18:20 ` [PATCH v3 2/3] powerpc: Avoid clang warnings around setjmp and longjmp Nathan Chancellor 2019-09-11 18:20 ` Nathan Chancellor 2019-09-11 20:55 ` Nick Desaulniers 2019-09-11 20:55 ` Nick Desaulniers 2019-09-11 18:20 ` [PATCH v3 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp Nathan Chancellor 2019-09-11 18:20 ` Nathan Chancellor 2019-09-11 21:01 ` Nick Desaulniers 2019-09-11 21:01 ` Nick Desaulniers 2019-09-12 5:43 ` Nathan Chancellor 2019-09-12 5:43 ` Nathan Chancellor 2019-09-12 17:30 ` Nick Desaulniers 2019-09-12 17:30 ` Nick Desaulniers 2019-10-14 2:50 ` [PATCH v4 0/3] LLVM/Clang fixes for pseries_defconfig Nathan Chancellor 2019-10-14 2:50 ` Nathan Chancellor 2019-10-14 2:50 ` [PATCH v4 1/3] powerpc: Don't add -mabi= flags when building with Clang Nathan Chancellor 2019-10-14 2:50 ` Nathan Chancellor 2019-10-14 2:51 ` [PATCH v4 2/3] powerpc: Avoid clang warnings around setjmp and longjmp Nathan Chancellor 2019-10-14 2:51 ` Nathan Chancellor 2019-10-14 2:51 ` [PATCH v4 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp Nathan Chancellor 2019-10-14 2:51 ` Nathan Chancellor 2019-10-14 9:35 ` Segher Boessenkool 2019-10-14 9:35 ` Segher Boessenkool 2019-10-14 15:56 ` Nick Desaulniers 2019-10-14 15:56 ` Nick Desaulniers 2019-10-14 19:11 ` Segher Boessenkool 2019-10-14 19:11 ` Segher Boessenkool 2019-10-18 19:00 ` Nathan Chancellor 2019-10-18 19:00 ` Nathan Chancellor 2019-10-18 20:02 ` Segher Boessenkool 2019-10-18 20:02 ` Segher Boessenkool 2019-10-22 5:15 ` Nathan Chancellor 2019-10-22 5:15 ` Nathan Chancellor 2019-10-22 8:57 ` Segher Boessenkool 2019-10-22 8:57 ` Segher Boessenkool 2019-10-30 4:12 ` Nathan Chancellor 2019-10-30 4:12 ` Nathan Chancellor 2019-10-14 16:03 ` [PATCH v4 0/3] LLVM/Clang fixes for pseries_defconfig Nick Desaulniers 2019-10-14 16:03 ` Nick Desaulniers 2019-11-19 4:57 ` [PATCH v5 0/3] LLVM/Clang fixes for a few defconfigs Nathan Chancellor 2019-11-19 4:57 ` Nathan Chancellor 2019-11-19 4:57 ` [PATCH v5 1/3] powerpc: Don't add -mabi= flags when building with Clang Nathan Chancellor 2019-11-19 4:57 ` Nathan Chancellor 2019-11-26 1:13 ` Michael Ellerman 2019-11-19 4:57 ` [PATCH v5 2/3] powerpc: Avoid clang warnings around setjmp and longjmp Nathan Chancellor 2019-11-19 4:57 ` Nathan Chancellor 2019-11-19 4:57 ` Nathan Chancellor [this message] 2019-11-19 4:57 ` [PATCH v5 3/3] powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp Nathan Chancellor 2019-11-25 20:15 ` [PATCH v5 0/3] LLVM/Clang fixes for a few defconfigs Nick Desaulniers 2019-11-25 20:15 ` Nick Desaulniers 2019-11-28 4:59 ` Michael Ellerman 2019-11-28 4:59 ` Michael Ellerman 2019-11-28 7:45 ` Nathan Chancellor 2019-11-28 7:45 ` Nathan Chancellor
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191119045712.39633-4-natechancellor@gmail.com \ --to=natechancellor@gmail.com \ --cc=benh@kernel.crashing.org \ --cc=clang-built-linux@googlegroups.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=ndesaulniers@google.com \ --cc=paulus@samba.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.