From: Jason Gunthorpe <jgg@mellanox.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "rdunlap@infradead.org" <rdunlap@infradead.org>,
"jakub.kicinski@netronome.com" <jakub.kicinski@netronome.com>,
"christophe.de.dinechin@gmail.com"
<christophe.de.dinechin@gmail.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"oberpar@linux.ibm.com" <oberpar@linux.ibm.com>,
"kwankhede@nvidia.com" <kwankhede@nvidia.com>,
"rob.miller@broadcom.com" <rob.miller@broadcom.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"sebott@linux.ibm.com" <sebott@linux.ibm.com>,
"lulu@redhat.com" <lulu@redhat.com>,
"eperezma@redhat.com" <eperezma@redhat.com>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
"borntraeger@de.ibm.com" <borntraeger@de.ibm.com>,
haotian.wang@s
Subject: Re: [PATCH V13 4/6] mdev: introduce mediated virtio bus
Date: Tue, 19 Nov 2019 12:38:08 +0000 [thread overview]
Message-ID: <20191119123803.GA26739@mellanox.com> (raw)
In-Reply-To: <a09f528f-cfca-69cf-4728-91ff33c5caa7@redhat.com>
On Tue, Nov 19, 2019 at 10:41:31AM +0800, Jason Wang wrote:
>
> On 2019/11/19 上午4:28, Jason Gunthorpe wrote:
> > On Mon, Nov 18, 2019 at 03:27:13PM -0500, Michael S. Tsirkin wrote:
> > > On Mon, Nov 18, 2019 at 01:41:00PM +0000, Jason Gunthorpe wrote:
> > > > On Mon, Nov 18, 2019 at 06:59:21PM +0800, Jason Wang wrote:
> > > > > +struct bus_type mdev_virtio_bus_type;
> > > > > +
> > > > > +struct mdev_virtio_device {
> > > > > + struct mdev_device mdev;
> > > > > + const struct mdev_virtio_ops *ops;
> > > > > + u16 class_id;
> > > > > +};
> > > > This seems to share nothing with mdev (ie mdev-vfio), why is it on the
> > > > same bus?
> > > I must be missing something - which bus do they share?
> > mdev_bus_type ?
> >
> > Jason
>
>
> Note: virtio has its own bus: mdev_virtio_bus_type. So they are not the same
> bus.
That is even worse, why involve struct mdev_device at all then?
Jason
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@mellanox.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "rdunlap@infradead.org" <rdunlap@infradead.org>,
"jakub.kicinski@netronome.com" <jakub.kicinski@netronome.com>,
"christophe.de.dinechin@gmail.com"
<christophe.de.dinechin@gmail.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"oberpar@linux.ibm.com" <oberpar@linux.ibm.com>,
"kwankhede@nvidia.com" <kwankhede@nvidia.com>,
"rob.miller@broadcom.com" <rob.miller@broadcom.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"sebott@linux.ibm.com" <sebott@linux.ibm.com>,
"lulu@redhat.com" <lulu@redhat.com>,
"eperezma@redhat.com" <eperezma@redhat.com>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
"borntraeger@de.ibm.com" <borntraeger@de.ibm.com>,
"haotian.wang@sifive.com" <haotian.wang@sifive.com>,
"jeffrey.t.kirsher@intel.com" <jeffrey.t.kirsher@intel.com>,
"cunming.liang@intel.com" <cunming.liang@intel.com>,
"farman@linux.ibm.com" <farman@linux.ibm.com>,
Parav Pandit <parav@mellanox.com>,
"gor@linux.ibm.com" <gor@linux.ibm.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"xiao.w.wang@intel.com" <xiao.w.wang@intel.com>,
"freude@linux.ibm.com" <freude@linux.ibm.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"zhihong.wang@intel.com" <zhihong.wang@intel.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"hch@infradead.org" <hch@infradead.org>,
"akrowiak@linux.ibm.com" <akrowiak@linux.ibm.com>,
"aadam@redhat.com" <aadam@redhat.com>,
Jiri Pirko <jiri@mellanox.com>,
"tiwei.bie@intel.com" <tiwei.bie@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"lingshan.zhu@intel.com" <lingshan.zhu@intel.com>
Subject: Re: [Intel-gfx] [PATCH V13 4/6] mdev: introduce mediated virtio bus
Date: Tue, 19 Nov 2019 12:38:08 +0000 [thread overview]
Message-ID: <20191119123803.GA26739@mellanox.com> (raw)
Message-ID: <20191119123808.KS1N_XEN9HmmyrFtZlQJMUwUdXs9BUCpUjUaZJsk4hg@z> (raw)
In-Reply-To: <a09f528f-cfca-69cf-4728-91ff33c5caa7@redhat.com>
On Tue, Nov 19, 2019 at 10:41:31AM +0800, Jason Wang wrote:
>
> On 2019/11/19 上午4:28, Jason Gunthorpe wrote:
> > On Mon, Nov 18, 2019 at 03:27:13PM -0500, Michael S. Tsirkin wrote:
> > > On Mon, Nov 18, 2019 at 01:41:00PM +0000, Jason Gunthorpe wrote:
> > > > On Mon, Nov 18, 2019 at 06:59:21PM +0800, Jason Wang wrote:
> > > > > +struct bus_type mdev_virtio_bus_type;
> > > > > +
> > > > > +struct mdev_virtio_device {
> > > > > + struct mdev_device mdev;
> > > > > + const struct mdev_virtio_ops *ops;
> > > > > + u16 class_id;
> > > > > +};
> > > > This seems to share nothing with mdev (ie mdev-vfio), why is it on the
> > > > same bus?
> > > I must be missing something - which bus do they share?
> > mdev_bus_type ?
> >
> > Jason
>
>
> Note: virtio has its own bus: mdev_virtio_bus_type. So they are not the same
> bus.
That is even worse, why involve struct mdev_device at all then?
Jason
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-19 12:38 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 10:59 [PATCH V13 0/6] mdev based hardware virtio offloading support Jason Wang
2019-11-18 10:59 ` [Intel-gfx] " Jason Wang
2019-11-18 10:59 ` Jason Wang
2019-11-18 10:59 ` [PATCH V13 1/6] mdev: make mdev bus agnostic Jason Wang
2019-11-18 10:59 ` [Intel-gfx] " Jason Wang
2019-11-18 10:59 ` Jason Wang
2019-11-19 3:08 ` Randy Dunlap
2019-11-19 3:08 ` [Intel-gfx] " Randy Dunlap
2019-11-19 3:08 ` Randy Dunlap
2019-11-19 3:08 ` Randy Dunlap
2019-11-18 10:59 ` [PATCH V13 2/6] mdev: split out VFIO bus specific parent ops Jason Wang
2019-11-18 10:59 ` [Intel-gfx] " Jason Wang
2019-11-18 10:59 ` Jason Wang
2019-11-18 10:59 ` Jason Wang
2019-11-18 10:59 ` [PATCH V13 3/6] mdev: move to drivers/ Jason Wang
2019-11-18 10:59 ` [Intel-gfx] " Jason Wang
2019-11-18 10:59 ` Jason Wang
2019-11-18 10:59 ` Jason Wang
2019-11-19 3:11 ` Randy Dunlap
2019-11-19 3:11 ` [Intel-gfx] " Randy Dunlap
2019-11-19 3:11 ` Randy Dunlap
2019-11-19 3:11 ` Randy Dunlap
2019-11-18 10:59 ` [PATCH V13 4/6] mdev: introduce mediated virtio bus Jason Wang
2019-11-18 10:59 ` [Intel-gfx] " Jason Wang
2019-11-18 10:59 ` Jason Wang
2019-11-18 13:41 ` Jason Gunthorpe
2019-11-18 13:41 ` [Intel-gfx] " Jason Gunthorpe
2019-11-18 13:41 ` Jason Gunthorpe
2019-11-18 20:27 ` Michael S. Tsirkin
2019-11-18 20:27 ` [Intel-gfx] " Michael S. Tsirkin
2019-11-18 20:27 ` Michael S. Tsirkin
2019-11-18 20:28 ` Jason Gunthorpe
2019-11-18 20:28 ` [Intel-gfx] " Jason Gunthorpe
2019-11-18 20:28 ` Jason Gunthorpe
2019-11-19 2:41 ` Jason Wang
2019-11-19 2:41 ` [Intel-gfx] " Jason Wang
2019-11-19 2:41 ` Jason Wang
2019-11-19 12:38 ` Jason Gunthorpe [this message]
2019-11-19 12:38 ` [Intel-gfx] " Jason Gunthorpe
2019-11-19 14:02 ` Jason Wang
2019-11-19 14:02 ` [Intel-gfx] " Jason Wang
2019-11-19 14:02 ` Jason Wang
2019-11-19 14:14 ` Jason Gunthorpe
2019-11-19 14:14 ` [Intel-gfx] " Jason Gunthorpe
2019-11-20 2:14 ` Jason Wang
2019-11-20 2:14 ` [Intel-gfx] " Jason Wang
2019-11-20 2:14 ` Jason Wang
2019-11-20 13:49 ` Jason Gunthorpe
2019-11-20 13:49 ` [Intel-gfx] " Jason Gunthorpe
2019-11-20 13:49 ` Jason Gunthorpe
2019-11-21 3:05 ` Jason Wang
2019-11-21 3:05 ` [Intel-gfx] " Jason Wang
2019-11-21 3:05 ` Jason Wang
2019-11-26 12:07 ` Rob Miller
2019-11-26 12:07 ` [Intel-gfx] " Rob Miller
2019-11-26 12:07 ` Rob Miller
2019-11-19 2:40 ` Jason Wang
2019-11-19 2:40 ` [Intel-gfx] " Jason Wang
2019-11-19 2:40 ` Jason Wang
2019-11-19 3:13 ` Randy Dunlap
2019-11-19 3:13 ` [Intel-gfx] " Randy Dunlap
2019-11-19 3:13 ` Randy Dunlap
2019-11-19 3:13 ` Randy Dunlap
2019-11-18 10:59 ` [PATCH V13 5/6] virtio: introduce a mdev based transport Jason Wang
2019-11-18 10:59 ` [Intel-gfx] " Jason Wang
2019-11-18 10:59 ` Jason Wang
2019-11-18 10:59 ` Jason Wang
2019-11-18 10:59 ` [PATCH V13 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework Jason Wang
2019-11-18 10:59 ` [Intel-gfx] " Jason Wang
2019-11-18 10:59 ` Jason Wang
2019-11-18 10:59 ` Jason Wang
2019-11-18 15:17 ` Greg KH
2019-11-18 15:17 ` [Intel-gfx] " Greg KH
2019-11-18 15:17 ` Greg KH
2019-11-18 15:17 ` Greg KH
2019-11-19 3:03 ` Jason Wang
2019-11-19 3:03 ` [Intel-gfx] " Jason Wang
2019-11-19 3:03 ` Jason Wang
2019-11-19 3:03 ` Jason Wang
2019-11-19 12:40 ` Jason Gunthorpe
2019-11-19 12:40 ` [Intel-gfx] " Jason Gunthorpe
2019-11-19 14:07 ` Jason Wang
2019-11-19 14:07 ` [Intel-gfx] " Jason Wang
2019-11-19 14:07 ` Jason Wang
2019-11-19 16:39 ` Jason Gunthorpe
2019-11-19 16:39 ` [Intel-gfx] " Jason Gunthorpe
2019-11-18 15:45 ` Cornelia Huck
2019-11-18 15:45 ` [Intel-gfx] " Cornelia Huck
2019-11-18 15:45 ` Cornelia Huck
2019-11-18 15:45 ` Cornelia Huck
2019-11-19 3:04 ` Jason Wang
2019-11-19 3:04 ` [Intel-gfx] " Jason Wang
2019-11-19 3:04 ` Jason Wang
2019-11-19 3:04 ` Jason Wang
2019-11-18 13:35 ` ✗ Fi.CI.CHECKPATCH: warning for mdev based hardware virtio offloading support Patchwork
2019-11-18 13:35 ` [Intel-gfx] " Patchwork
2019-11-18 13:51 ` ✗ Fi.CI.DOCS: " Patchwork
2019-11-18 13:51 ` [Intel-gfx] " Patchwork
2019-11-18 14:25 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-11-18 14:25 ` [Intel-gfx] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119123803.GA26739@mellanox.com \
--to=jgg@mellanox.com \
--cc=airlied@linux.ie \
--cc=borntraeger@de.ibm.com \
--cc=christophe.de.dinechin@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eperezma@redhat.com \
--cc=haotian.wang@s \
--cc=heiko.carstens@de.ibm.com \
--cc=jakub.kicinski@netronome.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=oberpar@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=rdunlap@infradead.org \
--cc=rob.miller@broadcom.com \
--cc=sebott@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.