All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] thermal: db8500: Depromote debug print
@ 2019-11-19  7:46 Linus Walleij
  2019-11-19 19:19 ` Stephan Gerhold
  2019-12-04 16:01 ` Daniel Lezcano
  0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2019-11-19  7:46 UTC (permalink / raw)
  To: Zhang Rui, Eduardo Valentin, Daniel Lezcano
  Cc: linux-pm, Linus Walleij, Stephan Gerhold

We are not interested in getting this debug print on our
console all the time.

Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Stephan Gerhold <stephan@gerhold.net>
Fixes: 6c375eccded4 ("thermal: db8500: Rewrite to be a pure OF sensor")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/thermal/db8500_thermal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/db8500_thermal.c b/drivers/thermal/db8500_thermal.c
index 372dbbaaafb8..21d4d6e6409a 100644
--- a/drivers/thermal/db8500_thermal.c
+++ b/drivers/thermal/db8500_thermal.c
@@ -152,8 +152,8 @@ static irqreturn_t prcmu_high_irq_handler(int irq, void *irq_data)
 		db8500_thermal_update_config(th, idx, THERMAL_TREND_RAISING,
 					     next_low, next_high);
 
-		dev_info(&th->tz->device,
-			 "PRCMU set max %ld, min %ld\n", next_high, next_low);
+		dev_dbg(&th->tz->device,
+			"PRCMU set max %ld, min %ld\n", next_high, next_low);
 	} else if (idx == num_points - 1)
 		/* So we roof out 1 degree over the max point */
 		th->interpolated_temp = db8500_thermal_points[idx] + 1;
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] thermal: db8500: Depromote debug print
  2019-11-19  7:46 [PATCH] thermal: db8500: Depromote debug print Linus Walleij
@ 2019-11-19 19:19 ` Stephan Gerhold
  2019-12-04 16:01 ` Daniel Lezcano
  1 sibling, 0 replies; 3+ messages in thread
From: Stephan Gerhold @ 2019-11-19 19:19 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Zhang Rui, Eduardo Valentin, Daniel Lezcano, linux-pm

On Tue, Nov 19, 2019 at 08:46:50AM +0100, Linus Walleij wrote:
> We are not interested in getting this debug print on our
> console all the time.
> 
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Fixes: 6c375eccded4 ("thermal: db8500: Rewrite to be a pure OF sensor")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

I noticed those as well. Thanks for the patch!

FWIW:
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>

> ---
>  drivers/thermal/db8500_thermal.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/db8500_thermal.c b/drivers/thermal/db8500_thermal.c
> index 372dbbaaafb8..21d4d6e6409a 100644
> --- a/drivers/thermal/db8500_thermal.c
> +++ b/drivers/thermal/db8500_thermal.c
> @@ -152,8 +152,8 @@ static irqreturn_t prcmu_high_irq_handler(int irq, void *irq_data)
>  		db8500_thermal_update_config(th, idx, THERMAL_TREND_RAISING,
>  					     next_low, next_high);
>  
> -		dev_info(&th->tz->device,
> -			 "PRCMU set max %ld, min %ld\n", next_high, next_low);
> +		dev_dbg(&th->tz->device,
> +			"PRCMU set max %ld, min %ld\n", next_high, next_low);
>  	} else if (idx == num_points - 1)
>  		/* So we roof out 1 degree over the max point */
>  		th->interpolated_temp = db8500_thermal_points[idx] + 1;
> -- 
> 2.21.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] thermal: db8500: Depromote debug print
  2019-11-19  7:46 [PATCH] thermal: db8500: Depromote debug print Linus Walleij
  2019-11-19 19:19 ` Stephan Gerhold
@ 2019-12-04 16:01 ` Daniel Lezcano
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2019-12-04 16:01 UTC (permalink / raw)
  To: Linus Walleij, Zhang Rui, Eduardo Valentin; +Cc: linux-pm, Stephan Gerhold

On 19/11/2019 08:46, Linus Walleij wrote:
> We are not interested in getting this debug print on our
> console all the time.
> 
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Fixes: 6c375eccded4 ("thermal: db8500: Rewrite to be a pure OF sensor")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Applied, thanks!

> ---
>  drivers/thermal/db8500_thermal.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/db8500_thermal.c b/drivers/thermal/db8500_thermal.c
> index 372dbbaaafb8..21d4d6e6409a 100644
> --- a/drivers/thermal/db8500_thermal.c
> +++ b/drivers/thermal/db8500_thermal.c
> @@ -152,8 +152,8 @@ static irqreturn_t prcmu_high_irq_handler(int irq, void *irq_data)
>  		db8500_thermal_update_config(th, idx, THERMAL_TREND_RAISING,
>  					     next_low, next_high);
>  
> -		dev_info(&th->tz->device,
> -			 "PRCMU set max %ld, min %ld\n", next_high, next_low);
> +		dev_dbg(&th->tz->device,
> +			"PRCMU set max %ld, min %ld\n", next_high, next_low);
>  	} else if (idx == num_points - 1)
>  		/* So we roof out 1 degree over the max point */
>  		th->interpolated_temp = db8500_thermal_points[idx] + 1;
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-04 16:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19  7:46 [PATCH] thermal: db8500: Depromote debug print Linus Walleij
2019-11-19 19:19 ` Stephan Gerhold
2019-12-04 16:01 ` Daniel Lezcano

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.