* [PATCH v2] powerpc: Add const qual to local_read() parameter
@ 2019-11-20 1:14 ` Michael Ellerman
0 siblings, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2019-11-20 1:14 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel, davem, edumazet, sfr, linuxppc-dev
From: Eric Dumazet <edumazet@google.com>
A patch in net-next triggered a compile error on powerpc:
include/linux/u64_stats_sync.h: In function 'u64_stats_read':
include/asm-generic/local64.h:30:37: warning: passing argument 1 of 'local_read' discards 'const' qualifier from pointer target type
This seems reasonable to relax powerpc local_read() requirements.
Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: kbuild test robot <lkp@intel.com>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
---
arch/powerpc/include/asm/local.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
v2: mpe: Update change log with compiler warning, resend to netdev so it appears
in the netdev patchwork.
Dave can you take this in the net tree so the window of the breakage is as small
as possible please?
diff --git a/arch/powerpc/include/asm/local.h b/arch/powerpc/include/asm/local.h
index fdd00939270b..bc4bd19b7fc2 100644
--- a/arch/powerpc/include/asm/local.h
+++ b/arch/powerpc/include/asm/local.h
@@ -17,7 +17,7 @@ typedef struct
#define LOCAL_INIT(i) { (i) }
-static __inline__ long local_read(local_t *l)
+static __inline__ long local_read(const local_t *l)
{
return READ_ONCE(l->v);
}
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2] powerpc: Add const qual to local_read() parameter
@ 2019-11-20 1:14 ` Michael Ellerman
0 siblings, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2019-11-20 1:14 UTC (permalink / raw)
To: netdev; +Cc: linuxppc-dev, sfr, edumazet, linux-kernel, davem
From: Eric Dumazet <edumazet@google.com>
A patch in net-next triggered a compile error on powerpc:
include/linux/u64_stats_sync.h: In function 'u64_stats_read':
include/asm-generic/local64.h:30:37: warning: passing argument 1 of 'local_read' discards 'const' qualifier from pointer target type
This seems reasonable to relax powerpc local_read() requirements.
Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: kbuild test robot <lkp@intel.com>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
---
arch/powerpc/include/asm/local.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
v2: mpe: Update change log with compiler warning, resend to netdev so it appears
in the netdev patchwork.
Dave can you take this in the net tree so the window of the breakage is as small
as possible please?
diff --git a/arch/powerpc/include/asm/local.h b/arch/powerpc/include/asm/local.h
index fdd00939270b..bc4bd19b7fc2 100644
--- a/arch/powerpc/include/asm/local.h
+++ b/arch/powerpc/include/asm/local.h
@@ -17,7 +17,7 @@ typedef struct
#define LOCAL_INIT(i) { (i) }
-static __inline__ long local_read(local_t *l)
+static __inline__ long local_read(const local_t *l)
{
return READ_ONCE(l->v);
}
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] powerpc: Add const qual to local_read() parameter
2019-11-20 1:14 ` Michael Ellerman
@ 2019-11-20 2:05 ` Stephen Rothwell
-1 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2019-11-20 2:05 UTC (permalink / raw)
To: Michael Ellerman; +Cc: netdev, linux-kernel, davem, edumazet, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
Hi all,
On Wed, 20 Nov 2019 12:14:51 +1100 Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> From: Eric Dumazet <edumazet@google.com>
>
> A patch in net-next triggered a compile error on powerpc:
>
> include/linux/u64_stats_sync.h: In function 'u64_stats_read':
> include/asm-generic/local64.h:30:37: warning: passing argument 1 of 'local_read' discards 'const' qualifier from pointer target type
>
> This seems reasonable to relax powerpc local_read() requirements.
>
> Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Tested-by: Stephen Rothwell <sfr@canb.auug.org.au> # build only
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] powerpc: Add const qual to local_read() parameter
@ 2019-11-20 2:05 ` Stephen Rothwell
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2019-11-20 2:05 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev, netdev, edumazet, linux-kernel, davem
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
Hi all,
On Wed, 20 Nov 2019 12:14:51 +1100 Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> From: Eric Dumazet <edumazet@google.com>
>
> A patch in net-next triggered a compile error on powerpc:
>
> include/linux/u64_stats_sync.h: In function 'u64_stats_read':
> include/asm-generic/local64.h:30:37: warning: passing argument 1 of 'local_read' discards 'const' qualifier from pointer target type
>
> This seems reasonable to relax powerpc local_read() requirements.
>
> Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Tested-by: Stephen Rothwell <sfr@canb.auug.org.au> # build only
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] powerpc: Add const qual to local_read() parameter
2019-11-20 1:14 ` Michael Ellerman
@ 2019-11-24 3:25 ` Stephen Rothwell
-1 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2019-11-24 3:25 UTC (permalink / raw)
To: Dave Miller
Cc: Michael Ellerman, netdev, linux-kernel, edumazet, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 1750 bytes --]
Hi Dave,
On Wed, 20 Nov 2019 12:14:51 +1100 Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> From: Eric Dumazet <edumazet@google.com>
>
> A patch in net-next triggered a compile error on powerpc:
>
> include/linux/u64_stats_sync.h: In function 'u64_stats_read':
> include/asm-generic/local64.h:30:37: warning: passing argument 1 of 'local_read' discards 'const' qualifier from pointer target type
>
> This seems reasonable to relax powerpc local_read() requirements.
>
> Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> arch/powerpc/include/asm/local.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> v2: mpe: Update change log with compiler warning, resend to netdev so it appears
> in the netdev patchwork.
>
> Dave can you take this in the net tree so the window of the breakage is as small
> as possible please?
I see that you marked this as "Not Applicable" in patchwork.
Michael meant the net-next tree which contains commit
316580b69d0a ("u64_stats: provide u64_stats_t type")
Please consider applying this patch.
> diff --git a/arch/powerpc/include/asm/local.h b/arch/powerpc/include/asm/local.h
> index fdd00939270b..bc4bd19b7fc2 100644
> --- a/arch/powerpc/include/asm/local.h
> +++ b/arch/powerpc/include/asm/local.h
> @@ -17,7 +17,7 @@ typedef struct
>
> #define LOCAL_INIT(i) { (i) }
>
> -static __inline__ long local_read(local_t *l)
> +static __inline__ long local_read(const local_t *l)
> {
> return READ_ONCE(l->v);
> }
> --
> 2.21.0
>
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] powerpc: Add const qual to local_read() parameter
@ 2019-11-24 3:25 ` Stephen Rothwell
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2019-11-24 3:25 UTC (permalink / raw)
To: Dave Miller; +Cc: linuxppc-dev, edumazet, linux-kernel, netdev
[-- Attachment #1: Type: text/plain, Size: 1750 bytes --]
Hi Dave,
On Wed, 20 Nov 2019 12:14:51 +1100 Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> From: Eric Dumazet <edumazet@google.com>
>
> A patch in net-next triggered a compile error on powerpc:
>
> include/linux/u64_stats_sync.h: In function 'u64_stats_read':
> include/asm-generic/local64.h:30:37: warning: passing argument 1 of 'local_read' discards 'const' qualifier from pointer target type
>
> This seems reasonable to relax powerpc local_read() requirements.
>
> Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> arch/powerpc/include/asm/local.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> v2: mpe: Update change log with compiler warning, resend to netdev so it appears
> in the netdev patchwork.
>
> Dave can you take this in the net tree so the window of the breakage is as small
> as possible please?
I see that you marked this as "Not Applicable" in patchwork.
Michael meant the net-next tree which contains commit
316580b69d0a ("u64_stats: provide u64_stats_t type")
Please consider applying this patch.
> diff --git a/arch/powerpc/include/asm/local.h b/arch/powerpc/include/asm/local.h
> index fdd00939270b..bc4bd19b7fc2 100644
> --- a/arch/powerpc/include/asm/local.h
> +++ b/arch/powerpc/include/asm/local.h
> @@ -17,7 +17,7 @@ typedef struct
>
> #define LOCAL_INIT(i) { (i) }
>
> -static __inline__ long local_read(local_t *l)
> +static __inline__ long local_read(const local_t *l)
> {
> return READ_ONCE(l->v);
> }
> --
> 2.21.0
>
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] powerpc: Add const qual to local_read() parameter
2019-11-20 1:14 ` Michael Ellerman
@ 2019-11-24 23:18 ` Jakub Kicinski
-1 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2019-11-24 23:18 UTC (permalink / raw)
To: Michael Ellerman; +Cc: netdev, linux-kernel, davem, edumazet, sfr, linuxppc-dev
On Wed, 20 Nov 2019 12:14:51 +1100, Michael Ellerman wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> A patch in net-next triggered a compile error on powerpc:
>
> include/linux/u64_stats_sync.h: In function 'u64_stats_read':
> include/asm-generic/local64.h:30:37: warning: passing argument 1 of 'local_read' discards 'const' qualifier from pointer target type
>
> This seems reasonable to relax powerpc local_read() requirements.
>
> Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to net-next now, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] powerpc: Add const qual to local_read() parameter
@ 2019-11-24 23:18 ` Jakub Kicinski
0 siblings, 0 replies; 8+ messages in thread
From: Jakub Kicinski @ 2019-11-24 23:18 UTC (permalink / raw)
To: Michael Ellerman; +Cc: sfr, netdev, linux-kernel, linuxppc-dev, edumazet, davem
On Wed, 20 Nov 2019 12:14:51 +1100, Michael Ellerman wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> A patch in net-next triggered a compile error on powerpc:
>
> include/linux/u64_stats_sync.h: In function 'u64_stats_read':
> include/asm-generic/local64.h:30:37: warning: passing argument 1 of 'local_read' discards 'const' qualifier from pointer target type
>
> This seems reasonable to relax powerpc local_read() requirements.
>
> Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to net-next now, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-11-24 23:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-20 1:14 [PATCH v2] powerpc: Add const qual to local_read() parameter Michael Ellerman
2019-11-20 1:14 ` Michael Ellerman
2019-11-20 2:05 ` Stephen Rothwell
2019-11-20 2:05 ` Stephen Rothwell
2019-11-24 3:25 ` Stephen Rothwell
2019-11-24 3:25 ` Stephen Rothwell
2019-11-24 23:18 ` Jakub Kicinski
2019-11-24 23:18 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.