[U-Boot] [PATCH] armv7m: cache: add invalidate_icache_all() stub

[U-Boot] [PATCH] armv7m: cache: add invalidate_icache_all() stub

[Giulio Benetti]

This commit:
https://gitlab.denx.de/u-boot/u-boot/commit/d409c962169bd293e39386d0ddfa64d5222a3be4
causes build failure with ICACHE enabled. This is due to missing
invalidate_icache_all() stub. Let's add empty invalidate_icache_all() in
the case where ICACHE is not enabled.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 arch/arm/cpu/armv7m/cache.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/cpu/armv7m/cache.c b/arch/arm/cpu/armv7m/cache.c
index 0ccd7519a1..e3c5edce7a 100644
--- a/arch/arm/cpu/armv7m/cache.c
+++ b/arch/arm/cpu/armv7m/cache.c
@@ -337,6 +337,11 @@ void icache_disable(void)
 	isb();	/* subsequent instructions fetch see cache disable effect */
 }
 #else
+void invalidate_icache_all(void)
+{
+	return 0;
+}
+
 void icache_enable(void)
 {
 	return;
-- 
2.20.1

[U-Boot] [PATCH] armv7m: cache: add invalidate_icache_all() stub

[Giulio Benetti]

Hello,

On 11/21/19 12:00 AM, Giulio Benetti wrote:
> This commit:
> https://gitlab.denx.de/u-boot/u-boot/commit/d409c962169bd293e39386d0ddfa64d5222a3be4
> causes build failure with ICACHE enabled. This is due to missing
> invalidate_icache_all() stub. Let's add empty invalidate_icache_all() in
> the case where ICACHE is not enabled.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   arch/arm/cpu/armv7m/cache.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/cpu/armv7m/cache.c b/arch/arm/cpu/armv7m/cache.c
> index 0ccd7519a1..e3c5edce7a 100644
> --- a/arch/arm/cpu/armv7m/cache.c
> +++ b/arch/arm/cpu/armv7m/cache.c
> @@ -337,6 +337,11 @@ void icache_disable(void)
>   	isb();	/* subsequent instructions fetch see cache disable effect */
>   }
>   #else
> +void invalidate_icache_all(void)
> +{
> +	return 0;

This must return nothing instead of 0.
I'm going to send v2 patch.

Sorry for the noise

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

[U-Boot] [PATCH v2] armv7m: cache: add invalidate_icache_all() stub

[Giulio Benetti]

This commit:
https://gitlab.denx.de/u-boot/u-boot/commit/d409c962169bd293e39386d0ddfa64d5222a3be4
causes build failure with ICACHE enabled. This is due to missing
invalidate_icache_all() stub. Let's add empty invalidate_icache_all() in
the case where ICACHE is not enabled.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* substitute 'return 0;' with 'return;' since function returns void
---
 arch/arm/cpu/armv7m/cache.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/cpu/armv7m/cache.c b/arch/arm/cpu/armv7m/cache.c
index 0ccd7519a1..87c2baa60d 100644
--- a/arch/arm/cpu/armv7m/cache.c
+++ b/arch/arm/cpu/armv7m/cache.c
@@ -337,6 +337,11 @@ void icache_disable(void)
 	isb();	/* subsequent instructions fetch see cache disable effect */
 }
 #else
+void invalidate_icache_all(void)
+{
+	return;
+}
+
 void icache_enable(void)
 {
 	return;
-- 
2.20.1

[U-Boot] [PATCH v2] armv7m: cache: add invalidate_icache_all() stub

[Tom Rini]

On Tue, Nov 26, 2019 at 12:19:27PM +0100, Giulio Benetti wrote:

> This commit:
> https://gitlab.denx.de/u-boot/u-boot/commit/d409c962169bd293e39386d0ddfa64d5222a3be4
> causes build failure with ICACHE enabled. This is due to missing
> invalidate_icache_all() stub. Let's add empty invalidate_icache_all() in
> the case where ICACHE is not enabled.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191203/2faee92f/attachment.sig>