[PATCH v2] virtio-input: fix memory leak on unrealize

* [PATCH v2] virtio-input: fix memory leak on unrealize
@ 2019-11-21  9:56 Marc-André Lureau
  0 siblings, 0 replies; only message in thread
From: Marc-André Lureau @ 2019-11-21  9:56 UTC (permalink / raw)
  To: qemu-devel; +Cc: Marc-André Lureau, mst

Spotted by ASAN + minor stylistic change.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
---

Michael: can you peek this in your next pullreq? thanks

hw/input/virtio-input.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/input/virtio-input.c b/hw/input/virtio-input.c
index 51617a5885..ec54e46ad6 100644
--- a/hw/input/virtio-input.c
+++ b/hw/input/virtio-input.c
@@ -275,6 +275,7 @@ static void virtio_input_finalize(Object *obj)
 
     g_free(vinput->queue);
 }
+
 static void virtio_input_device_unrealize(DeviceState *dev, Error **errp)
 {
     VirtIOInputClass *vic = VIRTIO_INPUT_GET_CLASS(dev);
@@ -288,6 +289,8 @@ static void virtio_input_device_unrealize(DeviceState *dev, Error **errp)
             return;
         }
     }
+    virtio_del_queue(vdev, 0);
+    virtio_del_queue(vdev, 1);
     virtio_cleanup(vdev);
 }
 
-- 
2.24.0



^ permalink raw reply related	[flat|nested] only message in thread