From: kbuild test robot <lkp@intel.com> To: "Björn Töpel" <bjorn.topel@gmail.com> Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, "Björn Töpel" <bjorn.topel@intel.com>, bpf@vger.kernel.org, magnus.karlsson@gmail.com, magnus.karlsson@intel.com, jonathan.lemon@gmail.com, ecree@solarflare.com, thoiland@redhat.com, andrii.nakryiko@gmail.com Subject: Re: [PATCH bpf-next 1/3] bpf: introduce BPF dispatcher Date: Thu, 21 Nov 2019 15:27:12 +0800 [thread overview] Message-ID: <201911211536.JzaBr1Ub%lkp@intel.com> (raw) In-Reply-To: <20191119160757.27714-2-bjorn.topel@gmail.com> [-- Attachment #1: Type: text/plain, Size: 3604 bytes --] Hi "Björn, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] [also build test ERROR on next-20191120] [cannot apply to v5.4-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Introduce-xdp_call-h-and-the-BPF-dispatcher/20191120-074435 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: i386-randconfig-g003-20191121 (attached as .config) compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com> All error/warnings (new ones prefixed by >>): kernel/bpf/dispatcher.c: In function 'bpf_dispatcher_update': >> kernel/bpf/dispatcher.c:144:31: error: 'BPF_MOD_JUMP_TO_NOP' undeclared (first use in this function); did you mean 'BPF_MOD_CALL_TO_NOP'? bpf_arch_text_poke(d->func, BPF_MOD_JUMP_TO_NOP, ^~~~~~~~~~~~~~~~~~~ BPF_MOD_CALL_TO_NOP kernel/bpf/dispatcher.c:144:31: note: each undeclared identifier is reported only once for each function it appears in >> kernel/bpf/dispatcher.c:151:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] *ipsp++ = (s64)d->progs[i]->bpf_func; ^ >> kernel/bpf/dispatcher.c:159:37: error: 'BPF_MOD_JUMP_TO_JUMP' undeclared (first use in this function); did you mean 'BPF_MOD_JUMP_TO_NOP'? err = bpf_arch_text_poke(d->func, BPF_MOD_JUMP_TO_JUMP, ^~~~~~~~~~~~~~~~~~~~ BPF_MOD_JUMP_TO_NOP >> kernel/bpf/dispatcher.c:163:37: error: 'BPF_MOD_NOP_TO_JUMP' undeclared (first use in this function); did you mean 'BPF_MOD_JUMP_TO_JUMP'? err = bpf_arch_text_poke(d->func, BPF_MOD_NOP_TO_JUMP, ^~~~~~~~~~~~~~~~~~~ BPF_MOD_JUMP_TO_JUMP vim +144 kernel/bpf/dispatcher.c 135 136 static void bpf_dispatcher_update(struct bpf_dispatcher *d) 137 { 138 void *old_image = d->image + ((d->selector + 1) & 1) * PAGE_SIZE / 2; 139 void *new_image = d->image + (d->selector & 1) * PAGE_SIZE / 2; 140 s64 ips[BPF_DISPATCHER_MAX] = {}, *ipsp = &ips[0]; 141 int i, err; 142 143 if (!d->num_progs) { > 144 bpf_arch_text_poke(d->func, BPF_MOD_JUMP_TO_NOP, 145 old_image, NULL); 146 return; 147 } 148 149 for (i = 0; i < BPF_DISPATCHER_MAX; i++) { 150 if (d->progs[i]) > 151 *ipsp++ = (s64)d->progs[i]->bpf_func; 152 } 153 err = arch_prepare_bpf_dispatcher(new_image, &ips[0], d->num_progs); 154 if (err) 155 return; 156 157 if (d->selector) { 158 /* progs already running at this address */ > 159 err = bpf_arch_text_poke(d->func, BPF_MOD_JUMP_TO_JUMP, 160 old_image, new_image); 161 } else { 162 /* first time registering */ > 163 err = bpf_arch_text_poke(d->func, BPF_MOD_NOP_TO_JUMP, 164 NULL, new_image); 165 } 166 if (err) 167 return; 168 d->selector++; 169 } 170 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 35785 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH bpf-next 1/3] bpf: introduce BPF dispatcher Date: Thu, 21 Nov 2019 15:27:12 +0800 [thread overview] Message-ID: <201911211536.JzaBr1Ub%lkp@intel.com> (raw) In-Reply-To: <20191119160757.27714-2-bjorn.topel@gmail.com> [-- Attachment #1: Type: text/plain, Size: 3691 bytes --] Hi "Björn, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] [also build test ERROR on next-20191120] [cannot apply to v5.4-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Introduce-xdp_call-h-and-the-BPF-dispatcher/20191120-074435 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: i386-randconfig-g003-20191121 (attached as .config) compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com> All error/warnings (new ones prefixed by >>): kernel/bpf/dispatcher.c: In function 'bpf_dispatcher_update': >> kernel/bpf/dispatcher.c:144:31: error: 'BPF_MOD_JUMP_TO_NOP' undeclared (first use in this function); did you mean 'BPF_MOD_CALL_TO_NOP'? bpf_arch_text_poke(d->func, BPF_MOD_JUMP_TO_NOP, ^~~~~~~~~~~~~~~~~~~ BPF_MOD_CALL_TO_NOP kernel/bpf/dispatcher.c:144:31: note: each undeclared identifier is reported only once for each function it appears in >> kernel/bpf/dispatcher.c:151:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] *ipsp++ = (s64)d->progs[i]->bpf_func; ^ >> kernel/bpf/dispatcher.c:159:37: error: 'BPF_MOD_JUMP_TO_JUMP' undeclared (first use in this function); did you mean 'BPF_MOD_JUMP_TO_NOP'? err = bpf_arch_text_poke(d->func, BPF_MOD_JUMP_TO_JUMP, ^~~~~~~~~~~~~~~~~~~~ BPF_MOD_JUMP_TO_NOP >> kernel/bpf/dispatcher.c:163:37: error: 'BPF_MOD_NOP_TO_JUMP' undeclared (first use in this function); did you mean 'BPF_MOD_JUMP_TO_JUMP'? err = bpf_arch_text_poke(d->func, BPF_MOD_NOP_TO_JUMP, ^~~~~~~~~~~~~~~~~~~ BPF_MOD_JUMP_TO_JUMP vim +144 kernel/bpf/dispatcher.c 135 136 static void bpf_dispatcher_update(struct bpf_dispatcher *d) 137 { 138 void *old_image = d->image + ((d->selector + 1) & 1) * PAGE_SIZE / 2; 139 void *new_image = d->image + (d->selector & 1) * PAGE_SIZE / 2; 140 s64 ips[BPF_DISPATCHER_MAX] = {}, *ipsp = &ips[0]; 141 int i, err; 142 143 if (!d->num_progs) { > 144 bpf_arch_text_poke(d->func, BPF_MOD_JUMP_TO_NOP, 145 old_image, NULL); 146 return; 147 } 148 149 for (i = 0; i < BPF_DISPATCHER_MAX; i++) { 150 if (d->progs[i]) > 151 *ipsp++ = (s64)d->progs[i]->bpf_func; 152 } 153 err = arch_prepare_bpf_dispatcher(new_image, &ips[0], d->num_progs); 154 if (err) 155 return; 156 157 if (d->selector) { 158 /* progs already running at this address */ > 159 err = bpf_arch_text_poke(d->func, BPF_MOD_JUMP_TO_JUMP, 160 old_image, new_image); 161 } else { 162 /* first time registering */ > 163 err = bpf_arch_text_poke(d->func, BPF_MOD_NOP_TO_JUMP, 164 NULL, new_image); 165 } 166 if (err) 167 return; 168 d->selector++; 169 } 170 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 35785 bytes --]
next prev parent reply other threads:[~2019-11-21 7:27 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-19 16:07 [PATCH bpf-next 0/3] Introduce xdp_call.h and the BPF dispatcher Björn Töpel 2019-11-19 16:07 ` [PATCH bpf-next 1/3] bpf: introduce " Björn Töpel 2019-11-21 7:27 ` kbuild test robot [this message] 2019-11-21 7:27 ` kbuild test robot 2019-11-21 9:23 ` Björn Töpel 2019-11-23 0:25 ` [RFC PATCH] bpf: bpf_dispatcher_lookup() can be static kbuild test robot 2019-11-23 0:25 ` kbuild test robot 2019-11-23 14:03 ` kbuild test robot 2019-11-23 14:03 ` kbuild test robot 2019-11-19 16:07 ` [PATCH bpf-next 2/3] xdp: introduce xdp_call Björn Töpel 2019-11-19 16:07 ` [PATCH bpf-next 3/3] i40e: start using xdp_call.h Björn Töpel 2019-11-23 15:52 ` kbuild test robot 2019-11-23 15:52 ` kbuild test robot 2019-11-23 15:52 ` [RFC PATCH] i40e: ____xdp_call_i40e_xdp_call_tramp can be static kbuild test robot 2019-11-23 15:52 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201911211536.JzaBr1Ub%lkp@intel.com \ --to=lkp@intel.com \ --cc=andrii.nakryiko@gmail.com \ --cc=ast@kernel.org \ --cc=bjorn.topel@gmail.com \ --cc=bjorn.topel@intel.com \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=ecree@solarflare.com \ --cc=jonathan.lemon@gmail.com \ --cc=kbuild-all@lists.01.org \ --cc=magnus.karlsson@gmail.com \ --cc=magnus.karlsson@intel.com \ --cc=netdev@vger.kernel.org \ --cc=thoiland@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.