[PATCH] drm/i915: Use intel_gt_pm_put_async in GuC submission path

[PATCH] drm/i915: Use intel_gt_pm_put_async in GuC submission path

[Stuart Summers]

GuC submission path can be called from an interrupt context
and so should use a worker to avoid holding a mutex.

References: 07779a76ee1f ("drm/i915: Mark up the calling context for intel_wakeref_put()")

Signed-off-by: Stuart Summers <stuart.summers@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 902e25eb6b9d..dcccbd640809 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -537,7 +537,7 @@ static void schedule_out(struct i915_request *rq)
 {
 	trace_i915_request_out(rq);
 
-	intel_gt_pm_put(rq->engine->gt);
+	intel_gt_pm_put_async(rq->engine->gt);
 	i915_request_put(rq);
 }
 
-- 
2.22.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Use intel_gt_pm_put_async in GuC submission path

[Stuart Summers]

GuC submission path can be called from an interrupt context
and so should use a worker to avoid holding a mutex.

References: 07779a76ee1f ("drm/i915: Mark up the calling context for intel_wakeref_put()")

Signed-off-by: Stuart Summers <stuart.summers@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 902e25eb6b9d..dcccbd640809 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -537,7 +537,7 @@ static void schedule_out(struct i915_request *rq)
 {
 	trace_i915_request_out(rq);
 
-	intel_gt_pm_put(rq->engine->gt);
+	intel_gt_pm_put_async(rq->engine->gt);
 	i915_request_put(rq);
 }
 
-- 
2.22.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Use intel_gt_pm_put_async in GuC submission path

[Chris Wilson]

Quoting Stuart Summers (2019-11-20 21:13:21)
> GuC submission path can be called from an interrupt context
> and so should use a worker to avoid holding a mutex.

I completely forgot there was still the vestigial GuC submission code...
Ah, I was looking more carefully for engine_put in the wrong context.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Use intel_gt_pm_put_async in GuC submission path

[Chris Wilson]

Quoting Stuart Summers (2019-11-20 21:13:21)
> GuC submission path can be called from an interrupt context
> and so should use a worker to avoid holding a mutex.

I completely forgot there was still the vestigial GuC submission code...
Ah, I was looking more carefully for engine_put in the wrong context.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: failure for drm/i915: Use intel_gt_pm_put_async in GuC submission path

[Patchwork]

== Series Details ==

Series: drm/i915: Use intel_gt_pm_put_async in GuC submission path
URL   : https://patchwork.freedesktop.org/series/69781/
State : failure

== Summary ==

Applying: drm/i915: Use intel_gt_pm_put_async in GuC submission path
Using index info to reconstruct a base tree...
M	drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Use intel_gt_pm_put_async in GuC submission path

[Patchwork]

== Series Details ==

Series: drm/i915: Use intel_gt_pm_put_async in GuC submission path
URL   : https://patchwork.freedesktop.org/series/69781/
State : failure

== Summary ==

Applying: drm/i915: Use intel_gt_pm_put_async in GuC submission path
Using index info to reconstruct a base tree...
M	drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Use intel_gt_pm_put_async in GuC submission path

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1817 bytes --]

Hi Stuart,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v5.4-rc8 next-20191120]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Stuart-Summers/drm-i915-Use-intel_gt_pm_put_async-in-GuC-submission-path/20191121-203257
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c: In function 'schedule_out':
>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:540:2: error: implicit declaration of function 'intel_gt_pm_put_async'; did you mean 'intel_gt_pm_put'? [-Werror=implicit-function-declaration]
     intel_gt_pm_put_async(rq->engine->gt);
     ^~~~~~~~~~~~~~~~~~~~~
     intel_gt_pm_put
   cc1: some warnings being treated as errors

vim +540 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c

   535	
   536	static void schedule_out(struct i915_request *rq)
   537	{
   538		trace_i915_request_out(rq);
   539	
 > 540		intel_gt_pm_put_async(rq->engine->gt);
   541		i915_request_put(rq);
   542	}
   543	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28187 bytes --]