* [PATCH v2] drm/i915: Support more QGV points
@ 2019-11-22 14:10 ` Stanislav Lisovskiy
0 siblings, 0 replies; 17+ messages in thread
From: Stanislav Lisovskiy @ 2019-11-22 14:10 UTC (permalink / raw)
To: intel-gfx; +Cc: tomi.p.sarvela
According to BSpec 53998, there is a mask of
max 8 SAGV/QGV points we need to support.
Bumping this up to keep the CI happy(currently
preventing tests to run), until all SAGV
changes land.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
drivers/gpu/drm/i915/display/intel_bw.c | 22 +++++++++++++++++-----
drivers/gpu/drm/i915/i915_drv.h | 6 +++++-
2 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index 86e75e858008..d1b805b30177 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -15,7 +15,7 @@ struct intel_qgv_point {
};
struct intel_qgv_info {
- struct intel_qgv_point points[3];
+ struct intel_qgv_point points[I915_NUM_SAGV_POINTS];
u8 num_points;
u8 num_channels;
u8 t_bl;
@@ -276,15 +276,27 @@ void intel_bw_init_hw(struct drm_i915_private *dev_priv)
static unsigned int intel_max_data_rate(struct drm_i915_private *dev_priv,
int num_planes)
{
- if (INTEL_GEN(dev_priv) >= 11)
+ if (INTEL_GEN(dev_priv) >= 11) {
+ /*
+ * Any bw group has same amount of QGV points
+ */
+ const struct intel_bw_info *bi =
+ &dev_priv->max_bw[0];
+ unsigned int min_bw = UINT_MAX;
+ int i;
+
/*
* FIXME with SAGV disabled maybe we can assume
* point 1 will always be used? Seems to match
* the behaviour observed in the wild.
*/
- return min3(icl_max_bw(dev_priv, num_planes, 0),
- icl_max_bw(dev_priv, num_planes, 1),
- icl_max_bw(dev_priv, num_planes, 2));
+ for (i = 0; i < bi->num_qgv_points; i++) {
+ unsigned int bw = icl_max_bw(dev_priv, num_planes, i);
+
+ min_bw = min(bw, min_bw);
+ }
+ return min_bw;
+ }
else
return UINT_MAX;
}
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index fdae5a919bc8..d45a9ffaed4f 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -621,6 +621,9 @@ struct i915_gem_mm {
#define I915_ENGINE_WEDGED_TIMEOUT (60 * HZ) /* Reset but no recovery? */
+/* BSpec precisely defines this */
+#define I915_NUM_SAGV_POINTS 8
+
struct ddi_vbt_port_info {
/* Non-NULL if port present. */
const struct child_device_config *child;
@@ -1232,7 +1235,8 @@ struct drm_i915_private {
} dram_info;
struct intel_bw_info {
- unsigned int deratedbw[3]; /* for each QGV point */
+ /* for each QGV point */
+ unsigned int deratedbw[I915_NUM_SAGV_POINTS];
u8 num_qgv_points;
u8 num_planes;
} max_bw[6];
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915: Support more QGV points
@ 2019-11-22 14:10 ` Stanislav Lisovskiy
0 siblings, 0 replies; 17+ messages in thread
From: Stanislav Lisovskiy @ 2019-11-22 14:10 UTC (permalink / raw)
To: intel-gfx; +Cc: tomi.p.sarvela
According to BSpec 53998, there is a mask of
max 8 SAGV/QGV points we need to support.
Bumping this up to keep the CI happy(currently
preventing tests to run), until all SAGV
changes land.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
drivers/gpu/drm/i915/display/intel_bw.c | 22 +++++++++++++++++-----
drivers/gpu/drm/i915/i915_drv.h | 6 +++++-
2 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index 86e75e858008..d1b805b30177 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -15,7 +15,7 @@ struct intel_qgv_point {
};
struct intel_qgv_info {
- struct intel_qgv_point points[3];
+ struct intel_qgv_point points[I915_NUM_SAGV_POINTS];
u8 num_points;
u8 num_channels;
u8 t_bl;
@@ -276,15 +276,27 @@ void intel_bw_init_hw(struct drm_i915_private *dev_priv)
static unsigned int intel_max_data_rate(struct drm_i915_private *dev_priv,
int num_planes)
{
- if (INTEL_GEN(dev_priv) >= 11)
+ if (INTEL_GEN(dev_priv) >= 11) {
+ /*
+ * Any bw group has same amount of QGV points
+ */
+ const struct intel_bw_info *bi =
+ &dev_priv->max_bw[0];
+ unsigned int min_bw = UINT_MAX;
+ int i;
+
/*
* FIXME with SAGV disabled maybe we can assume
* point 1 will always be used? Seems to match
* the behaviour observed in the wild.
*/
- return min3(icl_max_bw(dev_priv, num_planes, 0),
- icl_max_bw(dev_priv, num_planes, 1),
- icl_max_bw(dev_priv, num_planes, 2));
+ for (i = 0; i < bi->num_qgv_points; i++) {
+ unsigned int bw = icl_max_bw(dev_priv, num_planes, i);
+
+ min_bw = min(bw, min_bw);
+ }
+ return min_bw;
+ }
else
return UINT_MAX;
}
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index fdae5a919bc8..d45a9ffaed4f 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -621,6 +621,9 @@ struct i915_gem_mm {
#define I915_ENGINE_WEDGED_TIMEOUT (60 * HZ) /* Reset but no recovery? */
+/* BSpec precisely defines this */
+#define I915_NUM_SAGV_POINTS 8
+
struct ddi_vbt_port_info {
/* Non-NULL if port present. */
const struct child_device_config *child;
@@ -1232,7 +1235,8 @@ struct drm_i915_private {
} dram_info;
struct intel_bw_info {
- unsigned int deratedbw[3]; /* for each QGV point */
+ /* for each QGV point */
+ unsigned int deratedbw[I915_NUM_SAGV_POINTS];
u8 num_qgv_points;
u8 num_planes;
} max_bw[6];
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support more QGV points (rev3)
@ 2019-11-22 14:45 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-22 14:45 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Support more QGV points (rev3)
URL : https://patchwork.freedesktop.org/series/69886/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
072e7302b3d6 drm/i915: Support more QGV points
-:34: CHECK:BRACES: braces {} should be used on all arms of this statement
#34: FILE: drivers/gpu/drm/i915/display/intel_bw.c:279:
+ if (INTEL_GEN(dev_priv) >= 11) {
[...]
+ }
[...]
total: 0 errors, 0 warnings, 1 checks, 57 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support more QGV points (rev3)
@ 2019-11-22 14:45 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-22 14:45 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Support more QGV points (rev3)
URL : https://patchwork.freedesktop.org/series/69886/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
072e7302b3d6 drm/i915: Support more QGV points
-:34: CHECK:BRACES: braces {} should be used on all arms of this statement
#34: FILE: drivers/gpu/drm/i915/display/intel_bw.c:279:
+ if (INTEL_GEN(dev_priv) >= 11) {
[...]
+ }
[...]
total: 0 errors, 0 warnings, 1 checks, 57 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Support more QGV points (rev3)
@ 2019-11-22 15:07 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-22 15:07 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Support more QGV points (rev3)
URL : https://patchwork.freedesktop.org/series/69886/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7405 -> Patchwork_15397
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/index.html
Known issues
------------
Here are the changes found in Patchwork_15397 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][1] -> [FAIL][2] ([fdo#108511])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-kefka: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([fdo#111045] / [fdo#111096])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@i915_module_load@reload-no-display:
- fi-skl-lmem: [DMESG-WARN][7] ([fdo#112261]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][9] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][10] ([fdo#103558] / [fdo#105602]) +5 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-x1275: [DMESG-WARN][11] ([fdo#103558] / [fdo#105602] / [fdo#105763] / [fdo#107139]) -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602] / [fdo#107139])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
* igt@kms_flip@basic-flip-vs-modeset:
- fi-kbl-x1275: [DMESG-WARN][13] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (49 -> 44)
------------------------------
Additional (1): fi-snb-2600
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7405 -> Patchwork_15397
CI-20190529: 20190529
CI_DRM_7405: 8a552b51e24ce46814072f99817a64ed3fa35055 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5301: 3fa72891269b16943e6511166aeebee094206791 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15397: 072e7302b3d6a50e48d608a7e2bc2e02f27ff611 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
072e7302b3d6 drm/i915: Support more QGV points
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Support more QGV points (rev3)
@ 2019-11-22 15:07 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-22 15:07 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Support more QGV points (rev3)
URL : https://patchwork.freedesktop.org/series/69886/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7405 -> Patchwork_15397
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/index.html
Known issues
------------
Here are the changes found in Patchwork_15397 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][1] -> [FAIL][2] ([fdo#108511])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-kefka: [PASS][3] -> [INCOMPLETE][4] ([fdo# 111542])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([fdo#111045] / [fdo#111096])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@i915_module_load@reload-no-display:
- fi-skl-lmem: [DMESG-WARN][7] ([fdo#112261]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-skl-lmem/igt@i915_module_load@reload-no-display.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][9] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][10] ([fdo#103558] / [fdo#105602]) +5 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-x1275: [DMESG-WARN][11] ([fdo#103558] / [fdo#105602] / [fdo#105763] / [fdo#107139]) -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602] / [fdo#107139])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
* igt@kms_flip@basic-flip-vs-modeset:
- fi-kbl-x1275: [DMESG-WARN][13] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112261]: https://bugs.freedesktop.org/show_bug.cgi?id=112261
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (49 -> 44)
------------------------------
Additional (1): fi-snb-2600
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7405 -> Patchwork_15397
CI-20190529: 20190529
CI_DRM_7405: 8a552b51e24ce46814072f99817a64ed3fa35055 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5301: 3fa72891269b16943e6511166aeebee094206791 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15397: 072e7302b3d6a50e48d608a7e2bc2e02f27ff611 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
072e7302b3d6 drm/i915: Support more QGV points
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Support more QGV points (rev3)
@ 2019-11-23 23:10 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-23 23:10 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Support more QGV points (rev3)
URL : https://patchwork.freedesktop.org/series/69886/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7405_full -> Patchwork_15397_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_15397_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb1/igt@gem_busy@busy-vcs1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb5/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_persistence@vcs1-mixed-process:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb2/igt@gem_ctx_persistence@vcs1-mixed-process.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb6/igt@gem_ctx_persistence@vcs1-mixed-process.html
* igt@gem_exec_schedule@preempt-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112146]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb5/igt@gem_exec_schedule@preempt-bsd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb2/igt@gem_exec_schedule@preempt-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-kbl6/igt@gem_exec_suspend@basic-s3.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-kbl3/igt@gem_exec_suspend@basic-s3.html
* igt@gem_persistent_relocs@forked-thrashing:
- shard-hsw: [PASS][9] -> [FAIL][10] ([fdo#112037])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw2/igt@gem_persistent_relocs@forked-thrashing.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw4/igt@gem_persistent_relocs@forked-thrashing.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [PASS][11] -> [DMESG-WARN][12] ([fdo#108566]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-apl7/igt@gem_softpin@noreloc-s3.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-apl1/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw1/igt@gem_userptr_blits@dmabuf-sync.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw7/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_workarounds@suspend-resume-context:
- shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([fdo#111832] / [fdo#111850]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb7/igt@gem_workarounds@suspend-resume-context.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb2/igt@gem_workarounds@suspend-resume-context.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-hsw: [PASS][19] -> [FAIL][20] ([fdo#103355])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-tglb: [PASS][21] -> [FAIL][22] ([fdo#102670])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb9/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb3/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([fdo#111747] / [fdo#111832] / [fdo#111850])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb5/igt@kms_fbcon_fbt@fbc-suspend.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb4/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#105363])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [PASS][27] -> [INCOMPLETE][28] ([fdo#103540])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw2/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@plain-flip-ts-check-interruptible:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#100368])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl6/igt@kms_flip@plain-flip-ts-check-interruptible.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl8/igt@kms_flip@plain-flip-ts-check-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
- shard-tglb: [PASS][31] -> [FAIL][32] ([fdo#103167])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +5 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-tglb: [PASS][35] -> [INCOMPLETE][36] ([fdo#111832] / [fdo#111850] / [fdo#111884])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109642] / [fdo#111068])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb6/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb4/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-tglb: [PASS][41] -> [INCOMPLETE][42] ([fdo#111850])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb6/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb3/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109276]) +18 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb2/igt@prime_vgem@fence-wait-bsd2.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb6/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][45] ([fdo#108566]) -> [PASS][46] +5 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
- shard-skl: [INCOMPLETE][47] ([fdo#104108]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl7/igt@gem_ctx_isolation@rcs0-s3.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl10/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [SKIP][49] ([fdo#109276] / [fdo#112080]) -> [PASS][50] +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb6/igt@gem_ctx_isolation@vcs1-none.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb4/igt@gem_ctx_isolation@vcs1-none.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][51] ([fdo#110854]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb8/igt@gem_exec_balancer@smoke.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_gttfill@basic:
- shard-tglb: [INCOMPLETE][53] ([fdo#111593]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb6/igt@gem_exec_gttfill@basic.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb1/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][55] ([fdo#112080]) -> [PASS][56] +21 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb6/igt@gem_exec_parallel@vcs1-fds.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb1/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][57] ([fdo#112146]) -> [PASS][58] +11 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [DMESG-WARN][59] ([fdo#111870]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-snb1/igt@gem_userptr_blits@dmabuf-sync.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-snb7/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-hsw: [DMESG-WARN][61] ([fdo#111870]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw6/igt@gem_userptr_blits@sync-unmap-cycles.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw1/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_selftest@live_hangcheck:
- shard-hsw: [DMESG-FAIL][63] ([fdo#111991]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw6/igt@i915_selftest@live_hangcheck.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw1/igt@i915_selftest@live_hangcheck.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [DMESG-WARN][65] ([fdo#108566]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-apl4/igt@i915_suspend@debugfs-reader.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-apl2/igt@i915_suspend@debugfs-reader.html
* igt@i915_suspend@sysfs-reader:
- shard-tglb: [INCOMPLETE][67] ([fdo#111832] / [fdo#111850]) -> [PASS][68] +6 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb2/igt@i915_suspend@sysfs-reader.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb4/igt@i915_suspend@sysfs-reader.html
* igt@kms_color@pipe-a-ctm-max:
- shard-skl: [DMESG-WARN][69] ([fdo#106107]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl2/igt@kms_color@pipe-a-ctm-max.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl9/igt@kms_color@pipe-a-ctm-max.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [FAIL][71] ([fdo#105767]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_flip@flip-vs-suspend:
- shard-iclb: [INCOMPLETE][73] ([fdo#107713] / [fdo#109507]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb3/igt@kms_flip@flip-vs-suspend.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb8/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@plain-flip-fb-recreate:
- shard-skl: [FAIL][75] ([fdo#100368]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl5/igt@kms_flip@plain-flip-fb-recreate.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl7/igt@kms_flip@plain-flip-fb-recreate.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-iclb: [FAIL][77] ([fdo#103167]) -> [PASS][78] +3 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu:
- shard-tglb: [FAIL][79] ([fdo#103167]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][81] ([fdo#108145] / [fdo#110403]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][83] ([fdo#109441]) -> [PASS][84] +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb5/igt@kms_psr@psr2_no_drrs.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-skl: [TIMEOUT][85] ([fdo#111732 ]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl5/igt@perf@gen8-unprivileged-single-ctx-counters.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl8/igt@perf@gen8-unprivileged-single-ctx-counters.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][87] ([fdo#109276]) -> [PASS][88] +14 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb8/igt@prime_busy@hang-bsd2.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb4/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][89] ([fdo#111329]) -> [SKIP][90] ([fdo#109276] / [fdo#112080])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb6/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_exec_schedule@deep-bsd1:
- shard-tglb: [INCOMPLETE][91] ([fdo#111671]) -> [FAIL][92] ([fdo#111646])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb3/igt@gem_exec_schedule@deep-bsd1.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb2/igt@gem_exec_schedule@deep-bsd1.html
* igt@kms_atomic_transition@6x-modeset-transitions-fencing:
- shard-tglb: [SKIP][93] ([fdo#112021 ]) -> [SKIP][94] ([fdo#112016 ] / [fdo#112021 ])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions-fencing.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb3/igt@kms_atomic_transition@6x-modeset-transitions-fencing.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][95] ([fdo#109441]) -> [DMESG-WARN][96] ([fdo#107724])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb5/igt@kms_psr@psr2_suspend.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb2/igt@kms_psr@psr2_suspend.html
- shard-tglb: [INCOMPLETE][97] ([fdo#111832] / [fdo#111850]) -> [DMESG-WARN][98] ([fdo#111600])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb1/igt@kms_psr@psr2_suspend.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb9/igt@kms_psr@psr2_suspend.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
[fdo#111671]: https://bugs.fre
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Support more QGV points (rev3)
@ 2019-11-23 23:10 ` Patchwork
0 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-11-23 23:10 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Support more QGV points (rev3)
URL : https://patchwork.freedesktop.org/series/69886/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7405_full -> Patchwork_15397_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_15397_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb1/igt@gem_busy@busy-vcs1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb5/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_persistence@vcs1-mixed-process:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb2/igt@gem_ctx_persistence@vcs1-mixed-process.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb6/igt@gem_ctx_persistence@vcs1-mixed-process.html
* igt@gem_exec_schedule@preempt-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112146]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb5/igt@gem_exec_schedule@preempt-bsd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb2/igt@gem_exec_schedule@preempt-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-kbl6/igt@gem_exec_suspend@basic-s3.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-kbl3/igt@gem_exec_suspend@basic-s3.html
* igt@gem_persistent_relocs@forked-thrashing:
- shard-hsw: [PASS][9] -> [FAIL][10] ([fdo#112037])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw2/igt@gem_persistent_relocs@forked-thrashing.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw4/igt@gem_persistent_relocs@forked-thrashing.html
* igt@gem_softpin@noreloc-s3:
- shard-apl: [PASS][11] -> [DMESG-WARN][12] ([fdo#108566]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-apl7/igt@gem_softpin@noreloc-s3.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-apl1/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw1/igt@gem_userptr_blits@dmabuf-sync.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw7/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_workarounds@suspend-resume-context:
- shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([fdo#111832] / [fdo#111850]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb7/igt@gem_workarounds@suspend-resume-context.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb2/igt@gem_workarounds@suspend-resume-context.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-hsw: [PASS][19] -> [FAIL][20] ([fdo#103355])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-tglb: [PASS][21] -> [FAIL][22] ([fdo#102670])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb9/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb3/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([fdo#111747] / [fdo#111832] / [fdo#111850])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb5/igt@kms_fbcon_fbt@fbc-suspend.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb4/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#105363])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-hsw: [PASS][27] -> [INCOMPLETE][28] ([fdo#103540])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw2/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@plain-flip-ts-check-interruptible:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#100368])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl6/igt@kms_flip@plain-flip-ts-check-interruptible.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl8/igt@kms_flip@plain-flip-ts-check-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
- shard-tglb: [PASS][31] -> [FAIL][32] ([fdo#103167])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103167]) +5 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-tglb: [PASS][35] -> [INCOMPLETE][36] ([fdo#111832] / [fdo#111850] / [fdo#111884])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109642] / [fdo#111068])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb6/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb4/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-tglb: [PASS][41] -> [INCOMPLETE][42] ([fdo#111850])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb6/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb3/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109276]) +18 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb2/igt@prime_vgem@fence-wait-bsd2.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb6/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][45] ([fdo#108566]) -> [PASS][46] +5 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
- shard-skl: [INCOMPLETE][47] ([fdo#104108]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl7/igt@gem_ctx_isolation@rcs0-s3.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl10/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [SKIP][49] ([fdo#109276] / [fdo#112080]) -> [PASS][50] +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb6/igt@gem_ctx_isolation@vcs1-none.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb4/igt@gem_ctx_isolation@vcs1-none.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][51] ([fdo#110854]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb8/igt@gem_exec_balancer@smoke.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_gttfill@basic:
- shard-tglb: [INCOMPLETE][53] ([fdo#111593]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb6/igt@gem_exec_gttfill@basic.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb1/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][55] ([fdo#112080]) -> [PASS][56] +21 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb6/igt@gem_exec_parallel@vcs1-fds.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb1/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][57] ([fdo#112146]) -> [PASS][58] +11 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [DMESG-WARN][59] ([fdo#111870]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-snb1/igt@gem_userptr_blits@dmabuf-sync.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-snb7/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-hsw: [DMESG-WARN][61] ([fdo#111870]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw6/igt@gem_userptr_blits@sync-unmap-cycles.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw1/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_selftest@live_hangcheck:
- shard-hsw: [DMESG-FAIL][63] ([fdo#111991]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw6/igt@i915_selftest@live_hangcheck.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw1/igt@i915_selftest@live_hangcheck.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [DMESG-WARN][65] ([fdo#108566]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-apl4/igt@i915_suspend@debugfs-reader.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-apl2/igt@i915_suspend@debugfs-reader.html
* igt@i915_suspend@sysfs-reader:
- shard-tglb: [INCOMPLETE][67] ([fdo#111832] / [fdo#111850]) -> [PASS][68] +6 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb2/igt@i915_suspend@sysfs-reader.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb4/igt@i915_suspend@sysfs-reader.html
* igt@kms_color@pipe-a-ctm-max:
- shard-skl: [DMESG-WARN][69] ([fdo#106107]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl2/igt@kms_color@pipe-a-ctm-max.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl9/igt@kms_color@pipe-a-ctm-max.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [FAIL][71] ([fdo#105767]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_flip@flip-vs-suspend:
- shard-iclb: [INCOMPLETE][73] ([fdo#107713] / [fdo#109507]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb3/igt@kms_flip@flip-vs-suspend.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb8/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@plain-flip-fb-recreate:
- shard-skl: [FAIL][75] ([fdo#100368]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl5/igt@kms_flip@plain-flip-fb-recreate.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl7/igt@kms_flip@plain-flip-fb-recreate.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-iclb: [FAIL][77] ([fdo#103167]) -> [PASS][78] +3 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu:
- shard-tglb: [FAIL][79] ([fdo#103167]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][81] ([fdo#108145] / [fdo#110403]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][83] ([fdo#109441]) -> [PASS][84] +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb5/igt@kms_psr@psr2_no_drrs.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-skl: [TIMEOUT][85] ([fdo#111732 ]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-skl5/igt@perf@gen8-unprivileged-single-ctx-counters.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-skl8/igt@perf@gen8-unprivileged-single-ctx-counters.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][87] ([fdo#109276]) -> [PASS][88] +14 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb8/igt@prime_busy@hang-bsd2.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb4/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][89] ([fdo#111329]) -> [SKIP][90] ([fdo#109276] / [fdo#112080])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb6/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_exec_schedule@deep-bsd1:
- shard-tglb: [INCOMPLETE][91] ([fdo#111671]) -> [FAIL][92] ([fdo#111646])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb3/igt@gem_exec_schedule@deep-bsd1.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb2/igt@gem_exec_schedule@deep-bsd1.html
* igt@kms_atomic_transition@6x-modeset-transitions-fencing:
- shard-tglb: [SKIP][93] ([fdo#112021 ]) -> [SKIP][94] ([fdo#112016 ] / [fdo#112021 ])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb9/igt@kms_atomic_transition@6x-modeset-transitions-fencing.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb3/igt@kms_atomic_transition@6x-modeset-transitions-fencing.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][95] ([fdo#109441]) -> [DMESG-WARN][96] ([fdo#107724])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-iclb5/igt@kms_psr@psr2_suspend.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-iclb2/igt@kms_psr@psr2_suspend.html
- shard-tglb: [INCOMPLETE][97] ([fdo#111832] / [fdo#111850]) -> [DMESG-WARN][98] ([fdo#111600])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7405/shard-tglb1/igt@kms_psr@psr2_suspend.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/shard-tglb9/igt@kms_psr@psr2_suspend.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
[fdo#111671]: https://bugs.fre
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15397/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] drm/i915: Support more QGV points
@ 2019-11-25 15:31 ` Ville Syrjälä
0 siblings, 0 replies; 17+ messages in thread
From: Ville Syrjälä @ 2019-11-25 15:31 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: tomi.p.sarvela, intel-gfx
On Fri, Nov 22, 2019 at 04:10:49PM +0200, Stanislav Lisovskiy wrote:
> According to BSpec 53998, there is a mask of
> max 8 SAGV/QGV points we need to support.
>
> Bumping this up to keep the CI happy(currently
> preventing tests to run), until all SAGV
> changes land.
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bw.c | 22 +++++++++++++++++-----
> drivers/gpu/drm/i915/i915_drv.h | 6 +++++-
> 2 files changed, 22 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index 86e75e858008..d1b805b30177 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -15,7 +15,7 @@ struct intel_qgv_point {
> };
>
> struct intel_qgv_info {
> - struct intel_qgv_point points[3];
> + struct intel_qgv_point points[I915_NUM_SAGV_POINTS];
> u8 num_points;
> u8 num_channels;
> u8 t_bl;
> @@ -276,15 +276,27 @@ void intel_bw_init_hw(struct drm_i915_private *dev_priv)
> static unsigned int intel_max_data_rate(struct drm_i915_private *dev_priv,
> int num_planes)
> {
> - if (INTEL_GEN(dev_priv) >= 11)
> + if (INTEL_GEN(dev_priv) >= 11) {
> + /*
> + * Any bw group has same amount of QGV points
> + */
> + const struct intel_bw_info *bi =
> + &dev_priv->max_bw[0];
> + unsigned int min_bw = UINT_MAX;
> + int i;
> +
> /*
> * FIXME with SAGV disabled maybe we can assume
> * point 1 will always be used? Seems to match
> * the behaviour observed in the wild.
> */
> - return min3(icl_max_bw(dev_priv, num_planes, 0),
> - icl_max_bw(dev_priv, num_planes, 1),
> - icl_max_bw(dev_priv, num_planes, 2));
> + for (i = 0; i < bi->num_qgv_points; i++) {
> + unsigned int bw = icl_max_bw(dev_priv, num_planes, i);
> +
> + min_bw = min(bw, min_bw);
> + }
> + return min_bw;
> + }
> else
> return UINT_MAX;
> }
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index fdae5a919bc8..d45a9ffaed4f 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -621,6 +621,9 @@ struct i915_gem_mm {
>
> #define I915_ENGINE_WEDGED_TIMEOUT (60 * HZ) /* Reset but no recovery? */
>
> +/* BSpec precisely defines this */
> +#define I915_NUM_SAGV_POINTS 8
I think everything else talks about "QGV points" rather
than "SAGV points" now? Would be nice to be consistent.
Apart from that
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> +
> struct ddi_vbt_port_info {
> /* Non-NULL if port present. */
> const struct child_device_config *child;
> @@ -1232,7 +1235,8 @@ struct drm_i915_private {
> } dram_info;
>
> struct intel_bw_info {
> - unsigned int deratedbw[3]; /* for each QGV point */
> + /* for each QGV point */
> + unsigned int deratedbw[I915_NUM_SAGV_POINTS];
> u8 num_qgv_points;
> u8 num_planes;
> } max_bw[6];
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Support more QGV points
@ 2019-11-25 15:31 ` Ville Syrjälä
0 siblings, 0 replies; 17+ messages in thread
From: Ville Syrjälä @ 2019-11-25 15:31 UTC (permalink / raw)
To: Stanislav Lisovskiy; +Cc: tomi.p.sarvela, intel-gfx
On Fri, Nov 22, 2019 at 04:10:49PM +0200, Stanislav Lisovskiy wrote:
> According to BSpec 53998, there is a mask of
> max 8 SAGV/QGV points we need to support.
>
> Bumping this up to keep the CI happy(currently
> preventing tests to run), until all SAGV
> changes land.
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_bw.c | 22 +++++++++++++++++-----
> drivers/gpu/drm/i915/i915_drv.h | 6 +++++-
> 2 files changed, 22 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index 86e75e858008..d1b805b30177 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -15,7 +15,7 @@ struct intel_qgv_point {
> };
>
> struct intel_qgv_info {
> - struct intel_qgv_point points[3];
> + struct intel_qgv_point points[I915_NUM_SAGV_POINTS];
> u8 num_points;
> u8 num_channels;
> u8 t_bl;
> @@ -276,15 +276,27 @@ void intel_bw_init_hw(struct drm_i915_private *dev_priv)
> static unsigned int intel_max_data_rate(struct drm_i915_private *dev_priv,
> int num_planes)
> {
> - if (INTEL_GEN(dev_priv) >= 11)
> + if (INTEL_GEN(dev_priv) >= 11) {
> + /*
> + * Any bw group has same amount of QGV points
> + */
> + const struct intel_bw_info *bi =
> + &dev_priv->max_bw[0];
> + unsigned int min_bw = UINT_MAX;
> + int i;
> +
> /*
> * FIXME with SAGV disabled maybe we can assume
> * point 1 will always be used? Seems to match
> * the behaviour observed in the wild.
> */
> - return min3(icl_max_bw(dev_priv, num_planes, 0),
> - icl_max_bw(dev_priv, num_planes, 1),
> - icl_max_bw(dev_priv, num_planes, 2));
> + for (i = 0; i < bi->num_qgv_points; i++) {
> + unsigned int bw = icl_max_bw(dev_priv, num_planes, i);
> +
> + min_bw = min(bw, min_bw);
> + }
> + return min_bw;
> + }
> else
> return UINT_MAX;
> }
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index fdae5a919bc8..d45a9ffaed4f 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -621,6 +621,9 @@ struct i915_gem_mm {
>
> #define I915_ENGINE_WEDGED_TIMEOUT (60 * HZ) /* Reset but no recovery? */
>
> +/* BSpec precisely defines this */
> +#define I915_NUM_SAGV_POINTS 8
I think everything else talks about "QGV points" rather
than "SAGV points" now? Would be nice to be consistent.
Apart from that
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> +
> struct ddi_vbt_port_info {
> /* Non-NULL if port present. */
> const struct child_device_config *child;
> @@ -1232,7 +1235,8 @@ struct drm_i915_private {
> } dram_info;
>
> struct intel_bw_info {
> - unsigned int deratedbw[3]; /* for each QGV point */
> + /* for each QGV point */
> + unsigned int deratedbw[I915_NUM_SAGV_POINTS];
> u8 num_qgv_points;
> u8 num_planes;
> } max_bw[6];
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] drm/i915: Support more QGV points
@ 2019-11-25 15:55 ` Lisovskiy, Stanislav
0 siblings, 0 replies; 17+ messages in thread
From: Lisovskiy, Stanislav @ 2019-11-25 15:55 UTC (permalink / raw)
To: ville.syrjala; +Cc: Sarvela, Tomi P, intel-gfx
On Mon, 2019-11-25 at 17:31 +0200, Ville Syrjälä wrote:
> On Fri, Nov 22, 2019 at 04:10:49PM +0200, Stanislav Lisovskiy wrote:
> > According to BSpec 53998, there is a mask of
> > max 8 SAGV/QGV points we need to support.
> >
> > Bumping this up to keep the CI happy(currently
> > preventing tests to run), until all SAGV
> > changes land.
> >
> > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189
> > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_bw.c | 22 +++++++++++++++++--
> > ---
> > drivers/gpu/drm/i915/i915_drv.h | 6 +++++-
> > 2 files changed, 22 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c
> > b/drivers/gpu/drm/i915/display/intel_bw.c
> > index 86e75e858008..d1b805b30177 100644
> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > @@ -15,7 +15,7 @@ struct intel_qgv_point {
> > };
> >
> > struct intel_qgv_info {
> > - struct intel_qgv_point points[3];
> > + struct intel_qgv_point points[I915_NUM_SAGV_POINTS];
> > u8 num_points;
> > u8 num_channels;
> > u8 t_bl;
> > @@ -276,15 +276,27 @@ void intel_bw_init_hw(struct drm_i915_private
> > *dev_priv)
> > static unsigned int intel_max_data_rate(struct drm_i915_private
> > *dev_priv,
> > int num_planes)
> > {
> > - if (INTEL_GEN(dev_priv) >= 11)
> > + if (INTEL_GEN(dev_priv) >= 11) {
> > + /*
> > + * Any bw group has same amount of QGV points
> > + */
> > + const struct intel_bw_info *bi =
> > + &dev_priv->max_bw[0];
> > + unsigned int min_bw = UINT_MAX;
> > + int i;
> > +
> > /*
> > * FIXME with SAGV disabled maybe we can assume
> > * point 1 will always be used? Seems to match
> > * the behaviour observed in the wild.
> > */
> > - return min3(icl_max_bw(dev_priv, num_planes, 0),
> > - icl_max_bw(dev_priv, num_planes, 1),
> > - icl_max_bw(dev_priv, num_planes, 2));
> > + for (i = 0; i < bi->num_qgv_points; i++) {
> > + unsigned int bw = icl_max_bw(dev_priv,
> > num_planes, i);
> > +
> > + min_bw = min(bw, min_bw);
> > + }
> > + return min_bw;
> > + }
> > else
> > return UINT_MAX;
> > }
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > b/drivers/gpu/drm/i915/i915_drv.h
> > index fdae5a919bc8..d45a9ffaed4f 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -621,6 +621,9 @@ struct i915_gem_mm {
> >
> > #define I915_ENGINE_WEDGED_TIMEOUT (60 * HZ) /* Reset but no
> > recovery? */
> >
> > +/* BSpec precisely defines this */
> > +#define I915_NUM_SAGV_POINTS 8
>
> I think everything else talks about "QGV points" rather
> than "SAGV points" now? Would be nice to be consistent.
Agree, _SAGV_ is not that accurate here.
Will change the naming.
Stan
>
> Apart from that
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> > +
> > struct ddi_vbt_port_info {
> > /* Non-NULL if port present. */
> > const struct child_device_config *child;
> > @@ -1232,7 +1235,8 @@ struct drm_i915_private {
> > } dram_info;
> >
> > struct intel_bw_info {
> > - unsigned int deratedbw[3]; /* for each QGV point */
> > + /* for each QGV point */
> > + unsigned int deratedbw[I915_NUM_SAGV_POINTS];
> > u8 num_qgv_points;
> > u8 num_planes;
> > } max_bw[6];
> > --
> > 2.17.1
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Support more QGV points
@ 2019-11-25 15:55 ` Lisovskiy, Stanislav
0 siblings, 0 replies; 17+ messages in thread
From: Lisovskiy, Stanislav @ 2019-11-25 15:55 UTC (permalink / raw)
To: ville.syrjala; +Cc: Sarvela, Tomi P, intel-gfx
On Mon, 2019-11-25 at 17:31 +0200, Ville Syrjälä wrote:
> On Fri, Nov 22, 2019 at 04:10:49PM +0200, Stanislav Lisovskiy wrote:
> > According to BSpec 53998, there is a mask of
> > max 8 SAGV/QGV points we need to support.
> >
> > Bumping this up to keep the CI happy(currently
> > preventing tests to run), until all SAGV
> > changes land.
> >
> > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189
> > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_bw.c | 22 +++++++++++++++++--
> > ---
> > drivers/gpu/drm/i915/i915_drv.h | 6 +++++-
> > 2 files changed, 22 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c
> > b/drivers/gpu/drm/i915/display/intel_bw.c
> > index 86e75e858008..d1b805b30177 100644
> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > @@ -15,7 +15,7 @@ struct intel_qgv_point {
> > };
> >
> > struct intel_qgv_info {
> > - struct intel_qgv_point points[3];
> > + struct intel_qgv_point points[I915_NUM_SAGV_POINTS];
> > u8 num_points;
> > u8 num_channels;
> > u8 t_bl;
> > @@ -276,15 +276,27 @@ void intel_bw_init_hw(struct drm_i915_private
> > *dev_priv)
> > static unsigned int intel_max_data_rate(struct drm_i915_private
> > *dev_priv,
> > int num_planes)
> > {
> > - if (INTEL_GEN(dev_priv) >= 11)
> > + if (INTEL_GEN(dev_priv) >= 11) {
> > + /*
> > + * Any bw group has same amount of QGV points
> > + */
> > + const struct intel_bw_info *bi =
> > + &dev_priv->max_bw[0];
> > + unsigned int min_bw = UINT_MAX;
> > + int i;
> > +
> > /*
> > * FIXME with SAGV disabled maybe we can assume
> > * point 1 will always be used? Seems to match
> > * the behaviour observed in the wild.
> > */
> > - return min3(icl_max_bw(dev_priv, num_planes, 0),
> > - icl_max_bw(dev_priv, num_planes, 1),
> > - icl_max_bw(dev_priv, num_planes, 2));
> > + for (i = 0; i < bi->num_qgv_points; i++) {
> > + unsigned int bw = icl_max_bw(dev_priv,
> > num_planes, i);
> > +
> > + min_bw = min(bw, min_bw);
> > + }
> > + return min_bw;
> > + }
> > else
> > return UINT_MAX;
> > }
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > b/drivers/gpu/drm/i915/i915_drv.h
> > index fdae5a919bc8..d45a9ffaed4f 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -621,6 +621,9 @@ struct i915_gem_mm {
> >
> > #define I915_ENGINE_WEDGED_TIMEOUT (60 * HZ) /* Reset but no
> > recovery? */
> >
> > +/* BSpec precisely defines this */
> > +#define I915_NUM_SAGV_POINTS 8
>
> I think everything else talks about "QGV points" rather
> than "SAGV points" now? Would be nice to be consistent.
Agree, _SAGV_ is not that accurate here.
Will change the naming.
Stan
>
> Apart from that
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> > +
> > struct ddi_vbt_port_info {
> > /* Non-NULL if port present. */
> > const struct child_device_config *child;
> > @@ -1232,7 +1235,8 @@ struct drm_i915_private {
> > } dram_info;
> >
> > struct intel_bw_info {
> > - unsigned int deratedbw[3]; /* for each QGV point */
> > + /* for each QGV point */
> > + unsigned int deratedbw[I915_NUM_SAGV_POINTS];
> > u8 num_qgv_points;
> > u8 num_planes;
> > } max_bw[6];
> > --
> > 2.17.1
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] drm/i915: Support more QGV points
@ 2019-11-25 16:03 ` Saarinen, Jani
0 siblings, 0 replies; 17+ messages in thread
From: Saarinen, Jani @ 2019-11-25 16:03 UTC (permalink / raw)
To: Lisovskiy, Stanislav, ville.syrjala; +Cc: Sarvela, Tomi P, intel-gfx
Hi,
> -----Original Message-----
> From: Lisovskiy, Stanislav <stanislav.lisovskiy@intel.com>
> Sent: maanantai 25. marraskuuta 2019 17.55
> To: ville.syrjala@linux.intel.com
> Cc: Saarinen, Jani <jani.saarinen@intel.com>; intel-gfx@lists.freedesktop.org;
> Roper, Matthew D <matthew.d.roper@intel.com>; jani.nikula@linux.intel.com;
> Sarvela, Tomi P <tomi.p.sarvela@intel.com>
> Subject: Re: [PATCH v2] drm/i915: Support more QGV points
>
> On Mon, 2019-11-25 at 17:31 +0200, Ville Syrjälä wrote:
> > On Fri, Nov 22, 2019 at 04:10:49PM +0200, Stanislav Lisovskiy wrote:
> > > According to BSpec 53998, there is a mask of max 8 SAGV/QGV points
> > > we need to support.
> > >
> > > Bumping this up to keep the CI happy(currently preventing tests to
> > > run), until all SAGV changes land.
> > >
> > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189
> > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_bw.c | 22 +++++++++++++++++--
> > > ---
> > > drivers/gpu/drm/i915/i915_drv.h | 6 +++++-
> > > 2 files changed, 22 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c
> > > b/drivers/gpu/drm/i915/display/intel_bw.c
> > > index 86e75e858008..d1b805b30177 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > > @@ -15,7 +15,7 @@ struct intel_qgv_point { };
> > >
> > > struct intel_qgv_info {
> > > - struct intel_qgv_point points[3];
> > > + struct intel_qgv_point points[I915_NUM_SAGV_POINTS];
> > > u8 num_points;
> > > u8 num_channels;
> > > u8 t_bl;
> > > @@ -276,15 +276,27 @@ void intel_bw_init_hw(struct drm_i915_private
> > > *dev_priv)
> > > static unsigned int intel_max_data_rate(struct drm_i915_private
> > > *dev_priv,
> > > int
> num_planes)
> > > {
> > > - if (INTEL_GEN(dev_priv) >= 11)
> > > + if (INTEL_GEN(dev_priv) >= 11) {
> > > + /*
> > > + * Any bw group has same amount of QGV points
> > > + */
> > > + const struct intel_bw_info *bi =
> > > + &dev_priv->max_bw[0];
> > > + unsigned int min_bw = UINT_MAX;
> > > + int i;
> > > +
> > > /*
> > > * FIXME with SAGV disabled maybe we can assume
> > > * point 1 will always be used? Seems to match
> > > * the behaviour observed in the wild.
> > > */
> > > - return min3(icl_max_bw(dev_priv, num_planes, 0),
> > > - icl_max_bw(dev_priv, num_planes,
> 1),
> > > - icl_max_bw(dev_priv, num_planes,
> 2));
> > > + for (i = 0; i < bi->num_qgv_points; i++) {
> > > + unsigned int bw = icl_max_bw(dev_priv,
> > > num_planes, i);
> > > +
> > > + min_bw = min(bw, min_bw);
> > > + }
> > > + return min_bw;
> > > + }
> > > else
> > > return UINT_MAX;
> > > }
> > > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > > b/drivers/gpu/drm/i915/i915_drv.h index fdae5a919bc8..d45a9ffaed4f
> > > 100644
> > > --- a/drivers/gpu/drm/i915/i915_drv.h
> > > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > > @@ -621,6 +621,9 @@ struct i915_gem_mm {
> > >
> > > #define I915_ENGINE_WEDGED_TIMEOUT (60 * HZ) /* Reset but no
> > > recovery? */
> > >
> > > +/* BSpec precisely defines this */
> > > +#define I915_NUM_SAGV_POINTS 8
> >
> > I think everything else talks about "QGV points" rather than "SAGV
> > points" now? Would be nice to be consistent.
>
> Agree, _SAGV_ is not that accurate here.
> Will change the naming.
Can we do that while merging?
>
> Stan
>
> >
> > Apart from that
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > > +
> > > struct ddi_vbt_port_info {
> > > /* Non-NULL if port present. */
> > > const struct child_device_config *child; @@ -1232,7 +1235,8 @@
> > > struct drm_i915_private {
> > > } dram_info;
> > >
> > > struct intel_bw_info {
> > > - unsigned int deratedbw[3]; /* for each QGV point */
> > > + /* for each QGV point */
> > > + unsigned int deratedbw[I915_NUM_SAGV_POINTS];
> > > u8 num_qgv_points;
> > > u8 num_planes;
> > > } max_bw[6];
> > > --
> > > 2.17.1
> >
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Support more QGV points
@ 2019-11-25 16:03 ` Saarinen, Jani
0 siblings, 0 replies; 17+ messages in thread
From: Saarinen, Jani @ 2019-11-25 16:03 UTC (permalink / raw)
To: Lisovskiy, Stanislav, ville.syrjala; +Cc: Sarvela, Tomi P, intel-gfx
Hi,
> -----Original Message-----
> From: Lisovskiy, Stanislav <stanislav.lisovskiy@intel.com>
> Sent: maanantai 25. marraskuuta 2019 17.55
> To: ville.syrjala@linux.intel.com
> Cc: Saarinen, Jani <jani.saarinen@intel.com>; intel-gfx@lists.freedesktop.org;
> Roper, Matthew D <matthew.d.roper@intel.com>; jani.nikula@linux.intel.com;
> Sarvela, Tomi P <tomi.p.sarvela@intel.com>
> Subject: Re: [PATCH v2] drm/i915: Support more QGV points
>
> On Mon, 2019-11-25 at 17:31 +0200, Ville Syrjälä wrote:
> > On Fri, Nov 22, 2019 at 04:10:49PM +0200, Stanislav Lisovskiy wrote:
> > > According to BSpec 53998, there is a mask of max 8 SAGV/QGV points
> > > we need to support.
> > >
> > > Bumping this up to keep the CI happy(currently preventing tests to
> > > run), until all SAGV changes land.
> > >
> > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189
> > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_bw.c | 22 +++++++++++++++++--
> > > ---
> > > drivers/gpu/drm/i915/i915_drv.h | 6 +++++-
> > > 2 files changed, 22 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c
> > > b/drivers/gpu/drm/i915/display/intel_bw.c
> > > index 86e75e858008..d1b805b30177 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > > @@ -15,7 +15,7 @@ struct intel_qgv_point { };
> > >
> > > struct intel_qgv_info {
> > > - struct intel_qgv_point points[3];
> > > + struct intel_qgv_point points[I915_NUM_SAGV_POINTS];
> > > u8 num_points;
> > > u8 num_channels;
> > > u8 t_bl;
> > > @@ -276,15 +276,27 @@ void intel_bw_init_hw(struct drm_i915_private
> > > *dev_priv)
> > > static unsigned int intel_max_data_rate(struct drm_i915_private
> > > *dev_priv,
> > > int
> num_planes)
> > > {
> > > - if (INTEL_GEN(dev_priv) >= 11)
> > > + if (INTEL_GEN(dev_priv) >= 11) {
> > > + /*
> > > + * Any bw group has same amount of QGV points
> > > + */
> > > + const struct intel_bw_info *bi =
> > > + &dev_priv->max_bw[0];
> > > + unsigned int min_bw = UINT_MAX;
> > > + int i;
> > > +
> > > /*
> > > * FIXME with SAGV disabled maybe we can assume
> > > * point 1 will always be used? Seems to match
> > > * the behaviour observed in the wild.
> > > */
> > > - return min3(icl_max_bw(dev_priv, num_planes, 0),
> > > - icl_max_bw(dev_priv, num_planes,
> 1),
> > > - icl_max_bw(dev_priv, num_planes,
> 2));
> > > + for (i = 0; i < bi->num_qgv_points; i++) {
> > > + unsigned int bw = icl_max_bw(dev_priv,
> > > num_planes, i);
> > > +
> > > + min_bw = min(bw, min_bw);
> > > + }
> > > + return min_bw;
> > > + }
> > > else
> > > return UINT_MAX;
> > > }
> > > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > > b/drivers/gpu/drm/i915/i915_drv.h index fdae5a919bc8..d45a9ffaed4f
> > > 100644
> > > --- a/drivers/gpu/drm/i915/i915_drv.h
> > > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > > @@ -621,6 +621,9 @@ struct i915_gem_mm {
> > >
> > > #define I915_ENGINE_WEDGED_TIMEOUT (60 * HZ) /* Reset but no
> > > recovery? */
> > >
> > > +/* BSpec precisely defines this */
> > > +#define I915_NUM_SAGV_POINTS 8
> >
> > I think everything else talks about "QGV points" rather than "SAGV
> > points" now? Would be nice to be consistent.
>
> Agree, _SAGV_ is not that accurate here.
> Will change the naming.
Can we do that while merging?
>
> Stan
>
> >
> > Apart from that
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > > +
> > > struct ddi_vbt_port_info {
> > > /* Non-NULL if port present. */
> > > const struct child_device_config *child; @@ -1232,7 +1235,8 @@
> > > struct drm_i915_private {
> > > } dram_info;
> > >
> > > struct intel_bw_info {
> > > - unsigned int deratedbw[3]; /* for each QGV point */
> > > + /* for each QGV point */
> > > + unsigned int deratedbw[I915_NUM_SAGV_POINTS];
> > > u8 num_qgv_points;
> > > u8 num_planes;
> > > } max_bw[6];
> > > --
> > > 2.17.1
> >
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] drm/i915: Support more QGV points
@ 2019-11-25 16:08 ` Lisovskiy, Stanislav
0 siblings, 0 replies; 17+ messages in thread
From: Lisovskiy, Stanislav @ 2019-11-25 16:08 UTC (permalink / raw)
To: Saarinen, Jani, ville.syrjala; +Cc: Sarvela, Tomi P, intel-gfx
On Mon, 2019-11-25 at 16:03 +0000, Saarinen, Jani wrote:
> Hi,
>
> > -----Original Message-----
> > From: Lisovskiy, Stanislav <stanislav.lisovskiy@intel.com>
> > Sent: maanantai 25. marraskuuta 2019 17.55
> > To: ville.syrjala@linux.intel.com
> > Cc: Saarinen, Jani <jani.saarinen@intel.com>;
> > intel-gfx@lists.freedesktop.org;
> > Roper, Matthew D <matthew.d.roper@intel.com>;
> > jani.nikula@linux.intel.com;
> > Sarvela, Tomi P <tomi.p.sarvela@intel.com>
> > Subject: Re: [PATCH v2] drm/i915: Support more QGV points
> >
> > On Mon, 2019-11-25 at 17:31 +0200, Ville Syrjälä wrote:
> > > On Fri, Nov 22, 2019 at 04:10:49PM +0200, Stanislav Lisovskiy
> > > wrote:
> > > > According to BSpec 53998, there is a mask of max 8 SAGV/QGV
> > > > points
> > > > we need to support.
> > > >
> > > > Bumping this up to keep the CI happy(currently preventing tests
> > > > to
> > > > run), until all SAGV changes land.
> > > >
> > > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189
> > > > Signed-off-by: Stanislav Lisovskiy <
> > > > stanislav.lisovskiy@intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/display/intel_bw.c | 22
> > > > +++++++++++++++++--
> > > > ---
> > > > drivers/gpu/drm/i915/i915_drv.h | 6 +++++-
> > > > 2 files changed, 22 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c
> > > > b/drivers/gpu/drm/i915/display/intel_bw.c
> > > > index 86e75e858008..d1b805b30177 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > > > @@ -15,7 +15,7 @@ struct intel_qgv_point { };
> > > >
> > > > struct intel_qgv_info {
> > > > - struct intel_qgv_point points[3];
> > > > + struct intel_qgv_point points[I915_NUM_SAGV_POINTS];
> > > > u8 num_points;
> > > > u8 num_channels;
> > > > u8 t_bl;
> > > > @@ -276,15 +276,27 @@ void intel_bw_init_hw(struct
> > > > drm_i915_private
> > > > *dev_priv)
> > > > static unsigned int intel_max_data_rate(struct
> > > > drm_i915_private
> > > > *dev_priv,
> > > > int
> >
> > num_planes)
> > > > {
> > > > - if (INTEL_GEN(dev_priv) >= 11)
> > > > + if (INTEL_GEN(dev_priv) >= 11) {
> > > > + /*
> > > > + * Any bw group has same amount of QGV points
> > > > + */
> > > > + const struct intel_bw_info *bi =
> > > > + &dev_priv->max_bw[0];
> > > > + unsigned int min_bw = UINT_MAX;
> > > > + int i;
> > > > +
> > > > /*
> > > > * FIXME with SAGV disabled maybe we can assume
> > > > * point 1 will always be used? Seems to match
> > > > * the behaviour observed in the wild.
> > > > */
> > > > - return min3(icl_max_bw(dev_priv, num_planes,
> > > > 0),
> > > > - icl_max_bw(dev_priv, num_planes,
> >
> > 1),
> > > > - icl_max_bw(dev_priv, num_planes,
> >
> > 2));
> > > > + for (i = 0; i < bi->num_qgv_points; i++) {
> > > > + unsigned int bw = icl_max_bw(dev_priv,
> > > > num_planes, i);
> > > > +
> > > > + min_bw = min(bw, min_bw);
> > > > + }
> > > > + return min_bw;
> > > > + }
> > > > else
> > > > return UINT_MAX;
> > > > }
> > > > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > > > b/drivers/gpu/drm/i915/i915_drv.h index
> > > > fdae5a919bc8..d45a9ffaed4f
> > > > 100644
> > > > --- a/drivers/gpu/drm/i915/i915_drv.h
> > > > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > > > @@ -621,6 +621,9 @@ struct i915_gem_mm {
> > > >
> > > > #define I915_ENGINE_WEDGED_TIMEOUT (60 * HZ) /* Reset but no
> > > > recovery? */
> > > >
> > > > +/* BSpec precisely defines this */
> > > > +#define I915_NUM_SAGV_POINTS 8
> > >
> > > I think everything else talks about "QGV points" rather than
> > > "SAGV
> > > points" now? Would be nice to be consistent.
> >
> > Agree, _SAGV_ is not that accurate here.
> > Will change the naming.
>
> Can we do that while merging?
I have already changed the name, will now send a v3,
as this is a trivial fix, I guess we can then push it.
>
> >
> > Stan
> >
> > >
> > > Apart from that
> > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > > +
> > > > struct ddi_vbt_port_info {
> > > > /* Non-NULL if port present. */
> > > > const struct child_device_config *child; @@ -1232,7
> > > > +1235,8 @@
> > > > struct drm_i915_private {
> > > > } dram_info;
> > > >
> > > > struct intel_bw_info {
> > > > - unsigned int deratedbw[3]; /* for each QGV
> > > > point */
> > > > + /* for each QGV point */
> > > > + unsigned int deratedbw[I915_NUM_SAGV_POINTS];
> > > > u8 num_qgv_points;
> > > > u8 num_planes;
> > > > } max_bw[6];
> > > > --
> > > > 2.17.1
> > >
> > >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Support more QGV points
@ 2019-11-25 16:08 ` Lisovskiy, Stanislav
0 siblings, 0 replies; 17+ messages in thread
From: Lisovskiy, Stanislav @ 2019-11-25 16:08 UTC (permalink / raw)
To: Saarinen, Jani, ville.syrjala; +Cc: Sarvela, Tomi P, intel-gfx
On Mon, 2019-11-25 at 16:03 +0000, Saarinen, Jani wrote:
> Hi,
>
> > -----Original Message-----
> > From: Lisovskiy, Stanislav <stanislav.lisovskiy@intel.com>
> > Sent: maanantai 25. marraskuuta 2019 17.55
> > To: ville.syrjala@linux.intel.com
> > Cc: Saarinen, Jani <jani.saarinen@intel.com>;
> > intel-gfx@lists.freedesktop.org;
> > Roper, Matthew D <matthew.d.roper@intel.com>;
> > jani.nikula@linux.intel.com;
> > Sarvela, Tomi P <tomi.p.sarvela@intel.com>
> > Subject: Re: [PATCH v2] drm/i915: Support more QGV points
> >
> > On Mon, 2019-11-25 at 17:31 +0200, Ville Syrjälä wrote:
> > > On Fri, Nov 22, 2019 at 04:10:49PM +0200, Stanislav Lisovskiy
> > > wrote:
> > > > According to BSpec 53998, there is a mask of max 8 SAGV/QGV
> > > > points
> > > > we need to support.
> > > >
> > > > Bumping this up to keep the CI happy(currently preventing tests
> > > > to
> > > > run), until all SAGV changes land.
> > > >
> > > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189
> > > > Signed-off-by: Stanislav Lisovskiy <
> > > > stanislav.lisovskiy@intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/display/intel_bw.c | 22
> > > > +++++++++++++++++--
> > > > ---
> > > > drivers/gpu/drm/i915/i915_drv.h | 6 +++++-
> > > > 2 files changed, 22 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c
> > > > b/drivers/gpu/drm/i915/display/intel_bw.c
> > > > index 86e75e858008..d1b805b30177 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > > > @@ -15,7 +15,7 @@ struct intel_qgv_point { };
> > > >
> > > > struct intel_qgv_info {
> > > > - struct intel_qgv_point points[3];
> > > > + struct intel_qgv_point points[I915_NUM_SAGV_POINTS];
> > > > u8 num_points;
> > > > u8 num_channels;
> > > > u8 t_bl;
> > > > @@ -276,15 +276,27 @@ void intel_bw_init_hw(struct
> > > > drm_i915_private
> > > > *dev_priv)
> > > > static unsigned int intel_max_data_rate(struct
> > > > drm_i915_private
> > > > *dev_priv,
> > > > int
> >
> > num_planes)
> > > > {
> > > > - if (INTEL_GEN(dev_priv) >= 11)
> > > > + if (INTEL_GEN(dev_priv) >= 11) {
> > > > + /*
> > > > + * Any bw group has same amount of QGV points
> > > > + */
> > > > + const struct intel_bw_info *bi =
> > > > + &dev_priv->max_bw[0];
> > > > + unsigned int min_bw = UINT_MAX;
> > > > + int i;
> > > > +
> > > > /*
> > > > * FIXME with SAGV disabled maybe we can assume
> > > > * point 1 will always be used? Seems to match
> > > > * the behaviour observed in the wild.
> > > > */
> > > > - return min3(icl_max_bw(dev_priv, num_planes,
> > > > 0),
> > > > - icl_max_bw(dev_priv, num_planes,
> >
> > 1),
> > > > - icl_max_bw(dev_priv, num_planes,
> >
> > 2));
> > > > + for (i = 0; i < bi->num_qgv_points; i++) {
> > > > + unsigned int bw = icl_max_bw(dev_priv,
> > > > num_planes, i);
> > > > +
> > > > + min_bw = min(bw, min_bw);
> > > > + }
> > > > + return min_bw;
> > > > + }
> > > > else
> > > > return UINT_MAX;
> > > > }
> > > > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > > > b/drivers/gpu/drm/i915/i915_drv.h index
> > > > fdae5a919bc8..d45a9ffaed4f
> > > > 100644
> > > > --- a/drivers/gpu/drm/i915/i915_drv.h
> > > > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > > > @@ -621,6 +621,9 @@ struct i915_gem_mm {
> > > >
> > > > #define I915_ENGINE_WEDGED_TIMEOUT (60 * HZ) /* Reset but no
> > > > recovery? */
> > > >
> > > > +/* BSpec precisely defines this */
> > > > +#define I915_NUM_SAGV_POINTS 8
> > >
> > > I think everything else talks about "QGV points" rather than
> > > "SAGV
> > > points" now? Would be nice to be consistent.
> >
> > Agree, _SAGV_ is not that accurate here.
> > Will change the naming.
>
> Can we do that while merging?
I have already changed the name, will now send a v3,
as this is a trivial fix, I guess we can then push it.
>
> >
> > Stan
> >
> > >
> > > Apart from that
> > > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > > +
> > > > struct ddi_vbt_port_info {
> > > > /* Non-NULL if port present. */
> > > > const struct child_device_config *child; @@ -1232,7
> > > > +1235,8 @@
> > > > struct drm_i915_private {
> > > > } dram_info;
> > > >
> > > > struct intel_bw_info {
> > > > - unsigned int deratedbw[3]; /* for each QGV
> > > > point */
> > > > + /* for each QGV point */
> > > > + unsigned int deratedbw[I915_NUM_SAGV_POINTS];
> > > > u8 num_qgv_points;
> > > > u8 num_planes;
> > > > } max_bw[6];
> > > > --
> > > > 2.17.1
> > >
> > >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2] drm/i915: Support more QGV points
@ 2019-11-22 14:09 Stanislav Lisovskiy
0 siblings, 0 replies; 17+ messages in thread
From: Stanislav Lisovskiy @ 2019-11-22 14:09 UTC (permalink / raw)
To: intel-gfx; +Cc: tomi.p.sarvela
According to BSpec 53998, there is a mask of
max 8 SAGV/QGV points we need to support.
Bumping this up to keep the CI happy(currently
preventing tests to run), until all SAGV
changes land.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
drivers/gpu/drm/i915/display/intel_bw.c | 25 ++++++++++++++++++++-----
drivers/gpu/drm/i915/i915_drv.h | 6 +++++-
2 files changed, 25 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index 86e75e858008..a6c15f133dd3 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -15,7 +15,7 @@ struct intel_qgv_point {
};
struct intel_qgv_info {
- struct intel_qgv_point points[3];
+ struct intel_qgv_point points[I915_NUM_SAGV_POINTS];
u8 num_points;
u8 num_channels;
u8 t_bl;
@@ -125,6 +125,9 @@ static int icl_get_qgv_points(struct drm_i915_private *dev_priv,
if (WARN_ON(qi->num_points > ARRAY_SIZE(qi->points)))
qi->num_points = ARRAY_SIZE(qi->points);
+ if (qi->num_points > 3)
+ qi->num_points = 3;
+
for (i = 0; i < qi->num_points; i++) {
struct intel_qgv_point *sp = &qi->points[i];
@@ -276,15 +279,27 @@ void intel_bw_init_hw(struct drm_i915_private *dev_priv)
static unsigned int intel_max_data_rate(struct drm_i915_private *dev_priv,
int num_planes)
{
- if (INTEL_GEN(dev_priv) >= 11)
+ if (INTEL_GEN(dev_priv) >= 11) {
+ /*
+ * Any bw group has same amount of QGV points
+ */
+ const struct intel_bw_info *bi =
+ &dev_priv->max_bw[0];
+ unsigned int min_bw = UINT_MAX;
+ int i;
+
/*
* FIXME with SAGV disabled maybe we can assume
* point 1 will always be used? Seems to match
* the behaviour observed in the wild.
*/
- return min3(icl_max_bw(dev_priv, num_planes, 0),
- icl_max_bw(dev_priv, num_planes, 1),
- icl_max_bw(dev_priv, num_planes, 2));
+ for (i = 0; i < bi->num_qgv_points; i++) {
+ unsigned int bw = icl_max_bw(dev_priv, num_planes, i);
+
+ min_bw = min(bw, min_bw);
+ }
+ return min_bw;
+ }
else
return UINT_MAX;
}
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index fdae5a919bc8..d45a9ffaed4f 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -621,6 +621,9 @@ struct i915_gem_mm {
#define I915_ENGINE_WEDGED_TIMEOUT (60 * HZ) /* Reset but no recovery? */
+/* BSpec precisely defines this */
+#define I915_NUM_SAGV_POINTS 8
+
struct ddi_vbt_port_info {
/* Non-NULL if port present. */
const struct child_device_config *child;
@@ -1232,7 +1235,8 @@ struct drm_i915_private {
} dram_info;
struct intel_bw_info {
- unsigned int deratedbw[3]; /* for each QGV point */
+ /* for each QGV point */
+ unsigned int deratedbw[I915_NUM_SAGV_POINTS];
u8 num_qgv_points;
u8 num_planes;
} max_bw[6];
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
end of thread, other threads:[~2019-11-25 16:08 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 14:10 [PATCH v2] drm/i915: Support more QGV points Stanislav Lisovskiy
2019-11-22 14:10 ` [Intel-gfx] " Stanislav Lisovskiy
2019-11-22 14:45 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support more QGV points (rev3) Patchwork
2019-11-22 14:45 ` [Intel-gfx] " Patchwork
2019-11-22 15:07 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-22 15:07 ` [Intel-gfx] " Patchwork
2019-11-23 23:10 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-23 23:10 ` [Intel-gfx] " Patchwork
2019-11-25 15:31 ` [PATCH v2] drm/i915: Support more QGV points Ville Syrjälä
2019-11-25 15:31 ` [Intel-gfx] " Ville Syrjälä
2019-11-25 15:55 ` Lisovskiy, Stanislav
2019-11-25 15:55 ` [Intel-gfx] " Lisovskiy, Stanislav
2019-11-25 16:03 ` Saarinen, Jani
2019-11-25 16:03 ` [Intel-gfx] " Saarinen, Jani
2019-11-25 16:08 ` Lisovskiy, Stanislav
2019-11-25 16:08 ` [Intel-gfx] " Lisovskiy, Stanislav
-- strict thread matches above, loose matches on Subject: below --
2019-11-22 14:09 Stanislav Lisovskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.