* [PATCH i-g-t] i915/gem_ctx_param: Keep the engine active while peeking at vm layout @ 2019-11-24 11:27 ` Chris Wilson 0 siblings, 0 replies; 8+ messages in thread From: Chris Wilson @ 2019-11-24 11:27 UTC (permalink / raw) To: intel-gfx; +Cc: igt-dev The implicit soft-pinning we use to probe the vm layout using execbuf, depends on the batch remaining active (not retired) between execbufs. Naturally, if the background retire worker runs the batch is retired and the implicit soft-pinning is free to use a fresh address. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- tests/i915/gem_ctx_param.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c index bd1ee3996..63e0db38d 100644 --- a/tests/i915/gem_ctx_param.c +++ b/tests/i915/gem_ctx_param.c @@ -161,6 +161,7 @@ static void test_vm(int i915) .param = I915_CONTEXT_PARAM_VM, }; uint32_t parent, child; + igt_spin_t *spin; /* * Proving 2 contexts share the same GTT is quite tricky as we have no @@ -177,6 +178,15 @@ static void test_vm(int i915) parent = gem_context_create(i915); child = gem_context_create(i915); + /* Create a background spinner to keep the engines busy */ + spin = igt_spin_new(i915); + for (int i = 0; i < 16; i++) { + spin->execbuf.rsvd1 = gem_context_create(i915); + gem_context_set_priority(i915, spin->execbuf.rsvd1, 1023); + gem_execbuf(i915, &spin->execbuf); + gem_context_destroy(i915, spin->execbuf.rsvd1); + } + /* Using implicit soft-pinning */ eb.rsvd1 = parent; batch.offset = nonzero_offset; @@ -226,6 +236,7 @@ static void test_vm(int i915) gem_context_destroy(i915, child); gem_vm_destroy(i915, arg.value); + igt_spin_free(i915, spin); gem_sync(i915, batch.handle); gem_close(i915, batch.handle); } -- 2.24.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t] i915/gem_ctx_param: Keep the engine active while peeking at vm layout @ 2019-11-24 11:27 ` Chris Wilson 0 siblings, 0 replies; 8+ messages in thread From: Chris Wilson @ 2019-11-24 11:27 UTC (permalink / raw) To: intel-gfx; +Cc: igt-dev The implicit soft-pinning we use to probe the vm layout using execbuf, depends on the batch remaining active (not retired) between execbufs. Naturally, if the background retire worker runs the batch is retired and the implicit soft-pinning is free to use a fresh address. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- tests/i915/gem_ctx_param.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c index bd1ee3996..63e0db38d 100644 --- a/tests/i915/gem_ctx_param.c +++ b/tests/i915/gem_ctx_param.c @@ -161,6 +161,7 @@ static void test_vm(int i915) .param = I915_CONTEXT_PARAM_VM, }; uint32_t parent, child; + igt_spin_t *spin; /* * Proving 2 contexts share the same GTT is quite tricky as we have no @@ -177,6 +178,15 @@ static void test_vm(int i915) parent = gem_context_create(i915); child = gem_context_create(i915); + /* Create a background spinner to keep the engines busy */ + spin = igt_spin_new(i915); + for (int i = 0; i < 16; i++) { + spin->execbuf.rsvd1 = gem_context_create(i915); + gem_context_set_priority(i915, spin->execbuf.rsvd1, 1023); + gem_execbuf(i915, &spin->execbuf); + gem_context_destroy(i915, spin->execbuf.rsvd1); + } + /* Using implicit soft-pinning */ eb.rsvd1 = parent; batch.offset = nonzero_offset; @@ -226,6 +236,7 @@ static void test_vm(int i915) gem_context_destroy(i915, child); gem_vm_destroy(i915, arg.value); + igt_spin_free(i915, spin); gem_sync(i915, batch.handle); gem_close(i915, batch.handle); } -- 2.24.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_param: Keep the engine active while peeking at vm layout @ 2019-11-24 11:27 ` Chris Wilson 0 siblings, 0 replies; 8+ messages in thread From: Chris Wilson @ 2019-11-24 11:27 UTC (permalink / raw) To: intel-gfx; +Cc: igt-dev The implicit soft-pinning we use to probe the vm layout using execbuf, depends on the batch remaining active (not retired) between execbufs. Naturally, if the background retire worker runs the batch is retired and the implicit soft-pinning is free to use a fresh address. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- tests/i915/gem_ctx_param.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c index bd1ee3996..63e0db38d 100644 --- a/tests/i915/gem_ctx_param.c +++ b/tests/i915/gem_ctx_param.c @@ -161,6 +161,7 @@ static void test_vm(int i915) .param = I915_CONTEXT_PARAM_VM, }; uint32_t parent, child; + igt_spin_t *spin; /* * Proving 2 contexts share the same GTT is quite tricky as we have no @@ -177,6 +178,15 @@ static void test_vm(int i915) parent = gem_context_create(i915); child = gem_context_create(i915); + /* Create a background spinner to keep the engines busy */ + spin = igt_spin_new(i915); + for (int i = 0; i < 16; i++) { + spin->execbuf.rsvd1 = gem_context_create(i915); + gem_context_set_priority(i915, spin->execbuf.rsvd1, 1023); + gem_execbuf(i915, &spin->execbuf); + gem_context_destroy(i915, spin->execbuf.rsvd1); + } + /* Using implicit soft-pinning */ eb.rsvd1 = parent; batch.offset = nonzero_offset; @@ -226,6 +236,7 @@ static void test_vm(int i915) gem_context_destroy(i915, child); gem_vm_destroy(i915, arg.value); + igt_spin_free(i915, spin); gem_sync(i915, batch.handle); gem_close(i915, batch.handle); } -- 2.24.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_ctx_param: Keep the engine active while peeking at vm layout 2019-11-24 11:27 ` [Intel-gfx] " Chris Wilson (?) (?) @ 2019-11-24 12:12 ` Patchwork -1 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2019-11-24 12:12 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev == Series Details == Series: i915/gem_ctx_param: Keep the engine active while peeking at vm layout URL : https://patchwork.freedesktop.org/series/69947/ State : success == Summary == CI Bug Log - changes from IGT_5304 -> IGTPW_3751 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/index.html Known issues ------------ Here are the changes found in IGTPW_3751 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_module_load@reload-with-fault-injection: - fi-skl-6770hq: [PASS][1] -> [DMESG-WARN][2] ([fdo#105541]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/fi-skl-6770hq/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_selftest@live_blt: - fi-hsw-peppy: [PASS][3] -> [DMESG-FAIL][4] ([fdo#112147]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/fi-hsw-peppy/igt@i915_selftest@live_blt.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/fi-hsw-peppy/igt@i915_selftest@live_blt.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([fdo#111407]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html * igt@kms_flip@basic-flip-vs-dpms: - fi-skl-6770hq: [PASS][7] -> [SKIP][8] ([fdo#109271]) +26 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html #### Possible fixes #### * igt@i915_selftest@live_gem_contexts: - fi-bsw-n3050: [INCOMPLETE][9] ([fdo# 111542]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html #### Warnings #### * igt@gem_exec_suspend@basic-s4-devices: - fi-kbl-x1275: [DMESG-WARN][11] ([fdo#103558] / [fdo#105602] / [fdo#105763] / [fdo#107139]) -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602] / [fdo#107139]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy: - fi-kbl-x1275: [DMESG-WARN][13] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +7 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/fi-kbl-x1275/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html * igt@kms_flip@basic-flip-vs-dpms: - fi-kbl-x1275: [DMESG-WARN][15] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][16] ([fdo#103558] / [fdo#105602]) +5 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-dpms.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-dpms.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542 [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558 [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541 [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602 [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763 [fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964 [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407 [fdo#112147]: https://bugs.freedesktop.org/show_bug.cgi?id=112147 [fdo#112260]: https://bugs.freedesktop.org/show_bug.cgi?id=112260 [fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298 Participating hosts (44 -> 40) ------------------------------ Additional (2): fi-bsw-kefka fi-bwr-2160 Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-gdg-551 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5304 -> IGTPW_3751 CI-20190529: 20190529 CI_DRM_7411: 9e8df10785d3ae60d3b54bc45e06aa32621a472c @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3751: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/index.html IGT_5304: 0542bba6d00cfe56fb36c3340a77fe93df5147a7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_ctx_param: Keep the engine active while peeking at vm layout 2019-11-24 11:27 ` [Intel-gfx] " Chris Wilson ` (2 preceding siblings ...) (?) @ 2019-11-24 20:36 ` Patchwork -1 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2019-11-24 20:36 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev == Series Details == Series: i915/gem_ctx_param: Keep the engine active while peeking at vm layout URL : https://patchwork.freedesktop.org/series/69947/ State : success == Summary == CI Bug Log - changes from IGT_5304_full -> IGTPW_3751_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/index.html Known issues ------------ Here are the changes found in IGTPW_3751_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@bcs0-s3: - shard-tglb: [PASS][1] -> [INCOMPLETE][2] ([fdo#111832]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-tglb9/igt@gem_ctx_isolation@bcs0-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-tglb7/igt@gem_ctx_isolation@bcs0-s3.html * igt@gem_ctx_isolation@vcs1-s3: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb2/igt@gem_ctx_isolation@vcs1-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb3/igt@gem_ctx_isolation@vcs1-s3.html * igt@gem_ctx_shared@q-smoketest-blt: - shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([fdo#111735]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-tglb7/igt@gem_ctx_shared@q-smoketest-blt.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-tglb6/igt@gem_ctx_shared@q-smoketest-blt.html * igt@gem_exec_parallel@vcs1-fds: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112080]) +10 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb6/igt@gem_exec_parallel@vcs1-fds.html * igt@gem_exec_schedule@in-order-bsd: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +8 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb6/igt@gem_exec_schedule@in-order-bsd.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb1/igt@gem_exec_schedule@in-order-bsd.html * igt@gem_exec_schedule@promotion-bsd1: - shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109276]) +17 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb8/igt@gem_exec_schedule@promotion-bsd1.html * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive: - shard-apl: [PASS][13] -> [TIMEOUT][14] ([fdo#112068 ] / [fdo#112113]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-apl4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-apl1/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup: - shard-hsw: [PASS][15] -> [DMESG-WARN][16] ([fdo#111870]) +3 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html * igt@gem_userptr_blits@sync-unmap-cycles: - shard-snb: [PASS][17] -> [DMESG-WARN][18] ([fdo#111870]) +2 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-snb7/igt@gem_userptr_blits@sync-unmap-cycles.html * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +2 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [PASS][21] -> [FAIL][22] ([fdo#111830 ]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb8/igt@i915_pm_dc@dc6-psr.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb6/igt@i915_pm_dc@dc6-psr.html * igt@i915_selftest@live_requests: - shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([fdo#112057]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-tglb4/igt@i915_selftest@live_requests.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-tglb6/igt@i915_selftest@live_requests.html * igt@kms_flip@flip-vs-suspend: - shard-snb: [PASS][25] -> [INCOMPLETE][26] ([fdo#105411]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-snb1/igt@kms_flip@flip-vs-suspend.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-snb1/igt@kms_flip@flip-vs-suspend.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt: - shard-tglb: [PASS][27] -> [FAIL][28] ([fdo#103167]) +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff: - shard-apl: [PASS][29] -> [FAIL][30] ([fdo#103167]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-apl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-apl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html - shard-kbl: [PASS][31] -> [FAIL][32] ([fdo#103167]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt: - shard-glk: [PASS][33] -> [FAIL][34] ([fdo#103167]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-glk2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-glk7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite: - shard-iclb: [PASS][35] -> [FAIL][36] ([fdo#103167]) +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-tglb: [PASS][37] -> [INCOMPLETE][38] ([fdo#111832] / [fdo#111850] / [fdo#111884]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-suspend.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-tglb: [PASS][39] -> [INCOMPLETE][40] ([fdo#111832] / [fdo#111850]) +2 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-tglb1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-tglb2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: - shard-apl: [PASS][41] -> [DMESG-WARN][42] ([fdo#108566]) +4 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109441]) +2 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb4/igt@kms_psr@psr2_cursor_blt.html * igt@kms_setmode@basic: - shard-kbl: [PASS][45] -> [FAIL][46] ([fdo#99912]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-kbl7/igt@kms_setmode@basic.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-kbl6/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend: - shard-tglb: [PASS][47] -> [INCOMPLETE][48] ([fdo#111850]) +1 similar issue [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-tglb5/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-tglb3/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html * igt@perf@oa-exponents: - shard-glk: [PASS][49] -> [FAIL][50] ([fdo#105483]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-glk5/igt@perf@oa-exponents.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-glk8/igt@perf@oa-exponents.html #### Possible fixes #### * igt@gem_ctx_persistence@vcs1-queued: - shard-iclb: [SKIP][51] ([fdo#109276] / [fdo#112080]) -> [PASS][52] +3 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb5/igt@gem_ctx_persistence@vcs1-queued.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb1/igt@gem_ctx_persistence@vcs1-queued.html * igt@gem_ctx_switch@vcs1-heavy: - shard-iclb: [SKIP][53] ([fdo#112080]) -> [PASS][54] +12 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb3/igt@gem_ctx_switch@vcs1-heavy.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb2/igt@gem_ctx_switch@vcs1-heavy.html * igt@gem_exec_balancer@smoke: - shard-iclb: [SKIP][55] ([fdo#110854]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb6/igt@gem_exec_balancer@smoke.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb1/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@preempt-contexts-bsd2: - shard-iclb: [SKIP][57] ([fdo#109276]) -> [PASS][58] +15 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb3/igt@gem_exec_schedule@preempt-contexts-bsd2.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb4/igt@gem_exec_schedule@preempt-contexts-bsd2.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [SKIP][59] ([fdo#112146]) -> [PASS][60] +3 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb3/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_userptr_blits@dmabuf-sync: - shard-snb: [DMESG-WARN][61] ([fdo#111870]) -> [PASS][62] +1 similar issue [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-snb1/igt@gem_userptr_blits@dmabuf-sync.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-snb5/igt@gem_userptr_blits@dmabuf-sync.html * igt@gem_userptr_blits@dmabuf-unsync: - shard-hsw: [DMESG-WARN][63] ([fdo#111870]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-hsw2/igt@gem_userptr_blits@dmabuf-unsync.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-hsw7/igt@gem_userptr_blits@dmabuf-unsync.html * igt@i915_suspend@debugfs-reader: - shard-tglb: [INCOMPLETE][65] ([fdo#111832] / [fdo#111850]) -> [PASS][66] +2 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-tglb3/igt@i915_suspend@debugfs-reader.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-tglb5/igt@i915_suspend@debugfs-reader.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-iclb: [DMESG-WARN][67] ([fdo#111764]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-tglb: [INCOMPLETE][69] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-tglb4/igt@kms_fbcon_fbt@fbc-suspend.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-tglb5/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@2x-flip-vs-fences-interruptible: - shard-hsw: [INCOMPLETE][71] ([fdo#103540]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-hsw2/igt@kms_flip@2x-flip-vs-fences-interruptible.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-hsw5/igt@kms_flip@2x-flip-vs-fences-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt: - shard-apl: [FAIL][73] ([fdo#103167]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html - shard-kbl: [FAIL][75] ([fdo#103167]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-apl: [DMESG-WARN][77] ([fdo#108566]) -> [PASS][78] +3 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-apl1/igt@kms_frontbuffer_tracking@fbc-suspend.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-apl4/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt: - shard-iclb: [FAIL][79] ([fdo#103167]) -> [PASS][80] +10 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-kbl: [DMESG-WARN][81] ([fdo#108566]) -> [PASS][82] +5 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-iclb: [FAIL][83] ([fdo#103166]) -> [PASS][84] [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [SKIP][85] ([fdo#109642] / [fdo#111068]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb8/igt@kms_psr2_su@frontbuffer.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb2/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_dpms: - shard-iclb: [SKIP][87] ([fdo#109441]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb8/igt@kms_psr@psr2_dpms.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb2/igt@kms_psr@psr2_dpms.html * igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend: - shard-tglb: [INCOMPLETE][89] ([fdo#111850]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-tglb4/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-tglb3/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html #### Warnings #### * igt@gem_ctx_isolation@vcs1-nonpriv: - shard-iclb: [FAIL][91] ([fdo#111329]) -> [SKIP][92] ([fdo#109276] / [fdo#112080]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv.html * igt@gem_ctx_isolation@vcs1-nonpriv-switch: - shard-iclb: [SKIP][93] ([fdo#109276] / [fdo#112080]) -> [FAIL][94] ([fdo#111329]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-iclb6/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html * igt@i915_pm_dc@dc6-dpms: - shard-tglb: [FAIL][95] ([fdo#111830 ]) -> [SKIP][96] ([fdo#111865]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5304/shard-tglb7/igt@i915_pm_dc@dc6-dpms.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/shard-tglb6/igt@i915_pm_dc@dc6-dpms.html [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411 [fdo#105483]: https://bugs.freedesktop.org/show_bug.cgi?id=105483 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329 [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735 [fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747 [fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764 [fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830 [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832 [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850 [fdo#111865]: https://bugs.freedesktop.org/show_bug.cgi?id=111865 [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870 [fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884 [fdo#112057]: https://bugs.freedesktop.org/show_bug.cgi?id=112057 [fdo#112068 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112068 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112113]: https://bugs.freedesktop.org/show_bug.cgi?id=112113 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (8 -> 8) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5304 -> IGTPW_3751 CI-20190529: 20190529 CI_DRM_7411: 9e8df10785d3ae60d3b54bc45e06aa32621a472c @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3751: https://intel- == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3751/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH i-g-t] i915/gem_ctx_param: Keep the engine active while peeking at vm layout @ 2019-11-25 18:45 ` Summers, Stuart 0 siblings, 0 replies; 8+ messages in thread From: Summers, Stuart @ 2019-11-25 18:45 UTC (permalink / raw) To: intel-gfx, chris; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 1844 bytes --] On Sun, 2019-11-24 at 11:27 +0000, Chris Wilson wrote: > The implicit soft-pinning we use to probe the vm layout using > execbuf, > depends on the batch remaining active (not retired) between execbufs. > Naturally, if the background retire worker runs the batch is retired > and > the implicit soft-pinning is free to use a fresh address. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > tests/i915/gem_ctx_param.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c > index bd1ee3996..63e0db38d 100644 > --- a/tests/i915/gem_ctx_param.c > +++ b/tests/i915/gem_ctx_param.c > @@ -161,6 +161,7 @@ static void test_vm(int i915) > .param = I915_CONTEXT_PARAM_VM, > }; > uint32_t parent, child; > + igt_spin_t *spin; > > /* > * Proving 2 contexts share the same GTT is quite tricky as we > have no > @@ -177,6 +178,15 @@ static void test_vm(int i915) > parent = gem_context_create(i915); > child = gem_context_create(i915); > > + /* Create a background spinner to keep the engines busy */ > + spin = igt_spin_new(i915); > + for (int i = 0; i < 16; i++) { Why 16 here? > + spin->execbuf.rsvd1 = gem_context_create(i915); > + gem_context_set_priority(i915, spin->execbuf.rsvd1, > 1023); Can you make this 1023 a macro? Thanks, Stuart > + gem_execbuf(i915, &spin->execbuf); > + gem_context_destroy(i915, spin->execbuf.rsvd1); > + } > + > /* Using implicit soft-pinning */ > eb.rsvd1 = parent; > batch.offset = nonzero_offset; > @@ -226,6 +236,7 @@ static void test_vm(int i915) > gem_context_destroy(i915, child); > gem_vm_destroy(i915, arg.value); > > + igt_spin_free(i915, spin); > gem_sync(i915, batch.handle); > gem_close(i915, batch.handle); > } [-- Attachment #1.2: smime.p7s --] [-- Type: application/x-pkcs7-signature, Size: 3270 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_param: Keep the engine active while peeking at vm layout @ 2019-11-25 18:45 ` Summers, Stuart 0 siblings, 0 replies; 8+ messages in thread From: Summers, Stuart @ 2019-11-25 18:45 UTC (permalink / raw) To: intel-gfx, chris; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 1844 bytes --] On Sun, 2019-11-24 at 11:27 +0000, Chris Wilson wrote: > The implicit soft-pinning we use to probe the vm layout using > execbuf, > depends on the batch remaining active (not retired) between execbufs. > Naturally, if the background retire worker runs the batch is retired > and > the implicit soft-pinning is free to use a fresh address. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > tests/i915/gem_ctx_param.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c > index bd1ee3996..63e0db38d 100644 > --- a/tests/i915/gem_ctx_param.c > +++ b/tests/i915/gem_ctx_param.c > @@ -161,6 +161,7 @@ static void test_vm(int i915) > .param = I915_CONTEXT_PARAM_VM, > }; > uint32_t parent, child; > + igt_spin_t *spin; > > /* > * Proving 2 contexts share the same GTT is quite tricky as we > have no > @@ -177,6 +178,15 @@ static void test_vm(int i915) > parent = gem_context_create(i915); > child = gem_context_create(i915); > > + /* Create a background spinner to keep the engines busy */ > + spin = igt_spin_new(i915); > + for (int i = 0; i < 16; i++) { Why 16 here? > + spin->execbuf.rsvd1 = gem_context_create(i915); > + gem_context_set_priority(i915, spin->execbuf.rsvd1, > 1023); Can you make this 1023 a macro? Thanks, Stuart > + gem_execbuf(i915, &spin->execbuf); > + gem_context_destroy(i915, spin->execbuf.rsvd1); > + } > + > /* Using implicit soft-pinning */ > eb.rsvd1 = parent; > batch.offset = nonzero_offset; > @@ -226,6 +236,7 @@ static void test_vm(int i915) > gem_context_destroy(i915, child); > gem_vm_destroy(i915, arg.value); > > + igt_spin_free(i915, spin); > gem_sync(i915, batch.handle); > gem_close(i915, batch.handle); > } [-- Attachment #1.2: smime.p7s --] [-- Type: application/x-pkcs7-signature, Size: 3270 bytes --] [-- Attachment #2: Type: text/plain, Size: 153 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_param: Keep the engine active while peeking at vm layout @ 2019-11-25 18:45 ` Summers, Stuart 0 siblings, 0 replies; 8+ messages in thread From: Summers, Stuart @ 2019-11-25 18:45 UTC (permalink / raw) To: intel-gfx, chris; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 1844 bytes --] On Sun, 2019-11-24 at 11:27 +0000, Chris Wilson wrote: > The implicit soft-pinning we use to probe the vm layout using > execbuf, > depends on the batch remaining active (not retired) between execbufs. > Naturally, if the background retire worker runs the batch is retired > and > the implicit soft-pinning is free to use a fresh address. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > --- > tests/i915/gem_ctx_param.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c > index bd1ee3996..63e0db38d 100644 > --- a/tests/i915/gem_ctx_param.c > +++ b/tests/i915/gem_ctx_param.c > @@ -161,6 +161,7 @@ static void test_vm(int i915) > .param = I915_CONTEXT_PARAM_VM, > }; > uint32_t parent, child; > + igt_spin_t *spin; > > /* > * Proving 2 contexts share the same GTT is quite tricky as we > have no > @@ -177,6 +178,15 @@ static void test_vm(int i915) > parent = gem_context_create(i915); > child = gem_context_create(i915); > > + /* Create a background spinner to keep the engines busy */ > + spin = igt_spin_new(i915); > + for (int i = 0; i < 16; i++) { Why 16 here? > + spin->execbuf.rsvd1 = gem_context_create(i915); > + gem_context_set_priority(i915, spin->execbuf.rsvd1, > 1023); Can you make this 1023 a macro? Thanks, Stuart > + gem_execbuf(i915, &spin->execbuf); > + gem_context_destroy(i915, spin->execbuf.rsvd1); > + } > + > /* Using implicit soft-pinning */ > eb.rsvd1 = parent; > batch.offset = nonzero_offset; > @@ -226,6 +236,7 @@ static void test_vm(int i915) > gem_context_destroy(i915, child); > gem_vm_destroy(i915, arg.value); > > + igt_spin_free(i915, spin); > gem_sync(i915, batch.handle); > gem_close(i915, batch.handle); > } [-- Attachment #1.2: smime.p7s --] [-- Type: application/x-pkcs7-signature, Size: 3270 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-11-25 18:45 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-24 11:27 [PATCH i-g-t] i915/gem_ctx_param: Keep the engine active while peeking at vm layout Chris Wilson 2019-11-24 11:27 ` [igt-dev] " Chris Wilson 2019-11-24 11:27 ` [Intel-gfx] " Chris Wilson 2019-11-24 12:12 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2019-11-24 20:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2019-11-25 18:45 ` [PATCH i-g-t] " Summers, Stuart 2019-11-25 18:45 ` [igt-dev] [Intel-gfx] " Summers, Stuart 2019-11-25 18:45 ` Summers, Stuart
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.