* [PATCH] drm/i915: Switch kunmap() to take the page not vaddr
@ 2019-11-25 9:14 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-11-25 9:14 UTC (permalink / raw)
To: intel-gfx
On converting from kunmap_atomic() to kunamp() one must remember the
latter takes the struct page, the former the vaddr.
Fixes: 48715f700174 ("drm/i915: Avoid atomic context for error capture")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 7118ecb7f144..2b30a45fa25c 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1045,7 +1045,7 @@ i915_error_object_create(struct drm_i915_private *i915,
s = kmap(page);
ret = compress_page(compress, s, dst);
- kunmap(s);
+ kunmap(page);
drm_clflush_pages(&page, 1);
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Switch kunmap() to take the page not vaddr
@ 2019-11-25 9:14 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-11-25 9:14 UTC (permalink / raw)
To: intel-gfx
On converting from kunmap_atomic() to kunamp() one must remember the
latter takes the struct page, the former the vaddr.
Fixes: 48715f700174 ("drm/i915: Avoid atomic context for error capture")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 7118ecb7f144..2b30a45fa25c 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1045,7 +1045,7 @@ i915_error_object_create(struct drm_i915_private *i915,
s = kmap(page);
ret = compress_page(compress, s, dst);
- kunmap(s);
+ kunmap(page);
drm_clflush_pages(&page, 1);
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Switch kunmap() to take the page not vaddr
@ 2019-11-25 9:21 ` Mika Kuoppala
0 siblings, 0 replies; 6+ messages in thread
From: Mika Kuoppala @ 2019-11-25 9:21 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> On converting from kunmap_atomic() to kunamp() one must remember the
> latter takes the struct page, the former the vaddr.
>
> Fixes: 48715f700174 ("drm/i915: Avoid atomic context for error capture")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Would it have been otherway around, we would have been caught as,
BUILD_BUG_ON(__same_type((addr), struct page *)); \
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 7118ecb7f144..2b30a45fa25c 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -1045,7 +1045,7 @@ i915_error_object_create(struct drm_i915_private *i915,
>
> s = kmap(page);
> ret = compress_page(compress, s, dst);
> - kunmap(s);
> + kunmap(page);
>
> drm_clflush_pages(&page, 1);
>
> --
> 2.24.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Switch kunmap() to take the page not vaddr
@ 2019-11-25 9:21 ` Mika Kuoppala
0 siblings, 0 replies; 6+ messages in thread
From: Mika Kuoppala @ 2019-11-25 9:21 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> On converting from kunmap_atomic() to kunamp() one must remember the
> latter takes the struct page, the former the vaddr.
>
> Fixes: 48715f700174 ("drm/i915: Avoid atomic context for error capture")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Would it have been otherway around, we would have been caught as,
BUILD_BUG_ON(__same_type((addr), struct page *)); \
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 7118ecb7f144..2b30a45fa25c 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -1045,7 +1045,7 @@ i915_error_object_create(struct drm_i915_private *i915,
>
> s = kmap(page);
> ret = compress_page(compress, s, dst);
> - kunmap(s);
> + kunmap(page);
>
> drm_clflush_pages(&page, 1);
>
> --
> 2.24.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Switch kunmap() to take the page not vaddr
@ 2019-11-25 11:47 ` Patchwork
0 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-11-25 11:47 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Switch kunmap() to take the page not vaddr
URL : https://patchwork.freedesktop.org/series/69967/
State : failure
== Summary ==
Applying: drm/i915: Switch kunmap() to take the page not vaddr
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/i915_gpu_error.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Switch kunmap() to take the page not vaddr
@ 2019-11-25 11:47 ` Patchwork
0 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-11-25 11:47 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Switch kunmap() to take the page not vaddr
URL : https://patchwork.freedesktop.org/series/69967/
State : failure
== Summary ==
Applying: drm/i915: Switch kunmap() to take the page not vaddr
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/i915_gpu_error.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-25 11:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 9:14 [PATCH] drm/i915: Switch kunmap() to take the page not vaddr Chris Wilson
2019-11-25 9:14 ` [Intel-gfx] " Chris Wilson
2019-11-25 9:21 ` Mika Kuoppala
2019-11-25 9:21 ` [Intel-gfx] " Mika Kuoppala
2019-11-25 11:47 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-11-25 11:47 ` [Intel-gfx] " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.